From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDABE7C4F4 for ; Thu, 5 Oct 2023 08:19:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D51278D0002; Thu, 5 Oct 2023 04:19:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D00E66B01F3; Thu, 5 Oct 2023 04:19:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7B2D8D0002; Thu, 5 Oct 2023 04:19:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AAB8C6B01F2 for ; Thu, 5 Oct 2023 04:19:17 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 799DE1A010B for ; Thu, 5 Oct 2023 08:19:17 +0000 (UTC) X-FDA: 81310707954.05.C928F0F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 35DC440026 for ; Thu, 5 Oct 2023 08:19:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A1GsA8kw; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696493955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p8OERLt30v5GuP5/A96MP1RVbcyVg7KG0iqkYYWA2oU=; b=MDAUojgo89eHxuzlst4OKxhy9L/O5Q7tGrih3zhW66e5ChqZighMzfe/2LtVnveN31S6gq LV2ILF1ZDUMOhHWcZYNFgrqEwUts0sjsDnIBh0arulL0iP0p3Xn1ZK4rqfqMNcKDYQIKEO aucGDsXWWQf6ew+/sahR8ycWV2McEEk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696493955; a=rsa-sha256; cv=none; b=ETyuCDv8DZpKgsjgbMULlGxkCiyeA8lzp3RwnvVaEfagXdaMh+ZLZsgI5Q5PK+ZU8V4VRd XF1aTJIlKKscpml9lX6QnjVwuLeAajhS604a9JjcMPwNo2b4kc1G1NCeJntX40gVlTCDQO 0UgMCFTZINguT6srOTwt1EuwfhRl5hE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A1GsA8kw; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696493954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8OERLt30v5GuP5/A96MP1RVbcyVg7KG0iqkYYWA2oU=; b=A1GsA8kwg0drnW0KNtGvwJDeNBAAOfcpcZZX1bHaIjnIE5KwN1dBiVJ0vaU61gtmF6ONQt sOxbJZ847ePKVXVlmbfqstyGg0pBCDLdI+0N6dBe2bXU/3z4Rm5a2PFehKRrvGy5QDhy6t mcY8QCXnR+8iXEmRyENpYLI/F1R25PU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-fXJ1nAX7Mla9IttlN1oDsA-1; Thu, 05 Oct 2023 04:19:10 -0400 X-MC-Unique: fXJ1nAX7Mla9IttlN1oDsA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40570ccc497so5287515e9.3 for ; Thu, 05 Oct 2023 01:19:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696493949; x=1697098749; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p8OERLt30v5GuP5/A96MP1RVbcyVg7KG0iqkYYWA2oU=; b=lAgbaNRaU+4Pl2X6uOMy6+Sj9QSj05olatvLv/DGUvkUlbnfygDwOFgpQIcShPSv4o A3GhpXMV97tVto/Pj9CbUkNFJ3Furi6qENoEWCdZ84MUG7uhTQZWCZ58AQ7+cwtu1UzG x14jyj6assCnRKnOKiXPi9ZU6XidTCPYMKJwJH0/nPM/l5Qha9xBWHYUd7gXELDQxsJx 7CIn7NqzG3kTy9WZT56BxnDLUNsQRunook8kZWv2eQWD7HEu9XLKfgaZ2hnJxEgiSvGQ IfSFQB9rg9VKWZRBKgwAKQoxLO8MoJTCcQcPs1iK5fLfhkPjHoONCL/Rs0OeQSWn7iqN mDVw== X-Gm-Message-State: AOJu0YzNl6h9hhT6OV7sIET9TqVkvwBdjzmkkfhyl+lmn3lKWCjLdcOH NWdDmew4BfmqoE5gYNkpo/MM/4LqQUSiD/JINvuffOK7dCPUV5LEq4uWuoisMFE51LV53ip0cAw bXFVd/Zf2k0Q= X-Received: by 2002:a1c:7918:0:b0:406:5303:9be2 with SMTP id l24-20020a1c7918000000b0040653039be2mr4592410wme.0.1696493949046; Thu, 05 Oct 2023 01:19:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBbWTEjl1tZ+K+VDxwydJ2ZY8lKhMy6qbI1xCWeBAJWf0ILuqBVCgDtEPtvwMduKSwmGhbgQ== X-Received: by 2002:a1c:7918:0:b0:406:5303:9be2 with SMTP id l24-20020a1c7918000000b0040653039be2mr4592381wme.0.1696493948671; Thu, 05 Oct 2023 01:19:08 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:d000:419d:b58e:720e:5890? (p200300cbc707d000419db58e720e5890.dip0.t-ipconnect.de. [2003:cb:c707:d000:419d:b58e:720e:5890]) by smtp.gmail.com with ESMTPSA id n5-20020a5d67c5000000b00317f70240afsm1165396wrw.27.2023.10.05.01.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 01:19:08 -0700 (PDT) Message-ID: <65867977-ac07-092e-6831-91543bb2da77@redhat.com> Date: Thu, 5 Oct 2023 10:19:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 1/9] mm: Allow deferred splitting of arbitrary anon large folios To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230929114421.3761121-1-ryan.roberts@arm.com> <20230929114421.3761121-2-ryan.roberts@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230929114421.3761121-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: k66dnzeh5x1pd4x6a931578ahmiqicjz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 35DC440026 X-Rspam-User: X-HE-Tag: 1696493955-89447 X-HE-Meta: U2FsdGVkX18y+PjQvmoAH+8+RMX/SAOVuTwiqc2nEoPId156sE7dCIYQMnClHRIfKKlp9HlxXrK2UD0q3amLa4BNuRb9boA1+j+5CM4qVQB9GJ9WAAvk9SOOlr7yB/he+XdFEVV22LxZ3FS04pJdgDpLOrfzQGBw57LogcR1GToGYci+t90TtWoFOpdFSL6neKnzfWn/lE+rViBjTdnEcGm5oNrFUL/3BBhB5TZqPsT528csNu/o3baIAQgAKSRP0hgWS7pRpZ/CG/2H2ytKDrDqjJSXGMwnU8ybuzpC29Wvdum76kRGGYciqaLuVKSwGuqsvSoS+LkvQ4fnr0fReV9F/egzr4edtPFHrEYAfcZDwvH8jap/WyVLhpDg7Qx+5X0r16VBWDIKED8wfk3ByYDFpOu6ujmMal7OMMzgKMwTxn3DuQliSFPjG8lcnkfxwA83XdGWFmecj9r0Udn/+E/4rkL5iuxut8s53p6l1FoMPHprI1gKJDcoYpCHE183WavuJAS20/TdvfZV9NGoC2fJQY0IBlyefjeR7CCGHHhaWGhUbHBwwDGab7pslCS1z/r7EoiCRrCS/Yu1v1QMzYwSHZbghT36I8T+d53TtiH67uy8hBPOeVaPnC1Vw+bpHp2azQdYO2XzLmSe02iZeARR9Ujy81PoM+7Nli6EhQF1F8LVDadB4DT2GQcApYZkRnJRbJczrBFlu9cJv0+nwbsRQEkMgXORD2TeCnyyY6BTdfgpLzPvnwCR7KBt/3T2nS8xnX4PSbRMDjxW8UkcOqgUdRsl+zVTq1Bmi7gXllDInzQxTL6ygz0lBVGwDQV4SlFMLmhjgw15cH7ZH/OFt1X+eJVPgeWCKnwsiza8wQwBKYBLw8N0oAhk6gQEMAZ3SEfjmXZ9SImHoUqSK5yFomQGZXUoO6ZIzysJ261k2EM6IyBv1TJngHz6OmfzfcZhVxV9BPQUB5O98H/20Hk YsXNMZso DViQwV8qoyAXcgdxTnPs512tvms6OlRCMLo8M+fSeLsP/uVFxpHuBHkz5bqyoq1YLpy9VSntNARYrx5URnrXhQmeZzfQuwkJkuU3ipN4EuI8nmuH3o3IDyAkkxmqpy7NZvmb0oAiUo2avM2zBJB3fHacwIUCwZH8aKon8O+sJPVdhmCL0uet3ZepBO7QGzZed3ppC57AKQ7zpeYsHvUpVE2CKslktaA38+MUSMA1So7npMFKKqgwk3v0dZyZutmP6/H8fwqmOetDCA6e/uLOiLK4G+VDLRAR3S0NovfoyDY3CMCIxjx6YTJ1dBIFZOw2FKtTcZtCAv3HYX0dIK+ZxueHkqIu4aizsE+eR2L3K+mS2KJ13YePPPTav/ItIEPQw+OagSSNMJul5qtIpYT03Y0SNhR+VYhuDVoF72AaBdIHVcToUCqSlaKszT1osX3sT/UXVnRvve//cedtSS7BTgda1CqCDJUSG8MSaFyjWYrxK/gz3iedyUToewwChzgHuaLUQxJe28I9E6/yxgHDPSBNaQFF190fNy4mQ07B8upvvZ7zlaivNVvWTBVKSKMCNQe8dhakfXvjH3t12uvZUNANQ5TBdwsTyCQhYLXEEzbf093FnjZU71U/42wnj9yCx3mvSQD1Dbsu+1ZA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.09.23 13:44, Ryan Roberts wrote: > In preparation for the introduction of large folios for anonymous > memory, we would like to be able to split them when they have unmapped > subpages, in order to free those unused pages under memory pressure. So > remove the artificial requirement that the large folio needed to be at > least PMD-sized. > > Reviewed-by: Yu Zhao > Reviewed-by: Yin Fengwei > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: David Hildenbrand > Signed-off-by: Ryan Roberts > --- > mm/rmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 9f795b93cf40..8600bd029acf 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1446,11 +1446,11 @@ void page_remove_rmap(struct page *page, struct vm_area_struct *vma, > __lruvec_stat_mod_folio(folio, idx, -nr); > > /* > - * Queue anon THP for deferred split if at least one > + * Queue anon large folio for deferred split if at least one > * page of the folio is unmapped and at least one page > * is still mapped. > */ > - if (folio_test_pmd_mappable(folio) && folio_test_anon(folio)) > + if (folio_test_large(folio) && folio_test_anon(folio)) > if (!compound || nr < nr_pmdmapped) > deferred_split_folio(folio); > } This patch can be picked up early I think. -- Cheers, David / dhildenb