From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646D7C5B543 for ; Thu, 5 Jun 2025 16:48:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED4146B0092; Thu, 5 Jun 2025 12:48:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E84656B0093; Thu, 5 Jun 2025 12:48:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4C806B0098; Thu, 5 Jun 2025 12:48:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A8F306B0092 for ; Thu, 5 Jun 2025 12:48:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E532C1053 for ; Thu, 5 Jun 2025 16:48:57 +0000 (UTC) X-FDA: 83521931514.28.5BA130B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id A1D8C1A0014 for ; Thu, 5 Jun 2025 16:48:54 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aGVWz6Ix; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749142135; a=rsa-sha256; cv=none; b=0jeDmFhKv/+Lu1lrHr6u0GD5bDVkxW5JkRNilqIqKOIvrUpdHa6EHyAr2c+CrK4gZ7bpAl 8cuwUtzuiS3+iS1U70zfBlG2DQ38/qhYEKNpo5ISAFZXCzVV5p2gMeoKv5jaZnFtM2Yc4I F0JBdX5ueRgrt04dvGwW/j0CGLg+keY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aGVWz6Ix; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749142135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EhGEn/OmiPAvj5eatsAY05GMVNPxdCqcjhL6DIoJxjs=; b=ySgsA2BsWpX4gOsodOvZIe4TSvz/v99O9kfvC4zcmWplWje5U7AK2PM/h+NZIX97leOfpG 81vY3wZVp/Q0dWwEmk094mQarSU8e6x6/yi34m2Nmu2h5LnGDlx0LvEEnkht6TK193b/F/ YqaFn06KbNaqrsnlZdxOpA8xtIaCrww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749142134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EhGEn/OmiPAvj5eatsAY05GMVNPxdCqcjhL6DIoJxjs=; b=aGVWz6IxlA21uvx6k9dRUKJshGHZGRHgKMkdpi0ze5Y4fKSICX5Wes3uFvv+LyKPQEZRSc xFnDDlvvkAet52/IDQ032pIELF1pMXCoAvwL3qDrt8ov2OcK6Mx4HyrvlpZPmmVS+Jwt2v Eb2yr+nzsK7Jd6kmhoLlQgYribAJoBM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-ZsFm1lnoPYumAk38k8HXvA-1; Thu, 05 Jun 2025 12:48:52 -0400 X-MC-Unique: ZsFm1lnoPYumAk38k8HXvA-1 X-Mimecast-MFC-AGG-ID: ZsFm1lnoPYumAk38k8HXvA_1749142132 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d9f96f61so8702595e9.1 for ; Thu, 05 Jun 2025 09:48:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749142132; x=1749746932; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EhGEn/OmiPAvj5eatsAY05GMVNPxdCqcjhL6DIoJxjs=; b=SnR4wC7dBamLNr2TC+v3xg9chv0F1pTTCIQ9VjF53Y8YxYj1VE5c9BEfmCO+2wgM8D WKnZoEziEgbFyREbxLA/16/GWHoHm08N1oJfyMZpvWfJ1bIIw/mYaneYlVzawTA9qj7B JyW+yDqNcyXNcwobPGErsi9tMyzfNjl1vzVsNulsAIZqCleWUeqH699sb8M3KMsKKUp4 wZ3R6BNhXC7Db6TF7EykNzscr4zW1dJCmUvXrazVolEkB0m+7ccAm8+GUyqTG0e3o1RR 6bOkzvymXFB52cmZmSj3lcds/g0l05oh9+imqAgFE6coKaTH3ROHavAqSSS0+SQasHNg 60Qw== X-Forwarded-Encrypted: i=1; AJvYcCXcdEEjuMNxPtWGnYRXtZ2CYGCKggX46KHAwrzwO4xhtOMxWmaOVjRsIz1uw+bgSdgcbUDtHleu0g==@kvack.org X-Gm-Message-State: AOJu0Yw9eGKj50q0vKI0XhmvMNXFKbvZxe8y+SXg5QxUkpBWGVgD7I9A C0lDwnydzuGMGdZU+liv+jEUfeeI/bu6ULnJtitY/wzv/lFCO/NatV4BVd/X/05f6TtjXSYunRK XUntR8tLNeEK2uU/hcZm5QeRjnBje+2iRazVe+EaS5KWJlgcB/7Gv X-Gm-Gg: ASbGnct2apdubeHzt4/oLdh4OlsTqP+8XaLbiv5yNn+WaGFcYcz9BO6X+yCpSyBui5z po2sisCK9NlSHNV/vHwVqo1P5t8ooixRoOK2rc/ywCeiE4Sq5tGEQODCM0mjcxpq7I1nrS1xyVY VVhLkWNB+zEZPuh4zUUzTE76QM/kkO5FxghLGEgkB1S0N3MQ01Af4rr159d9yczBXFwjBDygvBv AH0Z2YeXuHze7BGPikPaq9osrPosuU0dBD0oyAzcJdTwAmSxNKVGZB29E3GGbMRwewmRu1ewh/s MPEANT9NFlDuJHhEv2Vzb1nyl9hK/kjvfMotX5ArzPQBxwP+KmIuwe2yDZIHdmkVjU+rhx9rWXM g17AdTksox7W6Dk/R0yKNdOv5vbzpUu0m6MHZ X-Received: by 2002:a05:6000:310e:b0:3a4:ea9a:1656 with SMTP id ffacd0b85a97d-3a51d8f5f86mr6635496f8f.10.1749142131669; Thu, 05 Jun 2025 09:48:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgxIlZfdw0n7Ig7PNG5drsa3AppFPtd8J3xQjqrfGMh581GAlmBD6NseEqNRK10dz3UBK3gw== X-Received: by 2002:a05:6000:310e:b0:3a4:ea9a:1656 with SMTP id ffacd0b85a97d-3a51d8f5f86mr6635463f8f.10.1749142131235; Thu, 05 Jun 2025 09:48:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f99243e6sm29693115e9.35.2025.06.05.09.48.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 09:48:50 -0700 (PDT) Message-ID: <65862fd7-16ca-4d3b-a589-4389d8df324e@redhat.com> Date: Thu, 5 Jun 2025 18:48:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm To: Mark Brown , Lorenzo Stoakes , Andrew Morton Cc: Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> <722628a8-f3fd-4fb9-ae04-2313a52ffb36@sirena.org.uk> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <722628a8-f3fd-4fb9-ae04-2313a52ffb36@sirena.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: g_OYBWQOQg1A94HMXRug9y0bXGXKxWa8ekDaGI842vI_1749142132 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A1D8C1A0014 X-Stat-Signature: 6z755ma978ekjzqkekjbjhdcffzgea95 X-Rspam-User: X-HE-Tag: 1749142134-11386 X-HE-Meta: U2FsdGVkX1/Z8BOZpEwc9K5ET3Mn8cO+bsdxgnYem+vJuHRiHubX7Jb3AFG5+WzCkhoYCrxUNhNv61guURHq+6PBr50ZrHE9FrH0nSbWn9j61Zkk6NFIy94wfMTSnXns1F5yYN5AW+X2p1+l0aBhap/ghwDJOJcr0ShwhNYwdXrd8eGP+Igrx3n3KOH0j6m3I/Rr1BfuJbPyTX7BtPe0RMSYxaZIhTBhJ1lXpNn/oEn+pnE/9aotGNyYwhTGMuxTEESJLovxIvZjmAYMbiwnOJMsfAKdid7tPNWyKhJ4uY+FjyBW1J1AN/Q8PH/GfpnhFQrxoIZFCPL/V8uc3eIDkXm5HthQd8POMF2+eJJOyCpzndk53cP+mtVJnA32idNu7Opytyr13rDwQCZUnfpVVxAXuDngU8EO4OxW4YmErui31PVpz9E4ggYv0oh1jteJUghS3LTJegY7nFKgZWw4xKBR3kqNQUamyQTNOnFd0zyoGei67vF+dIpxSxTT3Z8Pm0zFGxcQIJZiQ/YzkKd6lSs3Ot6JTBuHfEQiR9xbq8cGNOP6q4fyKKxWLelpz2xurFD7ZVyzhRW1qIhFp0YN8FvBS56RIGBvvaoiy8oHrTMP0JIXD8boQqY6vpQt2dYBGxMxIWe5JpYA99S4Nt8ZDCvrGPfLlUdsR2tYSiYBvVl66zoRc5GilqOwnTiIQC8t6mR1Tl+OR9jwkmQFcsOJ9kKfhJibDjWB2hkq7CpjWYj0bmtm0i/id0ktjcbNp0TvDo6YERKlcM3etmA+gOBnEYBd/nAPhfZiWFx/4x47Tm9Cmn95DzbVrZmm4Gp2JFeez8jVi4RjNfmb5GaQGoEhi2TUQhDS4b9W0J1roON935FxCusy5uHtorMnZflgpKlsZaBEacNSoTYuwMKsktFmDDjSREIwKYIVJjabx3kW71POwSYn1yEfka3idMZNARuqtCeoW3U4L48G7Hs5NPr jf9mR0oS wVCLXlJoVbbI6k3A0mUlbzkAuCrB9XcesEnzjMlgRRcd3shXX+5O/QokyPabbMTT96vryhZVte1c4mEanMZk/PpiNRx0CzVWLsaZQmyrqO3igDh3F6PKiBS+0aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 18:15, Mark Brown wrote: > On Thu, Jun 05, 2025 at 05:00:49PM +0100, Lorenzo Stoakes wrote: > >> This seems to be causing tests to fail rather than be skipped if hugetlb >> isn't configured. I bisected the problem to this patch so it's definitely >> changed how things are handled (though of course it might just be >> _revealing_ some previously existing bug in this test...). > >> Using a couple of tests as an example: > >> Before this patch: > >> # [RUN] R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (2048 kB) >> # memfd_create() failed (Cannot allocate memory) >> not ok 39 R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (2048 kB) >> # [RUN] R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (1048576 kB) >> # memfd_create() failed (Cannot allocate memory) >> not ok 40 R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (1048576 kB) > > That's the thing with memfd being special and skipping on setup failure > that David mentioned, I've got a patch as part of the formatting series > I was going to send after the merge window. @Andew, why did this series get merged already? -- Cheers, David / dhildenb