From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD94E7717F for ; Mon, 16 Dec 2024 06:40:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05CC36B0089; Mon, 16 Dec 2024 01:40:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00C216B008A; Mon, 16 Dec 2024 01:40:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC82E6B008C; Mon, 16 Dec 2024 01:40:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BEBC76B0089 for ; Mon, 16 Dec 2024 01:40:00 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2B7A6A079B for ; Mon, 16 Dec 2024 06:40:00 +0000 (UTC) X-FDA: 82899871572.11.DD69C9C Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf06.hostedemail.com (Postfix) with ESMTP id C55EE18000C for ; Mon, 16 Dec 2024 06:39:36 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=R2GoXNC2; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734331185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UsUfWbTNDQ4yaFPn/TYgtrpZhI+saD19RlS+nNZ0YD4=; b=AxMaHbUVvVUdSpgzTkhVdsXC5Aq0fnnDYy2y9CLllbFBd9AiQu/HfClyhMBXszQsh3PElX AWD1lrdvfCmELnOxXsOWYgC7gIeNUTxU8DW10vpXDaUYHgyMSQ4uRh6+NWcdiEJ0BHmB9d +v37uERW/XrlOcYqdP3ZXrkcJT/kL/4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=R2GoXNC2; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734331185; a=rsa-sha256; cv=none; b=uuVqJbaivOTZCF3//gQfl9pffBwdSIXC5WHNdy26OvO/b+kysBhXiiSD4Wh+jz05xTQcFa gLgNKnVQ0KYFlAvIZpZv82vatFA2ta6fgZj3La5Rr3YskdB+6tgcFGcv903rJr5UN/ZHQ8 UJJ1h8tNz9f9qby0XDNCspwbHPwpqVw= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2162c0f6a39so41613815ad.0 for ; Sun, 15 Dec 2024 22:39:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734331196; x=1734935996; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UsUfWbTNDQ4yaFPn/TYgtrpZhI+saD19RlS+nNZ0YD4=; b=R2GoXNC2kKOhddiVzmlNSXKkDyWBM/f34l3qJf20EaittgDip6BYD8hoQbKDNE8LzW dZLGqwVTezuyMfSUxL2cxSoFVkGfV5tbh4JSVosFSlzqsOBggV+oYyTW7InYu2Kf2JPB C7rmcJe+QhVyoLbvYDTZkUavGpQn/U462Q1zllE3zYJr7hZAVbztJ90OGGjJn0sKx7AS Ljmu9j1hddMbHMjaaD+QNMy0eYdDDxzzwO4iH1SXUFqPbpTYS6DC5/OL+wloLmM0gG52 1o5sm+mMzSli+UR967FeYy7vnR1XifAST4/TUuPWSpTen8lPe7AaLNAIv0SCArM8me7x 2Kgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734331196; x=1734935996; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UsUfWbTNDQ4yaFPn/TYgtrpZhI+saD19RlS+nNZ0YD4=; b=giDkqlofgFmMGM6fmv0yhTuMHH5BfJtx8/g6RjDVOAogL19pNcOm9ZupI703Kei76E D+FwOR+CrEdoeOXtxFN42tbdoR8L3EsQKH6p51WfN+nI806U8uQK3fqwe/2Ko/CN+Kdl zjVx+bIIip0NARij04aQLGDw9mihayJ0tXph8h/gGJJRRrzHTUTm5RTfK0IqxDnSC//b VnSyNJ2Yk0SpFE9buPcbn7kOp2r7/h3lJ7SNLIuWydBYqzibYdO0tjStvPhd8VX4OJCc TfE+c+6XscWBikGXHbbNQX+9Yty5RTchvXpPgjI0ZpBz8sSw1Jim3mW27SiZeSYuPLot AU9Q== X-Forwarded-Encrypted: i=1; AJvYcCX0D9CvcA5AdVbp+KXVDaWYeUtzmkcdIQowI1LYkXyD/orxN+ePkpGOQZ6ecsMbeTjWHtt/NuxUMQ==@kvack.org X-Gm-Message-State: AOJu0Yxn5KWD/2n2dxGEll5eMFsWA3aFq8QedCjXDXoUJtVtkxx9WV66 2QfdYk4emFmSALKSCduYGLEZ/Ut9TNO+27DERwdN7/+2MwUeb7uyyvrYTbLAI4E= X-Gm-Gg: ASbGnctYtesxgZZmqKCM7xFb0rhvuD1BWIUewei1exFmYoezU0HMIaO3QYrnnPFqLFZ lTCgX9yyM0aBuF4xj+i5oAZJ7fPSLuJorcQlFFfSEaPHXyKEDsnbC6F/CJjAsA3H9tUf/XA+z0V KoDRhU4JWhnPOVoV599dN5GLNGToOver4tx5/63o3ZOpQZdEt2/8+KCoWa7nrwNgSHokQ7U97bx N1rwJndFNc8YdwBgj3jCgO8Ke+RWhQ//az6r5mc/SfEj+D9U5NNnerKPn/J+yTZpunDlbf34dRD ZUZXIg== X-Google-Smtp-Source: AGHT+IFK8tHks1060uI+RlBcJzj+l+NfvGE63CRO3BmWHumrkl7Xwy7dLiLBN2q3bFaz9ROllDdddA== X-Received: by 2002:a17:902:d4d0:b0:216:5448:22c3 with SMTP id d9443c01a7336-2178c7b66d1mr185878685ad.6.1734331195774; Sun, 15 Dec 2024 22:39:55 -0800 (PST) Received: from [10.4.194.102] ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e5d7c5sm35569345ad.199.2024.12.15.22.39.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Dec 2024 22:39:55 -0800 (PST) Message-ID: <6584dc86-dadf-4a30-9da0-15eef253ce22@bytedance.com> Date: Mon, 16 Dec 2024 14:39:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] Revert "mm: pgtable: make ptlock be freed by RCU" Content-Language: en-US To: Andrew Morton Cc: Yu Zhao , peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1fdb3ee32e6958ad82229941b2213ef76b7c4705.1734164094.git.zhengqi.arch@bytedance.com> <18bc52f4-ab02-495f-8f8f-87f69ea5b914@bytedance.com> <20241215221015.a567dbf38c9a98d672aecd3e@linux-foundation.org> <20241215223542.2b8e45a7d68f6ebc71b5ce3a@linux-foundation.org> From: Qi Zheng In-Reply-To: <20241215223542.2b8e45a7d68f6ebc71b5ce3a@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C55EE18000C X-Stat-Signature: gdkm17dew9jdhpzi5d7t8wg317qbdkfi X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734331176-56737 X-HE-Meta: U2FsdGVkX1/uzrGeyyfaJZjV3gxbcJq6szTAETdPFs1N7vcXpl+AGphktq1Xg4KH1Uz888lHM33rdp3/UGcaBAnEtoA0XA+zdwCgDaFzUgbG+CCxnzEfaU/ZQbPlxBeamlab0IYyp4j2Tdp1zLZNnwpqrM8Yz/bdWXX+rKGmv3GK1GQnS35fev415cKLgcLiTt41PWE1gOVm12P9s0cAtDEgTCxaCS/gJi3W1X9IrxLCkeLkSsI4Ufx7xz1axvluVMijn2CJP8wZEMCvgpTTyQe2gEdyK1vfYZ0s9P8zUNQ9Gt98j4mvH4s8iw9LgdCqT22qrOq4eJF4KoOlEOMXNiv3iZLuWlrIJQJgi00HlyTPVXd94JwM30TBnBvvN4kjlT9lG4cFPn64jMWdr+oisjyshDPftJKbp6iTRwx+gsaf0YFW61zRE8goQtqX53xbEGxyKZ6mDLYPfzNIUv8EKZMEjAY7SnceK1E+VILN7WLynALYt886QAevqp0NKaUAweI1QkP0AApeIUQtSi2P4ZjZAHk3fY9xelB12w7cRcXM6mKJvOelg4WA2f3az18fq3tUkv22nNzPb7Zba3v1IEJH+Po4P7Qvqy2H19x+2l+v75/Z6TlmS7ZXFTptztPd02zzeCHnHgC08cpQg+2vGOeo5SJIiz23OqtCrslJmF8vtU/aC/AExPHD+Hr3MSTitdkROsg2h76y/SBsC6PwgeibgNUYcX+9A+qcRhc8/JGeIuLpR9uiAGGhy/h2cYMBaBB17y7cW6BLzzaYRChEve+hGVp2I1h/pgoAUPGJ/lXKWEDQTEzyczNQjSHHKXe9iUFprHAelKrIDS44YwK0+53k+l+J77q0CzBiVs04yx+YllKxGdZZMyah3pg/nff6qYg9BxYy1LxojJ2w52NPEAFL3Gqw7dlg9p5VkHuvTtSgstmxWzkUmpftOnfBXaOPzeVgd59xk/8Kgu6PWX1 ayiyoDZJ QMiVtfV2GMcnfKT/HUQl6dYU2+nCWFHIL3ACxJNCeHOr/cNO4pfmesBd8RxmTm0C3w8W7KAHf4nhhEpZs0EnkIcaBhghqzXkRvrPjxf/D2yMzMqMSXizGCMNPF+tnfF9tTzu2lIk9K2pKT3UGoODxtyWqo1l+jimjuM0hL62e9m0mOYx3hKxt3rJ+q1RrWulb00PsjXxxzaV9aCouGWKqa27SRAf9EZRR/5B0dVzFmvGP2JtEE753fMOt5Ogin3JQy8wSt11zZtw8FnspXjoBuxYhqtK8BsHDW3nbZuOksg8N7avH4jWymqAOK02WVPS4piyrjwmBmvCpsn/wwBBgFMtYpIf6HKQAgqL0VBhjKApA6Qbl5TKPgcDLxCd9CrPPLtMpwtwI6YlvwO477iQ948BGOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.027037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/16 14:35, Andrew Morton wrote: > On Mon, 16 Dec 2024 14:15:35 +0800 Qi Zheng wrote: > >> Hi Andrew, >> >> On 2024/12/16 14:10, Andrew Morton wrote: >>> On Sun, 15 Dec 2024 14:29:38 +0800 Qi Zheng wrote: >>> >>>>> >>>>> Acked-by: Yu Zhao >>>> >>>> Thanks! Once the review of this patch series is completed, we can simply >>>> drop "mm: pgtable: make ptlock be freed by RCU" from mm tree. >>> >>> Can we drop it now and does the remainder of the series "synchronously >>> scan and reclaim empty user PTE pages v4" remain valid and useful? >> >> The "mm: pgtable: make ptlock be freed by RCU" fixes the UAF issue [1] >> reported by syzbot. If it is dropped now and this patch series is not >> merged, the UAF issue will reappear. >> >> [1]. >> https://lore.kernel.org/lkml/67548279.050a0220.a30f1.015b.GAE@google.com/ > > OK, so as I understand it, > > - the series "synchronously scan and reclaim empty user PTE pages v4" > exposes a use-after-free bug, and fixes that bug with the patch "mm: > pgtable: make ptlock be freed by RCU". > > - The series "move pagetable_*_dtor() to __tlb_remove_table()" fixes > that bug in a more desirable way. > > - So when the series "move pagetable_*_dtor() to > __tlb_remove_table()" is merged into mm-unstable, I drop the patch > "mm: pgtable: make ptlock be freed by RCU". > > Correct? Right!