From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 519C8C433DB for ; Tue, 16 Mar 2021 20:05:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BEA7864F71 for ; Tue, 16 Mar 2021 20:05:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEA7864F71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 138A26B0036; Tue, 16 Mar 2021 16:05:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E8506B006C; Tue, 16 Mar 2021 16:05:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA31F6B006E; Tue, 16 Mar 2021 16:05:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id D1ABF6B0036 for ; Tue, 16 Mar 2021 16:05:35 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8755F180AD83B for ; Tue, 16 Mar 2021 20:05:35 +0000 (UTC) X-FDA: 77926817430.28.D64AF9F Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf23.hostedemail.com (Postfix) with ESMTP id 8E9C2A0009CA for ; Tue, 16 Mar 2021 20:05:34 +0000 (UTC) IronPort-SDR: qtaE8z+56SxPRFl1cZMP/jciK1Qg76eZnOJhb8aYJ/jiZodYqjXbkuhE3smBWUallYHePbxpkL GM8joTIp2q1w== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="189375978" X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="189375978" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 13:05:32 -0700 IronPort-SDR: m87m/iHLU9EGKxPObdn8zkRbbHBN/x4XyXUxDoK7CHfHQ6aT6A+9dSBc2gLhbCMWwCeQhSvuLA tT0wbHj/S9dA== X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="372095298" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.212.191.248]) ([10.212.191.248]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 13:05:31 -0700 Subject: Re: [PATCH v23 6/9] x86/entry: Introduce ENDBR macro To: Peter Zijlstra Cc: Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Jarkko Sakkinen References: <20210316151320.6123-1-yu-cheng.yu@intel.com> <20210316151320.6123-7-yu-cheng.yu@intel.com> <15966857-9be7-3029-7e93-e40596b4649a@intel.com> From: "Yu, Yu-cheng" Message-ID: <65845773-6cf0-1bdc-1ecf-168de74cc283@intel.com> Date: Tue, 16 Mar 2021 13:05:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: kk1msz3cryzcxpusnjsj7s4u4r9hbdfq X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8E9C2A0009CA Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mga03.intel.com; client-ip=134.134.136.65 X-HE-DKIM-Result: none/none X-HE-Tag: 1615925134-998891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/16/2021 12:57 PM, Peter Zijlstra wrote: > On Tue, Mar 16, 2021 at 10:12:39AM -0700, Yu, Yu-cheng wrote: >> Alternatively, there is another compiler-defined macro _CET_ENDBR that can >> be used. We can put the following in calling.h: >> >> #ifdef __CET__ >> #include >> #else >> #define _CET_ENDBR >> #endif >> >> and then use _CET_ENDBR in other files. How is that? >> >> In the future, in case we have kernel-mode IBT, ENDBR macros are also needed >> for other assembly files. > > Can we please call it IBT_ENDBR or just ENDBR. CET is a horrible name, > seeing how it is not specific. > _CET_ENDBR is from the compiler and we cannot change it. We can do: #define ENDBR _CET_ENDBR How is that?