From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FAA9C25B76 for ; Tue, 11 Jun 2024 13:07:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 256646B0085; Tue, 11 Jun 2024 09:07:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 204606B0088; Tue, 11 Jun 2024 09:07:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A64C6B0089; Tue, 11 Jun 2024 09:07:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DE89D6B0085 for ; Tue, 11 Jun 2024 09:07:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 441FF81459 for ; Tue, 11 Jun 2024 13:07:31 +0000 (UTC) X-FDA: 82218634302.30.E96AD7D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id AB79F180006 for ; Tue, 11 Jun 2024 13:07:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JBqFnHx9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9sVYOAsA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SZzkxRsE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bIb3aeQG; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718111249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AvHghk5W41aXrn/xcNR8gSHWU+lJDEG1qFqjEFD0lyE=; b=JiEfMPHvhzAgTnYsXAuSkZUmlxi5UAa3yYIY39PGE95LK2DSbM2ILBAfJtVbC0C7Eai674 ShdjFCCw1bmBbo84+Jt1w5qlSHAvmlzUqYQ17NZOKHcpkQZYzss9E/dRgg2vzpQ2mbyjWH /aWLt3pEAbBuX05dA+1NxR2HMl3Kbjs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JBqFnHx9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9sVYOAsA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SZzkxRsE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bIb3aeQG; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718111249; a=rsa-sha256; cv=none; b=2rdUeQx3joMsYlvnI0QHcl/2de16rA/owvgNk+zWdUeTGs1genn/jW43GiaIL9TB26bP+q wuSX6XwI2IBde7fjP/7w1kYGGLOyA6YOVeogmu4W3NnXPm45IRus5a/e+nUf6y5KxdiaXd H1s7uqxgW2RgJkkzzB93jMIhWBaSh7w= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 75AEC33770; Tue, 11 Jun 2024 13:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718111246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AvHghk5W41aXrn/xcNR8gSHWU+lJDEG1qFqjEFD0lyE=; b=JBqFnHx99FiyB0P2DN7IE3QJh9qMv9g9ihF0crMAVaSbim5PeY5Ye+Grvw5UZiaS8jb3M/ MuwJklpcPOJZevlOKX2D/7KlRe5+XjEWNLzwaob4Pq5sxYELPkvI0zrQbGLW1e4vzBPQVv 7Jsnb2qLumYEuX14VBF7PT25MG1C1R8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718111246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AvHghk5W41aXrn/xcNR8gSHWU+lJDEG1qFqjEFD0lyE=; b=9sVYOAsAYpsI7bUOKimNGbBySpdLRjSG72EYpVc76L2AUv5uMjpMdSmgGc42/kkIpI8YN7 DVX+Sb/njDAiFICw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718111245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AvHghk5W41aXrn/xcNR8gSHWU+lJDEG1qFqjEFD0lyE=; b=SZzkxRsE7HRGMUBDzYLMcD9rhuRjFaKVEyCqncvCvDArA8beWseJcDimWqKs9T8LuHmxfW MLUoKVHlwfUl/d0QOw8hXLVJmeysPzUSlf2lcLBDOT7rEVD/d4in+S3h3jd1aF0JTcQIqN 3BYbjTLNsefrRMDAlXT2XZjz2Jx/MwI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718111245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AvHghk5W41aXrn/xcNR8gSHWU+lJDEG1qFqjEFD0lyE=; b=bIb3aeQGyNz87w+Lf26YuUPg4Q/ULIo6okKARRgniCiEmj915RZ8FNVfktHNbNPH4jJKeB VMbV47Z1nCI/LBBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5DBBF137DF; Tue, 11 Jun 2024 13:07:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bC6RFg1MaGYQNwAAD6G6ig (envelope-from ); Tue, 11 Jun 2024 13:07:25 +0000 Message-ID: <65842230-cb75-441a-b2e7-2d4942bfdab1@suse.cz> Date: Tue, 11 Jun 2024 15:07:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] mm: convert page type macros to enum Content-Language: en-US To: Stephen Brennan , Andrew Morton Cc: linux-mm@kvack.org, "Vishal Moola (Oracle)" , Omar Sandoval , David Hildenbrand , "Matthew Wilcox (Oracle)" , Hao Ge , linux-debuggers@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240607202954.1198180-1-stephen.s.brennan@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240607202954.1198180-1-stephen.s.brennan@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AB79F180006 X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: xs6wp9zuj8ddtb1xq11xqh3myo55nwop X-HE-Tag: 1718111248-919469 X-HE-Meta: U2FsdGVkX1+ATy2OlZk5InkEVJFI1nW0OJdVst98PoeunFIKc+XMaNnP89gpYC11PTYGZ9V1cNHU8xCm/kGzqPAFXYwqBHl93yIHdeeb7nMkg//y/FcSDpeII39FJ9/gTPsdjO/ivYbRsVkDbpdoQgb5kj23WxJAksx3LkC+gKBJXQelpECd50Fv0PP7FuJvL6SlTE1EjRcdS1ou3ENCEoeR5C0mTQ8gNJl0RzZ7MxwmpkZR2pApTfr62kNz9NgfVG5gHaV/APk1Zb0Zk4pcL+kstv8aMGFjV7MPdHQWYBILFQDCWeZvdXPLcmlEOcd0aqNMVfnQz/1tYFTO5lxPeXILn44gkWqe234MenmHTbhw3Jt93EwabDkrCnRYk/pFICeFOPFmKJS9gsjgvUqMUtv7awXEJDYEqFwb2yYXgYP6SYum3OGnsBnyYe3xw/iKoSqYoO3SevMkcTKj4y5YOh7LmbiEHZqDMZgugVHv20/YXN1DQj1BiqqzCKyXK1CCfE21GfRyg/eZEGWOXzi/6nOYH/DrMe8YLEuAqGkaRBDxpnaS1HN4xxTHAvosZ8HmNEiA1AJociPNev5+qkq848q1oG25beaYzeQSLdKEyoPAYnqq1jMw3mr1E3grAe1E/SAjgf517PI/cYnA2yFvDxX9tSObVXRDHuOqvBkPp0Itsy2AweqCzBlvLMhuV+HWce5RJqelg+/bmLzXoQ1kuBTIQTuq8wasHwW5dJB2uhgmK7zAR/PNGMUUwnqEFjWKjX+Ns2czKVVsA9XMyKhsjhdb5XjnXjBFBcGCidjwnwKP4o5TQOY7SDuVPYqqaGyDcT+kuEOIyK7ltbXS2s6qK7b3qjq98L59dtlRzkqt9O79s3IihnJL4QYMKERyKzFC1asciw736IkP9bZtiRurrC2/wZedgR0QLFgeUM7jlb0w8xtVMNTkgQ9eCp16LKUqOVCYyX0QJXOfE28ysPj LQiXVtkN 3ks5oVw0iNNS1P1M2VMcKmf9cvBAXsUHA93C8dTx34iRy/FYjsklFKDUOqJ54bpccicpeFANvLOCver8XWd5gHUP9Sc+kbzYZEZN6tSBBdnIlhgnGZgz7Qew7brHTOqctvEwS3O45gCCjeptVMfxNk11ZoYazGI5tJK1APM3zyBObSV9ccEJ2k0MIJsG6EL9NnJeRdNRH0nUHJQVjGmh0AbVe7ALCVy8DCLXe87vA5pYHQwoMqf+f/N1axZJysGEs5jCaRVGes2xhsQMKGnciP0tzfCFIpOufL7QWrn+Vmulx3fWcTpnY40KV64ky3bfmrrbiSYR/ZmbEqsnfhSl4Vv1QxhfJklq3n9Ze/W7dRh6bCc4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/7/24 10:29 PM, Stephen Brennan wrote: > Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3 > ("mm: free up PG_slab") in has the unintended consequence of removing > the PG_slab constant from kernel debuginfo. The commit does add the > value to the vmcoreinfo note, which allows debuggers to find the value > without hardcoding it. However it's most flexible to continue > representing the constant with an enum. To that end, convert the page > type fields into an enum. Debuggers will now be able to detect that > PG_slab's type has changed from enum pageflags to enum pagetype. > > Fixes: 46df8e73a4a3 ("mm: free up PG_slab") > > Signed-off-by: Stephen Brennan Acked-by: Vlastimil Babka > --- > v3 -> v4: rename to enum pagetype, avoiding conflict in f2fs.h and matching > the name of enum pageflags > v2 -> v3: rebase on mm-unstable > v1 -> v2: include PAGE_TYPE_BASE and PAGE_MAPCOUNT_RESERVE > > include/linux/page-flags.h | 31 +++++++++++++++++-------------- > 1 file changed, 17 insertions(+), 14 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index f04fea86324d9..32722c6e8397b 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -945,20 +945,23 @@ PAGEFLAG_FALSE(HasHWPoisoned, has_hwpoisoned) > * mistaken for a page type value. > */ > > -#define PAGE_TYPE_BASE 0x80000000 > -/* > - * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and > - * allow owners that set a type to reuse the lower 16 bit for their own > - * purposes. > - */ > -#define PG_buddy 0x40000000 > -#define PG_offline 0x20000000 > -#define PG_table 0x10000000 > -#define PG_guard 0x08000000 > -#define PG_hugetlb 0x04000000 > -#define PG_slab 0x02000000 > -#define PG_zsmalloc 0x01000000 > -#define PAGE_MAPCOUNT_RESERVE (~0x0000ffff) > +enum pagetype { > + /* > + * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and > + * allow owners that set a type to reuse the lower 16 bit for their own > + * purposes. > + */ > + PG_buddy = 0x40000000, > + PG_offline = 0x20000000, > + PG_table = 0x10000000, > + PG_guard = 0x08000000, > + PG_hugetlb = 0x04000000, > + PG_slab = 0x02000000, > + PG_zsmalloc = 0x01000000, > + > + PAGE_TYPE_BASE = 0x80000000, > + PAGE_MAPCOUNT_RESERVE = ~0x0000ffff, > +}; > > #define PageType(page, flag) \ > ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE)