From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B306ACD5BA9 for ; Thu, 5 Sep 2024 11:08:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41D5F8D0001; Thu, 5 Sep 2024 07:08:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37F0C6B028E; Thu, 5 Sep 2024 07:08:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AABF8D0001; Thu, 5 Sep 2024 07:08:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E58246B028C for ; Thu, 5 Sep 2024 07:08:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9C120120B5B for ; Thu, 5 Sep 2024 11:08:43 +0000 (UTC) X-FDA: 82530411726.02.488784B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 52FEA40013 for ; Thu, 5 Sep 2024 11:08:41 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f0sXFzh2; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725534472; a=rsa-sha256; cv=none; b=LDE5B1AWzC7MFUzL2A0lFdAXhn4Vw+o0ZwfkyUZYoTBHJMHsmWeho8S0bequudkedW2CK0 ShNKSs3kVx9uNG8RGb+fxc1eXKiH0Kc+Re1C+J/3fdZxX6DLu76WBjOJp8k05zGpwmGPmC eWg0k6fZfYL2wT1cujB3UU5ZlFi0WSo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f0sXFzh2; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725534472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GuM9XXecG6m7Bq9F8M7Qo2NTP71Qi/wqsXre7rS8OKY=; b=BE2AsakrHouCtnDaXQzSgyI+iPka5h8o8+DGo0Cg5frs6u7QnsLYlwYKuiEExpTMeo51rM qVyrYSC8pCu4R/wXpa5MdV0iuETCRs0oXDreZvv8kU7wO749K537hz3DQkF6qHehTSMvBG qqOFb44OBuJLYpP5Q5zOQRnXvkyXKl0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725534520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GuM9XXecG6m7Bq9F8M7Qo2NTP71Qi/wqsXre7rS8OKY=; b=f0sXFzh2mSR+90bMjbtK9mOzFylnK+v+g8wv70FETy3PjbnyRRma8hGq1P3yQRTDhmJxdr 9iowib27UUSb8gw7gZlgmyjpfQSZl+mSYPgS3qmmkKIqlsg+LKTkLOnpcRwuugHzY7S4d6 BJ26CyrZ2eHVDHB4HY/h6z2WhyEI208= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-h5D6Xi1uMQ-nnBD50iREvQ-1; Thu, 05 Sep 2024 07:08:39 -0400 X-MC-Unique: h5D6Xi1uMQ-nnBD50iREvQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42bb68e1706so5813695e9.3 for ; Thu, 05 Sep 2024 04:08:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725534518; x=1726139318; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GuM9XXecG6m7Bq9F8M7Qo2NTP71Qi/wqsXre7rS8OKY=; b=hDdBfVktizrWFDT1G2zLoBbHu17Y+8lR7FjZRQdXKcJCB2DIka599GHpkrqhQRccJ8 jGtx/OODmtXgNjR8R/rKwBVqA22zaEgrR+NcGDLHfmZtFYMNAW6HgSlNhK5EFg+p+7SQ DgVAFaAc4EtYD7wOE5g9ddag6xe1MLbn52Wj9SueoGCTFb28nIpC+mvdRNoNR8njXVqr MtbLhOnSVijv4rR//DKuVlbYc16L1UkLYe4EM5AsmZXEsyuA/t2uh2JjutySlOP3hije zGp+Xt71SKm+8QOAqggu46uDRC4KXPrJky5p48huMMttCunzWTrDpS2gDA+0BsTBxJTB 3Avw== X-Forwarded-Encrypted: i=1; AJvYcCVjN/WXfi/wkF/uZ/Fkf5fxM/YT3CVzGXgzeI5byCqWDUJD9pNGzUWDnhzOUyMuWW7t0fTOcpOM8A==@kvack.org X-Gm-Message-State: AOJu0Yxmy9c8gKAbA6/CfoNcUMG7dwcMSRRnRTECRU3JGRtbEcQfj6JH f2bSP4ckB+86ZObVtEZYn3NIW/+h+n/72shUWqmCbc1L0oehljtrPDakEjgnP7ky4qkolFTS3SZ MgKV4PTWJSd1bCEwpFuBbyPTyKnYOWkSNaT61z39y2lkxdkkM X-Received: by 2002:a05:600c:474f:b0:428:d83:eb6b with SMTP id 5b1f17b1804b1-42c880efd7emr85389855e9.15.1725534518062; Thu, 05 Sep 2024 04:08:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8jb7VG0GmOLyhAxFm/EVuV0ysPY7NXFeWFToQ9W8b34/g4Fr0+wanY40DaGxyVG126b9kvg== X-Received: by 2002:a05:600c:474f:b0:428:d83:eb6b with SMTP id 5b1f17b1804b1-42c880efd7emr85389645e9.15.1725534517477; Thu, 05 Sep 2024 04:08:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:5400:6c12:d0e2:3757:2963? (p200300cbc70854006c12d0e237572963.dip0.t-ipconnect.de. [2003:cb:c708:5400:6c12:d0e2:3757:2963]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6e33d55sm234023595e9.41.2024.09.05.04.08.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 04:08:36 -0700 (PDT) Message-ID: <65838cc0-9a20-4994-a0ef-9cd50bb00951@redhat.com> Date: Thu, 5 Sep 2024 13:08:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory To: Andy Shevchenko , Dan Williams Cc: "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: rsyfhh4syatpdia38rm5ibszbpjsa5dc X-Rspamd-Queue-Id: 52FEA40013 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725534521-434381 X-HE-Meta: U2FsdGVkX1/orOaR9QHD7tb+mRxtwpo7PuAZopzKqb4X2IozZ8DT0iJPmJ2W53HW+1KwEC6nVGuo7Czm9gFBBsnVsj05lwPgUgxu7t7OUIwCRY1017+kkhrYvOyquko4ff6f2w5Hs1ajt0pC3gkPd0155adEzh3A/nV8PfDshDvphYAIGdCG3zkZnP4p1G2G0khv1nwUlxZATEFvvV7UNcAOu2F8HTr1uHktxlSXk/eQwrM8Fe3tQM1a5d6ZhV0EkH5XBDCr8txW74YkJkp4aSO6dkC0w4SOyadc3mDf7oLCc5eE7+GQWmA0B6x8F4nvGD8kqwZBG8HXDSAD+xNqqzm9uMlQ4CMaSvnIQc2tzN3cvRsBsDLKuPMkC/sx4TDs5X2QHqy87KJ1k1dVhDbcscnkspgbacHQQPVqrGw9v8H1wsAhBV7ZRVGNB5sL1ic+mmV98sGaksNCxPyKBCSa623cWgd/wHyMYeNmm7K1e/YEUvArd1jG1/ssgoih0YmubTPwRrK+i2AIb/WEsaG7VD9+jsFO/4jj0zMI5xxwF/Oj5Dk4S17nVcqycrXqgkLN8oLGOVabdXSJi0hLBPxYfcP6ePraixXDw4mfUoOIepWIk0qpUufnKgf20eoiApXf7LrvJQMnhj9CJuz0sMqKCA2HtJLuNS3OUDmML0eR+PWx1mzyeaIB0RCeUtAWts9EEO0/c8nhX9tGUBEpduZCP4O6Ad/WhFmKphdEVGE3ZBA68NKhdiWE2cRoSLYWPUhmVsm5zt/HPDBfM0UCxnHDxq7Kge7Kc+z7A946cOdgd2PSaNz8vjG1YJNCrhd1JvD/aJ7C5iW8FY362lJcTMFvHqSWC6KUHnhnvY1Iea8gHN1tqjAmm570mRSp/R8OD+4D+2zqDZRq+iDBqofbaHxbAaHWJxyTKeQRM+sbCMX7WwzpgHe5hZ4to//G9CQzgQwFwmp1yaqrur/Sjimgt0E nQFKM9Dw arWsgMLsYkm+uXvRsM8qlnkIvcHzstasUaf37vTsNp3xPVytgVJ/glPzPXACJVmLMaufaUyZkFvjAPi39IoUi/wFx0KRlSQQT5dBRqjzAdh5RKfYj3jleXqrJqh8/syuQqGOjhUIIN1lHR/LukHr7HTUfOXhs8wDQMiQUrjDEk/90hQbtPbGuR7dWUn9pWxq5WL/ulI5gliKUeKiCygGW+ppQMd5S4Ds+ZE2f/v9/ZVLyFkty/fqHzhudew5fERSRMBBO1iMvQX3IFp9zuTwTtMkvgq3oRSGVOx+9M7m7YqhhjGErP95pd9RUnhRmak8zr1iOjVV5hJqmKs2amjDGh3l7lDPtkRUJZVkZaxQNesUx1jl1OgMpOlaJJpg10XQnIRA+L5chWIPykUF6Tf5+5qPTiNbQZrFNCZPIFX6wfkmMkAancXdk4uTVvy7O/u3tOLroKiNOQ/avinP2AFVH8BbPbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.09.24 12:56, Andy Shevchenko wrote: > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: >> Huang, Ying wrote: >>> Andy Shevchenko writes: > > [..] > >>>> You may move Cc list after '---', so it won't unnecessarily pollute the commit >>>> message. >>> >>> Emm... It appears that it's a common practice to include "Cc" in the >>> commit log. >> >> Yes, just ignore this feedback, it goes against common practice. Cc list >> as is looks sane to me. > > It seems nobody can give technical arguments why it's better than just keeping > them outside of the commit message. Mantra "common practice" nowadays is > questionable. Just look at how patches look like in the git tree that Andrew picks up. (IIRC, he adds a bunch of CCs himself that are not even part of the original patch). Having in the git tree who was actually involved/CCed can be quite valuable. More helpful than get_maintainers.pl sometimes. -- Cheers, David / dhildenb