From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E195C77B7A for ; Tue, 13 Jun 2023 12:28:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5F9A6B007E; Tue, 13 Jun 2023 08:28:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9486B0080; Tue, 13 Jun 2023 08:28:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64036B0081; Tue, 13 Jun 2023 08:28:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 94C686B007E for ; Tue, 13 Jun 2023 08:28:42 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6C32D1A04A2 for ; Tue, 13 Jun 2023 12:28:42 +0000 (UTC) X-FDA: 80897653284.08.B3F26CE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 26256A001A for ; Tue, 13 Jun 2023 12:28:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNwjk5DF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686659320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5APAgmZrGjFJ9+U0RvJUaGvdr2gWc6sxi+r6310cnNs=; b=Mjcucpai3ePsTI0iTJP7Gs8eEbekavUFD8a2faUyaiQb1ZQUzD8Kc3KEkSuoYrIRB/qx+b 72UIA9m6Ybtaja8NzRjRWBBzpEd01jXtGsHhT7UEe/elHYu6Kf3xBZlrTgKcD5+4wb2wkH t2NG9uR8NAhgeYmNQE6HQWNZY9tBWaU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNwjk5DF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686659320; a=rsa-sha256; cv=none; b=dButUIRnWZggXFrJxI495HLinOSbbE+EFm+TdcO/S46tWqgr6DkdY4FCcrucywukIqWPrU +jUUm3ItQH0UFfpqn90dSj/UDgH2so/5A955RHbNko3wA/6v6ArG7LuokQ448flMbR0NYF 0qtnnzfjd6z5vUQP6lmn2jTuhMwLl4A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686659319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5APAgmZrGjFJ9+U0RvJUaGvdr2gWc6sxi+r6310cnNs=; b=cNwjk5DF0Kbn8DfmoWEY+VI8IvUbl1H7QOAB1C0gI3kAYvEAFtj5oF620gugzsltDU0WA6 K+Bw7vfPTKDgu59Nni3EbtBP5mb0+UxYaYsLSa9Qe9TEuEP2HTiaz9/RpBfQpXdxs9IL/s nRl39xwVy20ftFEyDzU5Bg0tYHbSSrI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-540-HeJl2nYwOQ6CAvOVvN2lsQ-1; Tue, 13 Jun 2023 08:28:17 -0400 X-MC-Unique: HeJl2nYwOQ6CAvOVvN2lsQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-30fc9cfe82eso580171f8f.1 for ; Tue, 13 Jun 2023 05:28:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686659296; x=1689251296; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5APAgmZrGjFJ9+U0RvJUaGvdr2gWc6sxi+r6310cnNs=; b=SaI/XRCybZhaAQ7sPUrpZTcavvNsfE8L/bdWGQ9QTi+UGI9GqxSzobtrCjVn3wi5Uf woEGipccV7Si0idvjsmWDyFaEvjzBQKyGQpLkNIM5znH75zwJs7+QQGA266uPtuRoWxH MBDQ/4A/atWdaP7hGo2KA06BZWxDSDkIFd9c2DOWNOiSjVlqB6BbD+8HMp3rpXfSoZ+1 HUkSMtJS3yc4UGx5vRMKKqpaDYJS+qdH7QXJ0BAzrAp+8W1K8Y9m0dtGVIlRg2UpMV+y k2g+HU2+NzkXXq7wz56/XqlIYaX30xzuH5Fhco5qCEC8MKUs336SB5ir9I6IuAMoKZop TqSw== X-Gm-Message-State: AC+VfDzPNt6wiuPL/0M+T26y+kgyGglt5SuAXayf1RcWnSQ5GOy9tumM sCndm3A01ADbKcPVwMfjfLDLANkG1fHuuGGmgRFZrO6gU+Wvx58zEkliiT2++i2S4bayBnzUE+Y qs2npT+kX/rI= X-Received: by 2002:a05:6000:10c7:b0:30a:eae0:106c with SMTP id b7-20020a05600010c700b0030aeae0106cmr7102028wrx.10.1686659296215; Tue, 13 Jun 2023 05:28:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ61EMABfB7hkEtd8rE3feiAmwo8GaJnsqM5qFYcE5rkOiMq3BqizYRb/VE1CFB4BKMLKA5RWQ== X-Received: by 2002:a05:6000:10c7:b0:30a:eae0:106c with SMTP id b7-20020a05600010c700b0030aeae0106cmr7101998wrx.10.1686659295754; Tue, 13 Jun 2023 05:28:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:ff00:1a06:80f:733a:e8c6? (p200300cbc710ff001a06080f733ae8c6.dip0.t-ipconnect.de. [2003:cb:c710:ff00:1a06:80f:733a:e8c6]) by smtp.gmail.com with ESMTPSA id u2-20020a5d4342000000b0030e5c8d55f2sm15258101wrr.6.2023.06.13.05.28.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 05:28:15 -0700 (PDT) Message-ID: <65805965-c6a2-ce0c-fb11-5277e5976120@redhat.com> Date: Tue, 13 Jun 2023 14:28:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v9 03/42] mm: Make pte_mkwrite() take a VMA To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com, szabolcs.nagy@arm.com, torvalds@linux-foundation.org, broonie@kernel.org References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-4-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230613001108.3040476-4-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 26256A001A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: c9xkabkrg36as9dwb1epqehq6axb8tqs X-HE-Tag: 1686659319-968999 X-HE-Meta: U2FsdGVkX18jVp7MbrXKyYG/7k4P05ykdpHpCXyyQNQPtk4xtKq3+Syh+7Y5mM0GAZsNToSi8LPOzeL898C8XJDNxUmlMfSNTeOz3Pe81XnxxrqgNffaCJNVUYKgRNJ8dL6j3OsgAGaptsCkRqj54rddD/W/olEGlHBkX2aJL5cEsYTNAXwiZjfX9eqFPFkKO+dGBUO6qxd1J2ViPJ1gXb9xLbNTuOJd0dF6VJ5HmULvo7rv2kcZyRv2mn7Hy41x1jGzczwEjHRlXIk87WuZYQvr5nFLQfSzJFomY8OgZ6xlVESBAcj7OALvXNXAsX2YnGUGFIpzYSHM9C1yiXTz86zO5R4CUOtpMlOFGyyRBYNnmfL2IB2za7Lp99iNE8xTBefZhjJB8fFZGDJbu7Do0msQ57apsvY5ym0Gtz922nHo2SauleqVZunZ2GK217P/iorg28yuovUvMTD4z0zix5yxpE7ir/q1R6pyQMUtDpv5e6fGa9mCKbJStZBGBlaYO1MOPddYZNhnEYyhLjvSD/tl6xdur9Xu6UnzDqV8l13uSMkuDpAYeTtjNuGH5bW4ECHOWGT7jZcEvg0MI3jeBU4eLnW2rUNC6xM+EdVPBXWkM8NKU8XOlUuxc8VSF+52W91oIEWSBHunDB4T90gM2gETTaB+Tu4zHXlANQe3+Tvx+BDR9f5dR2br3oiGGoyqaDh6C9zChapp3Y0s2u2+rGt5f+VmO4FrI7tLLmuofj1xxvryHWfDq4u7HQ7e7UivNAJnzU6HJ80BOokZvdqgY3imMo2tLAHqnPdu8Q7fYsg5rIrZZ72Q/cHZxTe8yAIN4iJgf9+WgiuHGCM6SgAoJMunsw4TcmmcdJ4v5pgatLkvg18LWWNHcLc7LGCYko+0gfqXzqKhJMrHm1ijA0Xry5FwGn7c9li7zVhanGPgbAYX5l51ackG9NVXjOGtGl4AEng6q+N4H943zKz0Vce pSiP61VS 5YMaKsl29+WN3dle8nX5H3ZTmRU7ts4k5F43nkEr2yHXwCGaKVo/DZqHdNHwK3CUY7M6flKH7DwwDbkAjeGOPhfY0iKoKzYiN8OmaOs+dOIvK8CbO4OR5xWcE5uCqS4RTovpFf/pUJ91DsBRNCejCYlVxHX241hjYzIfuKjcFGNvPNRIwLEOubHvaRRqYM2c8YfDXA8vtZ0w7Hx72SeEXydCwvHepslvmF9dH402eCY6luFiVQRWoWMEoCeKdDqJUyISZEK8F/YXKG2lC7pZvWbqJN9PNgAFTAFEkWEUeG31RhOAPS5Zd6GrPZjzzDXGpLx+FY0ruqpOmEgSSRsQXkSlJqEP/ZaX6sPV5eqAUSk0V8czneS+lfIFPBiZcpUwC1AVADWy38fg4UXJ+KDGFVGyX9uOATdLBsMtXgNrDTaGylG/iSSVu9BwIqHHd4lvcLqdtAfEJwkpCDPewtwyQAV8rPGVgdnnwm7VtBqJKyfISHLwv2OQ7z2H+hTiiWXpeuSaqY5k++F//ks0cybKnACpz05mCamzIoqANo6eo0PMhjGE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 02:10, Rick Edgecombe wrote: > The x86 Shadow stack feature includes a new type of memory called shadow > stack. This shadow stack memory has some unusual properties, which requires > some core mm changes to function properly. > > One of these unusual properties is that shadow stack memory is writable, > but only in limited ways. These limits are applied via a specific PTE > bit combination. Nevertheless, the memory is writable, and core mm code > will need to apply the writable permissions in the typical paths that > call pte_mkwrite(). Future patches will make pte_mkwrite() take a VMA, so > that the x86 implementation of it can know whether to create regular > writable memory or shadow stack memory. > > But there are a couple of challenges to this. Modifying the signatures of > each arch pte_mkwrite() implementation would be error prone because some > are generated with macros and would need to be re-implemented. Also, some > pte_mkwrite() callers operate on kernel memory without a VMA. > > So this can be done in a three step process. First pte_mkwrite() can be > renamed to pte_mkwrite_novma() in each arch, with a generic pte_mkwrite() > added that just calls pte_mkwrite_novma(). Next callers without a VMA can > be moved to pte_mkwrite_novma(). And lastly, pte_mkwrite() and all callers > can be changed to take/pass a VMA. > > In a previous patches, pte_mkwrite() was renamed pte_mkwrite_novma() and > callers that don't have a VMA were changed to use pte_mkwrite_novma(). So > now change pte_mkwrite() to take a VMA and change the remaining callers to > pass a VMA. Apply the same changes for pmd_mkwrite(). > > No functional change. > > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe > --- Acked-by: David Hildenbrand Hopefully we'll get this landed soon :) -- Cheers, David / dhildenb