From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707B8C8302F for ; Tue, 1 Jul 2025 10:04:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F22996B00A8; Tue, 1 Jul 2025 06:04:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFA326B00A9; Tue, 1 Jul 2025 06:04:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC1BD6B00AA; Tue, 1 Jul 2025 06:04:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C7DE46B00A8 for ; Tue, 1 Jul 2025 06:04:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 402011D6A73 for ; Tue, 1 Jul 2025 10:04:52 +0000 (UTC) X-FDA: 83615262024.25.A036A8D Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf06.hostedemail.com (Postfix) with ESMTP id D9A7618000C for ; Tue, 1 Jul 2025 10:04:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=K8gQi8qy; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="RO/YvSMF"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751364289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mQj2A2jEZtS3kZVhPppfk5KAcaU4YJ0C9HUswLujEhs=; b=mQHtjWLo3LBmdaoUy9iAG3uJ/qlIAHkjC4fkqw29uaHqCK5qkFnQO8Pcd4d4H7/fVYLnL8 YY69pX1iEm/KjdglN5dOXQK4SPlzkgebcrercfsxTKjsxT5mOH6sYBiwvCT0a7RteSohN6 Vjpk6eTR6iFnNmGl4F9UZZZucqYriwY= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=K8gQi8qy; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="RO/YvSMF"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1751364289; a=rsa-sha256; cv=pass; b=RGO+hXtpzB75m9RLA5yoXWMPKgHn0xrGes8kQbqzhprlLZiHNIouyO2OHXM+qzTNmaZ3En 9JByRmm5GDR37CC16ooxXkWHx9Nzybj8cmBeV6GYVuVxQeHZ9/bLrYmiZdQcop9tBLVRbl hAnkyuQtnGo9OE3pyl3ADsmqtH2hobY= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5611N1bF008588; Tue, 1 Jul 2025 10:04:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=mQj2A2jEZtS3kZVhPp pfk5KAcaU4YJ0C9HUswLujEhs=; b=K8gQi8qy5nf6UD7cRblQYgNHAClO3cS+v4 wWkC2dNiihsBPv7GA5+cvF3b0sR4UeF8cJvn/Wz9mTseayDTob8Oj4SNjgdhxAoI CquY1H/JuvJxmGLK/wKYP3U5Gzx7f2xYibTwTO5/29VaCoY+qdLKx1LIDiHmXwE5 UGc3BmReGKTD3bzlnv0xZyBYadL9NrEr0SpqVxuoGbPQKrGDnN36fxetkNfTkhKO tN+vqCNUtY27a4Jx/sol4VSXB21hMdyIEkR4KsQXEv+PqWy/mwuWEHHmyklM9Pzs 7TZn/f0qcExjBWoG4jlO9AkDpES+bELQJR7dNNIId8JQolr3zRXw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47j766cfem-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Jul 2025 10:04:05 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5619TiYT005908; Tue, 1 Jul 2025 10:04:04 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2049.outbound.protection.outlook.com [40.107.220.49]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47j6ugsnt3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Jul 2025 10:04:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xE3TjRRwElxYvoba+a5hA8iyYZJNfZF1Byte7w9onCU+bfeUrcRx8vzB8KPrx8qjqwDu1i6RJxzMZWPGr08SjgIM566vPmqlKdldfWe1Zv+fotIeC2tFd5gNU92rlJcZ+YvE9LqdGyosAefXlTmM1U9UNEYxQv0Gn8vKcv9slihT6GerX0MBpLGhSBPT+4Cec35MWhESIaqw4BBKZz7Xq5c9sWhXKfbjunQVTTe8Ef3pE+m2Q6Fd+uqmoutp+4FHMCA2bEN1LZQ9sXfDAN4c/KU1dLcocMwLb4nhXbw1V6Eiczs4XeE2UCeSKU3pDzsH/wBqVWiatSG+6CRcig3Vhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mQj2A2jEZtS3kZVhPppfk5KAcaU4YJ0C9HUswLujEhs=; b=B0DAp+CVR5qgd/uSN6bUwKCAVwwFz3FsSvs4wqsaNhjpCUBp6P12ARjHhypHNwrKS1zUGFjIsMR6znNn7dSnnONxgloX6Q36sOgqd/ruw6+/J5sQcDVX3qzS2mDZ1zRHAkYbatxZBfMXeZnXlM7GcNMQm9ZYbMIw0AgCM7AREN4fnC1Rlqg+X/j0qLa3AofF3AiqkBlyOzgWQrYrU45kGxV+eqH5FgxEsIhhQvXEC3YVT5R1gV+T+Jt2F07MrRCNzxhIQZpJbDGhEHpgR6gAiR9ywQCnX5q9uLHGdJYyLwIssqIK0t3QoDM6kK6aOVYa+GWjPiRw4lhJnBp0SShmjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mQj2A2jEZtS3kZVhPppfk5KAcaU4YJ0C9HUswLujEhs=; b=RO/YvSMFV9+Jcj/y1yCKrp63F26SOujPMKgZSJSDl0+I2ADokH3n/e1o6rF3M3wnX9Zj7meKNIo3fQKDg0YSuAkzMQDIJTeL7HDf/jOqKiOL8RSqlYKFkDYzfb63sIbcY3hYC4luzXIPI2rG7Uy1JjH6RTei3odRdw5sv7PzLVk= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SJ5PPF8337777B9.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::7b0) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.27; Tue, 1 Jul 2025 10:04:00 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8880.027; Tue, 1 Jul 2025 10:04:00 +0000 Date: Tue, 1 Jul 2025 11:03:58 +0100 From: Lorenzo Stoakes To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH v1 13/29] mm/balloon_compaction: stop using __ClearPageMovable() Message-ID: <65804db3-71c0-47ff-8189-6a1587d4a0cc@lucifer.local> References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-14-david@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630130011.330477-14-david@redhat.com> X-ClientProxiedBy: LO4P265CA0230.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::6) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SJ5PPF8337777B9:EE_ X-MS-Office365-Filtering-Correlation-Id: 03390a08-8835-4fbd-94ce-08ddb8869a00 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BEKUe/UiQbp3hc9L3KWZPI0LM2AAr9Ce8Ufcg+aKM50SHQVqy0KnWAuUvB6l?= =?us-ascii?Q?zoe+Cki3dc8cNmtPW9X8rJCzVYLmFd1GBG4N0E2wgL1DZrv0zCo1FZtKGhx7?= =?us-ascii?Q?V5xpLbD0gtxQogpl2FVrcqkwoUtdzUUkY8cASf8Vglz9AMfLktVxEUB2X5k5?= =?us-ascii?Q?Qf9O9XSwUaFlgn4+jERpwPp4u5cqNSrgKkJfSx4ZXgIGVhY+KjVnz1qTdNpf?= =?us-ascii?Q?alXMAeOgvpP5i1JEuLK6nvs6D9ObrSHOlVjKIOZxLNJtyOb8GJAdrG9hkhKF?= =?us-ascii?Q?tvGkf4Zo/Dmv5BOvz4xdncan22WDiA8U1slZSIiwuExkE0Rwtwn/5cqNSewf?= =?us-ascii?Q?sIyVMsD2nb8SDevcVGUw4Z6Fp/TOYRY6rjst3B9zDAaX6KGakUqrtqTgjoTI?= =?us-ascii?Q?fFafJco439xya+loGD+Q7UXZaPSZlTot5GTyYfwdIUtSqoGoGJtqT98KG3Wt?= =?us-ascii?Q?vPmLZ8hd/Cmxg8CXB9kO7yRdpV5A2jlD7lI2mQDPP+9biuwFM9BwkTqdCEDV?= =?us-ascii?Q?yRzJI4GkOnXowl5yZtEL9SCQeawwmhs4ZXhni+0ORsfcEIuuXUtWwNDxZKjb?= =?us-ascii?Q?LRNBHPRqX2VcRHskXeFvicMT8tykPuE+Fart0mZKpkGFw1Eu8MRGC2n96Hfk?= =?us-ascii?Q?UNJQQw0KVToAVxHmaDYOtv39zidGcFHcY60eZtVnznPP3YHlZrNrXqChKwiQ?= =?us-ascii?Q?/XUbehOLa+ot6VLVrLcFkg0HIe2Kie5VO9tkOR2Jfak1AzCM03rQ2oUiCpqN?= =?us-ascii?Q?LHA/IBa60xl2sz4pAzRa1qs4B78C1naQr5+bjXNkHYF/w6qLGcHrruembNCm?= =?us-ascii?Q?y2yjXbkcSsMgVfMTZufRsMAkW2u28yoB1OIkqRtlGjZaM9UFR5d5odzyPnKc?= =?us-ascii?Q?PeJFkuWlP7Z0rx6d8dWjIw4F3Lc3KeFyL/ljaticKraMqc+9aTQutk7brX57?= =?us-ascii?Q?TZfr/U5G0Tf+TdTExrB3GLtwMjESkdsr6xfAqajMCmOgazOcnXTkMbPEyk5x?= =?us-ascii?Q?gOZG9M2Pvq/g1N6TqSPcTiwSpMob/YZrAUGhys6pRMRDVY2F5stE+SuUE01N?= =?us-ascii?Q?9Wej16mBSfSctELsTdKEhqCogiIOJmqCM0lNi0+jgZ+whCcr8QUuiv8xRlVc?= =?us-ascii?Q?x18rTEsi2mGwUkcsvX9pHuJtvT/cY3U9sJMAsHUckq7vjdTLfK5PLe9jE/C+?= =?us-ascii?Q?+UDp4yhXdvYvMMdf+Aq/HCvC/vsrmEVab0FfeKzKdpc1iwD6P02PiFxUUPuY?= =?us-ascii?Q?bJ3SwGFUULnGFY2qF5DJMZkI/Ow5pmU9b5CLrSVbIzHLneOBllagYjj5ILhc?= =?us-ascii?Q?n9z5WZrBvHnO9hI7LdrCe+Pbf+9KAfb+Sh37ue5i/0uI0ATcMZy16NDW5V/Z?= =?us-ascii?Q?JdF88uZUITv+sXwtDCa2vvne8Fi10enHSwQ7EBoWyNM9TNaN35PVX68DeAat?= =?us-ascii?Q?VnXbTCwQj9o=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pjyZfnfih191tL59d9GKu8/YHEizPMGYA+DJGgSs/f3ATVxBRkkLyjD3Kfuz?= =?us-ascii?Q?xVFg3yeNCSKCg9iOoTNRyn0AatlApon1P2oB4PDxzHz6bB02G2nShBqYj0Sh?= =?us-ascii?Q?L8v20E36SNuA375x0kVDbaZ1WlfBoYoQSd8gdYOMmaFfh0l9lOLp7JUMg56K?= =?us-ascii?Q?aURNnIWB4OF3IVywuWVNVRRBOrKkkL8+MMAloAgpeVAxkCLFMH8l3cSEtdCZ?= =?us-ascii?Q?YzGmBFt22KdGDDCRDo2UTJWytGUrJ18ayxxb+x0tvoXlhRUNzi4/gxTNqPSr?= =?us-ascii?Q?OPSt+CeLmnXoMNE3iElmVV/Pi/zO2yrZTeE7kY6FUHrVXz4PNDrjTA2F9Gcl?= =?us-ascii?Q?PhZ+Atgkz2PsLapz4q2mOme2KC7bF8E8qvCl4K1lChEERoGPdAQIAADd+JBX?= =?us-ascii?Q?batvyHneIpkdANnzIRv68oIVW8fIxXsit+OTieeX6wn5r0ozEa+mAcYHl7ey?= =?us-ascii?Q?IT/J5aYQSYuOkmgn1jGWxSryeu0Q0PYJQHgpy1+HU0S5P3pZm5aGEhWTcACv?= =?us-ascii?Q?6Y1WXZAklg9qKqLLgPAYEcEiYjnOKiaSbD0d8UeaH4oIl3RctUV6pP8l6/Rg?= =?us-ascii?Q?y6giikn+JrrZBbOOYvz3cOcbWgslr5M5ArSWpWZrB9fmoWjat1abMa2y9kfD?= =?us-ascii?Q?R4BwBXAB37zSkhUKGW/0EhJzSQFfy3iY1W8bH5PFF8E5z7mXoktn2kx0KoQ5?= =?us-ascii?Q?RnF+qyK1b2c1F7p6LOZ2smRO+3KZ1WKFp/SOIw9QS9AW0HHYW+VdEl/WL6YO?= =?us-ascii?Q?xRNP83yBKT6MhpNsTtvIHEwu7hnJQs8mzUHfLQF/MH93eWOHP0jMNnRbuDPG?= =?us-ascii?Q?GeUgDIYaL/i8p00wmK/UTDflGd09mwefMJwOTuwX0YEkAAYmb201FHCRPJAQ?= =?us-ascii?Q?FABIbIniNSg0PmdMVuFiQ5LvRQSJy22lXEtAlycnZn4pi9uRQFM1QkgiUgXS?= =?us-ascii?Q?Ya5+CWcAgTHIHmK00bC9hfhiPehPb5dorByFgpa1If4GgGwjit85jXKHq+K/?= =?us-ascii?Q?fmNG4wxr46jB2JJ7h/BRwlI3aRqTztBUlPihcw3unMfugdtsW7RX/U22EiHa?= =?us-ascii?Q?+JgL4sR2aOzSpFPfU1ZcFARwh2zkkMgNZXEhpbYxyjkw87QZS/HfSCB38Vdn?= =?us-ascii?Q?ipcN+IE69KiDfEnj8LxNRjiAyidIIdFjRvB6MUiU4EAHMHLABxTjsuIWZ+jW?= =?us-ascii?Q?PtNxxpFJ0WCiWtF9JJXPr4zN+AV9qwXDgqnFtxFthaL8YhuFnSmnLoPsBpNP?= =?us-ascii?Q?ovCbeE0sKjRK9uLe2YuajLD7mHnmsaHC2y1ZmdbnIdbQMG/JPXMkYGdzA7AC?= =?us-ascii?Q?+T9UgwrDiPeRlO699xWaolWUL0gXGT9zoI+RqpLPfeTBfjK2pWQnLaXi+d3L?= =?us-ascii?Q?sS7x7Jl0tRSpxAqJD9Svjo7pJzIe9ON2HIyUFWn2Mbdp9+rLsWB1NmUxPY+/?= =?us-ascii?Q?Qa/8yHtIAnty7X/isiMo+N8adaFPbTFOEAEABEl+RUEgn0Vt1qXr7xNP3a6g?= =?us-ascii?Q?T6RxOYvZVtOsjMvfSPYsu5goOl3fRr/XuAqq/83rdCDb/fFlCwxDBMOQBcAM?= =?us-ascii?Q?Gu1tkD3C/Qf53BtEI9cCZq65pZ26rJeA03uYjs1la10odk+FGmq5bOS9IKuN?= =?us-ascii?Q?tA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: meywF8FFtmguFLEo4U+RuhsTzhCyK1TWjXoY7hgoBcS1QQQJelmKj5Il7TyMzLFhTlbi3MGQWRBI7XGdq1aKq3A4UtWplg4L9AK+gDm3NU1+jnaOr/qZCGRqHi1aRQIee0zVC+gsBonoAPBQN1p/EDZGYQbtRrmFzkV8BhAhwT3oqDpf4RplqvIM6AJ6mAODojuZtWD4QxP1J5lm+e9f/n1dN/awBZGlsAOtAIZEQBWlK5cyk6jb5D9HQyTdFo1Hf3VCUDhVf5yh89tc1HazSku3haYwCUeKEvhoOrYmbG6IFRTKDPsOcoyeYjZ57EpSgLrhQFT3lxO/QJT5VQoeu6KqndOqnIeKMUYv1uoE2zmHzZfQitg3AWs7RAvkdN7hGMt5uoUckfNXCigLhoDKiS/+6rtOk1jUnO85n/ML720hvogri6bs8X7QAu27MZCfWQmCyNSq4m5b2P8c7PIYi//eANz6OeTAv03dRG9GAJrhn3D+7usTZsZNXsVkUxwFZjWzUE3D/3gM5fMSsiN4rqZS4U8qiFik7n+01SKo/Nl93fgTMsVCodf5vUI6BBvnZ59ZAYRnMzy6zpTA6qm8Fb1LSbkZXSXQa/bVLn1dc5U= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03390a08-8835-4fbd-94ce-08ddb8869a00 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2025 10:04:00.5948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u9hp8x8EecEkAkrg2Vaa9/C8Yd0r7/HZut/js2SnIOQv9Nc9x2qoDxrFgYrWtHiksTSr4LTRm34CqUhqkv2+qtm3WdNl9QbGzSRCNR0V2nk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF8337777B9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-01_02,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507010060 X-Proofpoint-GUID: n__H7PrE-zdWfxHNHryt89-46FXVsW-u X-Proofpoint-ORIG-GUID: n__H7PrE-zdWfxHNHryt89-46FXVsW-u X-Authority-Analysis: v=2.4 cv=b82y4sGx c=1 sm=1 tr=0 ts=6863b295 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=20KFwNOVAAAA:8 a=yPCof4ZbAAAA:8 a=j7oEd8P2PXKous34eYQA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13215 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAxMDA2MCBTYWx0ZWRfX0ZRbC9LvAdrt oivIO0veyHKC+krgWeCaKjZZ356lneJblJDCUNHIKPHmmDDlJw2m+Z+CUFr25MAq7hGa9WeXrtQ qTkaj1TEZZ7zARowyGR7vT9l/cOPr46FxxmKJCmAYy7KnLlKDBv/4ZDyQELzFv724sSBMFtFlPl DP98kcCmy9ZYMZdnCs1+SlOe3k+lFPkgaoATsAjrrbYzrm2+iMqi1FV5DC9MiOo4CNehYwB9//C 7y+XjQzw61/Kjwehy0ZwaNHCiVMzGaCi/3EjyBQJTyr7b/Y6kHZOQFh7WZXFU4IW9NvW9Ms/5Zu qmVhR3xWTbKVy6yITDbgh4gPN8vReILIvCAT0GMVlIms39gclr0zI8ctkmaEL/bg0zB+ML591RE l2iflBMnGGlPpsh92mIGeg2kA4JXuQy0o/bx+sineUq27Rp2m+CpVKmG3j5x94GRiy5xCJVJ X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D9A7618000C X-Stat-Signature: g1q3mwo4grod8fg3713z5uixqaxskhdb X-Rspam-User: X-HE-Tag: 1751364288-323964 X-HE-Meta: U2FsdGVkX1+/OVE2XeDgIs94CRZDp4YyJNxP9mnoY4ECjyW2h5hAAdCZC0LJgstRBG/vWprle0N6raGde6KBQBJbLrZ/Thiu2hWJLHG5baZNbmttt0hV/c9obe3cUUDpGTi8iTF2mWqjujU8PraL3YxIh/7uIlPmVkt8SO/6Ugqf3JVqD8ujE4qmnknkvINGVhfJbCTke/8Cl4AqXAc+stHwfkKMi5fnxZ69hVRi3MA2KZIy3qRXJMY06K04fcRPXbQQs6UtGqS6EMAm/iZSBhM5qsX1SXMUA2NjrZuiBe64SPn1gHhvwdCdY21Nq4BD/6dq+6WCenFxbbd1EKG/pBv9IP7eHRNvlcSp6g2UKNsGMbbs0eoMZkWeVczaW0NjcmvonBtdU+rop5SCtziGwj667oWPmc94EHcEdz1h4FepGV8wJDCjzlDVIR0+dsDgCK0aDaT1ATgjTPHoWGk71pC/dtE5kXYzRJHhTGQSeHqeF/feooBFjxWd81YtOplNm1msaNZSmhiimFqULdZYYek+dmPvNK3pibMyDTptR4s33iOCRs97LYTBvipz6Jlf7CIMxfAErzg6oILWXDbOOGdG2LDLRdVwwHnSnabhjadcEu2dTnEWSSYBkwTzR+kxKJYuwqmkyPiNiGQvKx2mGS6FwbS1xynocOVLZFgoBM5k4FP7hIoCzA27VCjwdqgMzEj0fW9Z8ylU8httz3hSfjSCew8CjmZmVierMizKQZkr0PvR+gbzdKzAQPNg5So3JN624M8i35eKUulwgtDtWIBa/5u2lTStvRR29rsFd8+DDuNnpmKr+XrnMx8OllFmTuMzHzWx+uXfbKPWqkzgR8uNWt3b1yw0u/raDXZ2YHFOolzLQOhhgJH4FZwq1fdVmnFf8AbLNmhxRBa8Iga50OuV728W9ewxTU2uopmBPgUGJdFkgIQYUvzFA4o08w+0khLdDShaKjyklAzSeRA G5WXXI5J johatMaK3P4pBZLzxMvF02qSs/uDMKOO6X7RKYdIzhtkIoVKuJnQVbNM73gFnR2c+mLXyXZBFJVLWs1mT7YSBvhhgw+xa2dUHItht8O9QCN0IgDYRtNLbgd4ccbEpMYu1TlMN4T9PgGAZLpoqiTF4qS+Ci+BUMeFMBM7EHe6TiGGEhpBMDxLq0BpR5mL57OcWvmLhxreRN4NFKF8JFKe5hHing0zIVgDqc3xfYkLmpYJ9677XutraD4rDIQXvC8SUcdSjwf00+F0sK+OgO/bRKRd/F9OzAy5Sz5lfmBtJM8eM1M9mAdlq6sIVrTA6BttWvX3GfO/lk/XHkkDcRBxTjb1ndS6AKomMnnOmyEHgkBYYosoLawpnHITWsgmWN7EnSL3tk1JVjgY5o/6BTP78KjN/OsoVDUxaoOTvyJ5gk9N4FchqD8OH2XHWKrUW7Fp2lnhdfzYTpPI+Dze0MGmdEbvYUkbbu/MUvwHOjxrs+G4+1PNT8z05TRyRzWaxL88hLYqjACzT3v2g7sJcN9tf0bKEwwiw1oUv/yduiWSxMlRNfjzjpNFGjng2648C9RtVved+HaRM7iB4RNECFR3WosCpa9lkPp/LUS+MyEfoxdJ0TfyPFtcFS79vZTGEl510BlZsID14Tq1ID8STXX/dVCsRomBIUgD30oiLFFiOTdu9Ix47C72xaP6ImzBBs/KtizfG227kDARKzM0x/8xg34bRrvqTc/gVUpERt7HgHbZMyl/jfdoRj2RcXedNdT1JGce4LhQcF8nPIiiuDZBrWhIB45pPysQnXY00v5DshBMQuoV2khPqCXlSzgXpNm29jgH7/ZLZErqE9HHB1MGAwN9uTT2NakuUgMr3hC1762ozdvtrhlK5r9WmAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 02:59:54PM +0200, David Hildenbrand wrote: > We can just look at the balloon device (stored in page->private), to see > if the page is still part of the balloon. > > As isolated balloon pages cannot get released (they are taken off the > balloon list while isolated), we don't have to worry about this case in > the putback and migration callback. Add a WARN_ON_ONCE for now. > > Signed-off-by: David Hildenbrand Seems reasonable, one comment below re: comment. Reviewed-by: Lorenzo Stoakes > --- > include/linux/balloon_compaction.h | 4 +--- > mm/balloon_compaction.c | 11 +++++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index bfc6e50bd004b..9bce8e9f5018c 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -136,10 +136,8 @@ static inline gfp_t balloon_mapping_gfp_mask(void) > */ > static inline void balloon_page_finalize(struct page *page) > { > - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) { > - __ClearPageMovable(page); > + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) > set_page_private(page, 0); > - } > /* PageOffline is sticky until the page is freed to the buddy. */ > } > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index ec176bdb8a78b..e4f1a122d786b 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -206,6 +206,9 @@ static bool balloon_page_isolate(struct page *page, isolate_mode_t mode) > struct balloon_dev_info *b_dev_info = balloon_page_device(page); > unsigned long flags; > > + if (!b_dev_info) > + return false; > + > spin_lock_irqsave(&b_dev_info->pages_lock, flags); > list_del(&page->lru); > b_dev_info->isolated_pages++; > @@ -219,6 +222,10 @@ static void balloon_page_putback(struct page *page) > struct balloon_dev_info *b_dev_info = balloon_page_device(page); > unsigned long flags; > > + /* Isolated balloon pages cannot get deflated. */ > + if (WARN_ON_ONCE(!b_dev_info)) > + return; > + > spin_lock_irqsave(&b_dev_info->pages_lock, flags); > list_add(&page->lru, &b_dev_info->pages); > b_dev_info->isolated_pages--; > @@ -234,6 +241,10 @@ static int balloon_page_migrate(struct page *newpage, struct page *page, > VM_BUG_ON_PAGE(!PageLocked(page), page); > VM_BUG_ON_PAGE(!PageLocked(newpage), newpage); > > + /* Isolated balloon pages cannot get deflated. */ Hm do you mean migrated? > + if (WARN_ON_ONCE(!balloon)) > + return -EAGAIN; > + > return balloon->migratepage(balloon, newpage, page, mode); > } > > -- > 2.49.0 >