linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Satoru Moriya <satoru.moriya@hds.com>
To: Randy Dunlap <rdunlap@xenotime.net>, "riel@redhat.com" <riel@redhat.com>
Cc: Satoru Moriya <smoriya@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"lwoodman@redhat.com" <lwoodman@redhat.com>,
	Seiji Aguchi <saguchi@redhat.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"hughd@google.com" <hughd@google.com>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>
Subject: Re: [PATCH -v2 -mm] add extra free kbytes tunable
Date: Fri, 9 Sep 2011 19:01:13 -0400	[thread overview]
Message-ID: <65795E11DBF1E645A09CEC7EAEE94B9CAFE00218@USINDEVS02.corp.hds.com> (raw)

On 09/01/2011 03:26 PM, Rik van Riel wrote:

> @@ -5123,6 +5135,7 @@ static void setup_per_zone_lowmem_reserve(void)
>  void setup_per_zone_wmarks(void)
>  {
>  	unsigned long pages_min = min_free_kbytes >> (PAGE_SHIFT - 10);
> +	unsigned long pages_low = extra_free_kbytes >> (PAGE_SHIFT - 10);

I think pages_extra is better name for this variable because pages_low is
calculated like following.

pages_low = pages_min + "pages_extra" + (pages_min >> 2)

>  	unsigned long lowmem_pages = 0;
>  	struct zone *zone;
>  	unsigned long flags;
> @@ -5134,11 +5147,14 @@ void setup_per_zone_wmarks(void)
>  	}
>  
>  	for_each_zone(zone) {
> -		u64 tmp;
> +		u64 min, low;

Same as above.

Thanks,
Satoru

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2011-09-09 23:03 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09 23:01 Satoru Moriya [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-01 14:52 [PATCH " Rik van Riel
2011-09-01 17:06 ` Randy Dunlap
2011-09-01 19:26   ` [PATCH -v2 " Rik van Riel
2011-09-01 21:58     ` Andrew Morton
2011-09-01 22:08       ` David Rientjes
2011-09-01 22:16         ` Andrew Morton
2011-09-02 16:31       ` Satoru Moriya
2011-10-13  7:33         ` Minchan Kim
2011-10-13  8:09           ` KAMEZAWA Hiroyuki
     [not found]       ` <E1FA588BC672D846BDBB452FCA1E308C2389B4@USINDEVS02.corp.hds.com>
2011-09-15  3:33         ` Satoru Moriya
2011-09-01 22:09     ` Andrew Morton
2011-09-30 21:43     ` Johannes Weiner
2011-10-08  3:08     ` David Rientjes
2011-10-10 22:37       ` Andrew Morton
2011-10-11 19:32         ` Satoru Moriya
2011-10-11 19:54           ` Andrew Morton
2011-10-11 20:23             ` Satoru Moriya
2011-10-11 20:54               ` Andrew Morton
2011-10-12 13:09                 ` Rik van Riel
2011-10-12 19:20                   ` Andrew Morton
2011-10-12 19:58                     ` Rik van Riel
2011-10-12 20:26                       ` David Rientjes
2011-10-21 23:48                       ` Satoru Moriya
2011-10-23 21:22                         ` David Rientjes
2011-10-25  2:04                           ` Satoru Moriya
2011-10-25 21:50                             ` David Rientjes
2011-10-26 18:59                               ` Satoru Moriya
2011-10-12 21:08                 ` Satoru Moriya
2011-10-12 22:41                   ` David Rientjes
2011-10-12 23:52                     ` Satoru Moriya
2011-10-13  0:01                       ` David Rientjes
2011-10-13  5:35                         ` KAMEZAWA Hiroyuki
2011-10-13 20:55                           ` David Rientjes
2011-10-14 22:16                             ` Satoru Moriya
2011-10-14 22:46                               ` David Rientjes
2011-10-14  5:32                           ` Satoru Moriya
2011-10-14  5:06                         ` Satoru Moriya
2011-10-11 23:22           ` David Rientjes
2011-10-13 16:54             ` Satoru Moriya
2011-10-13 20:48               ` David Rientjes
2011-10-13 21:11                 ` Rik van Riel
2011-10-13 22:02                   ` David Rientjes
2011-10-11 19:20       ` Satoru Moriya
2011-10-11 21:04         ` David Rientjes
2011-10-12 13:13           ` Rik van Riel
2011-10-12 20:21             ` David Rientjes
2011-10-13  4:13               ` Rik van Riel
2011-10-13  5:22                 ` David Rientjes
2011-10-22  0:11                   ` Satoru Moriya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65795E11DBF1E645A09CEC7EAEE94B9CAFE00218@USINDEVS02.corp.hds.com \
    --to=satoru.moriya@hds.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=riel@redhat.com \
    --cc=saguchi@redhat.com \
    --cc=smoriya@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox