From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551EAEB64DD for ; Fri, 14 Jul 2023 02:21:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69D2C8E0001; Thu, 13 Jul 2023 22:21:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64D106B0093; Thu, 13 Jul 2023 22:21:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 514468E0001; Thu, 13 Jul 2023 22:21:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 424306B0092 for ; Thu, 13 Jul 2023 22:21:29 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BEA05B0733 for ; Fri, 14 Jul 2023 02:21:28 +0000 (UTC) X-FDA: 81008615856.23.8B01F7C Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf26.hostedemail.com (Postfix) with ESMTP id CB2F3140009 for ; Fri, 14 Jul 2023 02:21:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Qrk063lV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689301286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nPT21jJ10K5al6d1WRqyD1dKmIh1g9KwXfoxEHj+CKQ=; b=2iZp8pckFd4dZH/y6Per6FHDLpgp+ZAXjy9oADjCKatfVOFQqi2lFfBTGqKieeU53MtyOe IjmH2x8ir+SIUkLF8hlhtpqfIuFMt4C2VnMshhY7I3wF6buB0zXFapKzTt48mul41k1nDT fbo5iZYNPvpjmblQv4elUV0T8cVXqYs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Qrk063lV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689301286; a=rsa-sha256; cv=none; b=GX0lCtYUiH+KYYV7lt621A5IUrvRletHoXv/aWUDYe9QMxyZh03hNG4jZxCtzhP5IemAoT Uf1o9gQvadO82zDOfSYDDir8DtlO/gd9h0mUaDfzI0vCYZH3Yb4MUs35bemR9pDxC5T7v+ 5wBERbni7OeuoQ/T8qmFYigDffECKBM= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-57eb0df5265so12334377b3.3 for ; Thu, 13 Jul 2023 19:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689301286; x=1691893286; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=nPT21jJ10K5al6d1WRqyD1dKmIh1g9KwXfoxEHj+CKQ=; b=Qrk063lVDJXohNNs69c6BnwN4Tp7O34uuBstMu87PDyYA/7es76kn2yYqgEwpFYf6P q8Fc5hrJasmDjGjBDY6YBpmn7IqgWFLPI68Yz1ppHdJhK4TlFJJYMRfkJGUEV5tWyXug fOVIDNxv2Y3ckJkGx2HfQ/1KtRXLwAldokIjAgMSUxKwKBNnTAaYTK5C5+JG+1F0ooQj TIPQR3Lv/LgI+e5+buQkNjRG8ZVlnyxH8ICUZVNdjb4+IHXI38eqi9GFKYZHhuiz9BQk CVEuB02N1sHTxLQKlNWTgxkTZ7nHCYEUc2mtRCONfe71LB9rt8H41YG/9Cr6OZs/YbgV dn+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689301286; x=1691893286; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nPT21jJ10K5al6d1WRqyD1dKmIh1g9KwXfoxEHj+CKQ=; b=bePc1xT8rsTe0eS/UPSNN2XqcoGSP+B7Ml2y9RyL+r4tiErZjkF/yNuXjfE5A6F7ua 9Qd+58Ias3wrxWnpWxPmiSKjuYwdEwlJUAT1J54QiOkm4YbYE5SQI+1GXtwAVMSh35Rf 6jZEVseHIVhriDuto3VIvNFhsDI1/D+8snkbVtne5fzbwK++B2wlizv2+vTumcEG9fpI z7yAaKUQ0fKzGDqZ3kdvei4C3jK+HcvmmgkSPMHA+Kvs83WBdeLyIMtyvu8ntc0hTmqJ LzlCrpRS4CQvxO9S6ufRTXeXq3OyujjcTuDCS8ePi34BismE1LTqYZDm49iAuOKsnVe9 0iew== X-Gm-Message-State: ABy/qLaGBcknngkjkuM50vKxlX6uO8J0a7W0rD116OLD/nibyps1ffCZ VLxxo+GatsCHEo7DWlrI4qg7Tg== X-Google-Smtp-Source: APBJJlHAkOo/DcpF03vqEFA5G8IaQaPqkQIrTI44airjaZ4v8GZWz1EXsKa3qZWCTT3u3uVIWLNUlg== X-Received: by 2002:a0d:e812:0:b0:57a:504a:e019 with SMTP id r18-20020a0de812000000b0057a504ae019mr3443519ywe.20.1689301284364; Thu, 13 Jul 2023 19:21:24 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id c23-20020a814e17000000b0057726fce046sm2062661ywb.26.2023.07.13.19.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 19:21:23 -0700 (PDT) Date: Thu, 13 Jul 2023 19:21:14 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Yin Fengwei cc: Yu Zhao , hughd@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, david@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com Subject: Re: [RFC PATCH v2 2/3] mm: handle large folio when large folio in VM_LOCKED VMA range In-Reply-To: <6cc5a915-a28c-983f-9b32-6040f033970b@intel.com> Message-ID: <6573e671-62e-b7b9-1aae-64336c32bf1@google.com> References: <20230712060144.3006358-1-fengwei.yin@intel.com> <20230712060144.3006358-3-fengwei.yin@intel.com> <6cc5a915-a28c-983f-9b32-6040f033970b@intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463760895-755330418-1689301283=:3952" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CB2F3140009 X-Stat-Signature: b8dzzqjknwdc1y6g6xxjbd1wbnoi5bi4 X-Rspam-User: X-HE-Tag: 1689301286-846514 X-HE-Meta: U2FsdGVkX1/VuR3gyVnb9kgvo+Bz1xHjdb4LzNpChgfqdwqHQ5dZNKL12sEDEF93gd8TDR7ulGsmav8bPYnplEpZwpZjct+EOBSRvqpEqnjR7FJIX0U0jui6wKikVnPE8RcmMxTzuZ97rt+3lkNTcdnJm21F0CburpBUtOnmaMIeVTAGgH+hpfiq5rHjxr1VDxY2p9KC6+USx1a8Jvf6er5Z0AxNNqDKjmmmJxDDjdd0l2gb2ijcFZ5ThUvXAyjRgKoCkqbAwKGz7vSNOYCC6+dGIX03Y4wrphdo6MU0v9jKEFakOajVzF2ShtUKF7g8LbUudXX5wBFRwvafyq9HpQpI6M82EaH8MLbjjmHzlisOuZQnOm8Txx8QZCVw1jgQU0h0WCG/wQz8NPpDHXSheLiUsLAPluKvwbcDrFzuPp/Rh34DS86XNn1ZWADjg8TQ/hF7lusFzpqS3Q/K+3rsa+wl8ue2c4Z5y1KAKWG18SWYLxSFslJ+4RVN+w0S2VT5GM2ea0JKEqETC1A0ROK3jYdNSQ6eDlhZIi6+/HGKT48bsJ9Qg6wczJdc4vnoxHbenbAYFYez8zUtu8zossAjnyN65GgakAHe9qFSDIB+K/hUWtX+0hy80JP9Pm3ku/ZW219U34RA4HHroq3I8y5AysigmvfBr14lFiHWpKL/nEVBCnMYywmJjzgysWODHYSwoNrtj6VeSoAK9HFCzphBPbyrmzbqwU3lRQ/pLOCay7EWQj38qCt/k5hfzLlp6GZmSCbxIXS5cykSZ4sEfADZarTlOIg/KTaqiSlSBTjQDRjtBaKEIDBh9s4cFSGklPTjjyoR1pbb/vC+ofc0fkp+6Wq3BdiLQSJ3Lq24XT59aRlGMsg2yxEYk9FIbDBiji9aJb0Hzny0GQPpM4v/UQBaiakQNB9epmqTVILokTXzSogM0T2Vi0L5d7kkZvHIuVibzZxdUMSt+61jE42KI0u xJssS5yh HPrpk3Ed+Ap086BBEYz8GNIo/NoKnFg543DbOjQ+GpcBANe9uWPmwBJSZ75dZOdbM0OMHxmAEN5+0+Lznj6saPKw7MO2hR7UCoHj1BDrjri9bsIK/XO7/F+5syN9iEP8EabCVbincip2QXq3S1Cjoh/lxowAwd3R5eYrgeh3Be9ZCMyW7tKaOE6u7wB61O60UaUe29vEEm30v0HNT1sQAuVqIFBgQ6OTCyo2YkY5x5jaJsErwqIMKCGRWkbfrjrvaNQzmRl0oVgyIbFyLwBCN7loPAwxtoI+jPYwwZyzmxWbGPIjCaH2MEutxzPyOPitM76/CifupFWgbs7V0vvPrg6hTwMyWZRAO1w+WWAvHYbACj3WphG++QjePLkN2XDVwXzxeLd0TRVwFjt+Dvse0C8Nl1JVWa4i35WEtSS71VmdYHiPz3dAn5rGHLm7RXYQad3MtLl9bK2VGClCRjCGRdp4GSO6R9ku46rf5FRE4ldoi7D/r79Z7p7piSmnidN/cHCM3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463760895-755330418-1689301283=:3952 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 12 Jul 2023, Yin Fengwei wrote: > On 7/12/23 14:23, Yu Zhao wrote: > > On Wed, Jul 12, 2023 at 12:02=E2=80=AFAM Yin Fengwei wrote: > >> --- a/mm/internal.h > >> +++ b/mm/internal.h > >> @@ -643,7 +643,8 @@ static inline void mlock_vma_folio(struct folio *f= olio, > >> * still be set while VM_SPECIAL bits are added: so ignore = it then. > >> */ > >> if (unlikely((vma->vm_flags & (VM_LOCKED|VM_SPECIAL)) =3D=3D V= M_LOCKED) && > >> - (compound || !folio_test_large(folio))) > >> + (compound || !folio_test_large(folio) || > >> + folio_in_range(folio, vma, vma->vm_start, vma->vm_end))) > >> mlock_folio(folio); > >> } > >=20 > > This can be simplified: > > 1. remove the compound parameter > Yes. There is not difference here for pmd mapping of THPs and pte mapping= s of THPs > if the only condition need check is whether the folio is within VMA range= or not. >=20 > But let me add Huge for confirmation. I'm not sure what it is that you need me to confirm: if the folio fits within the vma, then the folio fits within the vma, pmd-mapped or not. (And I agree with Yu that it's better to drop the folio_test_large() check too.) This idea, of counting the folio as mlocked according to whether the whole folio fits within the vma, does seem a good idea to me: worth pursuing. But whether the implementation adds up and works out, I have not checked. It was always difficult to arrive at a satisfactory compromise in mlocking compound pages: I hope this way does work out. Hugh ---1463760895-755330418-1689301283=:3952--