From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819EBC433F5 for ; Fri, 1 Oct 2021 01:27:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0C21D61214 for ; Fri, 1 Oct 2021 01:27:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0C21D61214 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 53CAC9400ED; Thu, 30 Sep 2021 21:27:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4ECAA9400E4; Thu, 30 Sep 2021 21:27:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B3289400ED; Thu, 30 Sep 2021 21:27:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 2C9149400E4 for ; Thu, 30 Sep 2021 21:27:19 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E47D118463FAC for ; Fri, 1 Oct 2021 01:27:18 +0000 (UTC) X-FDA: 78646130556.11.1B03D40 Received: from smtprelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by imf18.hostedemail.com (Postfix) with ESMTP id 9BA854001E89 for ; Fri, 1 Oct 2021 01:27:18 +0000 (UTC) Received: from omf19.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 5201D182CED2A; Fri, 1 Oct 2021 01:27:18 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA id 8BDF120D756; Fri, 1 Oct 2021 01:27:17 +0000 (UTC) Message-ID: <6573ccd25ce80f5e28ed35e4c88c898b0f994fbc.camel@perches.com> Subject: Re: [PATCH] memblock: Neaten logging From: Joe Perches To: Mike Rapoport Cc: Andrew Morton , linux-mm , LKML Date: Thu, 30 Sep 2021 18:27:15 -0700 In-Reply-To: References: <623750dd31aa3fe5e45c416be98ab37707e2c45d.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/pOhNom2PREIjURhP051NROEzMBgf1kA4= X-HE-Tag: 1633051637-829100 X-Rspamd-Queue-Id: 9BA854001E89 X-Stat-Signature: 9toiq3xxaq3ms5iqqza35c1zjedry4ze Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=none (imf18.hostedemail.com: domain of joe@perches.com has no SPF policy when checking 216.40.44.97) smtp.mailfrom=joe@perches.com X-Rspamd-Server: rspam06 X-HE-Tag: 1633051638-598654 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote: > Hi Joe, > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote: > > Use more typical kernel logging styles. > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt > > I don't see it as an improvement. On the contrary, the output becomes > somewhat tautological: And rather easier to grep as the prefix is constant. > What is the base commit for this patch? > It seems it missed a pr_warn in memblock_cap_memory_range()... linus' master.