From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C15EC71136 for ; Fri, 13 Jun 2025 14:39:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 097C66B007B; Fri, 13 Jun 2025 10:39:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0478A6B008C; Fri, 13 Jun 2025 10:39:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E52C86B0092; Fri, 13 Jun 2025 10:39:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C4E556B007B for ; Fri, 13 Jun 2025 10:39:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7E8321405BD for ; Fri, 13 Jun 2025 14:39:38 +0000 (UTC) X-FDA: 83550636036.23.41EEDDC Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf25.hostedemail.com (Postfix) with ESMTP id 700ECA000C for ; Fri, 13 Jun 2025 14:39:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FtwEL6f5; spf=pass (imf25.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749825576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m89hPAjm7JVQxnf6x1SHOwhqzRUcSRlsNcgb9WG4NP4=; b=l3sn2Wlxi2DbvFWTJjxepP6UO0nlgn0zvu0JX5msYVQCtol3bFSlLaOd/LhVVTWBCXNqVu 7WTF4/nMyXFXDJ1p1xnOMZqv8zVd/Exd5/1gNfb5G/1+F/WZbKo4YoyrJznA370ybhxZzT sM0cxms1+zhzUZdrqFDSarSdQbmB7fU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FtwEL6f5; spf=pass (imf25.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749825576; a=rsa-sha256; cv=none; b=JtafT3X/FaDk3A1kb+Kyw8f+ZaeFro0Qxx6fvVgXr3JBI7gU5G5evM2ZzdDWcbGwti4gSi ySVYZDDMVvPN21YMCpTX3lzb/LzTVL0dekHdt3dbTUIzw7n2iKIfG2ZCXAc7Cmizh2wfWN Tsu3VNbJA0gxhQzPhlGK4AiLk0WUAP4= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-442f9043f56so13095945e9.0 for ; Fri, 13 Jun 2025 07:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749825575; x=1750430375; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m89hPAjm7JVQxnf6x1SHOwhqzRUcSRlsNcgb9WG4NP4=; b=FtwEL6f5ukI6nj/+l6EfM0bDfT6VMGQBmsukrivOjCpbq5MGyVUfbPbNxGH3Fxqgjz AKUB2p7E/LTdGn7/seuzd9URsvA983uKfY8d11dWCLYDcYOrV7G6cicTfMgDFbBTasPY uLRDkHrlCcU04/bcCxppTIRQ7Iu25V5aGblJvawaRjqFgyKDskXiUlcFTxM3fYGq/pTs 0nfnZhSHjFIzImsYF5S/fb4TzR2kXRJEriK5p4JVR7ISw73Mb1rmHEV/YrgyuczG8SRk 9m8BfNXDtB280mxQ59aCc/BVgX3Mziv3xodvsf6XCz/XMo2vRagImv4ZKE16ZcNRO3qV d43A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749825575; x=1750430375; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m89hPAjm7JVQxnf6x1SHOwhqzRUcSRlsNcgb9WG4NP4=; b=Jd6OS5vaIezkXsPO4aznhd7xi8PqIFMW7dCEjU2R4gDdGUc2k0oit9cUPX/pf5bmH3 EfEFUchaggXHBHXees9vQl5hfcesNaxhesqFXlQvnEEpyDIF2SMGYCdJC6RzzwiWz91T zEGmnZtU9GH7dgMcyZm7rNSuODiMqcfW2FIRUM3ZF54T3lTwyE3ciqKYXoH0czZ8dePZ bCwj/50+hoyVne3hQDNJvAgLtWwhFus/UP99zsICF0Vr0uhKrUpZILV3m4NziAITt/kr sUiEr1vi/+GDu4oWEx2US5D56Ew26ON9px1AqDsFr+lAnZkTSyLwoQZABIcHL0AFwzAC vD0w== X-Forwarded-Encrypted: i=1; AJvYcCURjX7gTF0FRFtfgcD5648RDhntQ49+mhwrL4XDI07XYvAVZAFrbbJ6PS3R5RUioejRfd+IYzzXlA==@kvack.org X-Gm-Message-State: AOJu0YzpgAjONtdtE/k7qBYpjtNibMVogXXX0Ff0ClJUaL/PkK/FtCrV oMVitacFRfnZqIZE6TvD1l8TyHQHZVT7207o+U/i19ExVHbUVlt2Fa3/ X-Gm-Gg: ASbGnct8WHnA26XNSGX+Qz+vL4k9sROXNT0whq0ulz+yFrotb3DXfsg6zZxr4Et84wf DQHXcDJn77y+OUpvSX5cdxrvfmL7UlhNAtvLa2koDA+ONIvmveN6fgjaqf+MnyFJkvwEb6TbqBG 9Y6hKyxEErhpLBxSZ7YB9dBmgDqbe97FiOcGv9yV8aEQ5ez5t5Z+xeAHa2kgxS7MsJoueO7bbEr CCJmTeeWxxQ6o6IZZ32m5ylJfoYINKvBm46Qhv9gU/gd0A5mDoWHr1cKpoAj3LzsEZC/HG9gVcM it8Tbs1PTnld15D4ZoFGctHd60oKz3vp2yjMYLpNBupjdWY/mKJmmTvMtcjUVw4vGe/ygiF3ALU OEa4aZNaAv/vl7XSW/gyWupF5NCyJIu2inBLYeoqV7DH20k1j1g5tW6qP3Fdg6vI= X-Google-Smtp-Source: AGHT+IE3cnDdikM1AS84OGv/BitJnwFCLU24i9ehxYAYk5ogEgW+SPifLAYY1v91a2wdyvVXu8YIAQ== X-Received: by 2002:a05:600c:3d97:b0:43d:fa59:cc8f with SMTP id 5b1f17b1804b1-45334b07fe9mr34281505e9.33.1749825574403; Fri, 13 Jun 2025 07:39:34 -0700 (PDT) Received: from ?IPV6:2a02:6b6f:e750:f900:146f:2c4f:d96e:4241? ([2a02:6b6f:e750:f900:146f:2c4f:d96e:4241]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532de8c2d2sm56899625e9.1.2025.06.13.07.39.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 07:39:34 -0700 (PDT) Message-ID: <657181dc-09b3-4f1e-b9aa-ed1d77826e8f@gmail.com> Date: Fri, 13 Jun 2025 15:39:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] fix MADV_COLLAPSE issue if THP settings are disabled To: Lorenzo Stoakes Cc: Baolin Wang , akpm@linux-foundation.org, hughd@google.com, david@redhat.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6d0e65f8-b12d-4ce1-a996-ebb053b9b0c5@lucifer.local> Content-Language: en-US From: Usama Arif In-Reply-To: <6d0e65f8-b12d-4ce1-a996-ebb053b9b0c5@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 700ECA000C X-Rspamd-Server: rspam07 X-Stat-Signature: 46jhuja3k9xrhqqpx73y11tswwf3fzje X-Rspam-User: X-HE-Tag: 1749825576-805089 X-HE-Meta: U2FsdGVkX18LT8v7ZR2XEwXZnWpp2b7ePblhCIoLqJlRINHhrrXeDPjQEcH7Kl/O4g9qw8P5qy4JPXNJrI6WUVvdJ+9zHDyAtDPmr0vjtuFFZctrxm7c2PG5btH4GRFkhl1+LqyZcyTAExHaFg/G5vhtl0eNuYEbJ7HlkeJexPMx/n/WaCS61GbjNJqxkpOiR1xk4HVIQ5kFlCugX5SUIMY6G3iLeOo9YP13VmlyxVQWjdDQyFDn3IQYk+6jFCN0T8Yd9mfgW1I4Zxa2bR5xN+9/BGZ8CzuP1LnX3e6V7UfPpjEyJ40hFgzgF/jV+0cEaVcw+rYFIqPERU59RvXgY+yrt/F9DfXzW4uOjPtJ2co7s2r7b5KvOUu1ESZD+Sa8d7SOGQIDRb7xLhnZBkcKC1kiirlNxDj2rwkZS/PoT2JRHM7HmpzspJqXqW/u+0NAzj/WvpRHNC8LuL8BBZYgADnD45zHLHXkOa09uQfToKNUwNzj6DmSrbWkPAiZn+K041OeIv6JsaFblKVM2GwErZKhmo1LPUZLfemjqGdLSaNxOsOKV6SXzU3fCgQ0tQOXU0nOhWtBP/M5YV0E85Yxwz53Sbk+gbkGh5ouAP2HOmMmjryhEahJRnimfP5elyD5jXkx4w0lUyyMM8mSceDKEf739NMUKGHpVS0WAGyyepPSl68pAjOA1OhlZzh2JMH1tMswr+DgWQyFMZCK/jXY6eQOUk286JBCVsDTLBMARHkkIlrTsr7dgyVBz7FKm1yh6Y/JWjRnlOV3ZryTWZlYxthF+13C2RHVpJMRFrj+rw/1/z+YTPa//UomCeAmF0jSWcLvhzw2N6GKlU2N4Jnm4TsX5j699rgZmiEutH9eGi+xSXzzyMcAe9NMiJZ40WuTdRdOcD37vL3U9SgPPV+iSt58Y6EHWQLbpT9hJFTilABHGMS06LnNUKZYavXQVhq2FmI2BW0WUXlr3gUXPSZ XzjWUZvj Sfi3sZVST2+dx9aEsEZd1+ruYjSuXWa25g12M+PQDQY7elxP7JIQp0cX41ojSv/N7sheMqYbEm/wCmaydd3x2fNy6wjEFY/ueEYG5qqP5CUiOFs2VyRA01h3b6L7UvUQD2n9bn2ngPr/id+HjBG/TltTlq5jWkG8s7mlDIHrBx1QQdIkxF0Mt0pZpdi6PhxbkgSXI2g1GASZq+jtK6pepJYo8Snn/D9DsB0ViuI9tZ3VviUmRrduWNHxh73y73XCD42ybXU5AyrK320IdHj3c0Yny32j0+wNxJglfupSSOSCgpPNKRfOqK5LCxg5c4rpcnH5Q9Ed3ZngmIZ/2Ohw0gdJ8uA2H/hPm8kyJRRoEb/v3gIrteWEpn2JZ0kpuxxWh04CbMvz71HpI/pxGeSYD6we5dBIl3xQoK5FadR7P16NYHd8zt3mPHu0omHOkDMC+qDf6Pk1hvMJXTtDMEZ8NdtxLlfC4OZzQxng+JuvWWgRniYGx25Dk+K0lOV9yhMZByjWodo32xV3XL3lrhXLKcnP0iqZAPttDTDgIhZovPANfYOcSyvU9ZfFmNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13/06/2025 15:29, Lorenzo Stoakes wrote: > On Fri, Jun 13, 2025 at 03:23:19PM +0100, Usama Arif wrote: >> >> >> On 05/06/2025 09:00, Baolin Wang wrote: >>> As we discussed in the previous thread [1], the MADV_COLLAPSE will ignore >>> the system-wide anon/shmem THP sysfs settings, which means that even though >>> we have disabled the anon/shmem THP configuration, MADV_COLLAPSE will still >>> attempt to collapse into a anon/shmem THP. This violates the rule we have >>> agreed upon: never means never. This patch set will address this issue. >> >> Hi Baolin, >> >> I know never means never, but I also thought that the per-size toggles had >> priority over the system ones. This was discussed in [1] as well. >> >> My understanding with these patches is that if we have: >> >> [root@vm4 vmuser]# cat /sys/kernel/mm/transparent_hugepage/enabled >> always madvise [never] >> [root@vm4 vmuser]# cat /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled >> always inherit [madvise] never >> >> Than without these patches we get a hugepage when we do MADV_HUGEPAGE, but with >> these we won't get a hugepage anymore eventhough hugepages-2048kB/enabled is set >> to madvise? > > This isn't correct, madvise at a specific pagesize will still be permitted for > MADV_COLLAPSE. > > In current contender for this patch: > > /* Strictly mask requested anonymous orders according to sysfs settings. */ > static inline unsigned long __thp_mask_anon_orders(unsigned long vm_flags, > unsigned long tva_flags, unsigned long orders) > { > const unsigned long always = READ_ONCE(huge_anon_orders_always); > const unsigned long madvise = READ_ONCE(huge_anon_orders_madvise); > const unsigned long inherit = READ_ONCE(huge_anon_orders_inherit);; > const unsigned long never = ~(always | madvise | inherit); > > Note that madvise is considered here. > Ah ok, Thanks for clearing that! I was reviewing the original patch in [1] but I see this version in the replies. I wish this function was simpler :) or maybe its me that takes so much time to figure out if the order will be set or not by the end of the function. [1] https://lore.kernel.org/all/8eefb0809c598fadaa4a022634fba5689a4f3257.1749109709.git.baolin.wang@linux.alibaba.com/ Thanks! Usama