From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C878FECAAD3 for ; Fri, 9 Sep 2022 06:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E0738D0003; Fri, 9 Sep 2022 02:18:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 190398D0001; Fri, 9 Sep 2022 02:18:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0597F8D0003; Fri, 9 Sep 2022 02:18:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E64A08D0001 for ; Fri, 9 Sep 2022 02:18:12 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BE0C81608F0 for ; Fri, 9 Sep 2022 06:18:12 +0000 (UTC) X-FDA: 79891542024.13.1859092 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 5F55A40094 for ; Fri, 9 Sep 2022 06:18:12 +0000 (UTC) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2895dKtc007409; Fri, 9 Sep 2022 06:18:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=o/qF6j+qJZVyqoVr2gZ2abJZWCeV62uWVQARpcQ5MhE=; b=Xt4EzXPaHU6LRxN88S5AUwdzIQg3LQmh/HN35VrWESO0XYlWGDh18liUDmPuhdWC17Q8 374h2u9m30d4O1uoagDpDbzFnosKQ/xAhX2CLemuHhNFmBEh4xJt1EUYv4u8vWzE6fun dsls/JUYFKYWTHcXlb3xhK2pHjpVa36KPEQCRYhOdGEFkDHDXSUvjrxytV1kQCKzMp+z 69AVaWuR9I1UySzE/8KXkLZJAl+RbXUW3BJ8B4QpkUdWB8C0KjGbHmQj6oyPSPvUs/po lsq5zqc2JCozM1BiEpB03mBOTRT9L1N1BI8OFKF9+tRwQOusWNKDbTKUW8UZsM0136tx 5A== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jfrhg8u32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Sep 2022 06:18:11 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2896IA8O027784 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Sep 2022 06:18:10 GMT Received: from [10.253.33.184] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 8 Sep 2022 23:18:08 -0700 Message-ID: <656ffdc5-2b7e-1ecb-f7a6-5456f113d190@quicinc.com> Date: Fri, 9 Sep 2022 14:18:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2] mm/page_owner.c: remove redudant drain_all_pages Content-Language: en-US To: Mel Gorman CC: , , References: <1662633204-10044-1-git-send-email-quic_zhenhuah@quicinc.com> <20220908145538.in2ttdaejp2zxwxk@techsingularity.net> From: Zhenhua Huang In-Reply-To: <20220908145538.in2ttdaejp2zxwxk@techsingularity.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: f4dQfkO0y3h1vjCE2LC7lAbh2L_ocM5I X-Proofpoint-GUID: f4dQfkO0y3h1vjCE2LC7lAbh2L_ocM5I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-09_02,2022-09-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 adultscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209090020 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662704292; a=rsa-sha256; cv=none; b=gblHcIqp8DzqfQeQTHPlYqefM/Wx/gTCviE/fTRm/xPuacqv+MZByA/K7qAXGo/WJwBnKj QGPqyeLwlQskPVRtirpNJPLQuJboyvVehVknLRmxwAoYr4WzfVojSXNvg6M+28CgvNCLMH CBB4RCLYQwyzVg7BtI6T1tA735IZqzs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Xt4EzXPa; spf=pass (imf12.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662704292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o/qF6j+qJZVyqoVr2gZ2abJZWCeV62uWVQARpcQ5MhE=; b=KeMuJttaonW8rvTqf5ubY9+kT1+le4jj16cTbQMVAcJkD8KeSM2OJT5tzsSv/jtadicOy8 fnEQP/bkqTRpI+UtJPisnYY2IzPqKM92zKm6WH4Ee4VHeT0UW2BpHsx/eulhk5m+i93bhp Wfm2otNN//T/sdffZV31PeuqwtelRU4= Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Xt4EzXPa; spf=pass (imf12.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Rspam-User: X-Rspamd-Queue-Id: 5F55A40094 X-Rspamd-Server: rspam09 X-Stat-Signature: zdcdhp1kqtiiiqaanxkkqu53hhe9gm61 X-HE-Tag: 1662704292-206698 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/8 22:55, Mel Gorman wrote: > On Thu, Sep 08, 2022 at 06:33:24PM +0800, Zhenhua Huang wrote: >> Remove an expensive and unnecessary operation as PCP pages are safely >> skipped when reading page owner. PCP pages can be skipped because >> PAGE_EXT_OWNER_ALLOCATED is cleared. >> >> With draining PCP pages, these pages are moved to buddy list so they >> can be identified as buddy pages and skipped quickly. Although it improved >> efficiency of PFN walker, the drain is guaranteed expensive that is >> unlikely to be offset by a slight increase in efficiency when skipping >> free pages. >> >> PAGE_EXT_OWNER_ALLOCATED is cleared in the page owner reset path below: >> free_unref_page >> -> free_unref_page_prepare >> -> free_pcp_prepare >> -> free_pages_prepare which do page owner >> reset >> -> free_unref_page_commit which add pages into pcp list >> >> Acked-by: Mel Gorman >> Signed-off-by: Zhenhua Huang > > Should be; > > Signed-off-by: Zhenhua Huang > Acked-by: Mel Gorman > > Otherwise looks good! Thanks Mel for your guide. Will update. >