From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB72C5ACD6 for ; Tue, 17 Mar 2020 19:29:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5DFC920754 for ; Tue, 17 Mar 2020 19:29:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DFC920754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E1F096B0007; Tue, 17 Mar 2020 15:29:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCE386B0008; Tue, 17 Mar 2020 15:29:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE47B6B000A; Tue, 17 Mar 2020 15:29:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id B680F6B0007 for ; Tue, 17 Mar 2020 15:29:42 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5ECF852BB for ; Tue, 17 Mar 2020 19:29:42 +0000 (UTC) X-FDA: 76605843804.26.cub09_3782e9efc0d47 X-HE-Tag: cub09_3782e9efc0d47 X-Filterd-Recvd-Size: 2203 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Mar 2020 19:29:41 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04396;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0TsuLFfP_1584473375; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0TsuLFfP_1584473375) by smtp.aliyun-inc.com(127.0.0.1); Wed, 18 Mar 2020 03:29:37 +0800 Subject: Re: [v3 PATCH 1/2] mm: swap: make page_evictable() inline To: Matthew Wilcox Cc: shakeelb@google.com, vbabka@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1584466971-110029-1-git-send-email-yang.shi@linux.alibaba.com> <20200317192136.GE22433@bombadil.infradead.org> From: Yang Shi Message-ID: <65617abd-d7b7-5e1c-46a3-77e9cddcc514@linux.alibaba.com> Date: Tue, 17 Mar 2020 12:29:33 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200317192136.GE22433@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/17/20 12:21 PM, Matthew Wilcox wrote: > On Wed, Mar 18, 2020 at 01:42:50AM +0800, Yang Shi wrote: >> -static inline int mapping_unevictable(struct address_space *mapping) >> +static inline bool mapping_unevictable(struct address_space *mapping) >> { >> if (mapping) >> return test_bit(AS_UNEVICTABLE, &mapping->flags); > Shouldn't this be: > > -static inline int mapping_unevictable(struct address_space *mapping) > +static inline bool mapping_unevictable(struct address_space *mapping) > { > - if (mapping) > - return test_bit(AS_UNEVICTABLE, &mapping->flags); > - return !!mapping; > + return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags); Looks neater. Will take it in thew new version. > }