From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A348C3600C for ; Fri, 4 Apr 2025 01:50:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1DF7280007; Thu, 3 Apr 2025 21:50:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCD00280006; Thu, 3 Apr 2025 21:50:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A95F4280007; Thu, 3 Apr 2025 21:50:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8B0B1280006 for ; Thu, 3 Apr 2025 21:50:51 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8854F5913E for ; Fri, 4 Apr 2025 01:50:51 +0000 (UTC) X-FDA: 83294682702.29.C4F6A05 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf23.hostedemail.com (Postfix) with ESMTP id A056114000A for ; Fri, 4 Apr 2025 01:50:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nYUDzZB4; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743731449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xkYgl4zr3nXqdErHUjkuxoKSDXxbWnctKWg4ernvjFw=; b=tmHJuOUr8mp8nIMvLBuwAs/hVXbRnCrHX990eAClFGkFMGkuRgZweD+yxAKYxtc281csT0 XehoMuLo2AT/6LeBXKeqU56dWYIbw5zcrFAlLEgwQFcjQ//sNpffS5jwcc00EZNlUZVPBf LS9R8oReaAvzqg5Qe3yEwtLU5szJgt8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nYUDzZB4; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743731449; a=rsa-sha256; cv=none; b=VDGZZSOYrqUV1bD7xdk1mAw/EzG4gPobW3UCmJ9tfqtEWD67ddEpFsBMh42WUWTMPXqf5V 1nFkYx3w2krOO1dfhix6YFyNWvj0SJheM6k37L86ZWC+KoP0rOmVD+A/8AC/ljbbpjo3LO w89bptVEUk/7Ip7piF2yTSshT8UI3EI= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22438c356c8so16473965ad.1 for ; Thu, 03 Apr 2025 18:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1743731448; x=1744336248; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xkYgl4zr3nXqdErHUjkuxoKSDXxbWnctKWg4ernvjFw=; b=nYUDzZB49WJtSbHTz7DLKYJtm8F8yFZzm8PK8jjEPusFFwFJzRb7+KTR+CMfgXzQYB ZPz7o3pGLw2Cf6IF2K8+pV1PxO0x9nEyBras+nQJ5Yo8fOZC4Ghe63vpGw2B13BVjVgj 4nAtmha6BpKNG/AXmPZvFrra5oqdCD3iT7ya8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743731448; x=1744336248; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xkYgl4zr3nXqdErHUjkuxoKSDXxbWnctKWg4ernvjFw=; b=AbH3n/GMfzQiy1HSQ/mAbKF4WkQpnBk8OlYlpYWlusAIq9QlrFSiFJNSbPZc63uvy8 teWsuD0pFNdIXsxiNqk4wS8Z+a6XgmbBO6KftNthhjgxgK7ztpBh9OhacV4zz9seGoIT qUfax7mWwzH++uFU20DizoaIvAc5zv/JYTziw3L6jzVURop0TzKbsnwWt1drm1wfXgwV thDFri6es4oEd0qwzHdw9774VyAePMPXt9J/XqeN4qmW0jhqFtYmsj5JZKZuKr/malQo sSjWjZK/Zkop9FZD5yTyTHTL5AoU1pNCPNUPu1J1AwpL+7iVjyFbpjNiX1BEGBOD7X+L Gl1A== X-Forwarded-Encrypted: i=1; AJvYcCWsjsbC2p1UJMXMSW1wBYm2VEUvX4BIGHJg1RUX3LsS+qL2M2tVLb7YkkNpl4A3/tbLFz5GDINUPg==@kvack.org X-Gm-Message-State: AOJu0YxV8HccH87v2y7KYM4xQkpPWUreOoUqnZvLS7zOBVA22K/qrsFo dN19qAo7eNa4l+i/lKJbpt+rUeY9nrLsf3HE5qfv4g52EZN17vbET0rwcjw5tA== X-Gm-Gg: ASbGnctiNAaVE9Z9xOOpokKLNYqijnhEliEEle1dJowE+umZfEJyP4BaED6A1hj7Kkp 51WvYZ20mMWzAkPprTpn1WTnAEu7rowVobZdbF2OVPsEnQJ5Q6TODWILqsBjAD84ZIUQcAREv4N M2GVo6wJTK1QHIJGO+z4ZpDs8eRxiPjA+ltqSiTwu1Nm1DmkynbBX+JeC1tR27dMqEQsAJQ+QhI EqxKS3SewmJ/C+Ei4U+c2dRe/3J3+/GMMjTr+tNbh6EUCE+WrGGenD4FjOSOYfjMNIcV/FFwPca CHE/N0uZOJ+1lQRl6Ug3ID2Vx2+1WDJf6MhBlhUTVBTGV45gaMAWdLi73gE= X-Google-Smtp-Source: AGHT+IG+VhyB5g//5WwnbEL9f4OcluPDZI0996O3JkznfBYQQ+pMS3M04Xzgt1Qg/Yhacit6cq/t4g== X-Received: by 2002:a17:902:ec8a:b0:223:5ca1:3b0b with SMTP id d9443c01a7336-22a8a8c99fcmr14437925ad.40.1743731448493; Thu, 03 Apr 2025 18:50:48 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:addc:e770:41f7:fb85]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297865bda1sm21348525ad.131.2025.04.03.18.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 18:50:48 -0700 (PDT) Date: Fri, 4 Apr 2025 10:50:43 +0900 From: Sergey Senozhatsky To: Brian Geffon Cc: Sergey Senozhatsky , Andrew Morton , Richard Chang , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sawlani@google.com Subject: Re: [PATCHv2] zram: modernize writeback interface Message-ID: <6555ksohyt2qvigdxpcdg3holtxurmoot4ocdahdtyunaaxx4b@jwlzy65jm5ob> References: <20250327015818.4148660-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A056114000A X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: 7cxwmq7og5iwbxh5skmsdufqgf7y5q8p X-HE-Tag: 1743731449-232928 X-HE-Meta: U2FsdGVkX1+JmT75GOl6YfTXVss/k4varIxreJixipCmWrJnBM2Bb0KjKtQLnEHLI51Poo2IM3T+uXjkcNB9JDGXv7CyimOvoSWZV2icks8VQDNk+QFThIn9RvNpqOtGaZzyyRTljFhHbIgIo0FVNsHH/m7E1PTHqWJWLiS5OpHaARWF32/4LdqqlMGnNAGzrCAy/hZUUa5RbN3JlB+MCorrxs1jg1j1q7Hw7a4wuSmPV1HJMt3PG91i+tsmDu3rupjPswTuC0krBfO3SHV5LtRvSNOXLVVri/OWV3BCRB0Lub2Ba13x229Ghwj61zM+pYG4ez2gE/oERXWz0PyJhbkdDhfYiTPJ/fGUzQ40AEY01gTBN4SInb269UdNMfzFKDXvbxUt31l/LXH/+bSKDv12e/Z/o1sI0JnSH0q+2NVo2u9avzQzV56ADU8yUYhJSVoATtUmHRWfAevls2Rt+EfpwO1n61Ox1Fhf1Q7GN9I3COAzpcF2J3z+p6SsuzAIqwEFFVl9xR7Ec6OThku/MwWPrjJ7qDWXIjmJD4W2xeMdh8aA0qu/Tc0qPztPyFsVsqVTEJRNYU4sLvXYUv8kTPftoKKgeLMZnSRXylIMDn2ScqtSNBcRCHCwG0NbyRRK/7zlI7TXObITGpi+FID6g68PYdssyYqefPoaeVSNgpNBSfvHt++aE9ZGGAp0DWH77wpICJWL0F7qt+BnR8hiUeve7S7PvHzZMN1mnJRWULBABqUOtN4S2/xdbMqyrl0Ho32rcxZQyDJ57y8PWSUeEXZ6Y3XX0fYfOQX7moELXYML4Y9e3FhghzYhsd5imtsZ9vgh4bwnQ1tBil+wu7xhdP34aHaXWiHuPr8/5XUvb57GHdV77j1BkQOOjXotEbDhXzHRtcfn8y+M8MEw5Jyqq8SEt0actKrK4NBroZs13vg1w+OG7mVl1PK6Qtn01yRn2YPiqKNwt7FWt8su4te YebR7hqt Se1017kfxIGnyyp/D/43aXBV0SFO+vFqHQBzMuWUGVyBAtFDyxIkHwEb3HqUSKxGn10GRNUyEn0kz6kCgTNpXm8CCsZjTSPeJAGJJtuvXgMCnG4LK/hgqAWZimaEBfkm/BXujvUk5YiE3LLrRYvSUpreTDPKlMaHjthWnT1r5CtVYoZIUFshmTPKKHkdgT5Tp56W2R1Qmffm1/HeO/Q1rDJqGdczBsJCc2YmvY39sKPKB5FOckay92xFLoZVVPagDKgNzrBcvyPRcz1BTV+dW1oOJhNsM2j2YgVZTjSuCujjBLQDgkPkfR52w9UYer9H1XAvnAy0ZSXu8+psG3iJzyaP6u6QLLm6CiRbEsx8QWs1vKPo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.054238, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/04/03 20:39), Brian Geffon wrote: [..] > > +static int parse_page_index(char *val, unsigned long nr_pages, > > + unsigned long *lo, unsigned long *hi) > > +{ > > + int ret; > > + > > + ret = kstrtoul(val, 10, lo); > > + if (ret) > > + return ret; > > + *hi = *lo + 1; > > + if (*lo >= nr_pages || *hi > nr_pages) > > I think you can do just: > if (*lo >= nr_pages) > > The *hi > nr_pages check seems superfluous given the > assignment directly above this. Ack, thanks.