From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 402FEC3ABC9 for ; Fri, 16 May 2025 11:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28FBF6B013A; Fri, 16 May 2025 07:01:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23DA66B013C; Fri, 16 May 2025 07:01:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DE376B013D; Fri, 16 May 2025 07:01:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0D326B013A for ; Fri, 16 May 2025 07:01:05 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 183CEC1F40 for ; Fri, 16 May 2025 11:01:08 +0000 (UTC) X-FDA: 83448479016.01.FE24338 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf04.hostedemail.com (Postfix) with ESMTP id AE0BF40003 for ; Fri, 16 May 2025 11:01:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ZpqufhJU; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747393265; a=rsa-sha256; cv=none; b=kR6H/PwG0npk75lnrCGhuObouVZStGnKTUfYtZQvQpNekStRsAZq797zRfeTKS0onqHp2a Jgqh/dicEujQcX+NskaJk7UNcHHqyQkRA/ykjo8p2LlExtdiF17mThvJgFxCcmcsIJbt26 ukLYY115AXg1sCPsVKCDo06c5QfSEF0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ZpqufhJU; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747393265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9KPterFkW62tyFKvD+8Fg0jSyjUVUtISswHvp618FF8=; b=EFA4oULgIEl6mmhrP067m5u24diM/ZQ/3LI0d/V97RO2VLNNKvAJRLdPCgx+A0e3mZZkPJ wuzUfvTta/QUDs9RkOMifx/JOlJV5VXp6SmWRYy+v6oq/0g2Ic9zZ3XPjGjKSKSQFD7KV1 A9fIKoQLNZv3FHE76uxohrmcm8zcmvs= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54G9F8sO007312; Fri, 16 May 2025 11:00:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=9KPter FkW62tyFKvD+8Fg0jSyjUVUtISswHvp618FF8=; b=ZpqufhJU9qZBszFGSAnsSz HTFA3qhVy84x5aTGx6AOG/qLyWqDwRfOFKdSz7W7qA5ZUOdYMmiyjm9R960VMyQF agUefMu4UV4hTK5RaeUbeprogYDed3+QcMMMKGm/a+HEbMBIFAKgZMpqxnAKH/1H nzV8Ee8IYiNFwuJnu67PRSVWkJWog2y5xqjaF/q9H1dkQsG7hoeMXtU2/8Azgor1 gs5fIb8sww4Do73ENMhvinyrjb7qtOhuuwCOMUZHDCecCq+D3ih2avIKYnmmQTGK Yk/8Kh+U8p7cHEYricQH7Ap29hc54nQ2RZxzPaV4d9xTZtRAsG+ZLV+I2tm4Lgnw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46p2jj8ejv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 11:00:54 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54GB0sdI009362; Fri, 16 May 2025 11:00:54 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46p2jj8ejr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 11:00:54 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54GA4G5L015330; Fri, 16 May 2025 11:00:53 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 46mbfq74pv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 May 2025 11:00:53 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54GB0qiL15270542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 May 2025 11:00:52 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65A755805E; Fri, 16 May 2025 11:00:52 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F24C658065; Fri, 16 May 2025 11:00:47 +0000 (GMT) Received: from [9.109.245.113] (unknown [9.109.245.113]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 16 May 2025 11:00:47 +0000 (GMT) Message-ID: <65547a74-ceeb-4aa2-afc1-ebbbd3b8d918@linux.ibm.com> Date: Fri, 16 May 2025 16:30:46 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] driver/base: Optimize memory block registration to reduce boot time To: David Hildenbrand , Mike Rapoport Cc: Andrew Morton , Oscar Salvador , Zi Yan , Ritesh Harjani , rafael@kernel.org, Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang References: <56cb2494-56ba-4895-9dd1-23243c2eecdb@redhat.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE2MDEwMCBTYWx0ZWRfXxVWHtPJD+ypg MTJiL5FhlpEC7oDVGWuokp4ZF0xFKc3DG8HHrVgq34dHoCNxjxCipZ+2uMt5xnHVKecg0TPJkSZ g4PHQJ+BTNWTwbOM4fi7AFoB1qow4yGeVMu9tkjd8VndB9S40b9z57uG64uzXjpPb0utxOVlQZ4 TrQkmZgbDepVEcVe+R+XA8Z1q8pupAputeq39k0lISdvlRYbK3PJTYPa2SKCg/X1eFIdsYNiuUD M7XJRQOVrr0IpdZzySXbMFnL80jF/zgCUVzhZE+koelx0sXKtjYkw1s9UOm+cxJM8KiXvpnc6ZD Vd7h9VgmYUO5ddmueymiTclxaS7CN4zOSugV9m3Cegjg0EmOCSZpWb9+cS+QYvzcpPcUGKuGdCX sOyZYlaPQWlao3gcDtxDJJkjeTJq0LcLxLNXOdsrJPuEVUI5XLlCcNl2EHFSMqqGCtrnpPj2 X-Proofpoint-GUID: sTKq_LsP0UnNh8IJek88S264LhWROSNQ X-Authority-Analysis: v=2.4 cv=O4o5vA9W c=1 sm=1 tr=0 ts=68271ae6 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=1mntedN-ysDotl4qOaoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: afHiZ8qCT6jrLbe6bSD4F8a3PexfidE6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-16_04,2025-05-16_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 mlxlogscore=844 suspectscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505160100 X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AE0BF40003 X-Stat-Signature: agp4peoes7i6u18yz9ukqg8ha4h1bjtb X-HE-Tag: 1747393265-905281 X-HE-Meta: U2FsdGVkX1+bYA+WAIa3iHLH4yBOMRjwW4R4GswwHLC+31ouV3bCXKpmzOzI0Cvlb3q9FsyNgCM9Yyu/WGOqP+C/hAR3Vm6eznqk/Apq3ptx6PYlaiEqdGn/xk02PCyrtBOdbrsKp8QSFXsAtVfcvSe1qigdXpqigaqneYRjLwvOQHRb4XBwXu4nv4AATURmAa1/+zwVCHdqLCmVE8Om3MXKYpctexoYZdUK0usLHxIzdDhDvit3zaff0QdX9HMqMZhLQVVu8IFRtF3TXv7cjw0695l3wgdS6eg5MHv4mhuGv0JQYVqU5kg6jMW2uv2+4p5yzEpSJ8uN/YgH+uXOA4vwIjHLI/y2z0CUapjGLTLes1tVk46cQjitzFa4NxS+A3ln32VUOrqyAxjLbcrDEwzPSWhnDn08KqFPU166viCL+xt6RmlSvF3QR6ke3QLGkUxMFxJSM0BS2ypq1B+55hTvafDyVh39eaHLDR6GY7mU3uPrQvk9s0HpOWns7HUTMW5yPS64Lp7OkpD5sMp1wPKHVbEJqAPxGBQr9jUaDaN1dVrgAE/IbKQMoDVSHZAOQKHUeq7p2M9mIv4GueW1po9SsmHEqLPEz9KB6NynmFcLDSsM+kZ7BeK87qztYRs08gZ0apuKhVRtIc3nlWojnGB5vXIZV2evTdg7w5aB4NGeBSJffRLWuTp/Fwgcw9ZtpEqIZwKpTuUARExbhHFTtgRZOcdClklMMxvtATQFHP+pV1PRdRdPcCcGHyBQYqH3G2ZMJCdexuE6kjpP/KeJLe1jAB2PS4KIR4vKTjTxGuWC3NoUDqZQAwLNi6RiWQZYJHj8DaUrWwLaja8ISb7+d4xcsSVF0rq0H9qdKU4iJpGn8GRN+977drqK0Y7NT5rtNnMubgYDCMorIAuxWQ6nP5acM//SWxla5irE+EjyYK6e9K8ibmTW7DiJtRSTjvL+Wj7/jKKu0K2OKbpHvFJ 2joiqW/s WU0AbwZbKunkN7G8rG71hpClNxmmAnXabs3uDkLvUivvmpnIljog94ju6wBXkV6PJ96iPoPeDPQEuyjp0OQLMEs7LwrgBKdiAoTwdD9Tf0/h//lYq9jaIObDrpoU3vwIzC0u6HkCZl7maxYrlYtHywRbadVfT1drVC84eOvs6/64vPO5QaXaDFb338b6/KA3xaTlRqNmWYRgcMH+uryo2emAIX+ALSfaTQo3ljVeY+kT1WJrpO2SLPoU8HgCjNnA03m13hF4DdRe4PtEReGzDUMppI4hvH2NyJMnh/ktOh/bm7p1zNZ+13UzzHvvlhrXid+k3FU2td1CeWXYBolT8sXq86i3+mzQwVJ++54JHJmDmZ/r1sWYHm2gr8r5Xm6pM+aRyL+WDLCLS3hOsf312T5/cnCDC3fPTxeFZSeEKGpl04So= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/16/25 3:42 PM, David Hildenbrand wrote: >>> We'd have to be smart about memory blocks that fall into multiple >>> regions, >>> but it should be a corner case and doable. >> >> This is a corner case that should be handled regardless of the loop >> order. >> And I don't think it's handled today at all. >> >> If we have a block that crosses node boundaries, current >> implementation of >> register_mem_block_under_node_early() will register it under the first >> node. > > At least upstream behavior should be that it would be linked under all > nodes. At least that's what I remember :) > >>> OTOH, we usually don't expect having a lot of regions, so iterating >>> over >>> them is probably not a big bottleneck? Anyhow, just wanted to raise it. >> >> There would be at least a region per node and having >> >> for_each_online_node() >>     for_each_mem_region() >> >> makes the loop O(n²) for no good reason. > > Yes, that's why I mentioned it. If we have many nodes it might > definitely be relevant. Thanks David and Mike I will implement this and send the next version.