From: Dave McCracken <dmccr@us.ibm.com>
To: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@digeo.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: install_page() lockup
Date: Wed, 23 Oct 2002 10:55:25 -0500 [thread overview]
Message-ID: <65490000.1035388525@baldur.austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0210230847190.2334-100000@localhost.localdomain>
--On Wednesday, October 23, 2002 08:49:11 +0200 Ingo Molnar <mingo@elte.hu>
wrote:
> i added install_page() for fremap()'s purposes so i'd be surprised if
> anything else used it. I have shared-pte turned off in my tests, will try
> with it on as well.
As I sent in an earlier mail, I found the bug. do_file_page needs to
unlock the pte_page_lock, not the page_table_lock.
If I understand the use of install_page correctly, I don't see a reason why
it should be calling pte_unshare. If it's only installing pages from
existing shared regions it should leave the pte page shared. The only
reason to call pte_unshare is if the vma for that mm has changed, making
the sharing decision invalid. Am I missing how this is being used?
Dave McCracken
======================================================================
Dave McCracken IBM Linux Base Kernel Team 1-512-838-3059
dmccr@us.ibm.com T/L 678-3059
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-10-23 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-23 5:37 Andrew Morton
2002-10-23 6:49 ` Ingo Molnar
2002-10-23 15:55 ` Dave McCracken [this message]
2002-10-23 15:52 ` Dave McCracken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65490000.1035388525@baldur.austin.ibm.com \
--to=dmccr@us.ibm.com \
--cc=akpm@digeo.com \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox