From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1D6C54E68 for ; Tue, 19 Mar 2024 22:29:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02ED36B007B; Tue, 19 Mar 2024 18:29:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F22586B0082; Tue, 19 Mar 2024 18:29:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE8BB6B0083; Tue, 19 Mar 2024 18:29:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CDFFD6B007B for ; Tue, 19 Mar 2024 18:29:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D7E1C40936 for ; Tue, 19 Mar 2024 22:29:02 +0000 (UTC) X-FDA: 81915230124.11.2E7A792 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by imf24.hostedemail.com (Postfix) with ESMTP id 9795418000D for ; Tue, 19 Mar 2024 22:29:00 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=proton.me header.s=2td2hcxam5f4blla4qexiqfvti.protonmail header.b=DwpdCwJ7; spf=pass (imf24.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710887341; a=rsa-sha256; cv=none; b=6T/UwNkE+FBsgrhCEmikdsaIMJs9CkZTqFRyFGno55V8xED7T+lpsiOM+tY5nNXVvq6LZr Fq4OuiKnCP4fWG83Zl4im1GmCyelKHLybaHXaxNLJpLsHVG/7Ea2OaRbhdIoTfynTUQCzp cx/+85V0QmK0O7SjQ1qQc31Ld96Gruw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=proton.me header.s=2td2hcxam5f4blla4qexiqfvti.protonmail header.b=DwpdCwJ7; spf=pass (imf24.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710887341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L20ailqB2zZNQ2Pi1DlqP7RA7u5R9k3CUjUtV3VgrxQ=; b=B/N8u4SSCrmaYXyKqgPkq30xqqDAsHWsJFRZXfq0UagSjUsdiQr2SntlYeq9ZCL+MeTvAN Hzpe/JHEJs231H/wmg2MNLpzrVCYWL9z2vPMU4e/SgTrnWn3EtnJzEgJp2RygclyM7ExVl Nm7z3hFgvAw1cs8dEPLd07RD2olwI20= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=2td2hcxam5f4blla4qexiqfvti.protonmail; t=1710887338; x=1711146538; bh=L20ailqB2zZNQ2Pi1DlqP7RA7u5R9k3CUjUtV3VgrxQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=DwpdCwJ7R0FXhXwrI1LaTEYBTItAi/qrEMzB7FUkf2GbMnh2NaOxQbkwb6P1ixTuv LH5nbCsEpmrJ+pH4texbSAicrUz8XowP6FwhRWKRldXsnhVEus1GkDi9zQaNuUgsD4 Ajz9VBySgeCOjDUe9T1ROslu5kyNNRrPtXsLdFfHYofRkXtvz9sr9Q/D/EodOenOka zSCiebBcGWFEsYAsOKhh3XWb8HFgvM4u9O1O151CY8iIrbO8bEP8Tc14ciW72qjo88 5VEWgoXgpvlMzl4QaBouqB/+zp2cH+z3d9VjVBKPy1/4dFLP88jjFKK8WTlPzhxl2p VthyZsOKjUFuw== Date: Tue, 19 Mar 2024 22:28:52 +0000 To: Boqun Feng , Alice Ryhl From: Benno Lossin Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Greg Kroah-Hartman , =?utf-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v3 4/4] rust: add abstraction for `struct page` Message-ID: <65457833-adbe-4a60-95d9-8391a746ede0@proton.me> In-Reply-To: References: <20240311-alice-mm-v3-0-cdf7b3a2049c@google.com> <20240311-alice-mm-v3-4-cdf7b3a2049c@google.com> Feedback-ID: 71780778:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9795418000D X-Stat-Signature: a9uibtchfgt4or7rgkbhx73tn86mo1x4 X-Rspam-User: X-HE-Tag: 1710887340-356263 X-HE-Meta: U2FsdGVkX1+cKkETgfp25yctyB9FMQDLxxmoEaNjnioQnpDf9VTmkyAvqQoe5fOBuR1DB19BFYmtmyGCjnH+d1rADL3YcwZHo90vRG6f6FedSjEIr8CMpOX/BdVU+z/sm9I8uAnC5LYMduXlMR3xu4eOPn21+mVUdacBd0F881cRJLItjTDF0Avk2B2cO/eS+G4pmZ3Zww11zjztBo304a8esfxcbJXy0Uk3pShVDP2dVk6G65gTS6KL4u9/2bwGH81IIwCMG5ybp0mFnvpZ1bU4Pz803OrJA0GBG0bwTXM9DC4aRCRtwNNdW49mpt3urPXsRrQsFHfyrl8AM5euiFv6FWFDxE0LqhtRZuYCoCQKf2bttPWboshpSjWv7OV8M6mlmJHfO+F45epu5cZ3zhaTvEnkz8LNIPInvHHLc2fEapvDmg6GagrKJ5LqoxNXP6E+YyZ9MUXUN4tgi5CLWH+YRAYhFGoYdcSXqs3I7gIzH54RZu7MGF4b7VXnR9SDSmGhgLOsc2xcS4Xj4DNJB+E85qwqPsC3laWPXP7DehHgJtaFSxq9raq/2XCWbe10u6cjqm2CbAFM5rCUb0YiKjo0d32gnoFEjhuYUXqYZOKwYC9ZAN2+3cWpvzj8wc0QtPYOaJJkTKWsSJi8OFZWVZaZs/YlyHXVsujcxcbovkPztpw84FDfKf/klWQCzaYoAB58LRj5VK4O1Tbd7l1G+Qdl1nkJYrxvd5jmLNWDefyukOfZ4OFLF9XDgaC0dsqgLCldOm5D+MUn2zP8n+1+xF8g7H/kAJvv97ydOeKQYqYvSzSB6m+HO+SvRHuVwmzpawgkA2h/S8BiYrX1+S0D8zsQ23F8nOHBMgcYRhaZpKCIW9StcO/R7jR6y3rOQl4SYThRSWPeNPEl+Q0KhV/6w+VX3vkoIdEMalasYOgdSQw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/19/24 23:16, Boqun Feng wrote: > On Mon, Mar 11, 2024 at 10:47:16AM +0000, Alice Ryhl wrote: > [...] >> /* `bindgen` gets confused at certain things. */ >> const size_t RUST_CONST_HELPER_ARCH_SLAB_MINALIGN =3D ARCH_SLAB_MINALI= GN; >> +const size_t RUST_CONST_HELPER_PAGE_SIZE =3D PAGE_SIZE; >> +const size_t RUST_CONST_HELPER_PAGE_MASK =3D PAGE_MASK; >=20 > At least for me, bindgen couldn't work out the macro expansion, and I > got: >=20 > =09pub const PAGE_SIZE: usize =3D 4096; > =09extern "C" { > =09 pub static RUST_CONST_HELPER_PAGE_MASK: usize; > =09} >=20 > in rust/bindings/bindings_generated.rs, which will eventually cause the > code cannot compile. >=20 > I'm using bindgen-cli 0.65.1, libclang (16 or 17), rustc (1.76 or 1.77). >=20 > Anyone else sees the same thing? I also have this problem with bindgen-cli 0.69.1 libclang 16 and rustc 1.76= .0. For reference, here is the actual compilation error: error[E0425]: cannot find value `PAGE_MASK` in crate `bindings` --> rust/kernel/page.rs:17:40 | 17 | pub const PAGE_MASK: usize =3D bindings::PAGE_MASK as usize; | ^^^^^^^^^ help: a constant = with a similar name exists: `GATE_TASK` | ::: /home/benno/kernel/review/mem-man-binder/rust/bindings/bindings_g= enerated.rs:12188:1 | 12188 | pub const GATE_TASK: _bindgen_ty_4 =3D 5; | ---------------------------------- similarly named constant `GATE_= TASK` defined here error: type `gfp_t` should have an upper camel case name --> rust/kernel/page.rs:21:14 | 21 | pub type gfp_t =3D bindings::gfp_t; | ^^^^^ help: convert the identifier to upper camel case: = `GfpT` | =3D note: `-D non-camel-case-types` implied by `-D warnings` =3D help: to override `-D warnings` add `#[allow(non_camel_case_types)]= ` error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0425`. @Alice: the second error should be unrelated to this problem. --=20 Cheers, Benno >=20 > Regards, > Boqun >=20 >> const gfp_t RUST_CONST_HELPER_GFP_KERNEL =3D GFP_KERNEL; >> const gfp_t RUST_CONST_HELPER___GFP_ZERO =3D __GFP_ZERO; >> +const gfp_t RUST_CONST_HELPER___GFP_HIGHMEM =3D ___GFP_HIGHMEM; > [...]