From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9CAC0015E for ; Wed, 9 Aug 2023 13:58:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C25036B0072; Wed, 9 Aug 2023 09:58:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD4C66B0075; Wed, 9 Aug 2023 09:58:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9C478E0001; Wed, 9 Aug 2023 09:58:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 994F16B0072 for ; Wed, 9 Aug 2023 09:58:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 65C99A0F02 for ; Wed, 9 Aug 2023 13:58:03 +0000 (UTC) X-FDA: 81104720046.29.AF91027 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf22.hostedemail.com (Postfix) with ESMTP id DEF1AC0023 for ; Wed, 9 Aug 2023 13:58:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=FApWEXJ2; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf22.hostedemail.com: domain of quic_bibekkum@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_bibekkum@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691589481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IBxLksRWQJNJ/J9zVQ4Q+Q6sPIraZpg7ZIon6o0L2Fs=; b=uimfHHx+S4P0f2UeGbnKeoe6i4fE3/mi+uIDfb7ix+4V1UCG415sWVs4IFPPa82TeR6fFp 1s/prw6iLpL6EgdxTsQHHKmMtU7eRI/U+igC9GPDqjgiN8LRszf75ca5DQhMBrRYbE4P2G 72oJzRs3/Dr2LM27gzuXJxssqqgtLHQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=FApWEXJ2; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf22.hostedemail.com: domain of quic_bibekkum@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_bibekkum@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691589481; a=rsa-sha256; cv=none; b=ZF9S+zdQ8BmFrGsnqZNb7+qTk+8R1ChN8s6zRXpXoz1Ztk20NPMdWrKvhCsZBnkSuaY67e bKWFVHtIvm2IyR3zGb+vVogj9N0Ih/hrgM1IW1R55RTjaCJvvtLAL05ikAk6IKDwnt2UGr nsiHO+hgamCguzkNlVcKa+U3p5PouMg= Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 379DntfB003373; Wed, 9 Aug 2023 13:57:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=IBxLksRWQJNJ/J9zVQ4Q+Q6sPIraZpg7ZIon6o0L2Fs=; b=FApWEXJ2l8Pv+kLcvoFg/daTaPe66t2zLBicp4H8VtWyGPJN7xlCE3DASSkcRu8K1sTz rn8uHro/cLfUcwdKX3Ighj3JiEoCM9WmygZMZhPSq0yhvgWFAxoerArW0Uzoasv3bnPZ 1TJ2ZussVk3pTRzca7m13lNxpG6Ch0iHYXIfhzXIQeBD+u+kqV6SaV4CjrymH4ox5jS9 miEwVwWZ3H97PqIet7/sPwM7D4ljjKcQCB+hkhjHWYEvsFpylF0o26HvXmoPy3R46JZJ eb94Ea3YQJIXS6CIrjM6l6zERAl8BU7Pfz9bk3Aitzm8FrrfeT0WMmnY1leLM5bNHlWn 7g== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sbmrqjya4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Aug 2023 13:57:59 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 379DvwcK022879 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 9 Aug 2023 13:57:58 GMT Received: from [10.214.227.50] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 9 Aug 2023 06:57:56 -0700 Message-ID: <653dd444-cb47-49ac-b20c-25e256025410@quicinc.com> Date: Wed, 9 Aug 2023 19:27:52 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cma: introduce CMA_ALLOC_DEBUG config Content-Language: en-US To: CC: , , , References: <20230809131640.18791-1-quic_bibekkum@quicinc.com> From: Bibek Kumar Patro In-Reply-To: <20230809131640.18791-1-quic_bibekkum@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: uyRoJB3vwoBhm_pDPqH1pz6JHFslOI25 X-Proofpoint-ORIG-GUID: uyRoJB3vwoBhm_pDPqH1pz6JHFslOI25 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-09_10,2023-08-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308090123 X-Rspam-User: X-Stat-Signature: 476gzchwga4d86okjtoycx6nm466ibo5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DEF1AC0023 X-HE-Tag: 1691589480-374082 X-HE-Meta: U2FsdGVkX19OT+qmEbd1S7zaLsk8h4p5JCAlSVJADn7ou+Bz28bPWUfZ8eX4t3f7hndtyAXf12vyjN4yGPZmhy2S/vI0qnLG7NJwjBbmviY2mD0WjObmpBPttWqoLo2N61SS9QdxSpMgj/WVorgWwBAFOzvNscJYFB+y9q69lvEJJJI07SalotCcyvTzTIsj+aOla1Lgvx0oj6guAIuo0NnkpRYrjCNcWfsGvIMRp/rYlb5CWQcehrOSqARyY8igrwq8OeB4XSFOCDSoJhIQdWoZHPoUiFBOez42E0NB8vuPiA8HCco5b6X2XwiXr8jVHMMnKV4v0vr/8Cfy2hlmNYr2GACTQdq62XmZyWtJnbgPvLtWoaFI6XIdxCQ2WNEfkm47dLJjJkkrUcyouTSsvigysBTa/Np6V6Sy3vOs6w9dZOTx3whHHebiiors2JnoTn3eYzCewpTjduiB8F6czkif78BX13TgLe56Y6ySJeYYF8ZBRiyxlEPJH/WC9Icv5VI12PV+vGyQ4giziCkzaoG/v+4j58puPFcmyvBsJhL3S3ki4bsltFjAqo1fMKt440jRyAO8kAjNwgQZD0RLl9ofr3I3OSjUr2vQl4cqWY/CswUVkpxRni2unegp7qfEJLwMzw2knbn9ijsZ9k4abADGZOCjIEw2mZBEWN/3SqhfE6WVVA5VfSVwkcj8x9b0JoZEarqjraDBYeoakVYwAotGFaC/gmI6YgEPrVP6Bn1jdJYb4+CBFq4FpihInf9xYQtt1Ue/E5BJzGMISmzElgK5bKwHm9jbzUGRAT4XttDhY1906WHhAjxedEPZup9uaqlugdJKJ0+b51HfHEbsNfS2alThXTC6vgNntPZYJ9PJy/tM0lbp0+EAPHzRNU9q6h2bj2QPQcyVXiAkwF4Y+goccwl6fLCVM8y9QbhAMlBewU30GVIqMmpPBUF6w01igEbeXL2lXWHaJSeHVTq pt3pzf8R ictmb3yVZinjrDY+eBpWuWscSbsJkHyNdOKY/jhvFEh4i6j8D7m2WHIyt8X1l35k21/T/0S7jG9+h584nRUBQq6oKdMcz/UnH3lVYZrd4URgdAARlRovG8UceH0BSuiVKCV1SZc05p/FWxZfaWKIIsQ5TG6J1KC2c8sRoBNySVXMeKU50flDtSGaR8K+5H5zwxycFkqgaJN2lDTOGRkl2lRW/7MJeUAcRFcjQtWADYvWU6uMTqQBNRcnjXffCibI9zvQJWEJ0rsHJyth9S3bOJ29WbyelYYh3Fv4hU+w+5HM4nglYmpMLH9PTRECacoQMsW1Q2Srz+CnZ1vtDdCcwLexgsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: v2 was added by mistake. It's first submission of the patch. Please ignore the v2. regards, Bibek On 8/9/2023 6:46 PM, Bibek Kumar Patro wrote: > Currently enabling CONFIG_CMA_DEBUG enables DEBUG preprocessor macro. > If DEBUG is defined, it's equivalent to a printk with KERN_DEBUG loglevel > flooding the dmesg buffer with pr_debug prints from mm/cma driver and from > included files as well. This results in excessive amount of CMA logging and > also might distract the debug teams with unrelated KERN_DEBUG prints.One of > the ways engineers currently tackle this problem is by passing loglevel=N > though commandline to suppress KERN_DEBUG messages. This approach can > sometimes become tiresome due to its repetitive nature. > This patch proposes an alternative approach by introducing a simple new > config CONFIG_CMA_ALLOC_DEBUG which only shows the cma bit allocation > status in case of cma failure and do not enable DEBUG preprocessor macro > from CONFIG_CMA_DEBUG avoiding excessive CMA logging from pr_debug. > Engineers and tech teams seeking only for bitmap status in case of cma > failure can use this simple config instead of worrying about changing > the loglevel or trying other similar workarounds. > > Signed-off-by: Bibek Kumar Patro > --- > mm/Kconfig | 11 +++++++++++ > mm/cma.c | 2 +- > 2 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09130434e30d..ad2a20576a65 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -891,12 +891,23 @@ config CMA > config CMA_DEBUG > bool "CMA debug messages (DEVELOPMENT)" > depends on DEBUG_KERNEL && CMA > + select CMA_ALLOC_DEBUG > help > Turns on debug messages in CMA. This produces KERN_DEBUG > messages for every CMA call as well as various messages while > processing calls such as dma_alloc_from_contiguous(). > This option does not affect warning and error messages. > > +config CMA_ALLOC_DEBUG > + bool "CMA bitmap status upon failure" > + depends on CMA > + help > + Turns on bitmap dump in case of cma failures. This prints > + current status of CMA bit upon failures and will appear > + when cma_alloc() return no_warn argument as false and won't > + flood the dmesg buffer with unrelated KERN_DEBUG prints. No > + need to explicitly enable this if CMA_DEBUG is enabled. > + > config CMA_DEBUGFS > bool "CMA debugfs interface" > depends on CMA && DEBUG_FS > diff --git a/mm/cma.c b/mm/cma.c > index a4cfe995e11e..0ead392769b3 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -383,7 +383,7 @@ int __init cma_declare_contiguous_nid(phys_addr_t base, > return ret; > } > > -#ifdef CONFIG_CMA_DEBUG > +#ifdef CONFIG_CMA_ALLOC_DEBUG > static void cma_debug_show_areas(struct cma *cma) > { > unsigned long next_zero_bit, next_set_bit, nr_zero; > -- > 2.17.1 >