From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5422C43334 for ; Wed, 13 Jul 2022 08:34:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4146794010F; Wed, 13 Jul 2022 04:34:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 355F69400E5; Wed, 13 Jul 2022 04:34:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17CC994010F; Wed, 13 Jul 2022 04:34:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E80F29400E5 for ; Wed, 13 Jul 2022 04:34:06 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BCA4E32DF0 for ; Wed, 13 Jul 2022 08:34:06 +0000 (UTC) X-FDA: 79681414092.31.B7CF2DF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 4751A100007 for ; Wed, 13 Jul 2022 08:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657701245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=70wu6Q93ZaJ2E16t3UBga1pfNO3TIEeHSMgPe4nGST8=; b=eQ8D+Q8BooxIvp0jl69HdylfpWLsP6+HmRD3fZX418xEHdRXJ1Jiz2NtTMQ7RiPEYW3mqX j9ErNBVsYKLZRixfhGdhF90ZYvIfDSG8Su7psjXZl299/hos/uhjxEnloaxiYKGNLJwemD A0MVEY8tPoZa+5D1Q56BpuOzOH7Wcyo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-Eeq1HwVWOMS6uchatzre5w-1; Wed, 13 Jul 2022 04:34:04 -0400 X-MC-Unique: Eeq1HwVWOMS6uchatzre5w-1 Received: by mail-wr1-f70.google.com with SMTP id r17-20020adfa151000000b0021d6c4743b0so1912576wrr.10 for ; Wed, 13 Jul 2022 01:34:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=70wu6Q93ZaJ2E16t3UBga1pfNO3TIEeHSMgPe4nGST8=; b=5s8seGCbEHhbXldaSVfHde6lwgWxrzc2RoRp9Bzk4vhgGjOASFi3q1KrMmo0+9HPhn 79xezYBZqcDeLC/eElCEgHrl91JAS5waT7JhSuv2squXR/d/wqYzTdqCI/chccZntD8c gUVnCiAKnTzXXRSDA7Kh4F1mZ4lWNwwKqwzBToA7DcnQesDPmjkQ/PBE5coMYA0iZvrK FwWxBNldf8iZb5I4glLeSbofoIleIExHzN5MNLJA9OycAUGgFj5OE3DE3eJijIkYfwbx bXfCwJd21d5VdDEtQvksZUa8ITfwjS3ddai3TtP+qYpXe4acOKJ8bZ7OOAEYED80EVp7 ONbA== X-Gm-Message-State: AJIora8MVEDUKDvI8A7YjZcN7k60CB139aZ9jpf5Cy8bvmhKa1nLB180 FEQn7xa6S9Dd8aM3H3U4P20xYHFUAlPOa07ZV4ZwN6VJeKoOQs6825l+xE8I1X4het4BkfIXnqD W4zk9Sgc/Tuk= X-Received: by 2002:a05:6000:1d89:b0:21d:5655:eb72 with SMTP id bk9-20020a0560001d8900b0021d5655eb72mr2100093wrb.110.1657701242847; Wed, 13 Jul 2022 01:34:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vtCIhLP80A2tYuvdXzA0RPOGTN/f6RtiPwyaCk599XzqPcqPudk/ewedaZFLfdSUPbUqjUsg== X-Received: by 2002:a05:6000:1d89:b0:21d:5655:eb72 with SMTP id bk9-20020a0560001d8900b0021d5655eb72mr2100072wrb.110.1657701242595; Wed, 13 Jul 2022 01:34:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5800:5009:e8d0:d95e:544d? (p200300cbc70758005009e8d0d95e544d.dip0.t-ipconnect.de. [2003:cb:c707:5800:5009:e8d0:d95e:544d]) by smtp.gmail.com with ESMTPSA id p42-20020a05600c1daa00b0039ee51fda45sm1536275wms.2.2022.07.13.01.34.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 01:34:02 -0700 (PDT) Message-ID: <653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com> Date: Wed, 13 Jul 2022 10:34:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] maple_tree: Fix sparse reported issues To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton References: <20220712142441.4184969-1-Liam.Howlett@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220712142441.4184969-1-Liam.Howlett@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657701246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=70wu6Q93ZaJ2E16t3UBga1pfNO3TIEeHSMgPe4nGST8=; b=cXXnWg/63DcH1YfPvT8FcDHI3W+25/2Gaug602bH8YHFSbKBnjhrVn+n+rDRH9EPmI88Ye QzWMNlF/eHJE2nyrIo9s0Cue4/mXThdyVLSk2QS4Az28vCsgW0HjDdaU1Yct5Dcy1rMX+o Inl+wAcUz+U911Nm/Xbh0FnUqi5KHnQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eQ8D+Q8B; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657701246; a=rsa-sha256; cv=none; b=JIHNvadaSjSJj0YkGYbgH9vTTTyZ37L9Pcx9/Ym69HwIEtfca2yX42k/S72HgUWZU6zCD9 Wg2Q/tE+qORQln1HVtqUNnE1SqmvL1CyCn5QV9Smi+/a5mMkFdS4oxG8YdDArCGf/qGH2/ m18CI2RQnnVT9pkdkLMYZCpWPy03Mso= X-Stat-Signature: 944d3yifu7qbtcdw6dbahfmc9y6prx9t X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4751A100007 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eQ8D+Q8B; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1657701246-366105 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.07.22 16:24, Liam Howlett wrote: > When building with C=1, the maple tree had some rcu type mismatch & > locking mismatches in the destroy functions. There were cosmetic only > since this happens after the nodes are removed from the tree. > > Fixes: f8acc5e9581e (Maple Tree: add new data structure) > Reported-by: kernel test robot > Signed-off-by: Liam R. Howlett Sorry to say, but the fixes become hard to follow (what/where/why). :) I guess it's time for a new series soon. Eventually it makes sense to send the fixes as reply to the individual problematic patches. (instead of fixes to commit ids that are not upstream) [yes, I'll do more review soon :) ] -- Thanks, David / dhildenb