From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D536C4345F for ; Mon, 22 Apr 2024 06:49:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EF9E6B0083; Mon, 22 Apr 2024 02:49:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A1656B0087; Mon, 22 Apr 2024 02:49:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED01D6B0088; Mon, 22 Apr 2024 02:49:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CFFBF6B0083 for ; Mon, 22 Apr 2024 02:49:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 01650A129F for ; Mon, 22 Apr 2024 06:49:41 +0000 (UTC) X-FDA: 82036242204.23.B1151A2 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf09.hostedemail.com (Postfix) with ESMTP id 378BD14000E for ; Mon, 22 Apr 2024 06:49:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=EDl6etw7; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713768580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M4r8qRC3GMq/V9Nvk3gHKxi0DstITpx7E6gXzk5LZpI=; b=D5um1a5sNs/KAzwsR252MucBsZBgzLa+DYL4GzqC3AV1UqTLtoj3GG83SRm/1wKnLqow1k tVaJHS67QRIRjv1cCs5M1EHPy+SgBa6xf3A1ToyXOS+h0tSluuWjMBuyT3oh0xU3p8ay4P QM4fpFxn8w6MreA6KowQd1zgOSywBgA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=EDl6etw7; spf=pass (imf09.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713768580; a=rsa-sha256; cv=none; b=CchiTYOWbK/3AHgE5PgTvBSOGGa02w/wNP0GkDoq/hx0VYcmpIT9pVDe4+KLhp8z6HwR8f DHGntUmK/eGpxpv/eN7/eZ1RxIbD0Waxkwja0AqwXTURKG5izKEE0KXZS5Budp8VJOypXd lVLLXHvnrz8Xlcz868prxTTYh6iTWbM= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713768576; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=M4r8qRC3GMq/V9Nvk3gHKxi0DstITpx7E6gXzk5LZpI=; b=EDl6etw7ECCEwKDElL6WwiOSltojyxW5NgP65Uz4e5YSkbvKjhYZi6pJZG5VM8Uc/7++E0wbxG7dD7wVafFqBz7ITRjwbK0ChXnMLqBrJ4fO45b951jPHD8Eh1XWGcGPob0hmLG80Q5sjWGJ0TJ8dKluTRFInA1GMI+nLJs9OiI= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R891e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0W5.HVkq_1713768573; Received: from 30.97.56.56(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W5.HVkq_1713768573) by smtp.aliyun-inc.com; Mon, 22 Apr 2024 14:49:34 +0800 Message-ID: <653923bb-51dc-40c1-aa88-276c71a333a4@linux.alibaba.com> Date: Mon, 22 Apr 2024 14:49:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: huge_memory: add the missing folio_test_pmd_mappable() for THP split statistics To: Lance Yang Cc: david@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240422061720.61697-1-ioworker0@gmail.com> From: Baolin Wang In-Reply-To: <20240422061720.61697-1-ioworker0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 378BD14000E X-Stat-Signature: 8tdneu6fhbeh6dx99nk3djckw17s16sz X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713768578-237425 X-HE-Meta: U2FsdGVkX19TDPiPPvSb7weRVJwP/mUkS2g8iSxV5akaVDIutcuvk1v+zpoQs/e3nroYvF7spp3crW7IA4BZ+c8Cj32D0Cu/FjzY6g6z7tlKbt+Av/XOs/3stP3TWxaWzRhhbpKFH7HV3dbeFVXkOID0b706TXAyMjfqrbVSFvThlWFLLJ84jU/EBq2OManGevEmB8Gej6pR9OyB98C97EXxU08Jdbe4jC+34m9nBeXTCk4ivK18NcY4iDl2YNNe4xyMKsyVMzms/BtoEQoGDFTrp7v93WqmGffNBMZhuqMIk7a6j7wfkblWFN2Bn/+3cwfT/+uMZOYfaCL2weMPSYfxUBo7zlzYmMUOeyyao2xt4IBcXu9Hz8E7OT56YuS/+f6ZjMmFdpqL1cHMQTkXNL8mZ8f2oKxpZL0zYwfiDGP6EyrdWZ7xyDq6JLHYttL9sOyaMZ2A5qc9GyJpJbO94sFIIJp9d1pmuiY7e4wFcBLf4JkT9JpkXm4YY63XpvikoYlqfAunA4UnA1dmcAjGSf9Gs+tmkE9ktrA9WwTLMB2HA5u/nVz9K6q9WX/bk7yCtptmvBuNhSon2SYqjJVNj1v7ekUN/lWsrVh2KD4P60IQjlNZBjGPbTZqnO5CsZYHUt3HRmaycpXVUHVHHEciX0ZeWbIbVoSEYoCsasoftg8SLtmyA7cAZHf37vSmV6BMY7M3x/OI7yBNmLi2RbFRzrtevR7KWJHW8zDqE2xH7OGmaO+XPKK+SIfUfZOB8vuCgBtFDL08aigaDecrUf0zRli7seUCWAmZflbezN4IiQO/LDmpLaYVztOJD7T8z08dbmnrR7cpBNMI7M5vzE7tSKH3i/Z8iDGERwPESJP5YIRfoY4s36fgksN43GTlzRXI0thuBT9eViZ0amzxG2FbmESz2mDmCLDghAsQJcnRuvEGqgqfw2LX/purMbcn34GakA0uB3cu0Ng= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/22 14:17, Lance Yang wrote: > Hey Baolin, > > Maybe I spotted a bug and made a change to this patch as follows. > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 824eff9211db..f3c4e08c6d30 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2994,6 +2994,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, new_order); > struct anon_vma *anon_vma = NULL; > struct address_space *mapping = NULL; > + int order = folio_order(folio); > int extra_pins, ret; > pgoff_t end; > bool is_hzp; > @@ -3172,7 +3173,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > i_mmap_unlock_read(mapping); > out: > xas_destroy(&xas); > - if (folio_test_pmd_mappable(folio)) > > IIUC, if we split the folio successfully, it won’t be large here. Yes, good catch. I did a blindly copy-paste. Will fix in next version. Thanks for reviewing. > + if (order >= HPAGE_PMD_ORDER) > count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); > return ret; > } > > Thanks, > Lance