From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD6CC48BC4 for ; Sat, 17 Feb 2024 12:57:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F1056B008A; Sat, 17 Feb 2024 07:57:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1BF6B008C; Sat, 17 Feb 2024 07:57:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 468AC6B0092; Sat, 17 Feb 2024 07:57:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 377486B008A for ; Sat, 17 Feb 2024 07:57:56 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DA8388021F for ; Sat, 17 Feb 2024 12:57:54 +0000 (UTC) X-FDA: 81801298068.03.65C62BA Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by imf25.hostedemail.com (Postfix) with ESMTP id 3176BA0003 for ; Sat, 17 Feb 2024 12:57:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LIznG4GN; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708174672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pDBUMl3ArLW54T1zw9cgRcfPxH0R/RBD4CB2P43r+28=; b=2OvjBY7L8r58ZusaIL/cd/ih7SLZeEMcP+XN651RMnqYRBwVMEVbTVGaqoOyGkneJcrVKD m84MXpQ9jQOXeDxzNHWhb3ZC2ACNMeRHNIGxqr8VojyzgO/BHVhjZ5paBgTStSlJCtRmn7 8Kzc+kIrieel/sA/nPnLMj3C/j1YMLE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LIznG4GN; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708174672; a=rsa-sha256; cv=none; b=WXYhodkV34/xW7STI0NXyoD4qMs5F+DrkWjK2UtOBgVOKf545HTayHuMW6124RcVALbSav 2Wl9wtj78OM0iPIO8I4j+8PS7IbJultI+RYfGK855UBnz1on7pLP+VmFFwliYc7I+Tp3vP /A/21JBm+LVPbKC93Rxt4nVC6Iv6C2s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708174672; x=1739710672; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=UO5I9VNSJI0f7byi/v8nNKzsJNlXdqv1O1K5PAuBLGk=; b=LIznG4GNEkY3a6tvMyJAgYREW89DyHmct89OoAJQpc2oXdtkblKmFDOx csMRqm7cYu05TZavJif1lxhUSc+9DqZXBQMeBw2f0qwoG7XZSdicPgUpa 0oChLXMtoNXRVVmEBLvzOa95BfZvpRcoHdbXdJKA+0CfapcuAR60aw7os fCho2fDy0PUYA3S2CdL+tAG52pqtINm9KQ7GopniuTnQGEeGjC/clBJcU GyKnrT+ARSIVwaJoKKLyoUE4R/u55+VfSdCksVmiceWu1Le2UaF4iTOGa M4p6kEsZbT1R3PX8KXaNg8+kAyNpD7LD8r/ktOv9w9yrA/URNBMkEV1H3 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10986"; a="2164431" X-IronPort-AV: E=Sophos;i="6.06,166,1705392000"; d="scan'208";a="2164431" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2024 04:57:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10986"; a="935995886" X-IronPort-AV: E=Sophos;i="6.06,166,1705392000"; d="scan'208";a="935995886" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 17 Feb 2024 04:57:46 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id 0446D2E9; Sat, 17 Feb 2024 14:57:44 +0200 (EET) Date: Sat, 17 Feb 2024 14:57:44 +0200 From: "kirill.shutemov@linux.intel.com" To: "Edgecombe, Rick P" Cc: "debug@rivosinc.com" , "luto@kernel.org" , "x86@kernel.org" , "Liam.Howlett@oracle.com" , "broonie@kernel.org" , "keescook@chromium.org" , "bp@alien8.de" , "mingo@redhat.com" , "tglx@linutronix.de" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "peterz@infradead.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 4/8] thp: Add thp_get_unmapped_area_vmflags() Message-ID: <652xgd4wemokoomshvncmhufwkr6o4ftzg5nrhugcchbnaiaao@jjf6dfjidwvc> References: <20240215231332.1556787-1-rick.p.edgecombe@intel.com> <20240215231332.1556787-5-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3176BA0003 X-Stat-Signature: secfhzkkyjfmmbthgod3edb11fwrczg9 X-HE-Tag: 1708174671-141225 X-HE-Meta: U2FsdGVkX1+rkQfPH+aG1alDFQlx0cl47K8um+qFU19k9yGSZ6crvOc9CDdkreP1rnJd7OlP03k5mb2AMbmAYZUMvZwO+8Nb1VoVHV32KBDNPSm+V5CSSXkU9vMXbVy6cFRnDDNCfS4ldIfXOsXrQv0xDv3l0NqcmDZmWXP9tPSHAgdnoNG4YJmv2iPXY8ESpxwjqkbhJcA0D27Wx9wk1Tm4zw9KBajnhacAhtCFr4JHT/oweWU7vSNpsiwrdjfWE7gpkz0cl4R3dQ9M5o3crnV444BsdKPq+OOKus5T/xn3l+pdhT/1ohU4CvCMfAlhLsT3GufgE2N/CEPaltJK2p818Ip2XGdc3yTaso5EtI7hmDUKjCZkS08Foq1NVmekYHKX+puTW7XNbxE1dGPGiPB3QwQbtoofG3P2CUeMD2LEKak9w4SX31oUDhwnJ7niSgghk8MCWIYJpKGoNwsmceL5My7k6iZtjmD0ckjvHWt/AX04/ykgFdG+8kDH56sDUwyjeBaEPvW3ZDNzs3l5uz/6dKcFMIY4LNoJrWsc/zcQfmqrIqY232cKNdUDaotxu+k1zL0wW3uRGEUHpNIBGpYIGce12b3Q2AOd+G7bhiCbhZ4S8ZIePYsbsae6hPDZv4AWHyMsnm3nXMhglJU4AwK2PX4ODKuw8u401e/uWaSsIoZhhrPqUaKN3i1LyQCaiYDFUcWHm+DJyCSCi6SEjQC6UyUAapOH8g4hcZoS8lZf4ub0jeu7WIv1fYZQ/SclODel10EEhhvdpmjEXYDDfDX7aP/BNICyUxyXfrDSmCnwgTbxpqnOvxGM51+xVMbcyYIbL4d7g5B9clxm465jtjfkN7ISMoqgBg2qE+pTE2qOHf6cpJaUdcIeDsQS61uJkfFOEKFNd9w7KYzSwDcFjzRW+ZgPGXVMi9ei6slo8rmZk5X/sjIGQhH79n8yOLcnbkTl5ecJmjJccYEiGmE Xhvfb44T bGqJM+kDnglT9LgKCHPh3iHmoHCylL8yutZ7NDZyYOX+UK4Nc8VgAIORPFr7dH7e2VyxATSQdbM/LgsfmcNb142eR8w8H1se2e6tDXubbHCtcMCz9Le+uhjVPapdEagdvbuTIiDpAkATRGXqz3sasyToUZsbaREFj0aoLKrOJ0YJcqoL70L8fMIclItCRQuRCYpoPfYGuOikaBxtGd292KeTiu0LsqsfOxOOP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 10:21:13PM +0000, Edgecombe, Rick P wrote: > On Fri, 2024-02-16 at 14:59 +0200, Kirill A. Shutemov wrote: > > On Thu, Feb 15, 2024 at 03:13:28PM -0800, Rick Edgecombe wrote: > > > +unsigned long thp_get_unmapped_area(struct file *filp, unsigned > > > long addr, > > > +               unsigned long len, unsigned long pgoff, unsigned > > > long flags) > > > +{ > > > +       return thp_get_unmapped_area_vmflags(filp, addr, len, > > > pgoff, flags, 0); > > >   } > > >   EXPORT_SYMBOL_GPL(thp_get_unmapped_area); > > > > Again, static inline should be fine. > > Not sure if the diff might be a bit misleading here, the signature of > thp_get_unmapped_area() didn't actually change. > > If thp_get_unmapped_area() is made into a static inline, then > thp_get_unmapped_area_vmflags() would need to be exported instead so it > could be used in some modules. Unlike get_unmapped_area() > thp_get_unmapped_area is actually is used that way. > > Better to export the more limited version? Okay, it is a valid point. -- Kiryl Shutsemau / Kirill A. Shutemov