From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF0EC00A94 for ; Mon, 15 Apr 2024 14:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 335D96B0085; Mon, 15 Apr 2024 10:52:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E4146B0089; Mon, 15 Apr 2024 10:52:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15E4C6B008A; Mon, 15 Apr 2024 10:52:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EB5EF6B0085 for ; Mon, 15 Apr 2024 10:52:08 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 666861A05C8 for ; Mon, 15 Apr 2024 14:52:08 +0000 (UTC) X-FDA: 82012056336.02.27A34E0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 0DEC24001E for ; Mon, 15 Apr 2024 14:52:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=taUicS8R; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sV44x0e5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1gFlIHwq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bX6lMNi2; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713192725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=Z/98yG84ysesTo+i4lRlnhfNVOvTcH+kjJLoycmGBcUQe9RhhWo5s8BMaOib+gBatFKSqr +3wbJnJjDTAa6jIqWSFWqLG8CfxtcfO0WPLyAUUs0bDsOjtgTdsuvSnTMQM6sZMYs6lhgi qllUoKGD82GEGJHY8cCNbvqcBosmwXk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713192725; a=rsa-sha256; cv=none; b=loDYIUa72O1/slySANh803qBWNqQ5UFNzJfrwKR03eYGXQ98UFjA8XN9r5iZKBw95A1fgV 4MaHYE7dhLfTBmcQoHK+ZeUCE3qt08kPkFNKilwzkxmaZ36MWLvvgGWu4GTOFkw9yFiMFh RssCTHEMebxB9sHr3PeK7FDnriod19k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=taUicS8R; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sV44x0e5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1gFlIHwq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bX6lMNi2; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E100D37225; Mon, 15 Apr 2024 14:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713192722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=taUicS8RUcAKBhngMZLBJcmqPKmS/fcT7+4cggVszAuGFd9l9e1Y2Cx1aal6ZYF5HCvpgV b/8FsdWdN3J6OZ4cTVP4e6TeqiHcR64xFVDUEswTDx2bSt8yJf5o7wYkz2Gy8GoAWOD+28 DxXfeZFLxxZQwgDmjmyZiUTtZzYnFbw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713192722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=sV44x0e5u58amHmHzsHC3h82mL3J/I7vUtTEQWW+0XgU6Etnp0gcjqx4gwQVkeL9YD1pCz sVfExs3I/iSB7ZAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713192721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=1gFlIHwqEkMuO50/VrCH39v5SJI+HO5hp7IWMwSAVwNEQ6TfaOBiv4RaHEv3CNt9JIbXK2 bWLC3qRyQbC/rlBOJF5reiB4G6VpJyrIncHQk3HiaN49CM6peWMhUSOF4OSaUUT1DD86Zz 6w95XIePpy40daz4EtH84yhwmPYTGlU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713192721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=13UNKjhVIHv/NGbiVDOStxduKjcdnZrO5WucI5Y4RmA=; b=bX6lMNi2M24RlR7OIxzGfE9V6qGHZ18j7ona/BlW0gtfRwiJEX+9/1EP90rAyxGl2MsUKY k/DJYKwLESdYgaBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C7C351386E; Mon, 15 Apr 2024 14:52:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id L+lWMBE/HWZQMQAAD6G6ig (envelope-from ); Mon, 15 Apr 2024 14:52:01 +0000 Message-ID: <652e9d20-07a9-44e6-abb6-c644f5f3e996@suse.cz> Date: Mon, 15 Apr 2024 16:52:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slub: Set __GFP_COMP in kmem_cache by default Content-Language: en-US To: Haifeng Xu , cl@linux.com, willy@infradead.org Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240413155603.617554-1-haifeng.xu@shopee.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240413155603.617554-1-haifeng.xu@shopee.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: rp4mnchw76mejqj487jwcibybqqx63qb X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0DEC24001E X-Rspam-User: X-HE-Tag: 1713192724-497769 X-HE-Meta: U2FsdGVkX1+ZocDnkovAz9z3CxhS49KBFnqbe7VhNVI0hVDfaDPVlZiL2jflHbhua2kO58snV5klWXAvOUNxidDgtM5JffplE6affxueUFPh/FKYHG8FdC0InBC56XdkvOMjvFbGZ+lZMZb1lLbAS7gbyWnjtPXB84PI5VbVf4x/R+C38gnNDMFrmh1BlwDt2XBgGQp6O8NOSITH2SlU9Pbu5Z+pn7gfXsMeCqPg8zQ6/74lD4fPjdFOfnsK+pvWXyDRhA7eGbT3Pcjbk/6urz78UAAv1nGgF0PaASyEoBTnmHu7tSHb529K6o/iM+VwUYtkbaX2hStcWqknxFZIjrUOskgJhUvTqZh0Gbmznkak4Yq5WJZdRgdtGzvjvU7hUfmovxa7BNoKJydSnv5LpN78sGgKAprJNSpFFdMtCPvm634MrrUr5vg/MgJ7EkU9bjXRw9RSOrSDdORxUj0biotMtp1PiQ1x1Po/01+po2olIm5C93irM5/Q/CSO/Tqaoui8Gf9M8Voy5Bb7FNVnE5e1A5j567SwgylCL2VkPzBimbMYvLPd1wKV3wHo8zZkSn5ziC1fpdCr+VNeQxEQ0xm9hTZu6WeEXEP5FuPiTY8wvZNhQekdcNsEznj92Dm0rZfryDY8h4p8O4BrKlUnMhVNJYnpVf1FZbQzxkD0Qa83PzXftEQQqRZn9Z/P+xLpNHj/mBDj5gOC2O377TUtZX78evB0wjj7kRUukfUFSBoXQyxcpcq7fyUCwEF0v2oC9pkQxeIhAICgD6G4QXBofKNxbfWlhAieX/yGzjI0bYJoq7X/TwI5AGpaHgLNPtiNF97PlUpK9tBZij0wcCcysFu6iip7Y1TcJ4oxPrZVBl7UtwKCm9hoybZWik23uZjC4V4JhMhkn/5yohCsY8pylOiD/mhHpDCc8Irs+HKPkswv4ntltx344iaciUKmd8bqUmla3u8OKrIAkfllFSI mboHcjve WtyKztKmX2PHRigeXPTYJl/PG7+HLDF0/VJhMbg0KhfIh/FXqjS4mKZX4FaiJVmYlxLXw2GkOSvEHdm3W91C1c3na0duh57wVl9z7iyqYrgaic4zUKGpgK8q2Za9I9YGtuOSyRHii4WZZkH0tnKbHgjTKxrym3HV3sEmzTec9ewiOjVtS+DXdKO3LNKP/q8v4CD3ckleoLqOPF8aQSSaAiT0gWzi7cezo/ov9MpEX12HZmT3DqwZnhKgQZ5R3ipymEBK3IDBWS/71vRHQGm8loaVpzucWOuJdMsXKMwE5NNiy0PLkzW8Yf2G+X50xHUwHsQLcUj+ZiQgMMMkXzjKfPwJkSU4J2TUVSgjBzxDC0XjK76p5GKHd19wPpSSeXENYdIeeCxCmY0MOuRHglDxzU8r2cVoahA4MCoGw1Pz7amsDmXCFCyJinYhF4ckEbMuMEQoSnECELtfeDdQBe0wvJXYqHna19EXI8nFgTvvGdFHKCuqD4OKD4vXamA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/13/24 5:56 PM, Haifeng Xu wrote: > Now the __GFP_COMP is set only if the higher-order is not 0. However, > __GFP_COMP flag can be set unconditionally because compound page can > not be created in the order-0 case. And this can also simplify the code > a bit (no need to check the order is 0 or not). > > Signed-off-by: Haifeng Xu > Reviewed-by: Matthew Wilcox (Oracle) Thanks, added to slab/for-next > --- > mm/slub.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index e7bf1a1a31a8..49a3ebefab86 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s) > if ((int)order < 0) > return 0; > > - s->allocflags = 0; > - if (order) > - s->allocflags |= __GFP_COMP; > + s->allocflags = __GFP_COMP; > > if (s->flags & SLAB_CACHE_DMA) > s->allocflags |= GFP_DMA;