From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE54EC8743 for ; Thu, 7 Sep 2023 15:36:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BEB68D0009; Thu, 7 Sep 2023 11:36:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06E7F8D0001; Thu, 7 Sep 2023 11:36:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E51D48D0009; Thu, 7 Sep 2023 11:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D0F4C8D0001 for ; Thu, 7 Sep 2023 11:36:27 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9E3471602E3 for ; Thu, 7 Sep 2023 15:36:27 +0000 (UTC) X-FDA: 81210203214.25.5D82502 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by imf24.hostedemail.com (Postfix) with ESMTP id 40997180010 for ; Thu, 7 Sep 2023 15:36:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RkwHsO7r; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694100985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y1gHS9SSNFNvWG6eyvi+HUQZWQaO5pG9Zy4wPcXd1tI=; b=lx4puJ0d4x+XPZpjXiX0Htf7SUSYVAFWMK/tQ86KDuHZJ5WNmzdB0fNUJW7ype2zZxRlMf jgb87bjAE1sq2Kjpz6hTxvBMqnGrNn4fHoZAGUMujbmhWSZCLHIL7/0jgp0K0M90CGA5qy MRRHfobWyCaWQ5iTDVh7lPm34PpAl/Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694100985; a=rsa-sha256; cv=none; b=yXr/GUp3f5U741o9RcF4RkntUBZayXaM9y+4xfgv1KqFbRXtnK3KwVBv/+Zv/FJL4jMRtm vg0UYymdjrp3lVX/6Jeyniu3XWTAgtphVp3OLu6FWxOYWqG5yQq4XSLahqThbLMxEcCYn4 oMIsKf4Z2M5Di/Hl/A+mA6Dj8p1aYHs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RkwHsO7r; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694100984; x=1725636984; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gAFNTJqAbOYf7VH/NCFNgTzEP7NzuWW3ie9UYXuVLIw=; b=RkwHsO7ret5F2W1eIRQA78D6MQTZ/78lI8TXkGB57/kZogdJkTVpnG3h F/ovyiTERaMcN/u/QUrufZZHkJ2axI+a1T0zOBbl1iodxkFIGLUUeKN+f kdYctSq+1Xe1JuaZlQInE7BRanF737o1sSUg+KvNWzkS4mfEML87ETH3B k7Bdc/nKaeVxi/mu9962aZ41UHFbOJRQM9MYsxNbZSjtb1s1MfR37lQBX 6fgIC3KeMHD5FfG5/gwCNFHIHW4UsTKsyJr92H3Jh1b7rfjebVQiuWUP5 QnkrTR77s6hJP+cjl6FAAQLwto3wIGUc+ZFm8hpfUa1k0iXjpMOSo2xkc g==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="357698691" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="357698691" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 08:36:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="691833951" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="691833951" Received: from ningle-mobl2.amr.corp.intel.com (HELO [10.209.13.77]) ([10.209.13.77]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 08:36:18 -0700 Message-ID: <651365aa-389c-6465-1ad4-49b40036ac38@intel.com> Date: Thu, 7 Sep 2023 08:36:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/3] proc/kcore: Do not map unaccepted memory Content-Language: en-US To: Adrian Hunter , "Kirill A. Shutemov" , Borislav Petkov , Andrew Morton Cc: Vlastimil Babka , Mike Rapoport , Lorenzo Stoakes , Tom Lendacky , Baoquan He , Vivek Goyal , Dave Young , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, kexec@lists.infradead.org References: <20230906073902.4229-1-adrian.hunter@intel.com> <20230906073902.4229-3-adrian.hunter@intel.com> From: Dave Hansen In-Reply-To: <20230906073902.4229-3-adrian.hunter@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 40997180010 X-Rspam-User: X-Stat-Signature: 7bphizoa1twpqn8ekpzdpf8kacf9upbt X-Rspamd-Server: rspam03 X-HE-Tag: 1694100984-556046 X-HE-Meta: U2FsdGVkX19TYOrtdLmi2oH+/MAM5P1zV5StMMbqlwmDJjie1uFOTgtFS8/BM1MBwLfIhy5fk0ngR+JbXR9Mn6gWUAj4H0PzOl2/66SEIRJoXUf/LLQIa2PSfisAZ5AVUwUY6H5rpuTkZbDziLZlQSKurigx1RsOkvfbEoATsYbZVBWZ8dyxUcvWy9SpHiW/cmC/twbK/61cE43mr8u6+tdXqUula8G1DciKF8+1YfVVhPnf1BQs8MSps13WRUNFjEPhcPkwQ5FgRvMs2CTl9WnzQmUoi/PvamDuHtEW5XogVx+/HiLJUWn+1pdgotqldxN4L4S4Xi/DBmI3nw0CeR2BugreSpuHk8+Vfq+WY8LprpEl7oGZh/XXl5iM6XcWf31WRdalmznLFfiCQqQkHc00/Iq7OkEBQo/SvFqcUbCFYSgQYhsKC8vdPGQZ1EfsZwtOoZ+zYl55gsba9lvPlB6P1YNxrbuuw4VOJ8ToXLC4ugOPgObmTFnPNCPa1prtoQ7RzN2v9U69ULqxRHONjTK+/pcNSx6C0UbCe4pvjydoO2/eSBZYwzhpicSFQHyakliUfHgxHBKEIy58TjhYGvQlKrcA49QApUe+CUJTIS2X4lMQUOlYmg2thTFoVk/uB0HkM9p5k2vW0EL8K8FcDLYgU+s3jMhD+sYLGRQOn6WisLLdGZnYwibLDQvY9csK4tDTE9cAiCtAeWzDArnUrIlCMj+3yUR9LBl9WqeM1onKI8jkGtjP3u7hqLBf+1SHXERX934iv3x175blmReTH8V4SJd74H/sY2Nudv6cdc6GH77bLbhIG/Xe0GohwYz2MvMsPU9W/Pfo+xKxPCpKkyt7wWY5fkA602dAhByQWk15RXQKrIF63JOsnIRkNZLf+lvDpJ5RiygVQ+ojUmgmdfWvqrGlTYybgIcgp3Aa5rjxFB/hLWWyW5KEe8hb+y2Li6KJOpUWtlmWoBCs9qT AmlYK6XX v4Mb5/0VowlluKGMHs0rm7I4qJ0AzZdYQB3K7WHwofiFASMPYgbpAyh3c7l9XKfVOQr9BahY5q2nWuQcGs6f01slEiU9/X3oPR1lQsvJJkgQPZ5IMTt5b2WrnlHw2KLeqwi/nLPso0zuQYsv3S5za0KVcaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/6/23 00:39, Adrian Hunter wrote: > +static bool pfn_is_unaccepted_memory(unsigned long pfn) > +{ > + phys_addr_t paddr = pfn << PAGE_SHIFT; > + > + return range_contains_unaccepted_memory(paddr, paddr + PAGE_SIZE); > +} Please just add this as an inline helper to common code rather than copying and pasting two copies around the tree.