From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942E5C54F30 for ; Tue, 27 May 2025 05:29:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 107306B0082; Tue, 27 May 2025 01:29:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DFC96B0083; Tue, 27 May 2025 01:29:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F38B96B0085; Tue, 27 May 2025 01:29:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D4B576B0082 for ; Tue, 27 May 2025 01:29:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6FE3381BBD for ; Tue, 27 May 2025 05:29:06 +0000 (UTC) X-FDA: 83487559092.11.39CBCC9 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf16.hostedemail.com (Postfix) with ESMTP id 4B60F180006 for ; Tue, 27 May 2025 05:29:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="APB/Xemj"; spf=pass (imf16.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748323744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XPYBWyOq7r+7W8qExCRG+4zXFY/pJBbil6VcRDPRQGs=; b=c0SOCGGjFuFQRwUwRCobBV9otvy6aKLcTYwEqGyBcIldEwqWrfEyWpjxNADo+caB/86XCy dWsdYyDC7UaF4N50V8IsiTVtyE/Hqc+85S09tbAQNGWhQArX4zFBpHnqn0WGZg1vCC+Tf9 1KcBGTXjItob+Cv3TnoaYO1DFhsPo1w= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="APB/Xemj"; spf=pass (imf16.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748323744; a=rsa-sha256; cv=none; b=Skk8Q1QYY5yHXduJIj6Jl0xcpOyjHqk1X+Eb29ARRvh3hgTzay+vqYtOLvI3kDG54BpHdx 9WUUqP1eXpT5iljFJT8LwShqcHzg8upJmrS8Zjfa0WR5HZ2IQgu7Y17huKj8AhsDNMX1NC sUmYZ+QmF9WFmwz2B8evKlxEURvFY8k= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ad56e993ae9so582146366b.3 for ; Mon, 26 May 2025 22:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748323743; x=1748928543; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XPYBWyOq7r+7W8qExCRG+4zXFY/pJBbil6VcRDPRQGs=; b=APB/XemjIq7iK560rfYkY9imAlGxCcPkM1LUm4DNy1mBaCFH4SWiIovHxWNHEggKCN IcMDmMcMzwTVkmfZuh2vwqw7cn4oBgcWWCH3rPIYJD3m3GeXxNGPvzVwYTxVSvSrCk6I qXoEgOg7Z3PqAnSZ6oa0eZxjHWE6Xv4HTCap8PJypwbD3HtHJmpr8UjRQNnYx7gbXbyc hksC4u94oI049eUMc9uRDCeI2S0wiccH2HJxxyRlJ1qgAXyCndol+kdb1Mftr2/+VE91 C/5VpmANUgVqZLsRVhKVW+2ahGqlTKfVZBw+y7+ZznTzLXy/mQHIzR8ynmka1DhNu2HO VW+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748323743; x=1748928543; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XPYBWyOq7r+7W8qExCRG+4zXFY/pJBbil6VcRDPRQGs=; b=fpWwDb3c/nEHBsBq8HYS/r3BX57bnveg5u7nJGcrP39pWQ8RMo5zOdQQR/aKODWyej 4pGj7p2GSuyIVUGWT/3jRIWSAFR8Dc1u4TFzsAIIWYPKf8D4LhWZRhQoNx9j7eylGytB R2+OszfiJ1ic4gCsGpcto+Fe3kY1QXgnCzsQuKQPC0fXKIus91YJu0qJvJuFUIeuRWYz 72VQkMxzq0k5Kx2WnictonKe9G4ZjEgL3sRHysxzfuJ9yiB1KV4FO/oONeYDVefjYLvH 34xnrM8hTS1562qq9/bzIcBHPvu0WykvHruov8k3jBmJ8U6RJ2PRKM3NBIv7/U5NJF86 29/g== X-Forwarded-Encrypted: i=1; AJvYcCXtS/N1ZJooEmyHXCOIwp3VJnTpzN1iAIaMVCvpGWzRUGO0sX260KGqCVMzmccIxzxNWJ4V/Us21w==@kvack.org X-Gm-Message-State: AOJu0YyPmFEKBCucMuA+WkiaB081d8/2SDcLYK6XvRY1xFmgqN7Mbmzh Ij0SkeK2ihbEd7QP4gyBIrhqacBl/8OsTp16xO6fSBiY9ZHfq+sQFGMf X-Gm-Gg: ASbGnctNOR/PImV3kcajdJCuzGCL6Y775p8Ckt0QjwiwaKWtakOIs5oIIb60nZ6FG2L yKQp7BBf6uPzSK+G086d4qIUDDmmqwxfR2/ZqsJIYH+nvablV4U3NQ08w9tiYPH5hz7zNpFzDDS RtnhbmKd++LIV2Aek1jTHM0xsIrzYBGgj+nDnFMMC0RT4IPoP2HAR3agtDnzwNjzLowrplBqQ/X yUW2wDs2aczc9n/AROBl6hHkNak5dXSmaChLJCkjGmBaR/8WR1k/jpy3Wv1S5Tr+If95KCTnLq3 0rtd2rKMsqET/wuyKlKEACXNHKKQ0ESjde4ePlPLXcciaicaShuBDYZZ4IOk5JTlCyJqPdA= X-Google-Smtp-Source: AGHT+IFyCR8YM6MYHZlh2Co1/HQCHjCvfrUUguXmsb48Z8OwvU5/EiOa5v8Hnhx4fjcjwxRKZC73BA== X-Received: by 2002:a17:907:97c8:b0:ad2:43be:6f04 with SMTP id a640c23a62f3a-ad85b1d6bb3mr930446566b.51.1748323742493; Mon, 26 May 2025 22:29:02 -0700 (PDT) Received: from [192.168.8.100] ([148.252.132.24]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d0717c3sm1807896766b.65.2025.05.26.22.28.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 May 2025 22:29:01 -0700 (PDT) Message-ID: <651351db-e3ec-4944-8db5-e63290a578e8@gmail.com> Date: Tue, 27 May 2025 06:30:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 18/18] mm, netmem: remove the page pool members in struct page To: Byungchul Park Cc: Mina Almasry , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250523032609.16334-1-byungchul@sk.com> <20250523032609.16334-19-byungchul@sk.com> <20250526013744.GD74632@system.software.com> <20250527010226.GA19906@system.software.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250527010226.GA19906@system.software.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4B60F180006 X-Stat-Signature: d6rprmewmguswmjuw7n7cnp5at15zf1x X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748323744-665837 X-HE-Meta: U2FsdGVkX180x8nqRF+Giy2PheePfJlrbUPC3ffEmR2/nNN99fUBxZk3IEpb1ZoZipqJCRWtIHGFzwZFb4mav2mO9xpbhkhUg5DS43IMeHVeXrZJLOKuCjcAiY0BTa0e+BS2HxiHwv8PJHRPtyXJ7V9yU6X9tfNW3dAyga4bOvDa+tDkwtItgRw9T7MOQpmKIZpDtkN6mLQZRwrBqzTIIhqVXQtjhlCJoF4oWRqf30RwX3cwdfsYLyIzfQdbmidv5QueSQp9aMKBiIYnJoeCuIEsCUFEZICnTu5myUZ6YFqeBYJE/l3P6nPBmf8u8ayojXqp9iSEUw22tff/DNFJVVtfaJhiElEWEf6oy0mE3GgP/bfC6S9pXWeU5SkS6p1SMgW2NgTyjRlFq2PwA8IyQgjNDasXUIuSaP2/qbfA5BdlviVS2I3AI/+eE3xyx7ryDd3W2dOhG55AQeLQ73rCRko2grUrsxqPIGGnzp+Y93T7zOETXbXKferuEXb1Afozms/HEiqRW9ThHj29eaWcV+W8OwAUFjVcPulQcahfHfTBnnByhM3kGSSknXfXj5stfipO3FpI7da1kUe7ECq3VEe8cSCV/1BZpQlgBDobeXRTV7VtzdVdw8KMfWLGv19tEe+ZTtugprRQ6RA52Rwfqg4R1fhA+CS7+sxltkLGoiMoKEsBwmHE5KV9HesJADXPtHKc4TazSQhNPh1qR7kidPi6zLvTQjtCRdjdqF5JIUIimxwRENOymVpjhQiimb27zN5BTvjmKyNr4UmkTH4oKm7l1Qzd/bL4f4y5ywJ9DekJbafsxb80T1sBiqpuje7kWjs7wWZmAtQ7RV5+6w5TrnBT54j/lgOzmCvHvJwqtVSYPfCeZH7AjAlxLecYsA2wXy+pJz/zV7/h3HeeVxOnGVrJ81qrVJ71br2yY0pKg/63Y03j0bE4WoT6jpE2JKz40jjwctXVEs6N+6Eav75 +cOlMXbg xs4jrECSn607oLlSyCsKu0xN/uZ9YlXfdn5/l61KiWQvokIOqPHHnB0gMbu4LZdUQFDotKoe6atuKjnsoWO7W9M4e4Kyt1q3CISIRLUARATp+NQcllrk8Oi6e1vJgapJySlGPFf8ZRqN5CS63SaK7Kr44dX8luUO3+Ab0+44ZNjbY8H2bBJR+mQF22vCDaYAwHRW9hWnV8s1lvsUEXLb94QT/oBM8XWFpEd6eXDgI4tVQyRAfyqCWkYrBtRCOuFXwGVXMjVvv8FUoHV9DpHNFomADpc41zHOCLxyj5GsVXnkbJJBg2Z98IjSDe/59w2mh6pYxC4hX+4kvYk7fyHbNkhfbw2qVzSoVZ9Zr7mWsvRTDKLyCO+c1vGEJusczqcQBFD51g1sl21XhN3nvVNaesDeeqnSXIcisd7Z7kDwnHzzHB3Ljy7FXo2PLJJukHS7fm84A+X1vqm371LtneK2n8LVx8EoaV4hwiTEOYEorWLJfIXIXiMT1cGQanDaqVmahYclTOkoE3fW25Q8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/27/25 02:02, Byungchul Park wrote: ...>> Patch 1: >> >> struct page { >> unsigned long flags; >> union { >> struct_group_tagged(netmem_desc, netmem_desc) { >> // same layout as before >> ... >> struct page_pool *pp; >> ... >> }; > > This part will be gone shortly. The matters come from absence of this > part. Right, the problem is not having an explicit netmem_desc in struct page and not using struct netmem_desc in all relevant helpers. >> struct net_iov { >> unsigned long flags_padding; >> union { >> struct { >> // same layout as in page + build asserts; >> ... >> struct page_pool *pp; >> ... >> }; >> struct netmem_desc desc; >> }; >> }; >> >> struct netmem_desc *page_to_netmem_desc(struct page *page) >> { >> return &page->netmem_desc; > > page will not have any netmem things in it after this, that matters. Ok, the question is where are you going to stash the fields? We still need space to store them. Are you going to do the indirection mm folks want? AFAIK, the plan is that in the end pages will still have netmem_desc but through an indirection. E.g. static inline bool page_pool_page_is_pp(struct page *page) { return page->page_type == PAGE_PP_NET; } struct netmem_desc *page_to_netmem_desc(struct page *page) { return page->page_private; } -- Pavel Begunkov