From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5EBD75BDC for ; Thu, 21 Nov 2024 09:30:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DE876B0083; Thu, 21 Nov 2024 04:30:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18EED6B0088; Thu, 21 Nov 2024 04:30:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02F3D6B0089; Thu, 21 Nov 2024 04:30:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D1EAA6B0083 for ; Thu, 21 Nov 2024 04:30:20 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B4A4A0F96 for ; Thu, 21 Nov 2024 09:30:20 +0000 (UTC) X-FDA: 82809580350.16.E08C542 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf05.hostedemail.com (Postfix) with ESMTP id DAF94100005 for ; Thu, 21 Nov 2024 09:28:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dsTqJLMs; spf=pass (imf05.hostedemail.com: domain of abdiel.janulgue@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=abdiel.janulgue@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732181325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=80PKBDEVtPQ4QjHxDlXlhwod1lEddQK+pje91L+duo4=; b=pzA9VfF9wANJvR1Fu4uMas0ze1UYe3cwM8j1VjLgLqGePTQsfK0n2fIyUzZ2V9i77mSFNh cMtNEB7HyOy41T5xpAgRG01bY/hvDgenZJTIYlv0Ox+cn//RCEFK8bCzJjCp6hvXgWLdhb 10X0KoEdCmKUd0dHMXqNpP3HcQJF7Tc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732181325; a=rsa-sha256; cv=none; b=pFKHAL0R/aaDripRiRSbQwJJs/FAeAlEO56c30LTvONDatZxu1AXTBMfcjqGgwR+KCpCyj eLyZtJL2xX0kuzB4BKgb1sJb+fV9L4HuHR7lHL7S3MkDmRCj0He1mwscnrNJ7Tly64ulNv QOjC7QNVQe0SNNkmOBY5TYN1LBJjzS8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dsTqJLMs; spf=pass (imf05.hostedemail.com: domain of abdiel.janulgue@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=abdiel.janulgue@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-53da2140769so680985e87.3 for ; Thu, 21 Nov 2024 01:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732181416; x=1732786216; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=80PKBDEVtPQ4QjHxDlXlhwod1lEddQK+pje91L+duo4=; b=dsTqJLMsLhRlknIAruBlBAvIl68fZkhGdtUVwsI8Rcu4qhdNWFJLLYvWjF879Rfqir 9mZo+VrwpUmBkm1dC+VNcumaF/Xz0cIFqo0gsTx8IXz2tMk0r5wa18lL9ZmZ8Facd+/v rbbmVaFLnvIqJj1xge1fI/OjWhAvIlz7DX5Ni8I8Z4nxxcFL1ShcVcQzVgmSAgTkltnr 2rPS8E+agCM1ZJOIUbZCRiBMt9R/oFTbRQSUp6CZpUCKq9d7P1k4DQKlv1KQCTBAOI1C w1XrMLs4U2oWSf/tfshNkNuwAT2GcA/dgBVq2bT6HPcU2q8Tk82kfrLXzTyy4KMFlihf TuWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732181416; x=1732786216; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=80PKBDEVtPQ4QjHxDlXlhwod1lEddQK+pje91L+duo4=; b=QHibCRCBnzGH38WVc77TGERiZDHIEJybImPZb/c0gZSSS3+lmjr0NmQzEIhCL3wDz8 nRsLl6YH5ZokLUZ5GF+NHDmU2BFj8jCeDw85dsWSFVFbvUkjXcCgMrBtBhNjV8slbxG6 DjYOMT3TyAAvPROxyP8YbFAPDGNNnFC8z+xhHjt8eeA2J1ERlP8lZzXQ8H/F0zbZDZND B443v/9IXQ4ISmwQXu+Roaae8hkakKu2gJxrJEYzwjNFuI5oTeP2P6e2EOrIjJ9zr8xx UHoZ+LJlAjNeZ/foWS3/dJ/gus0k878ctPp2h+uXX5NmAabZF7K+Z7T1on8j8qOHhXJc HZ6Q== X-Forwarded-Encrypted: i=1; AJvYcCVKGSkGONUUG8htx9QQ+DUpUZtsioK9M9gMliXL2EvVV/1hGZ1OizYQM5KgXaEgoqlFuz8iQfG9Ug==@kvack.org X-Gm-Message-State: AOJu0YwTv8HfHl99gkbdFEyQiI8n1AcOykccj0EKilOHtpwz209gIQNz eqf0f1Rr+c1nnTDTb38hjd7w7T3gSvYRxIVuHmjgpdcmyNyIdaqT X-Google-Smtp-Source: AGHT+IFO7XMPmUFEJbv0KQ/GnA69E/7miUMRAVhpaTsMfUcJm2jpB17RpCNvA5HvAdtk+8JdkMelOA== X-Received: by 2002:a19:6453:0:b0:53d:abc8:b6dc with SMTP id 2adb3069b0e04-53dc1327e39mr2549621e87.6.1732181416157; Thu, 21 Nov 2024 01:30:16 -0800 (PST) Received: from [192.168.1.146] (87-94-132-183.rev.dnainternet.fi. [87.94.132.183]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dbd47838bsm903749e87.243.2024.11.21.01.30.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 01:30:14 -0800 (PST) Message-ID: <650846e4-b6a0-472d-a14e-4357d20faadb@gmail.com> Date: Thu, 21 Nov 2024 11:30:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] rust: page: Add support for existing struct page mappings To: Boqun Feng Cc: Matthew Wilcox , Alice Ryhl , rust-for-linux@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , open list , Andrew Morton , "open list:MEMORY MANAGEMENT" , airlied@redhat.com References: <20241119112408.779243-1-abdiel.janulgue@gmail.com> <98a46b27-c4bb-4540-8f75-f176c3f2fae1@gmail.com> Content-Language: en-US From: Abdiel Janulgue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: aeiudzm44h3gz699a89iu194tfqntxmo X-Rspamd-Queue-Id: DAF94100005 X-Rspam-User: X-HE-Tag: 1732181318-672331 X-HE-Meta: U2FsdGVkX19+rLmEnA0j8Uf/+TpKWqfEFahaqB4uM6oVMPgJLfCuR69qlC3CXLkf++8zG/vxN5i4zFxyCgnPOg4ZazZ5Pvm2StuMtG6mPhJStqs3YVXvWKmmDLwnyAoMdtBOMygSnCxOPkUK2jJy1O0ylv8+R/yqXQO3B4RgfgIhTl92epBuyJNtuG5BMX59HQdrqpKX3NWVj9cb0mLbCrw7gBwTada10ucHFaqmRuI2vimRTke5vTP9R3l/ytG+IEiyp4PQE1Mptt6sjzeeto1JSmFH6neE7E5dTYDuhk+Ozzbx5t4EFE/VMvQPjj97xRedSLF+TBVy+pP244eDnbl7iQmaQNBM4iGY5blG340liSQTOdZ+5MTvKD55TfvxQJxyMoemUx3RILaBjGNOHiSy+/DOQktQWhrHhYzX5/DdJMLbTKvoPIbd7bHSQvIxTB2ZMcXnjhFu5pi6Al/DJl35hWe+3O5uLzvAFn2cKBQ0hdO+AN1AH8Vx74HpWc1eJlBV/moHFFP/FhRZzZGCIrLHivqNO4eeCKr/ejiXOmL1SU3md+d+mAoQh0ucP/rmQnVUOMZinHZ7B/O1cuD9UwEZJe1pC0t6oir07ZuDLTvE5r/GLY4RXBPa4QU35PRSoYcXywD8EvsjaSZzAM9UBjMwyGuM2lj3jllXLwiIuWvpN1y0mcNDZxrcNBhCW5E2eP+4CpxWO7hCBPQABp3R+oxws0NsQlmPUCoBaQNYIlwveDlZ52cREHURQR+jIJJe0A2DKS3HEs1a5YMnmvnm6EwbRYuLHk5IwzHAUOWj8GNGlVS4KRfqcEmJpUnaIaTSaiUesNQYCRJqK9vLGygzf5STsucSMD0yiwO3nHP9I06Eb3Skv/1XCZgaCQZyzXFgtMfFy/o646SmNSoJZ4vuUU2H41hssF6QZWw2351ungMDGFWp8j/SYemFTXGvMS69a8sHkbMRA/aRFAYSNqq GdE1Qqf7 U0FJxhd/7Kdq95twuMPBk91dngLrrCp87a3tWZKibQa7ibwUlcpf89l1XMvDv2UC61nJqeafPR1bjr4zgu17Z3cMx6+/MPN7CvEVUP+DqAUysPLkBsGGyKx+HQTWA4Dno9Qx5gV7k8b0awXW8OI9mpxFF3uTwFKeIbj4TyS1peWmTx+lblnaVdM+5l2nKNpQdKjKxkhAsKEuZJd1jQErAaiur1f7FfV+VlSDFIv3nC+NnPPLauHitpzImhRaUHHOuD5vh1JW38GDKlayD1n7D1jegB5i2ca6PHN4srUTVkVebinMmayCP96uWUUTU5H38LmMYe5qG1LZiSWiWKIwWZlLOWKZqyDKdxOxWB4CwQQ8PyA6323u11yZEP742ro9n7i13npernCO+2Yj5gA/P0/0vnfxTJ9SQpE2ZBPNWSks76eSzB9vpNza3hFIilOg+L5PtVadnkin3xF8uBrMNRDNbrrmMj63pIE94NHkKHUMatocYDK/ArRVI0ki6RyZ5341Yl3WXkPJvTo5ItGsNMuZzgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Boqun, Matthew: On 21/11/2024 02:24, Boqun Feng wrote: >>> So if I understand correctly, what Abdiel needs here is a way to convert >>> a virtual address to the corresponding page, would it make sense to just >>> use folio in this case? Abdiel, what's the operation you are going to >>> call on the page you get? >> >> Yes that's basically it. The goal here is represent those existing struct >> page within this rust Page abstraction but at the same time to avoid taking >> over its ownership. >> >> Boqun, Alice, should we reconsider Ownable and Owned trait again? :) >> > > Could you use folio in your case? If so, we can provide a simple binding > for folio which should be `AlwaysRefcounted`, and re-investigate how > page should be wrapped. > I'm not sure. Is there a way to get the struct folio from a vmalloc'd address, e.g vmalloc_to_folio()? Regards, Abdiel