From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEAD9EB64DC for ; Mon, 17 Jul 2023 17:24:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70EB96B0072; Mon, 17 Jul 2023 13:24:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 696FD8D0001; Mon, 17 Jul 2023 13:24:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5102F6B0078; Mon, 17 Jul 2023 13:24:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3E8796B0074 for ; Mon, 17 Jul 2023 13:24:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 06A0DA04D1 for ; Mon, 17 Jul 2023 17:24:44 +0000 (UTC) X-FDA: 81021778488.09.20A7A88 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id B057D40022 for ; Mon, 17 Jul 2023 17:24:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=APi7cH0z; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689614681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R04z1muq70NOluT/MMgTjYXn9ojqeIcHprwCvVIitCI=; b=u2cdV7FGCxZORxMltSgUW01eoG42VRAf0VvxT1GTqE8Subyjy84ktuJE+CWOpXyZF3x7jO RlREFhLtvR16oJhNGp6lWxjphTypq3YcLMsWOgVp1kqJX3kyqKmly/nniPhmmdh+7nP1LM uzu1xQ0WEbRBTXqaKxhvA9ktVXhBJj4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689614681; a=rsa-sha256; cv=none; b=umsE0HvnxojA1A/Flph4Ao+H67Yrr2rfHp3QoRGm6G5kI8jq3o85BjNhZamjVd4hbLpSae 0iqtVeDUdjStXs4pWAW11iIxvO5Sp0lSzrqQjugrTyLG01p2a25FBcpJEbW8VefJaJ8LUg F87VDYteerSlF1imwSAc22+SwJaL2FA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=APi7cH0z; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689614680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R04z1muq70NOluT/MMgTjYXn9ojqeIcHprwCvVIitCI=; b=APi7cH0z5S9g1FjMtrG6Hi7DhPgzZ09Bj6VIzdhDxe944tw9mbQpkwcP30IPGg+fEdW3Sw VV0qugwP9/Jxx6gIFozJ6UCTu91adVxjg7Nwqo28DHPKWUh4jSfxUuHaTXqISWaDkhMI1F 34IUu313GGtJ+1EqJBokzdpIAyHhJ+A= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-vvw8xu1yPpCm43rIu18GCw-1; Mon, 17 Jul 2023 13:24:38 -0400 X-MC-Unique: vvw8xu1yPpCm43rIu18GCw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31432b25c2fso3007084f8f.1 for ; Mon, 17 Jul 2023 10:24:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689614677; x=1692206677; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R04z1muq70NOluT/MMgTjYXn9ojqeIcHprwCvVIitCI=; b=F+d6Z4Am8FrO75zRQCYNrWlWbQkHrgHuE9SOTwzCD9SisEPe3jUOUUvAUskGMW2XvN SdG+L1Sd27SzrSvAdvnY6fXbRL4lUWNvwWUFY3S4UBa2PAAjDuY7EiIzZVDkj6QzJ/85 +kNpRVU3MY0GIJPYkNV0idtSKXVJ2Ih0+hEjNrQ63MUeHpPiXq5JeSP+9/ClfrD1rRkP sNgcLQf6O/Wu7ynNsZiMXjDJfTAjkWzmP/0iLYH53wPMMcRRfYl9szMl7KLnEkkmATmy S0qj1QDaeuEkY3aeG3IL3MapSjsb6tT1DmihCS1IePKSQYai32x7hMHatqWq/85KpqPS ZLsw== X-Gm-Message-State: ABy/qLYfDeSOfPRsI9ySEDn/6xobjJYgXx+g7H5qGfzBzv8F/fovbffB A5YMugB+0rWNV3+8Z2t/EzkwkkSgzmOXDQkKQuMCUXH4bnw0JvMu79mor3eBxxEa8/u3aHKo0Mx pCSOGdg1fRIw= X-Received: by 2002:adf:f588:0:b0:314:2faa:a23 with SMTP id f8-20020adff588000000b003142faa0a23mr13039973wro.43.1689614677060; Mon, 17 Jul 2023 10:24:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlERhG55UZ5P/9dNHty+NsytWcyoi/ydB9l/aWTsqzRmSyCe+1dol9syWV+mXx6pbV/YM3UgzQ== X-Received: by 2002:adf:f588:0:b0:314:2faa:a23 with SMTP id f8-20020adff588000000b003142faa0a23mr13039954wro.43.1689614676687; Mon, 17 Jul 2023 10:24:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:400:2501:5a2e:13c6:88da? (p200300cbc735040025015a2e13c688da.dip0.t-ipconnect.de. [2003:cb:c735:400:2501:5a2e:13c6:88da]) by smtp.gmail.com with ESMTPSA id 20-20020a05600c22d400b003fbc9d178a8sm8426294wmg.4.2023.07.17.10.24.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 10:24:36 -0700 (PDT) Message-ID: <64f546e6-9c65-78ca-0157-f823450d151f@redhat.com> Date: Mon, 17 Jul 2023 19:24:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 7/8] selftests/mm: Optionally pass duration to transhuge-stress To: Ryan Roberts , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Mark Brown , John Hubbard , Florent Revest , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230717103152.202078-1-ryan.roberts@arm.com> <20230717103152.202078-8-ryan.roberts@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230717103152.202078-8-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B057D40022 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1cwhacneusb148ima8fiwqbszgg3uk3c X-HE-Tag: 1689614681-48103 X-HE-Meta: U2FsdGVkX1+V/RAfLcaf8yAoPv0mRNKYX0Iu7sWzdR+4cSUmjvd2rROHFCKJsG4Eu8Mg/1m9gaAQq/HDxKjjelVC8SjzjyaBZRjfJK8n2t5tRrgyXHGATevKim05rjYI14hpIyw2O5LlWXMyL1Hdp3MGl9r0iai1ihF899PzJ+mFsS/ZsRgSRZJ74iYy0SX2bHNZGpE2k26PRPT9feGvCZbhMESsG6tGY3/8/azSDUj+xUlJLvhVBoTvOePZUiHnd20YtElT6oNh+74bC/tATURym5HkVdYjjRHx8d7gK+HwdMnAT193Bbl2V51h8EEcbBE4gCu6Hm5m7rDZ2FJz6LdKZwikIcj4HTgIt2Le/V4Yt0n+8hKWgJ35M9Q/ock6hDXOa4YYbhhMl40o+5x3qzVpU0qhU/UMu0YnNvib5HcTmk3iUYHv7VO3TMg3N/Vhf94AHyw+LBt/BP99oFCe0SHyytQxfZmIHDvYRb1bN3vfrJgB5AoHUPa2H6urlPJ58IgQpcY1ojB/58NafMGApsOR+bTAqPmIpnxGCTF3l3bb3XCVRutArd7qAKWOXFxwW1wQdTP6Iazoc5jeYfpe5BneFOOKxGKcXei0Z5cXT/oDF9Ts6J6xWVT/uRMMdP6n8kXj7w/1Az0Ar5AFMPak9PGLEKjr1QokNbRRCqUHXZ4CXNc9VonE1FSDB2Wzsb05b0y1GGS14FEoNQY4GusjBc6rL5N/roUdl/Vre7HfaKGfa5eGzqjQL1qsvZtflRv/DTLWRPnTzsGjGIWrAFqW1VaKbRl1Rsm0u099YI3JtZ6PhzxVPHF5iHiYoLUtx+QX4NbiPzlHeDPwt24LgAQ9+6N7MfXdCQgC9mnmOc5EEiu2kAO0SplFlEHri8mUXfpMD+3zIUF+h1V9uwLsA0dPpbZa1t9mGTkd2Iw9y49ZL1ShatdJdKMuMJrsXQwGrr+w86Na/mx82zPJ8yrkM4o yPumh5Mj o/NlQIrQ5q42enxxT8GkbyrFShreNpr3mzGEPPjnwyA1kwqJmAmc43DZcwpiJQ+WXt9qjZjQ1/hi3tXR9Tse1r4TNx0FDLiJuW9y7ld4a5WWjAA+oK4x7R7P2UNEL2HJTV9FaRlUmDarve0TbQUi+B66WqlQBaQ9zmDqpt/KOdF6lxu93u8dVaRaxTr+NbenFoxU90CIFGgcFoWbwOuk2D08yt7jOpJZRf9RnjWDTObmwizHUd9rDNArJwt0O71jR4JeF8X7YkLVNhqBSNaAl9ufPNdOWs1BjBCJa/dRa/2BakHg0IT8CE3s+KlBVmyOR7GBJYkgmpk9//Hc5dMbh5PDNkvYUFMiBOWp4Zs6P4JBSGVVHfyr6ATqzEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.07.23 12:31, Ryan Roberts wrote: > Until now, transhuge-stress runs until its explicitly killed, so when > invoked by run_kselftest.sh, it would run until the test timeout, then > it would be killed and the test would be marked as failed. > > Add a new, optional command line parameter that allows the user to > specify the duration in seconds that the program should run. The program > exits after this duration with a success (0) exit code. If the argument > is omitted the old behacvior remains. > > On it's own, this doesn't quite solve our problem because > run_kselftest.sh does not allow passing parameters to the program under > test. But we will shortly move this to run_vmtests.sh, which does allow > parameter passing. > > Signed-off-by: Ryan Roberts > --- > tools/testing/selftests/mm/transhuge-stress.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/transhuge-stress.c b/tools/testing/selftests/mm/transhuge-stress.c > index ba9d37ad3a89..c61fb9350b8c 100644 > --- a/tools/testing/selftests/mm/transhuge-stress.c > +++ b/tools/testing/selftests/mm/transhuge-stress.c > @@ -25,13 +25,14 @@ int main(int argc, char **argv) > { > size_t ram, len; > void *ptr, *p; > - struct timespec a, b; > + struct timespec start, a, b; > int i = 0; > char *name = NULL; > double s; > uint8_t *map; > size_t map_len; > int pagemap_fd; > + int duration = 0; > > ram = sysconf(_SC_PHYS_PAGES); > if (ram > SIZE_MAX / psize() / 4) > @@ -42,9 +43,11 @@ int main(int argc, char **argv) > > while (++i < argc) { > if (!strcmp(argv[i], "-h")) > - errx(1, "usage: %s [size in MiB]", argv[0]); > + errx(1, "usage: %s [-f ] [-d ] [size in MiB]", argv[0]); > else if (!strcmp(argv[i], "-f")) > name = argv[++i]; > + else if (!strcmp(argv[i], "-d")) > + duration = atoi(argv[++i]); > else > len = atoll(argv[i]) << 20; > } > @@ -78,6 +81,8 @@ int main(int argc, char **argv) > if (!map) > errx(2, "map malloc"); > > + clock_gettime(CLOCK_MONOTONIC, &start); > + > while (1) { > int nr_succeed = 0, nr_failed = 0, nr_pages = 0; > > @@ -118,5 +123,8 @@ int main(int argc, char **argv) > "%4d succeed, %4d failed, %4d different pages", > s, s * 1000 / (len >> HPAGE_SHIFT), len / s / (1 << 20), > nr_succeed, nr_failed, nr_pages); > + > + if (duration > 0 && b.tv_sec - start.tv_sec >= duration) > + return 0; > } > } Acked-by: David Hildenbrand -- Cheers, David / dhildenb