From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 394D1C05027 for ; Sun, 12 Feb 2023 17:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDA7D6B0073; Sun, 12 Feb 2023 12:38:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8B026B0074; Sun, 12 Feb 2023 12:38:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A52036B0075; Sun, 12 Feb 2023 12:38:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 96A9C6B0073 for ; Sun, 12 Feb 2023 12:38:44 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5338A1207D1 for ; Sun, 12 Feb 2023 17:38:44 +0000 (UTC) X-FDA: 80459349768.07.A9C739D Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by imf22.hostedemail.com (Postfix) with ESMTP id 59B41C000C for ; Sun, 12 Feb 2023 17:38:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="R330sse/"; spf=pass (imf22.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676223522; a=rsa-sha256; cv=none; b=PXAe3FWoFyC9wH82haFxA5xQ3D62m3PQwQ8mejX/aNSAe/DPS5BHWRymthfiR/Gjtk54fb opsQY0jhojogfpUdd2UEhMfniG7+Rtt6cfiUAmjvwBorzZgwtvn5nha6dpvYlSnvCUri1X 9IyYSnm+ra7xqL6d+HxrgYLNgjE45Mw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="R330sse/"; spf=pass (imf22.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676223522; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gEc3d6k45zjDeEZHbol4IIwzjmxqM4mBWgDI31Sfc5o=; b=YCDIoCWfhVef7TY/KYfFmpNw1d7lVxZF5P/5IaeKsj7iL6miDCF6BfXxjNkiW4FUERplcb nGuTX+T3B2wtws6VQM/p1w8/S1Qvq5N4UAL+ecMydmZExrooup2Anc7P389VQqSsuN3mMA FvEK3UHLg7lzBV+bDCgIHzeJc/gfS3E= Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-16df32f2ffdso2170991fac.1 for ; Sun, 12 Feb 2023 09:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=gEc3d6k45zjDeEZHbol4IIwzjmxqM4mBWgDI31Sfc5o=; b=R330sse/EVLRGFL0igafPWieDgvfGLbUv1mxwjjJZAHpBvZcU2/Gg7Ye7o55WJDp/T d/MkHSIY+rV5WmpmEtSQ3EcpkVyHgH/g8WGwdicgdAr8s7fVYzB3M6AQYSXN1fWO7dsD adnG3ljI9LKreMS0IYacGj+zm2/uKWOjveyAMeTbeBXzAlA0+lDjE38oWr0kFL4x/3pl NtGAiadx3cotdBgXvBg6mFyqYNavUvZnDTVR9OSu3hxj7Glcs0NmbhgPuh+/V46P8f0N UAStFFymZhcq+751kC0Xe8LgThvdTeD+HxCq3F5UGXwSHXYBMgqQ0gCOk/Vyqx7W2YhY u2kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gEc3d6k45zjDeEZHbol4IIwzjmxqM4mBWgDI31Sfc5o=; b=iuoLO33vKPKQIRzmnW3fkFGeGeofjwAyQHJ8khXjpiyAUdjw4dT0e7jYjP9hPe8XYC +omdFy4du1IlDIs1HfzyTKbTH3SGhGQrRJ2w6tEjVThfQyqxgo7MvwhKneDPIISbWcS0 A1S6vFgrqkcQA2HtFfPCya+2nKdohdCi8+hEJXm4ZncIXXqojAtJqmsg/p83t0JmQU+Y yWGXfxOZ38YNrnqeaICvFQKKrFeMLKnC0SwKj6TMKDZhxOXkkRHfXJAFn5yoqtl839xS yQb4791R0823a+ToAqw25PBE/6ZEdLw6m18yiFnLjemUWKct3AwbBsIHC11i+mKJRMh4 wPIw== X-Gm-Message-State: AO0yUKUf/AR8ohD3lN/4XDFAH2GcB3+oSvHrbc5snkZdR8ssi+pG61PE ZOLNp+MzNuKCwVqcs6Veuy8= X-Google-Smtp-Source: AK7set/4d6sAa3sFADK7k8Ny8wL2J6QT+VlS2G9nj4JhFjRiy2CF6KFV2p0y673SokHVHJOuHdHtkw== X-Received: by 2002:a05:6870:2885:b0:16e:a65:3b8e with SMTP id gy5-20020a056870288500b0016e0a653b8emr473342oab.9.1676223521592; Sun, 12 Feb 2023 09:38:41 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n40-20020a056870822800b0013bc95650c8sm4012885oae.54.2023.02.12.09.38.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Feb 2023 09:38:41 -0800 (PST) Message-ID: <64f2ba37-d869-0160-1a89-d7f15d243d05@roeck-us.net> Date: Sun, 12 Feb 2023 09:38:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM Content-Language: en-US To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org, Huacai Chen References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-5-rppt@kernel.org> <20230212161320.GA3784076@roeck-us.net> From: Guenter Roeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 59B41C000C X-Rspamd-Server: rspam01 X-Stat-Signature: pzu4ifn3q99aisxtpboz71ynbnp3n5to X-HE-Tag: 1676223522-495998 X-HE-Meta: U2FsdGVkX19jg6p0xppJE5oFIuy1f5fxOU6szNAcOG+zOiY/I0YBdV7CY8+RCWr7uNdZMg1LEh+M/kea9G0zf7ELDpSpdfX52Z1M7Wv/g2vJ1FGQXXhC+SQjbChzQglxAGaZiBsSRhGl4pSopAlsubiVtkrQej26K+NSQJhFMAT2JGBvlrWEt/ZO5jbQts3bd6RHkTqwfnr98OvDmNJemqtepqo4tF+RRoph3hCEztAxRxeGa6RrEcrQiqy0FQkwKE7LcyEdhlKetXnMsM3KhHgNlMRYOefk5C3VsjL/M6b3n+6U0QeI0C+N9DrEVRBEu+McvUO5mtF1QC4L6ifjwGJk7JXupKu1x/jr78LCVe0fbWn5eHBRMmlxTqZE9Ogg+z6haumdqQ1Bduz0qVXMGsqKbj9oPTeo9+iHEBZW2XJh2KcCWUTD063jpaOoOdT+xuWvXiBEZFFsz6vQJ8arl4jRc8UJ3RdvO5sVkRjVkpkUi3Gdy9B7dbV1VyhUoWWe2YJIlRDZCrbWBxUtgjTHSwzRM9d2AvhRJJH7yVH8TymmY+74l2YkdpGBs+8Kb1P48B9RE6YOdj/rWOlcG/UIt2U6Z3Emy7bwRnMpbULMa198UoO/wNwNOUZ6vbbDlrcoJG+JvxOf1jg2el68t7ufT6AffvQvmIoa0lZbmbxhbTQAkoNZGpSM7cHa6L4SBmkiH0DLmhhcFUW762OjUL/VE1kUbNeZ99S7GpsdMRmkeB1+1EOZErcU7GWLO+dxw3hvon7X+f1JWx3gJUv3tP17/h5smx9dn8MnXGnUCvpFhxtvU3fni+W9SEI/dF9FgxXSU3Eu5d5sm2ktS7sAnx53NHFl1czgRImrAEvapA0FCYulYAvM7+fvROPMuEI2q3osd5KGtykZxzwDWE8ZZVJTf5QHJv+Si1gVdmeQAwQ/grMt8THclEkN1jVGNJ8VbBQKZ3bas9jlpW/keSuqLA3 wt68waK0 ADTybh710SfWAAhil4b1n4bKiGhG63zF16J7lqeLcgEOirtNBe7eZ+pr+JsIIGPYB01Mi2WEitxiSbpoeG3V1KXjRogd2K8c5sEkHiAGK9KZi2RjgiFFcFEEZ0lGn7PFlJiAUQ490soYW0PHOsexiDXC5aEiMN1eQBtHTfcFzKZ0Qxryl5w+3TDYQWDhBkylr9FdJols+VTicN2t0gqZ0GOi5C7LWgt1fU8ZJdkh3ejg0jtw5Fmd1uWvqMQm7Hpn7v9VU70U/2oi35vL/disQ5QUOp+pBDpLeB3WuVXusCxJBxA1lucv1HwrsN5Z/FUpVLb8cKnNmmo2qw0QeoBvUASous5XFClZ0A/SdZ6s0kbXKD0oxN0AMLPCgX+hTPYBiDVKBXKDb/DXqXSdvYPeWvTldLxc6Mm9ULzU1ff9WWNGXN0lA2apAEU4LHVBhNstvg230fSDbPautpP9Yo25i/g1IE2SHBiYdQdlhloH18ADt6s1NB/1z+mw+yyCWz4f4ZOYvAD3by05wamJ0O2GWAmyF0I8+ZKD/E9769yvjbE8Xa6OVm/FNYJrJGsk6hBfiajwkUUljVGMhhPFU7B8Qw+SINgRim9fP0QaG4XpuEIuJ88A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/12/23 08:26, Mike Rapoport wrote: > Hi Guenter, > > On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote: >> On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: >>> From: "Mike Rapoport (IBM)" >>> >>> Every architecture that supports FLATMEM memory model defines its own >>> version of pfn_valid() that essentially compares a pfn to max_mapnr. >>> >>> Use mips/powerpc version implemented as static inline as a generic >>> implementation of pfn_valid() and drop its per-architecture definitions. >>> >> >> With this patch in the tree, sh4 and sh4eb qemu emulations no longer boot. >> Reverting this patch fixes the problem. > > Can you please test with only partial revert for arch/sh? > Sure, that works as well. Guenter