From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D691C433B4 for ; Mon, 10 May 2021 07:24:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 126C9613DC for ; Mon, 10 May 2021 07:24:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 126C9613DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 701AA6B0072; Mon, 10 May 2021 03:24:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1CB6B0073; Mon, 10 May 2021 03:24:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A06B6B0074; Mon, 10 May 2021 03:24:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 419136B0072 for ; Mon, 10 May 2021 03:24:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F26F783FB for ; Mon, 10 May 2021 07:24:37 +0000 (UTC) X-FDA: 78124483794.25.6D16FCA Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf17.hostedemail.com (Postfix) with ESMTP id 35F3440002EA for ; Mon, 10 May 2021 07:24:32 +0000 (UTC) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fdstq2Ltbz1BKlc; Mon, 10 May 2021 15:21:55 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 15:24:30 +0800 Subject: Re: [PATCH -next v3 1/2] mm/debug_vm_pgtable: Move {pmd/pud}_huge_tests out of CONFIG_TRANSPARENT_HUGEPAGE To: Andrew Morton References: <20210419071820.750217-1-liushixin2@huawei.com> <20210509212654.e215ff71042b62704965ae01@linux-foundation.org> CC: Anshuman Khandual , , From: Liu Shixin Message-ID: <64dd2a02-e175-e414-9a1b-1de38fdf9547@huawei.com> Date: Mon, 10 May 2021 15:24:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20210509212654.e215ff71042b62704965ae01@linux-foundation.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-CFilter-Loop: Reflected X-Rspamd-Server: rspam01 Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=liushixin2@huawei.com X-Stat-Signature: yb6s6thmncqnksikhtdmct7oxgu7gpff X-Rspamd-Queue-Id: 35F3440002EA Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=szxga04-in.huawei.com; client-ip=45.249.212.190 X-HE-DKIM-Result: none/none X-HE-Tag: 1620631472-969126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/5/10 12:26, Andrew Morton wrote: > On Mon, 19 Apr 2021 15:18:19 +0800 Liu Shixin wrote: > >> The functions {pmd/pud}_set_huge and {pmd/pud}_clear_huge are not dependent >> on THP. Hence move {pmd/pud}_huge_tests out of CONFIG_TRANSPARENT_HUGEPAGE. > What is the actual effect of this? Better test coverage? Smaller > kernel? Larger kernel? > > (I'm too lazy to figure this out and it should have been in the > changelog anyway ;)) > . > Better test coverage I think. And I want to add HUGE_VMAP support for riscv, which doesn't have THP support right now.