From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D331CF9C6B for ; Tue, 24 Sep 2024 15:14:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 145A06B0085; Tue, 24 Sep 2024 11:14:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F6596B00A0; Tue, 24 Sep 2024 11:14:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFE716B00A2; Tue, 24 Sep 2024 11:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C7EFA6B0085 for ; Tue, 24 Sep 2024 11:14:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 45F97ABCBD for ; Tue, 24 Sep 2024 15:14:53 +0000 (UTC) X-FDA: 82599979266.04.908F202 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 8C9F91C000E for ; Tue, 24 Sep 2024 15:14:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727190772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yuy7MWlTZpZbPFapGTu1r86zdVnXJ5tlBqFM4f2d6rs=; b=jhJewuXbRQAchiYDVbA+a2wqPaUxXQPVQJSBcK+cFYW0JtEC+C8I/ieuQHmRXOfATudVCp r3aNh947qD+iV7yGC+SaCASeZ9mCOT1nfLK6HR7nL1hdFOTSFH6T3EZgUDXQqrk6fflSRM KwdBU+5vUlyolcQR0udDlgg4yENByv0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727190772; a=rsa-sha256; cv=none; b=f49wbgNa642qBhi7dy4po3nREfXNsWuv1ptxNrhTaeiu3jdJjkW9NTWGQza9kvIHGhhX0F sy+4EK96RqnvtC8v2nQO0oH5p3ynEQZqLqVfh5QbPBe7nqVqQOavjKWXbG3iSK+QAZpHFu KoUMsXvQhG3Sf64tH/FfJF5xIgByDfs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A053DA7; Tue, 24 Sep 2024 08:15:20 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CEDE3F528; Tue, 24 Sep 2024 08:14:48 -0700 (PDT) Message-ID: <64d9b7af-0b5f-4164-a97f-3b6f6792e84e@arm.com> Date: Tue, 24 Sep 2024 16:14:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/8] vdso: Introduce uapi/vdso/random.h To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Andy Lutomirski , Thomas Gleixner , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20240923141943.133551-1-vincenzo.frascino@arm.com> <20240923141943.133551-8-vincenzo.frascino@arm.com> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8C9F91C000E X-Stat-Signature: w6agdrbzac3disicekwjpe9pwd14g9qk X-HE-Tag: 1727190891-128454 X-HE-Meta: U2FsdGVkX182rxPDQytDI2aUNsHhc7ezASNH6GE8j5srySsUHsDoNgwc26nwjxxMaWTHOHP/2q79j9n6fYsFx5qkIN0xFwc99oOmBf1ap1oYlEKn2sk1ZrdiiyZeZdQNdFcxKByxeBT9IXB9+OVjuoGmOAZQCNiVyJ2td3wRGD3x2Z+BY0+mVMLmJ92c/8xLUW31XPyMegFlj9KMGjWXxof7SlEFOzxKVHKLIeGVmLzM7cUrG0CpVS+KG90joz6UgEh7+JIb8NKUDVzcvA8EBKGpqO1n6+Jc/nDVLTigRX3efyWzZtcbXqH7rJhpdcpm1lX+QIZwKOtG6O2ETmvMC+hKIVxiAxIv59C2VWLH27iLufsDQu+ZFOXRSjFXJZevrEG+Tfq2y594aiLIEmBQeU+wOlykcvRo3AyPuimEo3pz2mcgdyqspUe+PTHgx214kJuMX9YIFl8JLOBaHj/OudPdL4BipaaUlO6TKIN6njL6Cs6lj59ScPX2xicTzd4AIKiyMDpJVjENJpH3VIZlbcah9IWvZo0JcA5xQjjIr9Fbv9h0JAjZg729Mi3xVbQXp1D6BqF6yHTrSWxBTdT/gnaKnaL3TKyA/ovRDSSsw7p3LQfQ4sQwnncG+CogvT2+Cq1U69Zjm1UlIN7yizG8M2rop4AWuq+ufK16mrQBLAiPP4c2H6wmxiqyGTDCH+f4Lv+ef3UVmRUsnWdFywI9kL+iwefe+30NlhiqNzqH51hn7JJ76E31K01IgwMHZSP5XIcv+7rXo5/LVhav2XNuYQ5XYLSWW3WdFHCR7dAIK+c55h6qTdC7yKbKn4JENcq+QPRf1lzHaRllhIcZtDa8m62hYxzkm/K2gHGwhUn75YgDPgZlvA3z2ZtBPnUUWwBkuwUP609QftEQKd0v5Vu98eyj88vjezTyRUq1b9VpCk7KxorD2eM0fOmcF2c3dp0V5PbzRJg9QJViB06Rr70 bONYAbEj sYUmaa3xZvUXl3cXcD5hB9L1UPd/TboS28Ezy2yoirDuahz1ctnccAB4x0Az7CAUSFlNRB60PA0QtDw81A2do5uXiFkP5oHLMMJxEBXJzKgeF1EOCU47T0p8OJH2A47JJpCCu+3RkltbCCFKtdbjyFKis7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/09/2024 00:09, Jason A. Donenfeld wrote: > On Mon, Sep 23, 2024 at 03:19:42PM +0100, Vincenzo Frascino wrote: >> --- a/include/uapi/linux/random.h >> +++ b/include/uapi/linux/random.h >> @@ -44,30 +44,6 @@ struct rand_pool_info { >> __u32 buf[]; >> }; >> >> -/* >> - * Flags for getrandom(2) >> - * >> - * GRND_NONBLOCK Don't block and return EAGAIN instead >> - * GRND_RANDOM No effect >> - * GRND_INSECURE Return non-cryptographic random bytes >> - */ >> -#define GRND_NONBLOCK 0x0001 >> -#define GRND_RANDOM 0x0002 >> -#define GRND_INSECURE 0x0004 >> - >> -/** >> - * struct vgetrandom_opaque_params - arguments for allocating memory for vgetrandom >> - * >> - * @size_per_opaque_state: Size of each state that is to be passed to vgetrandom(). >> - * @mmap_prot: Value of the prot argument in mmap(2). >> - * @mmap_flags: Value of the flags argument in mmap(2). >> - * @reserved: Reserved for future use. >> - */ >> -struct vgetrandom_opaque_params { >> - __u32 size_of_opaque_state; >> - __u32 mmap_prot; >> - __u32 mmap_flags; >> - __u32 reserved[13]; >> -}; >> +#include >> >> #endif /* _UAPI_LINUX_RANDOM_H */ >> diff --git a/include/uapi/vdso/random.h b/include/uapi/vdso/random.h >> new file mode 100644 >> index 000000000000..5c80995129c2 >> --- /dev/null >> +++ b/include/uapi/vdso/random.h >> @@ -0,0 +1,38 @@ >> + > > I really do not like this. This is UAPI, and it's linux/something.h > style of UAPI. What does moving it to vdso/ accomplish except confusion > for people looking where the code is and then polluting users' > /usr/include with extra directories that aren't meaningful? > > A change like this makes me think the approach taken by this patchset > might not be the right one. The rationale was explained in my comment on patch 1/8. If you do not like the vdso/ namespace in uapi/ could you please let me know what is your preference is isolating the parts needed by the vdso library? -- Regards, Vincenzo