From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADAAC4332F for ; Thu, 9 Nov 2023 14:26:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 949918D00D7; Thu, 9 Nov 2023 09:26:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F9428D0073; Thu, 9 Nov 2023 09:26:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C1578D00D7; Thu, 9 Nov 2023 09:26:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6A7098D0073 for ; Thu, 9 Nov 2023 09:26:39 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 251881A0E5C for ; Thu, 9 Nov 2023 14:26:39 +0000 (UTC) X-FDA: 81438641718.19.C8CF495 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by imf29.hostedemail.com (Postfix) with ESMTP id 547EE120002 for ; Thu, 9 Nov 2023 14:26:36 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bOb1NX4p; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699539997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PYW3xEF0JL2Tvc7wbIKaUpcYbA98kvJsI0nezOCZABQ=; b=bzTgT4tJNd5ClDOClFG+OkMy1LxJVQZPA96ZrshMKAvKN1vup5QWHtJDQ8Ex0TXob1VHb6 DGn95GIiBkJfC05nkPrvnXkCb/jWxeLZFMWVw26cX8xHXVpkmtEdEqRaKZBgldXWW6JjST csotK81uuS/BKcQ6f0FSHr47FFOGcqY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bOb1NX4p; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699539997; a=rsa-sha256; cv=none; b=2Pih1BXqQSjI+J5Bv5NER4VCDaxOqQqUyPDFKvyFljB8kTmUll/gUMM1YsIpBnWo8yRXAd DpUmdAdowLTPKG8suTiKt662N2EGvz5bn3G2f6PiiXBk/zdHZXCPXBjINk85d6z5ayApmy qGWdRAmLmyYksHwFfCk2zxLeAu8ixiI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699539996; x=1731075996; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=xCVkFxZ+nwQcrI9l3FgoWbo0aGr8bOhdLLJpf0a15Ks=; b=bOb1NX4pqXCuWtJWQfScLbGpEFxD8KEbFo1buFB6x0PQhTgGuizmUOEa LrW5l75qOGdkjlTRuqbniiTRbC4AZHGdWofGQjb6EEmDOVTYQTy4J7VQK BlvfoKbC8+UBz8xUjlJBxMr8c5CLtg2VRAgl+eDexemMXo79POTn0m7Z5 IfzG0nUEDoQMegscPvgIQO5lCIWWLDn1O1rFrj/eAiXFu/QzFBi2GhnUD xAs9ViObsAzJCasOGrEBdsyjy9XLJA+Gt49PMgeEtumIFdHoBqDhRLnDY mUwUwdPn0/PC43T2u6+Tgv0KC5sR07jOP29FsVFHaT5hsrFjUGR3GXTO3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="421088245" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="421088245" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 06:26:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="713307423" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="713307423" Received: from tiwariv-mobl.amr.corp.intel.com (HELO [10.212.165.194]) ([10.212.165.194]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 06:26:09 -0800 Message-ID: <64cb078b-d2e7-417f-8125-b38d423163ce@intel.com> Date: Thu, 9 Nov 2023 06:26:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v4 0/3] Reduce TLB flushes under some specific conditions Content-Language: en-US To: Byungchul Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, xhao@linux.alibaba.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com References: <20231109045908.54996-1-byungchul@sk.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231109045908.54996-1-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: p9356ey955nt1sc5a1xxp9pugmwr8gfx X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 547EE120002 X-HE-Tag: 1699539996-343770 X-HE-Meta: U2FsdGVkX187O+wfcjwY6a+e4RnsnPsYHcqNm7rxX7fc+YEtMKVsUZ7uZnKZeeSa/R5jTwooiodk5RnmV8InqejsmQlj5aPt7zw7Jj9D2GE2w6zenC6KgPV1ax6TmyH6kGtuH77yqnIAL+PieXvQXdVvm7u1rSFHQHprLC4sHSZL9N/AUHOZrxfSmZ4N1sZu2zgXwbIlHgCYx6YrL+q49lOY7FMDg7yh3bfic0QpVIMFEi/kGUFJ4F45QJyzBCzk+cHW+MeLGKsyqeRI2ieYoHibY15Lm4QkpsArtoEfN3hsAFeobjW6pF0ziqKVsv3RNkV+C8HQiYESn3OKIxTvSE+8ZnNrlEUXkJUkIElHsM+0vjiGtNZ7RbVf4FcDMGyO3OM26iqjLq42iiaS8cXMXMqpGM0V2s8Si1w/GEMSC2erSzsZsG8VNgjNutBBo+0J2QttxvG/MK74tAR/eWJoZACc+hzbbHgZ4lv8qlAcOuz+6tEpldMTZWLR4/Y/AUgamf95rZrWKr4C0FJOWV+Saty4H7eUzcVMpUvldD8ZkNo43dkLOxojSgdPc/0yEIvmXNiRH22Nd5jLsWSm7Q0evDWmfvnMDAoW+IYgtYkX8qYBhGJzEtp/rD95LAAtJLY3WoJjjKNp/BsFLB2c+y4YG7L6C1RgWGIbQeDsULOxvi8OugOYkNtLoD980UFP327SnL2IU5NSIqqM6e4SYLFEeIAuunuQPpif+2WDt8V43WmvHMlzEx8Kq3U5hzrMfAviyXo5gVc6SGctf5X6qMr3myRSH8BQqHZBqE6C/yi4LI3yjjF0hZHMTtpBu2zGIQ7j6LhhFelRUqGc8OHKR8LRw0S6tricMxwhT6AfmMLvQzo+mqLlOgYkCnZvpaB/uE27eUVK4ah1wdigNXj8NsKCMZaL6TndOKIdX2oEmc8dH31SBCE4Gi6zBDbJsDNnKCcNAZnpuwz8lXUkWbatJ9R D29k7Xer lK6ahWtM637W+yqRngqVgVkxSD5GfC1Mp6zKUFxIOmrOYPPf10iRo+zVFX8znKIjA0EzhzRBZRIdylvpYOk0GSmKPIHVtRazp/ZABbQul1RhozdR35RkNDz9VuKs8z1qAX7WLDFJfdcG36ReB6W0xqePleK1i08EU8u3RZAVsXCYYuGHSMd3w6HwQSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/8/23 20:59, Byungchul Park wrote: > Can you believe it? I saw the number of TLB full flush reduced about > 80% and iTLB miss reduced about 50%, and the time wise performance > always shows at least 1% stable improvement with the workload I tested > with, XSBench. However, I believe that it would help more with other > ones or any real ones. It'd be appreciated to let me know if I'm missing > something. I see that you've moved a substantial amount of code out of arch/x86. That's great. But there doesn't appear to be any improvement in the justification or performance data. The page flag is also here, which is horribly frowned upon. It's an absolute no-go with this level of justification. I'd really suggest not sending any more of these out until those issues are rectified. I know I definitely won't be reviewing them in this state.