From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27942C27C44 for ; Wed, 29 May 2024 02:17:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B15736B00C7; Tue, 28 May 2024 22:17:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC5816B00C8; Tue, 28 May 2024 22:17:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B49E6B00C9; Tue, 28 May 2024 22:17:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D2596B00C7 for ; Tue, 28 May 2024 22:17:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 01C87160763 for ; Wed, 29 May 2024 02:17:05 +0000 (UTC) X-FDA: 82169820852.01.1F1D055 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf07.hostedemail.com (Postfix) with ESMTP id 2C2AA40008; Wed, 29 May 2024 02:17:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716949024; a=rsa-sha256; cv=none; b=rNeBF5ocd+a0XkfO/zBb8dC30IQDEY/YFJL4kfg1vkHzWXJ9vv/vS07R3TTv/KeWZfrMPH XRibHoFc5EDJalVFerPOYGpzqK2IPDewx9MZ0BUYqrg2SWugFmQZHofsP3tXBsOk2IxNZR nFa4gcB+4Kw/X63npJP0mJJmrSY4uQY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716949024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=byQoGHyoEP/r8dx0aNXUbG5AilHipcubhKkc7ZzaYec=; b=vyh8mP2GECKaXY7xNxPHG5hsqHnumQxeh0m9mZwtNiQV8fDEYgH1yoFxioRXLRQum7mBdO cIwL7hJLsUkA/JeFA9XIoJB/hqxX8Sd/CajsqPysxjOdaTVgONxogISZYpB0M9pYJMsCnv f/4N3/2SXVA2csIsdnE4qogLUXv/YK4= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4VptGk0GVszPnps; Wed, 29 May 2024 10:13:50 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 67754140361; Wed, 29 May 2024 10:16:59 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 29 May 2024 10:16:58 +0800 Message-ID: <64b7eef5-ee7d-4288-93fd-6b1295f8a5eb@huawei.com> Date: Wed, 29 May 2024 10:16:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] mm: add folio_mc_copy() Content-Language: en-US To: Jane Chu , , CC: Tony Luck , Miaohe Lin , , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , Zi Yan , Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple , Oscar Salvador References: <20240528134513.2283548-1-wangkefeng.wang@huawei.com> <20240528134513.2283548-2-wangkefeng.wang@huawei.com> <438bd5a4-63b1-4f52-b312-423cd2cab23b@oracle.com> From: Kefeng Wang In-Reply-To: <438bd5a4-63b1-4f52-b312-423cd2cab23b@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 2C2AA40008 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: xq35sf5zn3qwj4co17m4r9yrokzzke5d X-HE-Tag: 1716949022-106437 X-HE-Meta: U2FsdGVkX1/BiNDebc/4JELZ/1NsY2BkqVwo4qaqhYGS7nVI6kheE9GjmAXU8BXs/kVfNg9QHAMXPsRqrTo2L4seo2sqPAxJJ3IbOFhk7ghu0pc6Fj6ck7Jzj7HT5dKWAKdJ3nPaXDsMJ6I5QHQfabBGsBsDAxhNFp3yYR62ghOD2Dc0wG5wi60iQW5OKDZ/XOUVxGtdAINKmsvEUnOooaYNVAnzVi1Bjwa26+kleQKHA6yXWioe/YQleYKwpnFnhFKTRSvrlTGfyIr6OtGNmMMljs2nu+Fwbpy73362rzdNNbCXihOwAFmYzDAUmQsrnWLgBKqbz8o/zalgt5UHCPf55W4loPutIjFs8fXbG84CYg3Sam5reJt/gZ7h5FdUhDaFE0lNnUp2mNdin0x0+c6YLoE6B/ImroUIzjL1jphZZNwp2JxEahq6+8gzisVuAVxWPPy5qvjDSsUkzxNzeO4PYV13/4tkBvmPOK4Q4T5gAusD/J2W273XMLTVWHMcA6dtCNNWsPO6J+XuGDO9JCdjr+Jgu/RHSK1fUD79OhWkdxcNpFO9MJdnMtm1jtvdGcO97bUrQGZ5C1ZFFTuIbIUnWT6HPNpSrReaACnogu7qVCekJcDPAeJn6/J7COyi+vr9T5sioEmCfNL6D7bCUXf/MmoTzZf6KGNRaMRw+uiqZvpZqwCTtOgwYqVtfSUBpE8OnXmYOT3C+giF+fETbvIMvR0vJ1L4QzWhYrX8eoPQ36KxSuNsN+SZQeWGIJNZNSO0mPpbtbd7+4OFW8A7dnbKl3pocfvcQkQ4tirTCtMMDOHTskbacVchOTsLU/MG4EHUKmb7EazPE3qrZzmc+qbUQzEHOuigc7/XXAuno/AEUZpAYQXQk/odNaXGqJWLqNnsb6Kq/HqzDxEVTYcqHqGV42clG0sPtbzrf+y7ASfnZVxTi3Zi3nwtyHI7JR6auDUrz0V6929pkLmhvpJ VDO/Uhlj Hb+kpgtxY/oNJR3GsZlT+6xnCaVwl3h2zOaUy4sPcu7u3OAOeKkCyfFEUoN/Ofv4QkV2IxbqNO89LnFDk6p39Ix5R3BDMZSmmiSW0T7dkP5E7kjeNygxukjPh5qqBaNGtGFeHwpKcYhtC06BZca81IhUDlG+J+zxf+/up3j9tpXex9nQXOQHFMNG2MZ5P3pncx/W3cl+HgkcD+npsBlWWvHZt1Kc1Xwm80braDZv1ao/0G3iZNdJkNwALOYtY5UZgCItSxr64w1//xOTKNY2XFJm70NFYD2VWMFTN/AfAjZh2LMWs0hW5zeecyU/Qn8urcQSi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/29 4:13, Jane Chu wrote: > On 5/28/2024 6:45 AM, Kefeng Wang wrote: > >> +int folio_mc_copy(struct folio *dst, struct folio *src) >> +{ >> +    long nr = folio_nr_pages(src); >> +    long i = 0; >> +    int ret = 0; >> + >> +    for (;;) { >> +        if (copy_mc_highpage(folio_page(dst, i), folio_page(src, i))) { >> +            ret = -EFAULT; >> +            break; >> +        } > Why not be more specific by returning -EHWPOISON ? Yes, this is better, will update, thanks. > > -jane >