From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 115A2C41513 for ; Fri, 7 Jun 2024 15:59:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89F766B00A1; Fri, 7 Jun 2024 11:59:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84E976B00A2; Fri, 7 Jun 2024 11:59:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A20B6B00A3; Fri, 7 Jun 2024 11:59:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 483096B00A1 for ; Fri, 7 Jun 2024 11:59:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CA28E80271 for ; Fri, 7 Jun 2024 15:59:30 +0000 (UTC) X-FDA: 82204552500.13.3A889E4 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf10.hostedemail.com (Postfix) with ESMTP id 70537C000C for ; Fri, 7 Jun 2024 15:59:27 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=F0Kg8XXV; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=J1qRFiWy; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717775967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5P/XK4ybvgo4pVltbfpMU2nboBNzHH/2RQFfMgLDMo0=; b=kk422X9VjhjOpWjL2cE2zmG4XF34440QDBHeO9IEUuMjVvken8GSCgMmz3s09P34rQIAdH ABVBm/3tQh70v9OT2cAE++MB0R1g1Qm8R1Xgzmqu85zNKUgqBfwXos0OQuELXlkAANd66K i13wu4EykYdeiSBtXnnKT9a5iCzeJsE= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=F0Kg8XXV; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=J1qRFiWy; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717775967; a=rsa-sha256; cv=pass; b=WL8d803+U44nY/1z80lwmEKqCPVvnopzWvXht7+QRQ/wjDgup5ewsI5b5AzNuT8vOWOKNk 6zW7ge8HTenW0NxcwcCPEOce0aCJQAumXlahEcyl2FgVL/RbBThrxkXW29gjoS/rwqzzMy PtCFb3SPgK0ef5Dx7W1CFNNyO/woaXo= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 457Curo2021572; Fri, 7 Jun 2024 15:59:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=corp-2023-11-20; bh=5P/XK4ybvgo4pVltbfpMU2nboBNzHH/2RQFfMgLDMo0=; b=F0Kg8XXV2RE7D0RQixu7Y4mSvvWHdXELuSZ/lnKyO+i9pkA8l2EvIw/AyC5W0m8ZQBVG mlk6A7LcvAHaomdvnVW0mvkH6/t883rFqoAkEQSotA+A1f3ttUzhJr+hsD0RfsHIMjI9 KS5sSZI8KYDGJRyTOdPda6skQZZ+H1aNIEQ+tOJrGfxFcY6YSNP8eqSyM5EBodunTNf6 9/DAt4nMG6Ii2gJrxe7eO49Q8aWHG2+xnvbfYtFhVo/xXY4LT8u9hO475iaRBQ2OgTij L3xN5vOsEXd7c8W/CEVnPnfAfTF1l3u5op7aBtliH8+NuV2r0WDuU6e+yqGVGu9l7SY/ iA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3yjbrhe0qw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2024 15:59:23 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 457FVb5H005463; Fri, 7 Jun 2024 15:59:22 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ygrmj2437-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2024 15:59:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lp5X+RQjKr0EBU1fY+jLOqPA+45LI1dWgHuh1YJhrxHAXtl8PQiW6Mj5srWcQ/AVd0/5tRDMt13imULQ5phvM5hpcG6DXDN9+3U9Rr2XENRVapeRxgK4n9AuYDnHZLlWp6/911owm5LnAWC30Utf7GXqpAIr74ac2d1t5+7KkLGNq0IDGe0iSoJbG+UqIe3vjoPDxLFtNht6OQGhg8IyNJPdmbh3ZApKAQNcTKanxN/JB4IIpQRnLWJa5OdeB8luO9ZyZSG4U2Zh5AmyI6XNEh1Xb1l60VMUtNuTon/Z9vFec2bX+zfYQcuoCxYFcznyoIlGGvw9M2URa4KgpTAHxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5P/XK4ybvgo4pVltbfpMU2nboBNzHH/2RQFfMgLDMo0=; b=RfYixzthiyRkc0S05iyIgiudYSiWerA4lGoEWP9UvaC98v+OSomc+5w2euC6Tz9mojRFcmak8W2HYiLeXXFryQJI8D2KXVd5YiiE80BVgUzuydut+cgalK0gogLemh7ConwtxhIBcbDN92o6MbM9mRvDpXAN9XRiG+ODo8GxL07LqRIRN7jpJxKupQVd4QzYsattEu0NW6ZhLOB0DsiWjnmL4YTrQes+eoXurg+tEsXFD1GheAADMZkNOSOgN6E9wIzjB0ZZJ3beMOYuM+LGRpBRkMkSZGx9r/7vi8nO2L3VXUDjO/HPFOy4yQYc3fHHJtEdb2pyuSV/Jij77wzEJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5P/XK4ybvgo4pVltbfpMU2nboBNzHH/2RQFfMgLDMo0=; b=J1qRFiWy26YPtUbHOlRhxcecQ6yj7M2B4IcQAj0bZ0bXDoeweBTOCD6Kluqct230FhFa1EviYSZWROT24zqIRMo09UOKInjDI7Lf9H3AEbfgmSqn8lOQqb4uQvuMUBPwI8KdYjuLIuJvnOkbh+cHExKvT+lt5LjlhLKpBjwWHws= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by CY8PR10MB6561.namprd10.prod.outlook.com (2603:10b6:930:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.22; Fri, 7 Jun 2024 15:59:20 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3%6]) with mapi id 15.20.7633.021; Fri, 7 Jun 2024 15:59:20 +0000 Message-ID: <64b1dcfd-ad9b-49ec-9ee8-3c67ced6fe0a@oracle.com> Date: Fri, 7 Jun 2024 08:59:14 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] mm: migrate: support poisoned recover from migrate folio To: Kefeng Wang , akpm@linux-foundation.org, linux-mm@kvack.org References: <20240603092439.3360652-1-wangkefeng.wang@huawei.com> <20240603092439.3360652-5-wangkefeng.wang@huawei.com> <0290a474-39f4-4549-9fc8-06ccd6321d5d@oracle.com> <4f7bcb28-bcad-4f1b-aa97-03a6b6c2fbba@huawei.com> Content-Language: en-US From: Jane Chu In-Reply-To: <4f7bcb28-bcad-4f1b-aa97-03a6b6c2fbba@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BLAPR05CA0047.namprd05.prod.outlook.com (2603:10b6:208:335::28) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|CY8PR10MB6561:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c41c619-9545-426a-1ace-08dc870acaab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aW1QaXFUNjdPSVJZNjZpY2VPL0plTXA5akVDUnI1eCtlZHlWZUZVUHJlRGdr?= =?utf-8?B?YkZ2aERaZkdSMzg0ZW1OL2pUSmYweGpUa3dXWE1zNHViZkVoSEY1YXpzZGFP?= =?utf-8?B?UTdVS0RWM2FCaG02MEVhbG8xZjczcGtNaGVqNDdDdEt1Ui8xam9XL0tIcjBv?= =?utf-8?B?UU9VTStWeW1xTDZCRW15eGo4eUtVTjJJUGNLMGR1WmZ0ZFc5KzZCYUNyYktu?= =?utf-8?B?NmdIeTh2d2hzZE9EWjBqanRwRFdUUm9ZWXY0a283OFJHRytGL3BvaXZUUGxp?= =?utf-8?B?VFpjVFRUNVVINzZCMFVIWjRFUE9zaERiaGNiVnQ0UldZS2Mzd2pmVVdkcVQr?= =?utf-8?B?MVNNMGJTSUZETXdFSUQ4QlB3bFJJY2hYN1R2Z2dxVndxaUNhd3hsMGwvNUlu?= =?utf-8?B?S2lZWXFJbG1DTlFwMGk5aEpIdWVnZWovcjNPVDNhRzBvQ2lyaEFRRlhLcGtY?= =?utf-8?B?RUliMElyaVhFT1RaVVhjbFJESk1IdXdvcjlsemh6NXVpWTM4ZkluZk10cVdx?= =?utf-8?B?bGRMN3J1QWlraFJEL1RaVng1bmMvSC9xYVhkWllLQXU1VWFoeUx0SGZDMW5W?= =?utf-8?B?eGpGZmxrNFJQWWpUM1JDQkozVmRSbFZLYUdZcmlmL2Fja2hPOHA3NTR1T1ho?= =?utf-8?B?TllBUmp5OExuQVhLdmRMczExZ1p0bFczTVpDZVNvSmlLYkJ4TnAyT3hPQVNL?= =?utf-8?B?UVE3Z2gvVExsNGZ2VkxQbTNPaCt4N1NleXpCaWxVSzQrdk10S3VIYkQ3ZERJ?= =?utf-8?B?RWVUamhWUHcxUC9uZHdsWXlkdDkrUGpPQVE3WkFpdG9DbFR5UUtvQ25WNTZZ?= =?utf-8?B?aTBCNmhjSjlTdjBoQkFNUHUyYWp3YzBWRXQvWE1pZUFCVWYwUi9lU0xuTk1S?= =?utf-8?B?Ni9vdkY2bndFZFNadFNRdHNCWkp0NTFEYW5FKzNzemlBTms3ajlCaTNHR0Vn?= =?utf-8?B?aGtjaXRGNHlET2RmTkNCSVN5Y0lTL3U3Q2FrSXZWVXN5MkFLZ2JMb0M0MU9Q?= =?utf-8?B?QTg5WTdEY1Z6WVhRemo4SHFBR0pkWXdISEpsSzRmU1BQRVp0enkxZ2NoYmxB?= =?utf-8?B?SDY4M1p1eXZwR1VVUjlSQVl3T21iNG9JU1lKalYzSk82OVZDZHI5MW9VaTh1?= =?utf-8?B?YTBPN1ZYVWVhRzhiR09nbTVUTG5MTkd0bVIzRjZLR2xQKzF6MTY1NThnN1Jl?= =?utf-8?B?RUNsZk4yTDlKRFlqOXREcVYrb0kxN0g1Nm9KOWhCN3NCdnFKK2hpRENXTGEr?= =?utf-8?B?WW5QVXR2TnR5WjVyVk00dU1obGNrRmRMQkltdVo4MVRxenZoZUZ5ZFJDdlJl?= =?utf-8?B?enVWYXI1Y3o3c0pDRHF6Z1RWY1FjU0Z0eGRqZkpmdXBjVWFJS1kxazBySy91?= =?utf-8?B?YmljbTh3aE5lbm9XY1MwdlFRNGkxL2h4V3E3UjQrYXloRTBySHBYT0UzUGpF?= =?utf-8?B?VGQ0cHA2bnRsaUFBanZrTTgySjBZUm1XZG1WNGpuaU51d3Bmb2tGQjBZT3dV?= =?utf-8?B?U2NxS3VKWWJmV29tMEFTdmoxYnEvWVIrK2FoVmI4c1B0cVpVN0VNSnFYenhX?= =?utf-8?B?bWVsazFuN0p6VU1iWWdJaVVtNWZselhUWVJTdE1GZVVhV0VyN3hEL2VmZmZi?= =?utf-8?B?UG5Rek55M0hIcHNXa3BXNUg5Y1RPMEFoc1U4clBKd1NHOENJOWh6NDBFOHBh?= =?utf-8?B?bHEyMTg2Sm1PYnFKckw5a0JmcnZOSWVDbkU0dlZNYVBlVk5BamhXRGdCN3dX?= =?utf-8?Q?o8pU+BatpkciXe0K1jJmRD2pl3rAVlSipsU7f0D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlNtaHJnNXVFbGlHV1F0a0MzaEc3TjVqandWQ2Yyd2ZCT3VyRWhZc3U5R2V3?= =?utf-8?B?VDVUK2wybDNiVGF0WmhlS0RKeFkvSXpyays0bkhoRGduL3NVWWNUUGJzaVVB?= =?utf-8?B?YnN3cVRxRFNNUHNNcXZjaHpsUVFTOStiS0J1N1ErSFJqMEhBSFJSL1l3cThh?= =?utf-8?B?dGhxVEVOL3FKbTc5d2xJZmt6d3V2REhia0N0U0VWMEo3SlNrVVd5YUhVS3l4?= =?utf-8?B?OUhXU01IZnFtWHRUK0taRmZIR2pDQjNseFh6V1YzZDl4S1JNcDJqUHo4SE1J?= =?utf-8?B?c1VFNkRuVTd5Ym1YTUkrZFFlZEFKWks5bWVISzhvTklIak0rMVVmZVE3QW9X?= =?utf-8?B?UG42VWo0dXFOcXFxK05NcEZuUDRsVkw5ak9oSDVMbEhyV09qRXdKbXVFV0Vq?= =?utf-8?B?T3JVMTRpUnU2bjlQbWZuN1MwTHc3VzloaW4rMW1JZGhLcGZtOFV1RDhvVFRu?= =?utf-8?B?S0VVTjNIY2tpd3FYR2hEaWlLU3hzZUxmK1FSaS8zWjhjNVJlNFEzY2s1RkIx?= =?utf-8?B?cEtQMmN0LzNPNDN2dXNxeUVSWVB1VW5YajduMDVOd1JpMjNyZHBJZ0swYVMw?= =?utf-8?B?VEh3T05WbDNwYi9JQjdLZmU4dkVRZFBsSW1nK0h6R3pnbEFlL1NwUmpPcWJP?= =?utf-8?B?azlnckJQTlk4ODRTL1pORGRkYWNyeVhzY2NJaEVtSGhtWFU4dzY5aWd2cWtY?= =?utf-8?B?bEVNYVZGcXB6L1JoZk15dWZTQzhRSDQrWkJXNjdhaGFjT3RqaGM0TStRQlRD?= =?utf-8?B?WnBJcE8zdTRLK09wcHZaSzR4QkR0Tk5URm0yRFJUNC9BNEM3dnBDUDRYL3k1?= =?utf-8?B?RGVTSHdveDMyNUwzNmVFWlJMV0QrVGhhQWNxSVdGbTJtMzJsdy93RjFLVUdI?= =?utf-8?B?U1Y3MGp1QmJDMS9JZk9rcmdiZGZ3Zjc0dC9TSEtFc256RnRWMGY0cyt4NHRZ?= =?utf-8?B?YzNjdjEvK08yVnhEK0J3K3pGRWMrZ1lQOGpQTVZFbktSZjhsWUp1RG9HY1ZJ?= =?utf-8?B?dlNEMmZTelRxUEVFbTBDbGV2S3ZxaTVvUHlQd0hxbkFCcWk2RldCM2U2SXUz?= =?utf-8?B?OUJKMFNMN0ZlZENuZnlBZUZwL0w0bm5oeFdCY1I1dlpVYWgwOXpnbnpuNFYv?= =?utf-8?B?cWcwSGp2RkdpcGNnTksrOXI5UmZjRHVXK3FIdU1JeVNGUnUwSVp1clNTOUV0?= =?utf-8?B?R1AyaEVCL09penRCbWlOYlB2Q0pLS3ZMbGZXRnc1NE5BZHBaL0FFVVRxS25K?= =?utf-8?B?TXFiUHpUMzhTV1g4ZGp3L25SSDgxR2Fhd3RtYWVSb0ZKNXlHdFY2YmRNWmJQ?= =?utf-8?B?Z0JQbnBTNURzLy9hV2ZYbXRrQW16M09LUFNxUXNWVW9CZE45bUtVK0tqUHBi?= =?utf-8?B?aUt3YzJSeFB2RytRemVsNFd0SFZ2eE1vUlJYM3kxeFF2SzJYMzBWRHBDT2hW?= =?utf-8?B?Q0dQZ0xBSjI1Qlp4L0lqUXhNQm0xdkJVZWZ4aWFRUGwwM0hKYno3dDduZXVz?= =?utf-8?B?WjR1NjY5RE90U0g0MHNWcXM0bUpkM3ZwWUlxVzJvZmxYYW1BZktibnBPVFJP?= =?utf-8?B?SExzTmxaWS9EQ0Z2aHJKLzYrN3dIZVFGMjRKcHhyK1FhTHkyeDhVRnhtNG1h?= =?utf-8?B?NE5xYWNSb0xOclFvR1Z5ckV4UytSWmJ4eDQwb1d2U3BxWEV5UDVsWDBIYnpL?= =?utf-8?B?K0NXMmVZOWo4dEkxNC85RGlISzdLOEEreGdaQ2VEWkx1eGRDK3Z5YS8yb0JG?= =?utf-8?B?STh3WXh1K1lRQ01ZMXNKUVdxU25MQjFINWhwb0RWa3ZXVHZOVEtyQ0QyR0c4?= =?utf-8?B?bkxjZDczaHpwRjF0T294Sk1oVEUyMVVtQUZrZlJVSjZFeHM5RFJoZFRBVGsv?= =?utf-8?B?SWRidWdVQ1BCS2syUlR0dDB5YUZKdk01TnNsZmpqRG9nOHp1ajBZN2htb293?= =?utf-8?B?NjJDOVR2Ylkzcm9FbGtjYlVRWXlUTFVsdDJkUVUvWUwxcjdUTUx4S002V01p?= =?utf-8?B?KzJOVVMvMnFiT2laenRUV2ZLWDBlTU9BSWpDSEZYb0Jkd0hDRXRlOUZBRmRy?= =?utf-8?B?aDdHU05QTVJWbmhqcm9NUUdPY3EzSVBMSmtTZkRpbU9LRmdOQk9JTzJvVGp6?= =?utf-8?Q?sY19sslF42IqS25RSKYyOOSUJ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: u7EhhEi9aNx/iboY+RwKg2AaadwxgX6Ik/fiV98+ZeoVi+uFGIqqriImKdxO0XFDkiDkO9/BeMYul+xVazPKE+1PMwUEmS9ximkGIDSwb7yhCX7ab+TtYRbC/XwelE/ICMxzfRPQEOJvAFRBZM434WGbA0wqNC+1ab1RMc8eUUNIuA6EVOfg6On4y/3ztym6be/9v/+CxQtJto6yY1W6Yb+7XE+0XiIZwk4diuLkxQSoA/93GS+Yj2wvizY87VLmftB1PE2eBC9bTwJnOGc3dPFVxMOmyUOAtL1qnCHsETplztHuZl+1v7/QdE2MNIM3Tt8sxF/abs5l/dRxkSp77bw5Ps32mtMeNBVV2aMLC4FeomhBscpao3ePh6MkFwwfyWGyq+jcn/0KrS/2IeelAC8zi8slshlmcr21HHkg7eaeGwXhdvlcgcIwcm1hdoDW/Vkw/nSpyvSEewO2HqNXHrrkzAcBus86uWO+DDC+HVeZ/Y3A7N+/dVnwhHgKuAxk2v96ek7/ou0+meEDN7sMX43h6/EVz/deg2/+wFPpLaVMZ/yK0nBTKK8JB+vSchII+IphwPR/N0mKvQWoUxVWXa3oyVU2ONFr1ETxsrHAOx4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c41c619-9545-426a-1ace-08dc870acaab X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 15:59:20.1098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ckkqwa3U/9Jb2JRZ2Y6cHBnLObcoVRVq8VyH/KjpVpA45+J9rdRkopL/OXey+bO1yeZgYnAS927ANqrvFOi6Mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6561 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-07_09,2024-06-06_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406070118 X-Proofpoint-GUID: MPcO22llUf1maA05H2ylRBtEM1tVBsWL X-Proofpoint-ORIG-GUID: MPcO22llUf1maA05H2ylRBtEM1tVBsWL X-Rspamd-Queue-Id: 70537C000C X-Stat-Signature: 35njfh7dh9wbe8rqjib1fs3dkagryitc X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717775967-718156 X-HE-Meta: U2FsdGVkX19PB5I0tFq5OSoGgmDoDBYKO6BYDrYxNdU9b+uPqdbzTGRIfxVfyt8e6s4jRbUzbTXQGovkUWCXDTCSlUrf/guy8LezcZzDFyMAgu+AzFOSH2G+Z1KaOxC+pEib7O5ASLqbiPQ1/jXdS08l0hCmRTBAmmvGoh/Y3meIuwPAHnLUyqbJ8BoMMddKYOD9mMD8ReZUlkV+Klre3Z5nYveq3nVuwe/KO7TWl3jT44+hBXNVjgwrh6axm8ivJSXGmGPm3130mgiGyFPbPN8WtYOQwkUghPjAhDyxjfUlhfwtIU/lXZGMacujqBMjqyxNNUbDE2xUGLMXNvTn575KpCSXn3pomcM6XXloCM87SUaZr3d4jCyyubKIvThM+lam6d9rlRdPkMZTr9AYLMsKWtdxrslR3cau4b4doDNYk48R1MRDWFuOGJrKUSTXktjAGs6SwZYvElUaqC+BBIpmop4ArUmOKhXw73b5la6ebSOcGw3yiMtlRaX/aDIY/V3jHvrlJ8xxyiJDADnjUyqdAv0pET5Nd0bnpLVbkMIx+1XLOBjMsJzEOSLpHyUKXUCJXCd0k2VUQoO4Tz1swoM+fSX0Nmi4tatEDyOq5mIHktDycQu+WxAniwzfY/wNfCFuSyTrmoqn2tzW7ILnNpLQtazQuw58VzfRO+Y+/02+GqSpe0nAyG96fG4cUHo368YEeEPWst5M7NChEpJqchRST/hNuDeBCn9wSmh7Z5OujWx8bXydE3H98s4/tLNTqOxNvioGxBmHNdQkeIBQd1kFS8/tsWxuQ34SgeUZ8Pv7d9mk1Y3+CiyansGCVDXnWuSQcO7J4Mr8vvsDDKsaBkFgPm436he3BcHTuSUh/kU7ai5Uz2pA5+KlKK8KhFfJjPwnLas+InyAPMWxU1M1p6quI2iBY+I0daHaJPaxT0qCWZgxVRKEWNiDsTYe1xEm5XNdqcGzjrlM3ktS8gq Tvhx5etk dG9WtneV57pVHiPtGW7/bIKg0RjekLrrtqbMa42YxxPlBCLOCyFuk/VLHtXHG0KjsiyuoS3L9sH/+qoJnrMv89wpd0YK+bDHM1/5gyU2I4a6poPXrq9HTjKy7ro/KDjMOyDAqsATeSzqHqRKUEKFjlxC0m8LStd7DKvm73t2OLS2Pn2y5xrd3hKdEa/J7MwbYsRnL661QaUv66qzWZ8SFVMtNwKK0VU5Mq8Xt7Lu4U4V1mn8PMBKXT0GxMf660LogCNCBZ8dQMkz2gIzdscJDcJgx4cX4mMvr126o2UkvpwjAT16v3l37JWv2AOnh1TxvbM3IvUXeohEpywuLD5LUf3ogWbCX7VSvCn3sWb2lMhbv3oyGYzNYrgdcvqEON6gwrSlAAhcJl6L8g2vm/ZtnaSWLCtEMKP80bcyLkS8vrvpDdt87dvCN8h4G+H+U+XLp3dhLgjjSyWdoBdhZngTmPd6wNhj1NX8rXLf8gP/ZaEMSrKPaautCSQrBVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/6/2024 9:01 PM, Kefeng Wang wrote: > > > On 2024/6/7 6:31, Jane Chu wrote: >> >> On 6/6/2024 3:28 PM, Jane Chu wrote: >>> On 6/6/2024 2:27 PM, Jane Chu wrote: >>> >>>> On 6/3/2024 2:24 AM, Kefeng Wang wrote: >>>>> diff --git a/mm/migrate.c b/mm/migrate.c >>>>> index e930376c261a..28aa9da95781 100644 >>>>> --- a/mm/migrate.c >>>>> +++ b/mm/migrate.c >>>>> @@ -663,16 +663,29 @@ static int __migrate_folio(struct >>>>> address_space *mapping, struct folio *dst, >>>>>                  struct folio *src, void *src_private, >>>>>                  enum migrate_mode mode) >>>>>   { >>>>> -    int rc; >>>>> +    int ret, expected_cnt = folio_expected_refs(mapping, src); >>>>>   -    rc = folio_migrate_mapping(mapping, dst, src, 0); >>>>> -    if (rc != MIGRATEPAGE_SUCCESS) >>>>> -        return rc; >>>>> +    if (!mapping) { >>>>> +        if (folio_ref_count(src) != expected_cnt) >>>>> +            return -EAGAIN; >>>>> +    } else { >>>>> +        if (!folio_ref_freeze(src, expected_cnt)) >>>>> +            return -EAGAIN; >>>>> +    } >>>>> + >>>> >>>> Let me take a guess, the reason you split up folio_migrate_copy() >>>> is that >>>> >>>> folio_mc_copy() should be done before the 'src' folio's ->flags is >>>> changed, right? >>>> >>>> Is there any other reason?  Could you add a comment please? >>> >>> I see, both the clearing of the 'dirty' bit in the source folio, and >>> the xas_store of the >>> >>> new folio to the mapping, these need to be done after folio_mc_copy >>> considering in the > > Yes, many metadata are changed, and also some statistic(lruvec_state), > so we have to move folio_copy() ahead. > > >>> >>> event of UE, memory_failure() is called to handle the poison in the >>> source page. >>> >>> That said, since the poisoned page was queued up and handling is >>> asynchronous, so in >>> >>> theory, there is an extremely unlikely chance that memory_failure() >>> is invoked after >>> >>> folio_migrate_mapping(), do you think things would still be cool? >> >> Hmm, perhaps after xas_store, the source folio->mapping should be set >> to NULL. > > When the folio_mc_copy() return -EHWPOISON, we never call > folio_migrate_mapping(), the source folio is not changed, so > it should be safe to handle the source folio by a asynchronous > memory_failure(), Right, I omitted this part, thanks! > maybe I'm missing something? > > PS: we test it via error injection to dimm and then soft offline memory. Got it. Reviewed-by: Jane Chu thanks, -jane > > Thanks.