From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55129E77188 for ; Tue, 14 Jan 2025 15:01:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4A31280005; Tue, 14 Jan 2025 10:01:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E213A280002; Tue, 14 Jan 2025 10:01:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9AB6280005; Tue, 14 Jan 2025 10:01:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ACB5D280002 for ; Tue, 14 Jan 2025 10:01:18 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6E01F120AB6 for ; Tue, 14 Jan 2025 15:01:17 +0000 (UTC) X-FDA: 83006370594.15.EA9239B Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf10.hostedemail.com (Postfix) with ESMTP id 5EC03C001B for ; Tue, 14 Jan 2025 15:01:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fmCjn2Lx; dmarc=none; spf=pass (imf10.hostedemail.com: domain of groeck7@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736866872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c4XL14+oIbnjkerJ5WD+7L+O/vlI+wTPhMKFazY0Vx8=; b=yLGXuFG1c8pj996/0qhoDiP/hm7fSV5PA2V5yAyLX9xxGP+VH2DdVoRiEgFmWQ1i338Dun q4ln8NOeLoUB4c1mfjtNGdEA8c9uQ60XHMcNDEvLb9yBeDIglQYNxXXRv2SnTu8R+tL3y8 kaL6pg5H8KBB1+XRwTv4EfI0v848EyQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736866872; a=rsa-sha256; cv=none; b=oygeWZ3G6BUg9oxshfXyoKnG37jPwKJ9py8j5vkT9gesVq9XtodoYTHQq67gQ64XeL9UV+ nZ+koQNilrvoWN1c+cu3SUJK/8zh/HRtnVPdcGkNgDp7oj7ltSc9KzNizB1ZxrO0hdvkE7 2pgkRgJoiDBrm+bHhSixS8xPory6JAk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fmCjn2Lx; dmarc=none; spf=pass (imf10.hostedemail.com: domain of groeck7@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=groeck7@gmail.com Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2efe25558ddso7025539a91.2 for ; Tue, 14 Jan 2025 07:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736866871; x=1737471671; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=c4XL14+oIbnjkerJ5WD+7L+O/vlI+wTPhMKFazY0Vx8=; b=fmCjn2LxZv8iqaWVybVP+whW2ZvFE4SpGifjSyyYj3DwX6CVfteRz2odrnMtAUD7JG Mxm/opjhAq7C7x90rBNzQL5K9epuMa8+nShB4rfpYd8HHLwgfz7iJUTJzc98RguyqmtK cbmR3Nr7nDX0R91ZKew5PgfPH0Ildh7LYPcPtX2f+ro6P6HooKIy75ES3Tqvxu4zVSPs PJfQoWPfZdRC39q8afieorjeJelf2RAlk9pkfy7t3m9Mp6mYF/aUhxnSmzFvnqYpLU+L mXNwPiL6uwfgzAo0MNh6pc8/EGf3osMFZOMbrggLesOznLiWiTOy4mXyX65NrZk3fAhI gkXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736866871; x=1737471671; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c4XL14+oIbnjkerJ5WD+7L+O/vlI+wTPhMKFazY0Vx8=; b=b3eHofUaFVX21d58e4szqQQH4YbZh/IzuBs+UJLHTWAYvRRVnpMNl8TZZsJPTSJ1ZZ y9kReLaKuJrCacIhT3NvT1cBoNVHVYxm6zloxVmp77/2TmE2YXBpZZDpqRbtIYzKryJT YfWsQLe0wiVkwPr0bMVP9aipq+4sbFMTn/v55A2dnbiYUDet1i2z39nNsR49FD6eqqOg 8PF47XaeKpJLv+09REx3quN2fnzvuexNTBWeCOJBrZKeoJPCQSDpg3UN9bBEP+02ogXp PXS/y72y17IHKRAyUrqBqR+UHVqa5tM6peDK2AMMRDMnROcRHT8wSM9Aviu+wzvFCGEG uJrA== X-Forwarded-Encrypted: i=1; AJvYcCVAep3/wCfdkboNHGlburnVfowmHAOzNJaycQkp3e0O1db/21yD8RfsJfl6iBm0VgPf4iPbACNSKA==@kvack.org X-Gm-Message-State: AOJu0YwYKoAkj2m4nwm9NMlNSC2LvA9PagjN/a4L1jfs+jZAl70qv676 Ny8LYKQqcQjGHfZ03SS7eh0TpVNGzVsKZR+cYnENYT7/Ar01ILT+ X-Gm-Gg: ASbGnctAtHjD/uVXjEDfk3c+uaQVorizcLnc8aLZCINWYKaL+yYJ+SmrNIP3wP4PQfl MEVgrYZGvCJBSQ5nU9TOAfUpjh4lPMTvYqz0ClQmeKkPRW9u0Ya01ZYzJw3nblAlfBnH7CgeCer 82sXwsWqmBQk/q2XqWMtqjDvmXTZzluls5VyzsPAoatwBX/X2rkAboYYkuf75aMQguA3AHe02wo vDgu5dANyZIJrHdlOJboCi1FF1Hinx2miuYzJ+Xnpw3XOZ5BeMGRRaM8ziUndElnkZzSkC48AXq 02Mbn56cG1lnfXmMliXqJ5ByRBqaiA== X-Google-Smtp-Source: AGHT+IHoIjoei3x+6cFXgCR+zscvE3MBDu+8qDVIkOz5icvFioeiJHBP+vzkJYAVHpmiZ+GIpJS9UQ== X-Received: by 2002:a17:90b:3f90:b0:2f6:f107:faf8 with SMTP id 98e67ed59e1d1-2f6f107fe30mr8889956a91.24.1736866870547; Tue, 14 Jan 2025 07:01:10 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f559451b3esm9632739a91.37.2025.01.14.07.01.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 07:01:09 -0800 (PST) Message-ID: <64a44636-16ec-4a10-aeb6-e327b7f989c2@roeck-us.net> Date: Tue, 14 Jan 2025 07:01:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page-writeback: Consolidate wb_thresh bumping logic into __wb_calc_thresh To: Jan Kara Cc: Jim Zhao , akpm@linux-foundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241121100539.605818-1-jimzhao.ai@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: kc46kka3e63zkd8i3ez9hcaf8b9a6au6 X-Rspamd-Queue-Id: 5EC03C001B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736866872-82271 X-HE-Meta: U2FsdGVkX18PbVz8LeVg24TMxJU2WipD+aNMbKB1nU/7j9TNEZKH+IIn/VJ6mai2dnHJj6WAw0OeY2bruoMmhgLEthbM3S6vf3jfLw/VlTFMDpBH/YcTsJkfdBcLo2LgcoT2zO6ZmI81HFjPTTXM7lz1WPu6swuxO+gs+emra7GlncszlQlRv3bjbtXGY21oAK3Zzr3vBbEqKUVkyXRrm2b6M7gObgSz8CwgsFQYHWnzQNNyznkGJ9YcVu4m+ZXPUdey/OC+Dl1JtzqU7nS38pHRUVYW/FJ+uNj+PWI2r+sk+nZ8yh5jGrt1CoLuqWcfVH0sfnGOIQ3TqofNPEFoCQ+oLlNTR4eCDftMHi6DN6Z6pNGOaQnfcr90Xp46zhXUHF/b9hfg4j+v6qtUrskiqI3ulCnRwx3b2dsvD58JuqAA91HQRgToEvhYgnsXpqSY9qgepHPJs6S3MgNdttuasFkqjJ/AaT9EqdRWWn/nO/GW7U1d2kn1A3HbAO58vTNHUvkNEZbvL/AyU1yovsw6vDP8tQMCxpSuyLbWC3IFnBW06nzTAn9t4HkykP0q9E2xWtvnFF8qDxPqHjhpTab259J+A8WEjRdNvbuxsJA6SVBFs6PdnLPl6v+TS1qdPZPU9krARF02KkVQdTCnLPepBH9mZ1rrmqqbrxPCpALjGK8aKKzFHnbptIT4HNWHetqjZr/XAwyo2gNBRXfifd4uo8qHKOkUXdWU+MJ1xmJec31rZprKz4VxoATCBW5qZW0Ols60uj8QRlzc3RbHUQpqRIqD2aPs6tWZ5BrrAt6kSl/Yf1yK9SzFeZLPmbE6yB+JpVfvz94QjX7aiev3ZBmVO/3Hdd5P0ApkrlZEWssFeVdyOm5i1cNIVGVQ45vNIcu2UUsSibQB+qS+B/3I5Vv21dE0EgR48vynMaRJhCTYtULJYEZP6qoAr3GKzQi0dkS8NmY8Nt9Bvib3FeCUarX allEeIXt eP4HJYPBqcCekzEjTDcPkZz2VatzN3OvzIiXymVZHUY+4LSPG06vK7CTMVZEJH/zOjTaAvGfR2sA2aNjShOKi4CB7pahSwDNQw9T6GBopTQlUDDcWWd/aEXg0U1pIsAaFEBiRqcz5iEgJeHYHtEO7UEjHPURHRpzHggyOlb0GxZB7kd9APvR+ITu0MM/AxX5+DDfTn1G6rrsnPaI7GUy/GDugdxknayM3dQ2a+OcISj2kN2skAtZ+kBUJLT4XBMbBJyU0L4pettZzE9qeJ+bDE6PQo940XMMmN7/vSo1XaPV3TnQCNFnvVbMa1D+Nj1LL8xVprBWYYkwYYepyy01c3xYOZolt/8IQUaXurQo68I3kY76YyWuxdE24wTDFCGqAGr+M5iS00W2sPsCyCh/M+EFwZzJMAv8YOUnGo9oa/RCv0Z5sHNf/TN6QQ0H7Usa6rSK+j3RbAhWZRTzwfjSXzuSVsEZOfO1H5HUYF8LmxG5UiuZoRUNUHb5cqDZL2JB+rpBlnScgFMoGbBRUccl9yMAonzq4g3o1mLER1n5TpqBwKqV4aTS+Gakz0eYmzJ/fsKqPiGd6dCEAfOrLyqbYNUlT/kn9tFIaOvFQ6qjWZ2G7dmYu4PFGp8A9eYNmanTi0dyS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/14/25 05:19, Jan Kara wrote: > On Mon 13-01-25 15:05:25, Guenter Roeck wrote: >> Hi, >> >> On Thu, Nov 21, 2024 at 06:05:39PM +0800, Jim Zhao wrote: >>> Address the feedback from "mm/page-writeback: raise wb_thresh to prevent >>> write blocking with strictlimit"(39ac99852fca98ca44d52716d792dfaf24981f53). >>> The wb_thresh bumping logic is scattered across wb_position_ratio, >>> __wb_calc_thresh, and wb_update_dirty_ratelimit. For consistency, >>> consolidate all wb_thresh bumping logic into __wb_calc_thresh. >>> >>> Reviewed-by: Jan Kara >>> Signed-off-by: Jim Zhao >> >> This patch triggers a boot failure with one of my 'sheb' boot tests. >> It is seen when trying to boot from flash (mtd). The log says >> >> ... >> Starting network: 8139cp 0000:00:02.0 eth0: link down >> udhcpc: started, v1.33.0 >> EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 >> udhcpc: sending discover >> udhcpc: sending discover >> udhcpc: sending discover >> EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 > > Thanks for report! Uh, I have to say I'm very confused by this. It is clear > than when ext2 detects the directory corruption (we fail checking directory > inode 363 which is likely /etc/init.d/), the boot fails in interesting > ways. What is unclear is how the commit can possibly cause ext2 directory > corruption. If you didn't verify reverting the commit fixes the issue, I'd > be suspecting bad bisection but that obviously isn't the case :-) > > Ext2 is storing directory data in the page cache so at least it uses the > subsystem which the patch impacts but how writeback throttling can cause > ext2 directory corruption is beyond me. BTW, do you recreate the root > filesystem before each boot? How exactly? > I use pre-built root file systems. For sheb, they are at https://github.com/groeck/linux-build-test/tree/master/rootfs/sheb I don't think this is related to ext2 itself. Booting an ext2 image from ata/ide drive works. Guenter