From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8293FC6197 for ; Fri, 8 Nov 2019 21:26:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 676AA2084D for ; Fri, 8 Nov 2019 21:26:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="BGsscPnI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 676AA2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE2F06B0007; Fri, 8 Nov 2019 16:26:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E93F66B0008; Fri, 8 Nov 2019 16:26:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D825A6B000A; Fri, 8 Nov 2019 16:26:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id C2F216B0007 for ; Fri, 8 Nov 2019 16:26:56 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 858B84DC8 for ; Fri, 8 Nov 2019 21:26:56 +0000 (UTC) X-FDA: 76134395232.06.songs59_3c8fd8b30e84e X-HE-Tag: songs59_3c8fd8b30e84e X-Filterd-Recvd-Size: 3340 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 Nov 2019 21:26:56 +0000 (UTC) Received: by mail-qk1-f171.google.com with SMTP id i19so6613653qki.2 for ; Fri, 08 Nov 2019 13:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=E/re/TtVqjhhFyMNUDrEMQoMA+rNSBWgaDnjt6xblfc=; b=BGsscPnI0I/AhxQtkp1ur0VrFYXf5H8Fg7QmP8nllWAk3LB+1xRvuro/YNq+Wi4p5F 3ZAD5u8+aHKV6BCRpJFppf3VuxZKf/sv7n021xyePsMo0qyk4ioIipKyJxsfny2R6RX3 muOR0J1B2kxQSzV9581+eZYOESV3d8dZz1I/0lFZM3rKt3ovoGT+VSWRIahQ6OsN3IV1 s8FtMLqcLzCVTjdBygGBm4m5G43Y6e3kQ7cTLWjekKCGP5ylAKVgqVGK8DUT21Ht4cN8 7GXkMXTsKy8U08dIiAi7+G9AKRSNl22O/wb8ep0nz17TwjAIvaYLFkN2KBK6QMSY1A7d ming== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=E/re/TtVqjhhFyMNUDrEMQoMA+rNSBWgaDnjt6xblfc=; b=FiKqOXhLKxKTl1pu25Cn/iAyW8fFAAmNv41ukIbkNuRVDg9YjdU+cY864SYOpkQuO7 XaU6Su9A6myho4CiIx3tny4ZdkwlbiMnLwmA///4ph0Y+9dHw/W3dJQd2i+GyRBHzc3a u13GLRNqjs7r55shMsH/lh2kJ6eC19TsUDBjR3UQMUz6Q4LGJS+fwwOW4/VkVbr4i4JR zYVHA+SeOC24yvjSEN3+k3ncdrounFl1DPACAoddfb/oLgZ15cqJIA1gWTyMcbTbyTeT Q5v7EVCYwJo8sD9fVSuBNrYbWouRjbvV0xU+uEcynBTbMmW4g2duYk/Ec8Kxq/jvAJZG cvrw== X-Gm-Message-State: APjAAAXtzOHNwA/MF015LsR1MN5ndoOtAo2Frmtgg91h/l3+LyJhDdMT ZlhkQYeTwLQO0k8DFXzABeCxLFp49eUFzA== X-Google-Smtp-Source: APXvYqyLA9raRCjGEtQ5L5aO6bE7f5z5e7jdeJYvdN/uTfRWHR1m08qA/W6lvIBR0YH8Zrl54083xw== X-Received: by 2002:a37:9d86:: with SMTP id g128mr11128288qke.191.1573248415230; Fri, 08 Nov 2019 13:26:55 -0800 (PST) Received: from ?IPv6:2600:1000:b04c:9cbe:6d67:a89d:e323:d2c? ([2600:1000:b04c:9cbe:6d67:a89d:e323:d2c]) by smtp.gmail.com with ESMTPSA id o2sm3375987qte.79.2019.11.08.13.26.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 13:26:54 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH -next] mm/vmscan: fix an undefined behavior for zone id Date: Fri, 8 Nov 2019 16:26:52 -0500 Message-Id: <64E60F6F-7582-427B-8DD5-EF97B1656F5A@lca.pw> References: <20191108204407.1435-1-cai@lca.pw> Cc: mhocko@suse.com, hannes@cmpxchg.org, guro@fb.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20191108204407.1435-1-cai@lca.pw> To: akpm@linux-foundation.org X-Mailer: iPhone Mail (17A878) X-Bogosity: Ham, tests=bogofilter, spamicity=0.282631, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Nov 8, 2019, at 3:44 PM, Qian Cai wrote: > > - for (zid = 0; zid <= zone_idx; zid++) { > + for (zid = 0; zid < zone_idx; zid++) { > struct zone *zone = Oops, I think here needs to be, for (zid = 0; zid <= zone_idx && zid < MAX_NR_ZONES; zid++) { to deal with this MAX_NR_ZONES special case.