From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9284EB64DA for ; Mon, 19 Jun 2023 11:46:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 434D08D0002; Mon, 19 Jun 2023 07:46:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BD238D0001; Mon, 19 Jun 2023 07:46:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 236C38D0002; Mon, 19 Jun 2023 07:46:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1140C8D0001 for ; Mon, 19 Jun 2023 07:46:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CE429B0532 for ; Mon, 19 Jun 2023 11:46:57 +0000 (UTC) X-FDA: 80919320874.22.161D272 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf14.hostedemail.com (Postfix) with ESMTP id E895B100004 for ; Mon, 19 Jun 2023 11:46:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=nlMY23NV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687175216; a=rsa-sha256; cv=none; b=NQ1cNxaOuql9Jkq8Uclpc67OvNV0tg/08tvw3DEFhofSNguYxG5hKJMQdjeXTHc2Nf7aOK wh8yOBt/LRiKhGePcGKChWN+37eFtLMIQpE+nEBKKy7rsl7EcqNobp5KLofMI2wFXUAUoY BivS2vMFwUZWfNzWEB0gPdrhfcXDYkg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=nlMY23NV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687175215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+DL0OF7uuuNOYsqXOPSGvFJ/HjEnbDBZl0VpUNHErKM=; b=WXIDgcUY4VM3H4WEaCq20hvE/Xq6ePcdu8Wrqhp0e7kmNqd4AMvvaRlDO/i8z7xrLIJ4IP T/oMVeqtmepgd7rnLjTxiTA6qonsJ/74kcHWkM3F6STTTNYZjR1LgRlcToW0eseBHnV/lq ZyryVtoFn6Bf5/60VDdDLTNqHKJo2zc= Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-763a2e39b88so34809585a.1 for ; Mon, 19 Jun 2023 04:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687175215; x=1689767215; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+DL0OF7uuuNOYsqXOPSGvFJ/HjEnbDBZl0VpUNHErKM=; b=nlMY23NVUs2/TV+4X1loiY46xV6KKlwv5w9g1oziAw3FFBWCs1oaRqWXorL4zeWrKM yNs/OVxOvtjDlfeamQV8dQP0N1MOXMARRiFBuiXEug37L5tCEVGAoMGS5XAUdUrfqGDH zfrPnB25ELPugT/FJzVlpx+Mj9Yg1ThZUj496XCTfiL6d11YRAa2kq0B3qDeUPZXCobI t7zP9Qhg0FT+SBkNok5LXxaby6qjtqhW4UGZV5xSusfM/Mox16LA4vlC/QsEaCb3+dw9 2q6W+6bV7UANVGEnlVFFe/vlIU1OsmmXfS/DBwlIEGhvq786JOecG07G75f3yk1RV1gE xuFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687175215; x=1689767215; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+DL0OF7uuuNOYsqXOPSGvFJ/HjEnbDBZl0VpUNHErKM=; b=QNvoPRt51lgO/1N8vmxWvVxYLYabsrthXJ7mOxkHd3/TH2qj/AWwtRFDrddx3bwPS6 cML0l5bwntjL1C/lk2NNgMOgbUwgrt1oQkvwQNeh4J3F1RiStxuHtP6jCdSgwA1wNUqY iqPXX0ibGdv2Ec/GKjvtMjnl5u5P3u1PLBk9XEjVxKCvYqbtJi4fPH521MzT+/ytAkMO EaoKj6Scw1GGtpT28uusr2wq3ThpmSKYzE/opYhAkn/5l/rUBHZaM0Aos4rcGXqSD7qj SAUIg8RNgO9TOzqSYjI4GcFfDCQmRHTTlGEcxBiBcdreYlHCQd9DIzbANn9h2q2FOMCH /ijQ== X-Gm-Message-State: AC+VfDwVBJtgd6CUPfdyJMm/pzaQ1lYiErEr1Tj3hUhmv3WmHuJakzJV xsOLm22eo4zk/sXZRMh6qFI= X-Google-Smtp-Source: ACHHUZ7WJGHmzDBSaJdMmZtj2q9g+F+HBvoIaWkaobPS5K/bb1dOY9PCsUd743jpPaFGn1z+i9saIw== X-Received: by 2002:a05:6214:401d:b0:626:376b:c95d with SMTP id kd29-20020a056214401d00b00626376bc95dmr12389587qvb.47.1687175214665; Mon, 19 Jun 2023 04:46:54 -0700 (PDT) Received: from localhost (172.174.245.35.bc.googleusercontent.com. [35.245.174.172]) by smtp.gmail.com with ESMTPSA id a20-20020a0ca994000000b0062de1ed9d15sm8529497qvb.102.2023.06.19.04.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 04:46:53 -0700 (PDT) Date: Mon, 19 Jun 2023 07:46:53 -0400 From: Willem de Bruijn To: David Howells , Willem de Bruijn Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org Message-ID: <6490402d8401a_37b5c7294c6@willemb.c.googlers.com.notmuch> In-Reply-To: <755077.1687109321@warthog.procyon.org.uk> References: <648f353c55ce8_33cfbc29413@willemb.c.googlers.com.notmuch> <20230617121146.716077-1-dhowells@redhat.com> <20230617121146.716077-11-dhowells@redhat.com> <755077.1687109321@warthog.procyon.org.uk> Subject: Re: [PATCH net-next v2 10/17] nvme: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E895B100004 X-Stat-Signature: kigzry4qqboxwbp3ocn1hye4tcpgwsrf X-HE-Tag: 1687175215-574117 X-HE-Meta: U2FsdGVkX1/vbpM3VfhI34N1WVURY+3At7NsZVQRzPrFgyUIn8JraDvut4C7bSFcAFtiER7rVQ7CKRoXMTg2Y2g3kgio/VmZznKBQjoO3AVXqLNIB5oUs0O97taiHW6vMELV+VPnzi0X9YzsNWwQDxOd7iTyNIYWhmIhn0pbtKtMuM2bQBTVaWk6RBBJkisYcoXntwqVJZ6+tWlWC3ogtyl0ez3iuzB/rM28y3NM9+Yz93fKutZftaV+J0eu4+JAonuS1TimosX+LSMS1pr+GZaCYhbMeFH25fIHcA+qx5huFJ/Zn7fnaMG+Z0LBrDRJAh9sERjzO6h/rWG676pS3pE7eqcruaXDhXQNweXhdJFoBiphu/QqDWDxIe+o8I3TmyW5PHPh/Tqt2vYGkS7ErxV6DsCvcWOkTv3iqcZfzvUmANxl4kziLJQ2gwjGVdlcgPetafyjLMCQW7nWFCEQtkSn4SCdzI2o7U5/b6sItbrgsjI9jGC4R3oxNCqV3o3RDQ/+V8BQUraTQ/h5B8R+zXxHmL57CI/aKehYbgc7GvnP6YTHEOPaKkd9bTDN4f53EvJQZeGR7Fyz4pZ8PayJg9D0nNe0fWMyyTblBbdomGW3YTYgPgF+nEcXXY3M/qSLBFV0h1wSpyRdLrFfzWr7DZFACocpPDxbOVT0gA4nMJt+J70QSpST0rfYsBGGGbJWOpI0whrkOxVFHzHlkZtUJkdT7EzaxMlImDd+v8pXDuVRbT3DbRcC+zUlDwnsz+0o5KCcdQmAgW8FZrmJFLIVzASMPqfpr/2c4WP/tmSyaebjdUHmvFUZ+3PZ/kJcD7aeXcnABjHkb8iOmrkABYUX6NqzTBzQkZcv7hGWdRJdhkx6gObJSyGp8Yi2dlLSl7v9YEAgoA++wdS+jNatngPnGklWyE6+Na6egtiSFuqCU+Vkbrmmzax2qEZ4IisgwRrur0CtQuL5YI8qkiZF7fZ 50T2KaX4 +Acd+TgkygKeo9lD+r6r+MXtL0AqGyORcV0naGJ3pjQTcFQmS8goNzGfQTKzWYFRBc44iwIkiVvFKS/LnYekVqgwzREDAl3xu7HZVegG1K42g5jU3ghN7UmzmHnjmEcm1pgGaA1PhIN8nVm8QyLYMxM5ZuT1nTlkITiK37+KpwSEmDOT19OGHFtNnvlQ3U8m0s4V8n/hh1ODWnH4H6tW2wLF9p8wcb3lbo/qClur5EK+cML0LUv6fSF2go118aelUYU48KN2QlsKHhYBi+bmt5HpWzeg604F5imyLciXkhVwDndPrxQnzVZYZcD7MBQLJg3HS1pQB6Gxz4N9zoGe7MsW3s+QhOqfI1qxgwMDDfMclKyWYUonfr6dV8Af67ysnQj916ZJMVFtw/rNOOx4SJiCIhJDnyxiA4GqXo3WInwNnQUIv0+MfhrJGKdEALdSXCMsbnv6pdi7bZBcolmm7UGjZt6DFBv9JEEAm8q10jNYGVlboBWnQGY4iFR8AiFvUNTGNdzN3aw58JqKoK+Haic0Bf1Jwrp4JCIPoRqaCHcdTjv+alTIZ5Ds7yleietm5ZVTgqjq2fMasBNdyc+hE1O0y0Hr7S2R6ffigyE2day44ljs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells wrote: > Willem de Bruijn wrote: > > > struct bio_vec bvec; > > struct msghdr msg = { .msg_flags = MSG_SPLICE_PAGES | ... }; > > > > .. > > > > bvec_set_virt > > iov_iter_bvec > > sock_sendmsg > > > > is a frequent pattern. Does it make sense to define a wrapper? Same for bvec_set_page. > > I dunno. I'm trying to move towards aggregating multiple pages in a bvec > before calling sendmsg if possible rather than doing it one page at a time, > but it's easier and more obvious in some places than others. Ok. I just wanted to have your opinion. Fine to leave as is. Acked-by: Willem de Bruijn