From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Mike Rapoport <rppt@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-mm@kvack.org, Mike Rapoport <rppt@linux.ibm.com>,
linux-kernel@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] powerpc: add support for folded p4d page tables
Date: Tue, 7 Jan 2020 12:12:15 +0100 [thread overview]
Message-ID: <64856046-97d5-bb10-b5d1-e9fb857c6123@c-s.fr> (raw)
In-Reply-To: <20200105070236.GA7261@rapoport-lnx>
Le 05/01/2020 à 08:02, Mike Rapoport a écrit :
> On Thu, Jan 02, 2020 at 05:42:31PM +0100, Christophe Leroy wrote:
>> Mike Rapoport <rppt@kernel.org> a écrit :
>>
>>> Any updates on this?
>>
>> Checkpatch reported several points, see
>> https://patchwork.ozlabs.org/patch/1206344/
>
> Well, for the most part checkpatch is unhappy because I've tried to keep
> the changes consistent with the old code. And, there are some lines over 90
> characters that do no seem worth breaking.
>
Yes I see, many places we have stuff like:
pmd = pmd_offset(pud_offset(pgd_offset(mm, start), start), start);
I sent a patch to refactor that. This should help fixing that long line
issue and reducing the number of lines impacted by your patch.
Christophe
next prev parent reply other threads:[~2020-01-07 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 15:09 Mike Rapoport
2019-12-09 17:46 ` Christophe Leroy
2019-12-09 18:33 ` Matthew Wilcox
2020-01-02 8:11 ` Mike Rapoport
2020-01-02 16:42 ` Christophe Leroy
2020-01-05 7:02 ` Mike Rapoport
2020-01-07 11:12 ` Christophe Leroy [this message]
2020-01-06 3:31 ` Michael Ellerman
2020-01-06 6:02 ` Mike Rapoport
2020-01-07 4:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64856046-97d5-bb10-b5d1-e9fb857c6123@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox