From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048E7C35274 for ; Tue, 19 Dec 2023 03:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43B936B0083; Mon, 18 Dec 2023 22:04:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EC066B0085; Mon, 18 Dec 2023 22:04:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DA166B0087; Mon, 18 Dec 2023 22:04:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1D6536B0083 for ; Mon, 18 Dec 2023 22:04:49 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ED6171A014A for ; Tue, 19 Dec 2023 03:04:48 +0000 (UTC) X-FDA: 81582075456.20.1BC57E1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 12AD9100010 for ; Tue, 19 Dec 2023 03:04:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNmdYXoR; spf=pass (imf05.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702955087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RQfG9eq9ewowiFP45GZFICAofL0rLlInSQ5uXMEvGss=; b=0Yv2M0VuE0iK9fkvBGG/Idh3CVKZ6Dbz4E0LRyGkB+IUdvL7N1dXNpyAHk6iOOtl3MzAlK VKLtRKe5ttn9vhq1QwLDFFzpomCoDI79xBoJtEcI60Jf+Wxr/8sBfYvVmoPL8h78zt68LC rOslUwMafcE49cwX91PZ2+HcrhB6Egw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702955087; a=rsa-sha256; cv=none; b=416i0GK7iwz6dQB3G+0l/djNqQiyGDF2AC/R7PiV/Kwu0ftKb1vHWuDbyhLJZJOSkh3KCq IAvAjcoHEH/xajvRxqH3oNaNLXS+NhOyPGpNocHdNXWKNsCy2krY0iHok7+sOz5p4eQECm wk2VDXf+8+JwrGznr+bnW72mehW4uWc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNmdYXoR; spf=pass (imf05.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702955086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RQfG9eq9ewowiFP45GZFICAofL0rLlInSQ5uXMEvGss=; b=MNmdYXoRxjbNwFpQRV5mGr2ZZpVYIR+sMt3Y9I0ZfrJmJy7UHPexqvkU87Z9H+WtjAD5QE +nmR1pWY8GF8MVQOx5yGsnZksjK2YnlKw30QPuRTry2sqewUcdQ09h14UIK22TQz6MPCT0 /D3RetgRNWkcuoyry6PRxyu6YpIgMgU= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-ywHlEbhyPYmWgska9lLskQ-1; Mon, 18 Dec 2023 22:04:41 -0500 X-MC-Unique: ywHlEbhyPYmWgska9lLskQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AED8F3C0E206; Tue, 19 Dec 2023 03:04:40 +0000 (UTC) Received: from [10.22.32.252] (unknown [10.22.32.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA957492BC6; Tue, 19 Dec 2023 03:04:39 +0000 (UTC) Message-ID: <647f6ed8-c6d8-421e-b5a7-faa3c19b9bd6@redhat.com> Date: Mon, 18 Dec 2023 22:04:39 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/50] locking/mutex: split out mutex_types.h Content-Language: en-US To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, boqun.feng@gmail.com, brauner@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-9-kent.overstreet@linux.dev> <7066c278-28e0-45eb-a046-eb684c4a659c@redhat.com> <20231219014617.dulwl3mdro6zyblt@moria.home.lan> From: Waiman Long In-Reply-To: <20231219014617.dulwl3mdro6zyblt@moria.home.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Rspamd-Queue-Id: 12AD9100010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hir7571ei43jybsk5sssi4ddangoira1 X-HE-Tag: 1702955086-894649 X-HE-Meta: U2FsdGVkX18P4VOYN0l8ubul2Tcgiz9joI14AgyLdU3HL9Z56rZUYA6mURt/Wbn3muqfDrQ4mqD713Q5k7Z/cz1bLekH4kfEUuuHeKFck4lewlXNtbZsPgpnHJZu5PgVGatKBBYM+TxE7tIlqDP2tp4hYwVhph2E56VWWSV1hyCyr8+n6ivf2V2JT9/5mdjX+0x3xT3fyADF3EfDsL43oBvwlp8B/HvE4AEdNbsD7yzdmh+PjcaUqvDD1fCUq+WEVaNBULA+OH/ozJP2+dPJWEyipHOoxNF8BGQuNwrR2Q8tserJYdbNuiNoSrcjwku8fyeDZKVroY7igDFUTEVqMgWe/rZIJ4SedQaQ53XOe9L8TwJheR+CJbvjPDxEVvYwL4XOVwY7nzsj2S7whUwCXK4VT21yqbI0MyvvGaZ1DoIeBFVv8TMZBGN/IusjPeS+vcd3DxrmUnAfxBbBx77ujwCdk5TsSKdkHB8Z0E+okRsJWsHQ8kNhptOFiJ3QReUnX0R2nQSc/CFXTRK4SSHjOPglujCyvScax8EI13z2YqSwGdwcZxG20YoSmdDFqKQ9umX+jpRA/ivFTYAatNX+AtdX+Gou7EPV4x1CModDNLH6vqKMJg1635+WfiJOOpVcJiTjxaatihDToGNXKS6OlNWzWsGRrg+oJsvsTLKM28rcWEmfJjoEaGYATKqn0qHdy+A8h4r1mQTOv3YC5s9rMNmUQAz0c9ADnwTnEINRHxEgZQmv2Z35pUVBeczc0sta9m6hvWO4Tz0UXv/2t0DG2nyveY9XlAmN8jCbwSPlilwoLvNm5gLaIBd3Vr9U9T015sBFu/HB2L81ENkIQvwe0yPhGOMOgs0qX1EP1XU8A9BOIwn7yPaZ5Y2rzuov2jM4bdwvef+RBK4+C+YDRQJBerZjbgohJVpqkFTYVzhOKshkZvTc+f7K1I8+w1CMOSSY4bJo7GX3clbg3hwkQgM DcXoI6SH oiU5DLoQByQ9tm5AdsRPYsfU5t6GD9+lBiS8OVkSjxhvecvZ4zq77nlMCvphgT8W9+lFWq8ODzrWnRtvPqrFJUa75usU46GZJAehqYXaFiWYAu3dnjXCEVr4ltvLbKgVFlXrAX5mPG8B4OPQ7Ls3k2+jWdrLALg+a3r8Rr6iirXkZVKdwWVhf2QALH54iP/Pim5orfOgriBJV1pDaLOtrjnEJdFEkjYrplDKNKa1wTuPGeO5WpkBFEFoHcNaAFccc5chP6KurLe6Rov9hGioJSC6yhW3lDAzv+0DSQ7D2Rnq2M0EJCHwvouX4WJRiSlkqTOVG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/18/23 20:46, Kent Overstreet wrote: > On Mon, Dec 18, 2023 at 11:53:08AM -0500, Waiman Long wrote: >> On 12/15/23 22:26, Kent Overstreet wrote: >>> -#include >> Including rtmutex.h here means that mutex_types.h is no longer a simple >> header for types only. So unless you also break out a rtmutex_types.h, it is >> inconsistent. > good observation, I'll have to leave it for the next round of cleanups > though since the merge window is approaching and I'll have to redo all > the testing. > >> Besides, the kernel/sched code does use mutex_lock/unlock calls quite >> frequently. With this patch, mutex.h will not be directly included. I >> suspect that it is indirectly included via other header files. This may be >> an issue with some configurations. > I've now put it through randconfig testing on every arch that debian > includes a compiler for (excluding sh and xtensa, which throw internal > compiler errors) and that one hasn't come up yet. > > could still be included indirectly though - I haven't checked for that > one specifically yet. If you are replacing mutex.h in include/linux/sched.h by mutex_types.h, I would suggest you add mutex.h to kernel/sched/sched.h to ensure this header file is included by the scheduler code. Cheers, Longman