From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48756C02181 for ; Wed, 22 Jan 2025 22:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E8946B007B; Wed, 22 Jan 2025 17:07:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8707E6B0082; Wed, 22 Jan 2025 17:07:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C2F66B0083; Wed, 22 Jan 2025 17:07:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 498EA6B007B for ; Wed, 22 Jan 2025 17:07:15 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C40751407CC for ; Wed, 22 Jan 2025 22:07:14 +0000 (UTC) X-FDA: 83036474388.18.B435D51 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 29FCC100003 for ; Wed, 22 Jan 2025 22:07:11 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K51NOMR1; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737583632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wa3d2xqSYlULBFS+guV9/8FSM2BW9DTlT2Ore095VS4=; b=iDUpBsjIzPLBrDQ8RQWQ4Whao3qM0osqmp8Jjax8LMmt747zvWqZh0tDP97q0lp9dl9lpp NQ33HoSteX5an/syYWwk1aW3d4sfeQrWG3w05slOwPFYwvcqyAFE1d/dpRESAlGMdTRB6P gbtSYx/viG45sRDtor+rNd+9i47um2k= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K51NOMR1; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737583632; a=rsa-sha256; cv=none; b=Iv6NPpDYcffPyqC8Zec/Nk/QwAzktb7vjoUg6SxbrtAxNd71zFrgNasAezSEOu9ebX+ouQ YkRhAS8MBe5wk61dWLkUHRINwH69b6WHR284zkWvP8OfMVG2Y7XaJH3kbp5wmZnWz+g5qO 1ZScXsw3AasSrq8iRQrpgKBrFAOe15w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737583631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Wa3d2xqSYlULBFS+guV9/8FSM2BW9DTlT2Ore095VS4=; b=K51NOMR10CDDlf+nSaeY0Y9CkmKULh6Ivvwl9sish82WClVN/AiCOSP9R8nCvzGg37Ft7r tYFW2+l88w/dT8OF09YgiRklZENZeD7HD/4GRZGpC+yOEL8E21han3GZBajk/gwVYpX5Fj XYSxOJ+tQiVZH+on4vBHnGB2JxuOrEk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-0Nh7vMF9PI-GM0_Fp9M1oA-1; Wed, 22 Jan 2025 17:07:06 -0500 X-MC-Unique: 0Nh7vMF9PI-GM0_Fp9M1oA-1 X-Mimecast-MFC-AGG-ID: 0Nh7vMF9PI-GM0_Fp9M1oA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43646b453bcso853125e9.3 for ; Wed, 22 Jan 2025 14:07:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737583625; x=1738188425; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Wa3d2xqSYlULBFS+guV9/8FSM2BW9DTlT2Ore095VS4=; b=nFc0c8HyrMIWzBr2UJGbc9qlU0qZSkEOFIKUA9/Rw2ySxWfsAlQ02U14wj6wJZhGIl 8TrFphsFwQ7LgsxjKDKNZXQQhN4LVnM8cFIrj/ov+b+GmbGyKeCyjVtJhQcNs/o926oX 52mIpynT/tOG6jMJctVj6Axkh5rjiRbmMACDj3j3uoK+WedDc60OKAasBKV6ERG2BsqY Mh5YWnPQ2rmmp7AM0ZFzX1npljd1Jpm3+OBVn2Z/Ft5BGV+RQnlSYxsPGSKbRpxhunVj AbQS7t2rkq02gmUHTAfC3u2MpJXq3rM4RxHV2mHuZR1sY4y5AD0JbDpLRTaAi8Rv8eK+ 0u9w== X-Forwarded-Encrypted: i=1; AJvYcCVt3EYVojtCaGi3n9wviyo3wk7yaNbQnhC083BJJ7nLJ59FjDAa/VqvQPvn2Q8g4GfPRaS/kxTIyQ==@kvack.org X-Gm-Message-State: AOJu0YziCl46LV9U7PaY9/Eyiy59BQE+UkKfca9BRQhUfheG9AaNgZT3 HEwfavnnatkC+OSu3uM1zXbYbJa9M3a/qR2GNDH+Vk7qhVoJ71TQp1CojIcir4Xxcv/0CNFXz8f yyG9EX42/LMrcGPfwn1V+pXdAaMsNJelKhW69u1g9SmI4xSksZ1uWjWbPgMY= X-Gm-Gg: ASbGnctjrAR4Rmh/pejOq01NHXmANu/5iksV2zBDETbVXT5/cmYn4jkiGlF8xp3nCUe BzAETQ+zFVVxaZvvDSwhhw+lJlayFn5+QENpltbVfX4rqeISggupJAvUT0zchA6KTYuicpXjTuw OlOvbYZD9x3pdqchpTxmDseyzLbe9JItuMUIQEjclfpchtB5bXV1LP6pIn5+y01iifo402YCO+M CSDACWk0gG7+aPl08nJ09gFxm95udDKfRr0Wm8TiuBRyRYNGdXRo0YuHmMUzsClidgs8WcO6/RK bLwrIhT44wvDftqlem571KtTnMzlCZ7Ek7p7A/7mtinhFwwJF7hemsYlN+O1U9oXBWK2FO9V0n5 xdOYwnGrAvugtIxm3CG0eRg== X-Received: by 2002:a05:600c:5012:b0:434:9e46:5bc with SMTP id 5b1f17b1804b1-438913ca718mr244463415e9.10.1737583625599; Wed, 22 Jan 2025 14:07:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxZ0RyfJ2RJeTD3ZLFT75LzLOeNp4itbBSWEqP/PS5xDq8omZA1XoGnRbF2VA3HltJNrsPZA== X-Received: by 2002:a05:600c:5012:b0:434:9e46:5bc with SMTP id 5b1f17b1804b1-438913ca718mr244463145e9.10.1737583625209; Wed, 22 Jan 2025 14:07:05 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:db00:724d:8b0c:110e:3713? (p200300cbc70bdb00724d8b0c110e3713.dip0.t-ipconnect.de. [2003:cb:c70b:db00:724d:8b0c:110e:3713]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b1718741sm24332155e9.0.2025.01.22.14.07.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 14:07:03 -0800 (PST) Message-ID: <647bbdac-df82-4cdb-a3e9-287d439b4ef7@redhat.com> Date: Wed, 22 Jan 2025 23:06:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 1/9] KVM: guest_memfd: Allow host to mmap guest_memfd() pages To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250122152738.1173160-1-tabba@google.com> <20250122152738.1173160-2-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250122152738.1173160-2-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zAV_tMypGOnXvYBJxs0XxD9G8QJMw7r1mJaSWJ8o8ro_1737583626 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 29FCC100003 X-Stat-Signature: 35uhoyrhg7nidm4jxzbftnqzsxskw183 X-Rspam-User: X-HE-Tag: 1737583631-230381 X-HE-Meta: U2FsdGVkX19aSYqCOYAp0f4Yutk8CNBMYy5LgY2O5lRNLZtf0k7uzIdAUL0Muff95jCTRz+LmgfIat28QrbumskZQmXldlSvIqSwEOFGh4zb/zNrBo1uI07tIInXZ867Z6i0gL7oBlB0HobBDr5TMbPamLJKOKWNU059UmMFDIAEdIdaL47DqYJSfaiKAtL3RU+ZmXyTYbziI/okEuyWbQL3+/s4Mj3CzxkZNCOVWH8ExnN4Lm3g6WXvkrHt/46lhfJUfPPCaUAf+RL4zbzabuozj4I3l0Tx7Xh1K+lsGB+bGrTXdLjqibcWfJGW8u14HuajNlr9RSVXWZ9pwzTm7mE3bmW/J2vDOxol9iHpp/xWTGGr5A+KIas2qkLsXS16+LOLFG8MaXLM/+xmhP2zxge0btAzGKowesShbNvRmegybJgk3eZ/aQlxS0FpYu45blyrjdd85zH2D3vtNhj65lfaLXCG0NKhnYvtyQGIOYtvBhSCz4axGs9Mmq6aFcnZzrAsaeo2QXxF3o4enMOCAS96XgR3bXuOrtPe5JbtNjoC8A3tLdzrzmcOKzjFiNRAAfZxpuvRWg0P0JFOxnUTAagb/PPMoIcLBX5WJlfDfH9/aa0bOvc+fMnHetl45fF+cV5kk0pBPbIDRtrxGyYsNpKJPj6GuJopqtvywwWTIkCMzSYjQxvQ+MrtupFk6KKWVtAaIwpA01Wwqz9Lqqj6wo4vxJe4LtPMs/BxHB1/xYURX1saoOUy8Qq2EmuxDDfqci+lcPr4MCVFcVnZWsNbz2/2INEKEEsCiB0osM80Yur7oMstUrGUj6EooqO6/ZUZfySYuPV9mURY6bSNxqroxcroglhbPX+2xiIajOmzoiAGNSZAL4Z4rbkPXPkBdR/+x6B05N8QcfAbxlWeqKf9KEt1NoPTSDmpMFRJ3b34rnkx7GqzirbZfCu2+52f4As+H3aDjmWAOZS8/bCcfPH Amdy2RT3 w8H+v1BQ0Q7SJ/sZkEF6dyjqhBwkoOYAx78E8Ob+BAs/+e4KvxJ8b5892c+H4+2T2ugpY9k28YHXDytObKbVZ9rnU/02Y6MJrFRw4hQF3VDMaUV1lNODoVIKS37NXz1b8n1ytQ2F9+MD3RjY8tuUMrbMGj0efnCQRyuGadfuFd04O3KEZogOWz+eTMf01Jl/3ghiv9MZKcuMmAIzcaC0+/7WaEjQXA0/ic8LmXhHKusRpw0mDva9qHmsmCPyZvZNR4O/bO7EEabZHb5wMYAUyLz4iVxPBC52JOjg7dH/SvbqpmyGXLwUTUQwTyCiQQ2G1Pr9ViUuLApQntBMWXEwg4Aqjoy9DozlkMbQ9SvljcavX1UCrKgA9EC40i8E4TA4qHU7mbGNPI7Iool5bdy0UYVjQh25RGLIGP/WDavIyrwyeiyhP8jVI76oZb1p6xopeXHfPGUoavVgCvxquzWsqWONIxhkyRdYkmwQP5gvEqLYeiLGB42SMldRUKtlqcth43Sp1JrlRjs0DvKyDOfPmHyzfOOZZeikQBypW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.01.25 16:27, Fuad Tabba wrote: > Add support for mmap() and fault() for guest_memfd in the host > for VMs that support in place conversion between shared and > private. > To that end, this patch adds the ability to check> whether the architecture has that support, and only allows mmap() > if that's the case. > > Additionally, this is gated with a new configuration option, > CONFIG_KVM_GMEM_MAPPABLE. > > Signed-off-by: Fuad Tabba > --- > arch/x86/include/asm/kvm_host.h | 2 + > include/linux/kvm_host.h | 11 +++++ > virt/kvm/Kconfig | 4 ++ > virt/kvm/guest_memfd.c | 71 +++++++++++++++++++++++++++++++++ > 4 files changed, 88 insertions(+) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index e159e44a6a1b..c0e149bc1d79 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -2206,6 +2206,8 @@ void kvm_configure_mmu(bool enable_tdp, int tdp_forced_root_level, > #define kvm_arch_has_private_mem(kvm) false > #endif > > +#define kvm_arch_private_mem_inplace(kvm) false > + > #define kvm_arch_has_readonly_mem(kvm) (!(kvm)->arch.has_protected_state) > > static inline u16 kvm_read_ldt(void) > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 401439bb21e3..ebca0ab4c5e2 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -717,6 +717,17 @@ static inline bool kvm_arch_has_private_mem(struct kvm *kvm) > } > #endif > > +/* > + * Arch code must define kvm_arch_private_mem_inplace if support for private > + * memory is enabled it supports in-place conversion between shared and private. > + */ > +#if !defined(kvm_arch_private_mem_inplace) && !IS_ENABLED(CONFIG_KVM_PRIVATE_MEM) > +static inline bool kvm_arch_private_mem_inplace(struct kvm *kvm) I assume right now this would rather indicate "support for shared (mappable) memory in guest_memfd". Maybe there is a better way to express that :) kvm_arch_gmem_supports_shared_mem ? The in-place conversion is (at least to me) implied with support for shared memory. > + > #ifndef kvm_arch_has_readonly_mem > static inline bool kvm_arch_has_readonly_mem(struct kvm *kvm) > { > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index 54e959e7d68f..59400fd8f539 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -124,3 +124,7 @@ config HAVE_KVM_ARCH_GMEM_PREPARE > config HAVE_KVM_ARCH_GMEM_INVALIDATE > bool > depends on KVM_PRIVATE_MEM > + > +config KVM_GMEM_MAPPABLE > + select KVM_PRIVATE_MEM Easier to grasp might be: KVM_GMEM_MAPPABLE -> KVM_GMEM_SHARED_MEM Support for "shared" memory kind of imply mmap support (otherwise, how to make use of it :) ), (KVM_PRIVATE_MEM -> KVM_GMEM might also make sense, but it's a different discussion) > + bool > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index 47a9f68f7b24..9ee162bf6bde 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -307,7 +307,78 @@ static pgoff_t kvm_gmem_get_index(struct kvm_memory_slot *slot, gfn_t gfn) > return gfn - slot->base_gfn + slot->gmem.pgoff; > } > > +#ifdef CONFIG_KVM_GMEM_MAPPABLE > +static vm_fault_t kvm_gmem_fault(struct vm_fault *vmf) > +{ > + struct inode *inode = file_inode(vmf->vma->vm_file); > + struct folio *folio; > + vm_fault_t ret = VM_FAULT_LOCKED; > + > + filemap_invalidate_lock_shared(inode->i_mapping); > + > + folio = kvm_gmem_get_folio(inode, vmf->pgoff); Would the idea be later that kvm_gmem_get_folio() would fail on private memory, or do you envision other checks in this code here in the future? -- Cheers, David / dhildenb