From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C51C7EE39 for ; Mon, 30 Jun 2025 10:54:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08B708D0002; Mon, 30 Jun 2025 06:54:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 063A68D0001; Mon, 30 Jun 2025 06:54:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E93938D0002; Mon, 30 Jun 2025 06:54:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D931D8D0001 for ; Mon, 30 Jun 2025 06:54:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7ECFD123396 for ; Mon, 30 Jun 2025 10:54:12 +0000 (UTC) X-FDA: 83611757544.01.4DA18B6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 19B81140002 for ; Mon, 30 Jun 2025 10:54:09 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UeH56JjL; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751280850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Ig4DRpO8S3ras7EkzYkIu+eY4pUsIGMfLOrlKNaDPY=; b=cIqEyeVXo7s9Il5U8zJik5Wq6ay65k6qxgIwliIMZPpsGeXdaGGkuSEfkIPQSL5tYXpkAC ZoD/O20nK12dapv1ZKdVNPctOVALPSZOthNE6IFBX31W70O4MygPvafJ7Ew+EEeA0UlGml sbfOT+ABjqzL/fClhU5Vkyw5JXY7dso= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UeH56JjL; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751280850; a=rsa-sha256; cv=none; b=LNPPwfAIAWohQ48X/GOsL8aobd/NKK4tHArfTiaiD01ABbgns1n9UqaFdoHuTpdjt/sHqz JU9W+KTAfvqSY3Tg2lBBeIKiME7s/+fofbTY8TjtBr6HQKjZE6J2JLiA3pND7Co34q5GdI r+rXd6c251Dj8S2GSZkFSZ+54ibEn/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751280849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/Ig4DRpO8S3ras7EkzYkIu+eY4pUsIGMfLOrlKNaDPY=; b=UeH56JjLGc2DIDOUGVaZ4M6GZkBwKSXdcApj2byGvWFPE7+M7IgonVPUwRsu8PbokyX9dN 2xJtbj1rGMgYk0oo/6MOjWStt1JL0afbI7pfFpQ4B4REQn5ewi0lQZMtx1moKDVN08YX9G YrC+97K4B8vkUM+wDMiJxaUuHHPmnPA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-xbHQjhwLOgmJPhOOScZcqw-1; Mon, 30 Jun 2025 06:54:08 -0400 X-MC-Unique: xbHQjhwLOgmJPhOOScZcqw-1 X-Mimecast-MFC-AGG-ID: xbHQjhwLOgmJPhOOScZcqw_1751280847 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-452ff9e054eso19665355e9.2 for ; Mon, 30 Jun 2025 03:54:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751280847; x=1751885647; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/Ig4DRpO8S3ras7EkzYkIu+eY4pUsIGMfLOrlKNaDPY=; b=WV2VTsdqNW3AdDUz1YNo5K6U4zVbR9VFx3uHG2WWywrS2qt/+cs7G6NHRSXn/oIawG 9xHjNjAl95bLdoKjYdMkWuWhNVO4ilLpA6+gEbuR1k10+aQ+qEuYn6q/GqxQKpuKAhu+ s+eb/jk2qb9lqSxDLnM49c8Kt63RCZ2sW6b3Dr296foqBqbtvCR+ivlcbRJWtVWmNSRQ Ma661RUjnOP0eLsz2bhIHAYRCOfmJmeur3gBdkIPVedpaAJkul3E35y2jRxJchYVSuM6 Y2n6iVC8+EXWptEC1+UGFhiBdsRK7/REhNxJgKRBvdxUO5ViJFnQOKJ21wQ/CzK3BPmR RRDw== X-Forwarded-Encrypted: i=1; AJvYcCUgMyZR6s+DXi44Y6a9IJVxNPFEy9RIvDD80A/0J9MuVkXQKbtfKd+5FHu1p6Gg/L7Kdav87Y1IDA==@kvack.org X-Gm-Message-State: AOJu0Yylbs2rKZ/d8J2uttsqoQstomYmATar6asQQzuNIn8VQgbTsQta RtSB2cS20Ohq3DNv48d9aK4Wbc29bw6vK8kY1hhwt7RfWG6Qvi1uuZwhUwNk7CFByOXY1yiB+S9 XLODOouGElVFIpf0q+C8BzyoanRHrWFdaAAp+2G1vLM6NCGFcISKK X-Gm-Gg: ASbGncscVu+kAMJmEF5MmJJqXaPDx/QnUnyqrsjw+d/pYf4eWlTm53B3vrRN+aTL6Oj Lo45rKToTeCaw3uIh3ea7BYfwtsfHP2PuzgwBKdC3cKrJ/tZO+aN/TAo+9/3bFzBNsV9Cj1ZOeX 2r2t3tYGtlamsmnWDKBAvnhvTAg+SDcDuE8cCK2CBree67svf5gPJJTfv31hkT86HJ593eRa4oc Rfy8YYMDdwUkzgYkH4q6C9jm94XhpCOuWXRoXCLNltzpPTULbvOM0WosrY787xWxGXs73mA4mV9 aKjAbaB01eHb2rUjlumJHUCSKpDIPojRoUwSH0XS6KiMdqTGWpOyV0QA5RSVgNICbF9+S2yv3Am tT/N+/w1bx3igtkt1T28SeBKWMHmIfRQG13DtL9KrUq9QepMpYw== X-Received: by 2002:a05:600c:a4d:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-4538ee5d1famr153944485e9.10.1751280846655; Mon, 30 Jun 2025 03:54:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYD6fei0tp2zEVfYn6rQl+iZ0sSUDc1J/Wx2MMLSubQmwLSI1dh/yx4qwWIITfxKejwbAR5Q== X-Received: by 2002:a05:600c:a4d:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-4538ee5d1famr153943985e9.10.1751280846222; Mon, 30 Jun 2025 03:54:06 -0700 (PDT) Received: from ?IPV6:2003:d8:2f40:b300:53f7:d260:aff4:7256? (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7e9d1csm10221615f8f.13.2025.06.30.03.54.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 03:54:05 -0700 (PDT) Message-ID: <6466a90a-6af0-4dc5-bbb6-19ec6d2f5c8c@redhat.com> Date: Mon, 30 Jun 2025 12:54:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> <9185c50a-1427-45fc-941d-e9796cea4831@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5Zw-i4wCKOpoIzbxv8p04bPfv8VYNx9xt6sdw3314e8_1751280847 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9r8sc673ht7wba7refe3xugwmxnkz5mq X-Rspamd-Queue-Id: 19B81140002 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751280849-754239 X-HE-Meta: U2FsdGVkX1/Y/sG33iOtcsfBSclsdnzRsy8XC+dppR5+jJxZRzvx2OsnYb/P15E32Vq5zbg3Lr4uVMtu6YiWimhCsw7bShLPI9U7ztg8PcyvNL6e95Dw/fCC/rX6ui3FdonVmiB+E0DRNwhte/8xAS6IJkJPA1VgD1vKKUDLVRDcWQGpHXwwOWv3LRxNzKyXX7h6/Plk+8FUJd/tblWkECj7qZn/QUkoitZe3ZwH30syO61sSOeXeM0Lh9IkFWRdBuys4NxQV4LH2TvXut+FJ8GvMmwwAJu+MWVfspnZjjcNl/U2enmOpsADSegRjlPcwRsnIDd9wpiH7xPHX3sFR0+pmq0fvW0rgCMfq6ube1pKDZquHtQ2IdJ0XcBmU7+K5PN6dbQsbC6KG+Vxz5WTh1av4xuldpXVDjyOxztahDN6TB5LgipuRGojVDOspwXlyQtp//6yOFrYkAO7G59K3qXzP2iQVZUkCwZxcH/fbObtml5GjqrJLkodE5jMvjhlGPRhuAkTLg+8WNMQn1LKLutHzOIPYVHg657ftuf8llR3qGURB4xZvxJcwf/ARR35xVSdBuwkmfHCNtmf8oBbeLi9HtFZUnjirHCFGdVkJ1n0yHRE8bEBsIQN+NW4ujPrb/lMLlvRtMl9rt6qQ5cm7xdgLavJqFRg7ThnK8jqMHNQNcIV33/uNfNub2nHD8o9Kz20qr6IourjtioiDvAn20SlyLXQIiCKA7Qe0b9ED07puPNATNQAbhNjUuIQoD8Z0JzGw2W7kZGLwW2Y3xJ+y9cDmFDJ+u8t6XTycUpQruwlnPx1gzPLbOaENQIUlyDQ6Y2sedrNNAwxCp5RAzMSUnLY/w4QDdaYO13oTBNTZf7amj1MwiKZfM5/YYS/aXxlat8p8sNwMsfDKal6tUPw7qItH6qIXSAvh7aWhjyRjRRCCg/BhGFOQ6vbMLiAWA6ab1GBov6jfGoMir8GfyB Uo8B1oFi FgUx1p6x7Z/h6q9GMrBln42h+dpy7eOVbuWgoRo75yvRK5XFf3+lXKVajV9bZaskDSckg6T15wAv5htH2MHBKOgZbiy+OQq/+o4y8+MCt7MuLKHvZhIxazN4LL/Dw+d9712W0O/kQON7ZCVKPKMe/eWMZpvtKG09n0KQ6Z+NFF8on410g4x3T71AKE3XwJMkqYULTmn6EUKPQo0cVSFvfp+Se/qM5Yu9G5HI6TntyoGi+tdsXhKshb8nvP3qeO5DTWQMyhOItjcGbs0ztK05oVKOY5aJ03fpgWKH/Dr1v3jMNiXmOgBXzEY/66Gr6ZbO5uKgU2mBZ8HP89kJ9545kG0NEtUSXhXKuNZP7JpkB9JX7nm5ln9XtiwxLJokLclan7FjSteMk4FEoR1tFBIpoMIwRv5BzWXXnF312D4GI28Sp9Kj37+QvU7YclC6KUxliTX2NKcGGVQDLReGHmx3TGZBFihpaiENcVOhC4hvoKb3UTCIwbXKoEHmYVZtkqpkYeFmxoIrMT4pR4E4dFdOTYqupB1A1T1e5U6X45Bry0vi/XoTgAfqWd6UxboSRdPnDzC3YPpxTj3RLO9pJLqxBU5KYzRQ0Hn+cTvPrynWLInNtEUbHa/zBJ7BifQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.25 12:41, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 11:19:13AM +0200, David Hildenbrand wrote: >> On 27.06.25 20:48, Lorenzo Stoakes wrote: >>> On Fri, Jun 27, 2025 at 01:55:09PM +0200, David Hildenbrand wrote: >>>> Many users (including upcoming ones) don't really need the flags etc, >>>> and can live with a function call. >>>> >>>> So let's provide a basic, non-inlined folio_pte_batch(). >>> >>> Hm, but why non-inlined, when it invokes an inlined function? Seems odd no? >> >> We want to always generate a function that uses as little runtime checks as >> possible. Essentially, optimize out the "flags" as much as possible. >> >> In case of folio_pte_batch(), where we won't use any flags, any checks will >> be optimized out by the compiler. >> >> So we get a single, specialized, non-inlined function. > > I mean I suppose code bloat is a thing too. Would the compiler not also optimise > out checks if it were inlined though? The compiler will optimize all (most) inlined variants, yes. But we will end up creating the same optimized variant for each folio_pte_batch() user before this change. And as Andrew put it "And why the heck is folio_pte_batch() inlined? It's larger then my first hard disk" [1] I should probably add a suggested-by + link to that discussion. [1] https://lore.kernel.org/linux-mm/20250503182858.5a02729fcffd6d4723afcfc2@linux-foundation.org/ [...] >> >> Obviously, I had that as part of the development, and decided against it at >> some point. :) >> >> Yeah, _ext() is not common in MM yet, in contrast to other subsystems. The >> only user is indeed page_ext. On arm we seem to have set_pte_ext(). But it's >> really "page_ext", that's the problematic part, not "_ext" :P >> >> No strong opinion, but I tend to dislike here "__", because often it means >> "internal helper you're not supposed to used", which isn't really the case >> here. > > Yeah, and of course we break this convention all over the place :) > > Maybe folio_pte_batch_flags()? Works for me as well. -- Cheers, David / dhildenb