From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2E0D2A523 for ; Wed, 16 Oct 2024 14:44:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43E846B009A; Wed, 16 Oct 2024 10:44:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C6816B0099; Wed, 16 Oct 2024 10:44:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 267286B009A; Wed, 16 Oct 2024 10:44:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F1EE76B0098 for ; Wed, 16 Oct 2024 10:44:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F22CAAAD60 for ; Wed, 16 Oct 2024 14:44:08 +0000 (UTC) X-FDA: 82679735964.26.4F5B303 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 20312C0006 for ; Wed, 16 Oct 2024 14:44:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729089819; a=rsa-sha256; cv=none; b=IO5+v7ujW3nNFEKxliBk9hS1ewWvg4PNVPhuNhz2SI23qcr/+ItVtpYjupXGQcobmI84/N PkI5Diq8TAgUItnnfNIZI2g7fnswwWtNffcJKwMxiM2G2FNzfe2j0RRZ52dAPpo3u830AA IIDnjvvPtmuMhVvlHmLYfwAL/fNukhk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729089819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/gievmNSp6gcEhgMsU62ZBHjqoa5a15h27lVU/uD/8U=; b=b1lIRUfGvzsDpDO6EdAanlVC5Mzt/vy2Z5Xkr5Mtbmp6UetyeNCrMok3uQrgFEPmrrhU9b YeHj+OqQsHhaUhJLKfv1RLI2eQ+TbeRSfqqyZ2GWy3kd7h0aSyGkEc0BlAZKXMxtwMyiit kpQfBvIc6pNSIxBKOb+pAUYDYm9R1aU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E13BF1007; Wed, 16 Oct 2024 07:44:55 -0700 (PDT) Received: from [10.1.28.177] (XHFQ2J9959.cambridge.arm.com [10.1.28.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84AB63F71E; Wed, 16 Oct 2024 07:44:22 -0700 (PDT) Message-ID: <6463a9f9-76ee-48bc-9173-75b220fcb3ac@arm.com> Date: Wed, 16 Oct 2024 15:44:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 28/57] net: igbvf: Remove PAGE_SIZE compile-time constant assumption Content-Language: en-GB To: "David S. Miller" , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Eric Dumazet , Greg Marsden , Ivan Ivanov , Jakub Kicinski , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Paolo Abeni , Will Deacon , Przemek Kitszel , Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-28-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: <20241014105912.3207374-28-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 20312C0006 X-Rspamd-Server: rspam01 X-Stat-Signature: c4uo34668hqnnia9ruar11wnxprrq1b4 X-HE-Tag: 1729089862-748698 X-HE-Meta: U2FsdGVkX18mRphBIeNHJJeAg/TSLUzKpxM/DURQtgUUA1ilpM57K1aa54Rlo4Vz2e6kwYfNYeDFLYtTPBo8eZxdn/8xtZpTVtPBgqOU7cWFUwZTTPAKpwcCxgtbI8j77YVlXn0GH00QUbLqDUruZgu0ZImm9BObrljdsN0g5Lo9aUPOgSXKVcy2GWxohzoYvBXEaut4npyKQ30e9sCr+z/1yMPGhXuHmGlpn47YJ/H4WA8zkd6Gk6vuzk2pgFR+DOj8S17NkObBjfW6kdJlbCoiOtZTfQf21+k8r66Pq3tdqlUYoObfV30dovbVKAY0LfOYLVvwNJ44zWbVkWpGCRWDpd2PysMx1/81BCrMka856ccrXM0p2dJ+FBvhKp61DGS31B1L49WjCawq6WlqUUQl/EX21N2IS61oyaP+MhUYBSEOXzd/8YjgccUUbme/d4ttZbKj+GalRSmyC8rCRYWJaxWsDf72ueX0flVMQ3i0Pym5/PSf62ZG8CCR7S0L5QD/n3qEq+Xt9o5H/IRBWBLw3KaGOhesAcbQvNQCH3gT2F40nj5U7oLmjbP9wzUedKMwF8g5GRfes1mkpbatrYq/PMwhnqDvVUqMDpxBmRIzJKnrBCBiusfAmASNVOUz/a/sRfy+Co9RDPyyHSLaqrKczBnOP2EuaSVv+q5JlWMBMgP+2XZAztTVuZBwzsAEc6dGJuIENWq2lvN93Jly7K8ulXxfxvaaYnEop5/y2Z95Z8gf1FXqWS3rb2u5qKCQm9Rzo4QWxoiIN1ifOHNscWOn8IjaNw8jk/fWCTTNknMW7dqDSkepY+RKSs5FxCFFab4XiE2Vpu7CC+W3V4SYVUH3ZTr9s2zBuht1DDsEX+LED4xaiE6ewxmaKaWtDvrXxFFrFsr7gQx8TCwKsei+bZfl2wKCQxu/jqyeO0poxmPEmDBTmRuUbQrOV+fB/v78pzspjo8O3r6TiuL1Vpz 5CkE2odL giNYEr9jmXpORvqRQGYwGP3OBY2QzVAcKGgkGSDZxBNuqFmrUILQO6LlqZm9kKLOZ1DiFJAHScB/+A2ja2rz+5lRBjWjSlKJdwO0cCfuD+3qzz2bTElUWfeBkmvix2pQ+PlvE6oWpzYl5eaJt+/gw7oNKOqir44OZuZXlXFumyyALtRGQqukSZM0DsmyKAvCTvej4rxz/JxE/SCSEjy8BSkuEhIwqi5a62SpeehjmEFp+Z/2PLHXg4mnpzuoOWOBorGSGtrRYxh5eMhdsGDncRflvJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + Przemek Kitszel, Tony Nguyen This was a rather tricky series to get the recipients correct for and my script did not realize that "supporter" was a pseudonym for "maintainer" so you were missed off the original post. Appologies! More context in cover letter: https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ On 14/10/2024 11:58, Ryan Roberts wrote: > To prepare for supporting boot-time page size selection, refactor code > to remove assumptions about PAGE_SIZE being compile-time constant. Code > intended to be equivalent when compile-time page size is active. > > Convert CPP conditionals to C conditionals. The compiler will dead code > strip when doing a compile-time page size build, for the same end > effect. But this will also work with boot-time page size builds. > > Signed-off-by: Ryan Roberts > --- > > ***NOTE*** > Any confused maintainers may want to read the cover note here for context: > https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ > > drivers/net/ethernet/intel/igbvf/netdev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c > index 925d7286a8ee4..2e11d999168de 100644 > --- a/drivers/net/ethernet/intel/igbvf/netdev.c > +++ b/drivers/net/ethernet/intel/igbvf/netdev.c > @@ -2419,12 +2419,10 @@ static int igbvf_change_mtu(struct net_device *netdev, int new_mtu) > adapter->rx_buffer_len = 1024; > else if (max_frame <= 2048) > adapter->rx_buffer_len = 2048; > - else > -#if (PAGE_SIZE / 2) > 16384 > + else if ((PAGE_SIZE / 2) > 16384) > adapter->rx_buffer_len = 16384; > -#else > + else > adapter->rx_buffer_len = PAGE_SIZE / 2; > -#endif > > /* adjust allocation if LPE protects us, and we aren't using SBP */ > if ((max_frame == ETH_FRAME_LEN + ETH_FCS_LEN) ||