From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E18C433FE for ; Tue, 26 Apr 2022 20:08:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3E256B0073; Tue, 26 Apr 2022 16:08:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E151F6B0074; Tue, 26 Apr 2022 16:08:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDF696B0075; Tue, 26 Apr 2022 16:08:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id C265A6B0073 for ; Tue, 26 Apr 2022 16:08:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9912827499 for ; Tue, 26 Apr 2022 20:08:07 +0000 (UTC) X-FDA: 79400116614.19.E068FC9 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf28.hostedemail.com (Postfix) with ESMTP id D1377C0040 for ; Tue, 26 Apr 2022 20:07:59 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id i19so6603719eja.11 for ; Tue, 26 Apr 2022 13:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tLEXJAA00IeUn92g+4KPqheiYchRzNk1CErI3hE/2ek=; b=GZTVe7N8eI4UTdUZ9Tjai6ca3oa5nN6rkKqDwJU5o1VwzHSMXgIHJRjjZsQACU5uBr GlkbgtWhXlTBtH3QXpvEoPAkUzhX7wHNUHEaLjFraK4Fxtf4kIrosSkKY/VWdTxIs6pf 5j3hctG+fUcS4QoW3bLZ0xoaJyYh9V/s3+zsgtxv2L2OcFOc1uHBT5Q7sglwvPcZZZdv bavXpvLDh9qLJjqRuhTKl+u9s40qyzYO9BnYYSieFdcxtSESEFvW2YK+MMlVYbi0SMeb Fc/sEvZjRZVKC3V11zRIwjbWtuJxw1dSkIWhUS+sK4rScXto270+v/jPojKThfYXG71w +PLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tLEXJAA00IeUn92g+4KPqheiYchRzNk1CErI3hE/2ek=; b=Nrw2Zy2cz+p61kp/1RIPT/QK9enc3o9ciMmK1a494aJRlAQx+cMAR6B1paOEAE7Ie5 jW8i5vjc7heL1d8KCOCayqx231s18UzP3t2xKq65f91vKmDbrlHwoWdO5WS9TGXV21nb KRNiE+Fljxqi8B25gcriNTA4c8WfdXoU36rYdAIiOkCiBb8ZCjRTInTWEnUMYc7Y+vOd +JoYr4TlKk8RXabKoDqtnLlyrdyZ5gNh7ViHvm/b1BGkXS+T7Fhkwcaf3+4SPdKEOg9v +znYQD+ziyVrx3s8Th6RnU8AA0Ojh6zN3aEE4i3EutD1Ep2wimZHPDQ3CNG/x1P7UnN4 fIwA== X-Gm-Message-State: AOAM530rdYIwbJlR8JesUzBqD6hKLlE0qiM02+U/ToZ3+s8cAOU2r65t oqySnLlCgcm14CIB9luIH8eGXA== X-Google-Smtp-Source: ABdhPJw9/fEtAIeFtCRKchGp8lfvceTRS5BAE6i9Fuu3os3IVIddM48wscmCVR8F4475NEB0tvMcPg== X-Received: by 2002:a17:907:62a6:b0:6ef:8118:d3e2 with SMTP id nd38-20020a17090762a600b006ef8118d3e2mr22587094ejc.605.1651003685427; Tue, 26 Apr 2022 13:08:05 -0700 (PDT) Received: from ?IPV6:2a02:578:8593:1200:d053:7ae:ded9:ba66? ([2a02:578:8593:1200:d053:7ae:ded9:ba66]) by smtp.gmail.com with ESMTPSA id kt24-20020a170906aad800b006f37988318esm4074017ejb.48.2022.04.26.13.08.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 13:08:02 -0700 (PDT) Message-ID: <645fe7b9-4751-f94a-2ae7-37e6c1a7165a@tessares.net> Date: Tue, 26 Apr 2022 22:08:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] x86/pm: fix false positive kmemleak report in msr_build_context() Content-Language: en-GB To: Borislav Petkov , "Rafael J. Wysocki" Cc: Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Chen Yu , Pawan Gupta , Catalin Marinas , Linux Memory Management List , Mat Martineau , Ingo Molnar , "Rafael J. Wysocki" , Linux PM , Linux Kernel Mailing List References: <20220423182410.1841114-1-matthieu.baerts@tessares.net> From: Matthieu Baerts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D1377C0040 X-Stat-Signature: oadqbo6iyiqwtorxgzho5gwbhriqwc7w Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=tessares-net.20210112.gappssmtp.com header.s=20210112 header.b=GZTVe7N8; spf=pass (imf28.hostedemail.com: domain of matthieu.baerts@tessares.net designates 209.85.218.52 as permitted sender) smtp.mailfrom=matthieu.baerts@tessares.net; dmarc=none X-HE-Tag: 1651003679-124912 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Borislav, Rafael, Thank you for your reviews! On 26/04/2022 19:27, Borislav Petkov wrote: > On Tue, Apr 26, 2022 at 06:24:04PM +0200, Rafael J. Wysocki wrote: >> So can the comment be dropped entirely? > > Looks like it to me. All the accesses in wakeup_64.S are done through > those offsets which are computed at build-time so they should always be > valid. > > OTOH, I wouldn't mind having there some text making any future person > touching this, aware of where to look when making changes. > > Some changes like removing a struct member are nicely caught, ofc, > see below. But for something else which is a lot more subtle having a > comment say "hey, have a look at where this is used in wakeup_64.S and > make sure everything is still kosher" is better than having no comment > at all. IMHO. Good point, let me update the comment and the commit message in a new v3. Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net