From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Borislav Petkov <bp@alien8.de>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
the arch/x86 maintainers <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Chen Yu <yu.c.chen@intel.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86/pm: fix false positive kmemleak report in msr_build_context()
Date: Tue, 26 Apr 2022 22:08:01 +0200 [thread overview]
Message-ID: <645fe7b9-4751-f94a-2ae7-37e6c1a7165a@tessares.net> (raw)
In-Reply-To: <Ymgrn03YqecDlPOB@zn.tnic>
Hi Borislav, Rafael,
Thank you for your reviews!
On 26/04/2022 19:27, Borislav Petkov wrote:
> On Tue, Apr 26, 2022 at 06:24:04PM +0200, Rafael J. Wysocki wrote:
>> So can the comment be dropped entirely?
>
> Looks like it to me. All the accesses in wakeup_64.S are done through
> those offsets which are computed at build-time so they should always be
> valid.
>
> OTOH, I wouldn't mind having there some text making any future person
> touching this, aware of where to look when making changes.
>
> Some changes like removing a struct member are nicely caught, ofc,
> see below. But for something else which is a lot more subtle having a
> comment say "hey, have a look at where this is used in wakeup_64.S and
> make sure everything is still kosher" is better than having no comment
> at all. IMHO.
Good point, let me update the comment and the commit message in a new v3.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2022-04-26 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 18:24 Matthieu Baerts
2022-04-25 16:28 ` Rafael J. Wysocki
[not found] ` <YmgOP1FFmidS9ecJ@zn.tnic>
2022-04-26 16:24 ` Rafael J. Wysocki
[not found] ` <Ymgrn03YqecDlPOB@zn.tnic>
2022-04-26 20:08 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645fe7b9-4751-f94a-2ae7-37e6c1a7165a@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox