From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 142BCC3DA7F for ; Wed, 31 Jul 2024 12:22:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75FEE6B008C; Wed, 31 Jul 2024 08:22:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7100F6B0092; Wed, 31 Jul 2024 08:22:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B14C6B0093; Wed, 31 Jul 2024 08:22:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 38CD26B008C for ; Wed, 31 Jul 2024 08:22:41 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D17C3A494D for ; Wed, 31 Jul 2024 12:22:40 +0000 (UTC) X-FDA: 82399961280.23.E4D059E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 8F29E14003A for ; Wed, 31 Jul 2024 12:22:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EUYykfPL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722428513; a=rsa-sha256; cv=none; b=6IrKSNO8exd1Ij4VdgS028T0lkuGT6hR3QdC7yQuZLTVYufor32Xg5FRjvEH7XFFH8zpVO V42rwVf+/Xnsru/mhqBQpub/OQEdKmaPYKdtVif59hoh/mUce6ePInPMvCo1bfAnhBEX3u cu8eA0AcB8eGSDCVRdtHZVFrEDxkD3E= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EUYykfPL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722428513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u8D0BMiT6IoVXQx1H4dU2A0Q04EQIo67aTwTXMI8Aso=; b=NV82FThfOqfO84tFX61OS1eCquSGb64xgAorpKKS956DZqdSt0i3wdo7NugPiFnFRv9gS9 FdV+Szt9K8Hd7aiAEd3h0DCSLhu1PXCs+0dU6cc+/ICZvqRmByQTVKRDZf1hnEMZik+riR HrGqcGK7BXG5jj5KRwavPI9ls3gi8Fw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722428557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=u8D0BMiT6IoVXQx1H4dU2A0Q04EQIo67aTwTXMI8Aso=; b=EUYykfPLf0IcRKJhZ5ZHKhOiOuYZP7P8St69Ju1NBG0DN+iuACOv6e7bxLIhFWE7Sic5Xy /ls/7WICI8ZnHv7hci5mux9OpCUqhn15Y3Dyi1ZLFInfZpLRsoLH/jnEXxGKcKKOecYYK9 prcW0R3cr40pA8jBoJdgcQjnQeW08wM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-rTX4TjakMeGh1grr3gCT_g-1; Wed, 31 Jul 2024 08:22:36 -0400 X-MC-Unique: rTX4TjakMeGh1grr3gCT_g-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-367962f0cb0so2726899f8f.1 for ; Wed, 31 Jul 2024 05:22:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722428555; x=1723033355; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=u8D0BMiT6IoVXQx1H4dU2A0Q04EQIo67aTwTXMI8Aso=; b=W9rlpunTVgzfH7uPCikIcaJ7xeA4Tolg5FHqiZYtM2BNBiZfNCvOpMhYAF8t6fpiSi Ys4daaJz1lTgSMOSYLckHb7YTNI55qLpkdBy/UlAfpYI07YtWsGemL1DEBp7oJVsCD0I Krfi2VArbzqbS1YdVx+xVe7l6kXW+JLH1wsXRMqegtzb3bfdFGGzw7Rw5KSYt/FYp1Ar TRe93QF2pLnm/Z7RiwWKHSJ1U0JwbQ0hVlOWRhzHnh9YbNlSHc3xairZ+rCMxztORQex FRDKO678FAkNY1OxUqiKObXQ7l07xo3yDM0VpqWONZGtaBhKV17wg7Nr2kMXNE0Dri51 zVyw== X-Forwarded-Encrypted: i=1; AJvYcCWiLHQ3i09uL32Dtaj7Wh9TBKS8RV1cmEY2FxrqkLb7ltnKz1HOi2VmSChWVWGmy7l2hTnQLM59c6/AP1tSAWjz5zI= X-Gm-Message-State: AOJu0YyWNXMhor5Qg3GSp3IdJN0U4y9GMQTBVWoU21Ek3mboY18Lu0pr kNxVlzhfZLUwe+nw97YD/cL2g1iabh78sfF/4OyVeLm5N8VSpPSTZa7iJeZ7fDlcbvAgR5Gk/KY Lz6hBRdv/JNDMNa4YV5dfeRFMxkGsYRnBYGai4Av0M4sS9rOe X-Received: by 2002:a5d:4708:0:b0:367:340e:d6e6 with SMTP id ffacd0b85a97d-36b5d0acf1emr9501356f8f.41.1722428555471; Wed, 31 Jul 2024 05:22:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHW+UTLIN0RxJ1X5ueyznLa5GLDh3jxBCM48XxXY8PyrBp6tsVe90U3Ukmdxw7GxNL3q6QZ2A== X-Received: by 2002:a5d:4708:0:b0:367:340e:d6e6 with SMTP id ffacd0b85a97d-36b5d0acf1emr9501327f8f.41.1722428555011; Wed, 31 Jul 2024 05:22:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:5f00:9b61:28a2:eea1:fa49? (p200300cbc70b5f009b6128a2eea1fa49.dip0.t-ipconnect.de. [2003:cb:c70b:5f00:9b61:28a2:eea1:fa49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b3686227csm16968300f8f.99.2024.07.31.05.22.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 05:22:34 -0700 (PDT) Message-ID: <644488b6-e838-48bb-98df-d979e01a51d6@redhat.com> Date: Wed, 31 Jul 2024 14:22:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/8] mm/x86: Make pud_leaf() only cares about PSE bit To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Dave Jiang , Rik van Riel , Dave Hansen , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Matthew Wilcox , Rick P Edgecombe , Oscar Salvador , Mel Gorman , Andrew Morton , Borislav Petkov , Christophe Leroy , Huang Ying , "Kirill A . Shutemov" , "Aneesh Kumar K . V" , Dan Williams , Thomas Gleixner , Hugh Dickins , x86@kernel.org, Nicholas Piggin , Vlastimil Babka , Ingo Molnar References: <20240715192142.3241557-1-peterx@redhat.com> <20240715192142.3241557-6-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240715192142.3241557-6-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8F29E14003A X-Stat-Signature: 9ccx3stnzw5kdqiidgda5p9x5a6aay6y X-Rspam-User: X-HE-Tag: 1722428558-323520 X-HE-Meta: U2FsdGVkX1/yHBE4ThOV+sabE7K1keLv1LqNpqbwUiOMr7WptOJZjINHPuXuqk7ymp4yWXl+FRrUKd9MTx6GNEUjOU8efhOzQqX2A3IufEx3WLh1G30NqWCdbzBdISwFEzOQYnRmVjEp76FTU2W2wMyZ9YT9bFm8aV0GOxyHSLawqTA5Sop1s9I7WDrzkuzhNrA5CPZn9REN7/I0aMJpsCChsrgkic+lvWyYNmPQvqs2eaPOqVV/VrCRWvA4OAsBObveO7UtqpWHokuDMCDq3MazBkIAOTS70W5mbiXkJ2dClB8BUfJpydUVjsR8nrivY3Jq8LI4jAN9HWhUCMsT36Rj+KRQ/OnKIhKbjpmVPgEuQmKcho2sfAHArtdHL3gS6mzJNbSn79CDujOSZvSkAQt1MwcUMQGA7iiT2ktsQ7g4glgl+L94WYLhZRjezVmZS9gwqsoM3wvHKsfHH/IQL6DrNLHgwukE/ccZgcreV68ro4sWyyBuzvg6bbb6n1Rsvy/iyjT73ojAZz4JDfVx0owdkBDI/tsx8WY4bpUoyH1b81+SVznMGUWqsz4jhX1aX8HjI30GAkZGG4H7fSlcjrpELE3cd2xB5Yj9ttc4C4LyzoRayup90FKHUCQJfzSXMrfHbz1BPpdDr3zb8q3PEVZwTWl3YA+GdNyqXajMD2c3PeyQsAIpR5T/jirgqvJr+KrYGBgTxZzOebUAWLqbcYThhQiYr4qedNAd1B0UoRKmXnQY9IHWKNDrsxNSvzXhAra7uU0EdtP59IaO9AgX16C8cwIRcmv8uFBrJUFk7hfZODg3B6PpPfk5feqoUhfr4PX00aNUpIGEutKXZCzBZJ1eLPE6xYvWx/7LZ72hDnlz2CpulBIIk0wGs1uVuGjbioGUiy3iHNiQurMZUcBrwdPXSKLR6bX3JwaYDFZvU76BOv/j80JI3EaBdqJhwz87YFi/rBOe+VkH1Q4YLC5 IHE6dRY9 EA31MY8POKZrC1jYshljQHxk/BUVBN0dv5zJtoEl50YASNEH1BUZtZIFMkdgZW3W93VtMGtFjCoKo414FpfCWl7ObIMpwg/M+TK//E9dmDKdQoeO8w2CKDv1QMqtWf17m6+RoPZSQaQpt0k4GHU14Bc63/UfagVyTTFc+52WOKvUGgL7poTu0ycf7qn1iaGJdywhTfK5feBU4uwTLMExQo+0o/UuDYd890Wg8PC8XMgxgiAeFZ8wS8DXFl2I9IN7Vbpe09LGWKYPFHcTn3bkeu3BoxFADsH/C5U0dynkbhye1rftq81s1tQe/glkPDtFOxgPnkDVqLK+NCgBzDu/JUoguiTLe459rFn2vdNpo6MBKe0FzxkFeb1QM1S1hVKICNyEllyfqx1ZnB4GPtk2nWNmb72f43DuymCGXZ8kp5V2DxMeycHMrRi5Nv0JLH12LHJNnj5RjfGedqTCSh9IY6t6aTA3XMOib4Ise6k5m3oInjnlNXW5dk107Y/Nu5NVg+cc05fTIzURsU4a/mydg1kTQwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.07.24 21:21, Peter Xu wrote: > An entry should be reported as PUD leaf even if it's PROT_NONE, in which > case PRESENT bit isn't there. I hit bad pud without this when testing dax > 1G on zapping a PROT_NONE PUD. > Subject s/cares/care/ > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Acked-by: Dave Hansen > Signed-off-by: Peter Xu > --- > arch/x86/include/asm/pgtable.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 65b8e5bb902c..25fc6d809572 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -1073,8 +1073,7 @@ static inline pmd_t *pud_pgtable(pud_t pud) > #define pud_leaf pud_leaf > static inline bool pud_leaf(pud_t pud) > { > - return (pud_val(pud) & (_PAGE_PSE | _PAGE_PRESENT)) == > - (_PAGE_PSE | _PAGE_PRESENT); > + return pud_val(pud) & _PAGE_PSE; > } > > static inline int pud_bad(pud_t pud) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb