From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C0DC5479D for ; Sat, 7 Jan 2023 00:47:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 763EC8E0002; Fri, 6 Jan 2023 19:47:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ECCB8E0001; Fri, 6 Jan 2023 19:47:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58E268E0002; Fri, 6 Jan 2023 19:47:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3C3968E0001 for ; Fri, 6 Jan 2023 19:47:05 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1238FA0EF5 for ; Sat, 7 Jan 2023 00:47:05 +0000 (UTC) X-FDA: 80326163610.21.751FEE9 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf12.hostedemail.com (Postfix) with ESMTP id CDA8D40003 for ; Sat, 7 Jan 2023 00:47:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iY6Ckg0i; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673052423; a=rsa-sha256; cv=none; b=UxuI0+CmGAjKzy32CmHk2tDlkG14gGmxCruHPj5eLDr+rGbFjBtJsPR0PgLt6M+plSsbrv 1xJwgWVvW69KBm6eU2KESd0PQQeXZi+isBQ9ic8kEe8Mnos7Muw28ADBBHmuyrAVLJjbRe kUF1bGnpftsNlgEHy0lZEVHkbI7C8I8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iY6Ckg0i; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673052423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CgG/jg366KhOWODTBklmFqwzzd2r3+pD5Q9bbILL54Y=; b=57JNlqXZ3DbSJaxKXO1au4iU0z4DjZ3G3MX7M5c8TeJR2Jqrp4/mNFPFnKAygMKLja+o2S buYdjbg2010JVM/ITNreM21xjOhAk40pqcmt82S4J6yXzR3gMt3/EOdTZLkou+Bd2n/dNF ddzUb1mce2vFCYThCgdbe7ETPgbuAhQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673052422; x=1704588422; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Kk1xFVbKS7sAQ5IQVZhgv/OVqCZqVfmRlO7PwuhRX6E=; b=iY6Ckg0iS/YLxnxgIdZxJYD6PcOrKUeTIlVSloyoTr+gZ3y4AqvsjPJa jKw6HUva80QDPOfl8a70iMl8WaCPUazFUvAja9VuHIVP+ewek+qKJ1B0C EoLmV1SSfdGvAVzMqmFk+eYRDM8W3hhISGx5XJ2DuQ4k71pJWBeeS5SwE pOXyvc6zWkL372wZeZxtRpGIXTx4V8XvOPGFvM0bvp0jYKHxVMpsavhs+ /0b5BD5GSbbI16Wwc3+VJzsGjQVZt42H1VyLRuZKBqsLNZXgy1ex7/Fei DlhNKtmaywgs/uNcLyvig6cErqqNaubHZhw+C06NkdLaSaLgvhN9ORWX9 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="302293161" X-IronPort-AV: E=Sophos;i="5.96,306,1665471600"; d="scan'208";a="302293161" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 16:47:01 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="830065883" X-IronPort-AV: E=Sophos;i="5.96,306,1665471600"; d="scan'208";a="830065883" Received: from xiangyuy-mobl.amr.corp.intel.com (HELO [10.212.251.186]) ([10.212.251.186]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 16:47:00 -0800 Message-ID: <64381030-bdbd-bc98-45b3-e3d40132a309@intel.com> Date: Fri, 6 Jan 2023 16:47:00 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8 10/16] x86/virt/tdx: Allocate and set up PAMTs for TDMRs Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <76a17c574da18c10ad7a4f96e010697aaa5f7c04.1670566861.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: <76a17c574da18c10ad7a4f96e010697aaa5f7c04.1670566861.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CDA8D40003 X-Stat-Signature: 49b38b56gccrxjnpm1ii7quw1yw1ay7c X-HE-Tag: 1673052422-769324 X-HE-Meta: U2FsdGVkX1/mxuqYdnxIbU0Fr3SLiVYmj75h5PFFhk8NJwm+i067390KG9nzWzb08qzIDY1PAKc/GgBTOODqtfDWj9GrT9zIDFR2dS7HVBHC/0ptZtHqWvAhC9kQWpyBxQ+WZoy1iNGMzVlWzsPA8KEKzZLQGZU98FBp6NsKc2Yx1Ca8XxeVzwNKf52xStZ+1gUFbLOUnuahqYKbItiZ15mYAFPrPkKUJAwXHB1cEugSoYFq//hne/8SV52PpbkTMDUyBkAxoozPtEb0bOOv+LdmMc/sa88Ypr1M7ZESUPW4ilcVySClqvbvudUI7i8Ul3hBf5VKn/d3+o/iXpvS7sgmZftrdRQogPdQQN9TaKkE1zCLl63aL4Ciz/YaFESCOHQc1GcpiY1dgWSHYvEFrQEqqKjBiqM8+oTcDG1a2AjDxaEKZUtZkOjZc1skUJdrrQN9glTYqZSuSqDgSBK3CNOJYbMSyvQkS77FrgRYpfQK7nfuxopoWASakBc77Ra5TW62dQni4Fa1/MZUHE+UQFohWHrQvwNnRR0LuIQWNer4f0QR+230ktkbtQNn3krAvt/KJa3zfdGGHcMJkJSGVBS1aET1nXRoXObZfQNx02mspHq+B0aYxJc8ihCKT/PCG7o/tRt1DR7iAlJeGQb0jfZwvU5Huw+kaXojFntP95DC8abjs40fHQqs6++gDuJ14rH5X9I6GQQ8sbL23jxAdLBK7IuljGYl9XbFhfVudnwHy34oWlY5Mb6HOn4HJE1Ln+ZDtzBqmVOmski79MFo16W2dnDD/fFRRqdmrq9YuNyKXDxIIFCU7ugyBaoOCM9xkUTPusC5x4HQ3WaoO5kvtJ7uF+vW2dsND1d+rklsV7I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/8/22 22:52, Kai Huang wrote: > @@ -574,6 +774,11 @@ static int init_tdx_module(void) > * Return error before all steps are done. > */ > ret = -EINVAL; > + if (ret) > + tdmrs_free_pamt_all(&tdmr_list); > + else > + pr_info("%lu pages allocated for PAMT.\n", > + tdmrs_count_pamt_pages(&tdmr_list)); Could you please convert this to megabytes or kilobytes? dmesg is for humans and humans don't generally know how large their systems or DIMMs are in pages without looking or grabbing a calculator.