From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A764DC021AA for ; Wed, 19 Feb 2025 16:25:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EFA844016C; Wed, 19 Feb 2025 11:25:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29F3A440156; Wed, 19 Feb 2025 11:25:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1411344016C; Wed, 19 Feb 2025 11:25:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E8554440156 for ; Wed, 19 Feb 2025 11:25:23 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 94169C1A75 for ; Wed, 19 Feb 2025 16:25:21 +0000 (UTC) X-FDA: 83137219242.21.E3153B0 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf04.hostedemail.com (Postfix) with ESMTP id 4FA3440015 for ; Wed, 19 Feb 2025 16:25:19 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=JLxXHB7S; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.42 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739982319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5K4FEOaAuj8ZRtiYP0BTVitcPLRr2Kq/PgjSQHr4YSI=; b=PwSdQUvNtkOn439CtQM87Spbojq4xHrg6LKFlT0beh48B+i7P1QnffHnqMiWD4xSKNvk2t 8k3ng5scTS7kyzmPwaGw2oJX/63BIsJpMk2QrL5t8RdB6AyInk4JOavjSY4xhKmjggSbeF rODRSsfFlFYxeU9p/Bzn2aH2tS6eRjs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=JLxXHB7S; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.42 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739982319; a=rsa-sha256; cv=none; b=HFu6WwKiy9OKSsFVpISie97cdjdefPvl3DPQBVuLXm2V4YB72iShDJdz5ep+v1KoyeG2n8 2Y0TXpwXIb46NkbucIKzDl9QwHueQBwoQkOUOQGxvM+P3ihaO91Np8Ue5D43W3+W7S+fwe /1O70ReecIAu3RfR1UMDCqjlP+AkerY= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-85592116ca4so241770039f.1 for ; Wed, 19 Feb 2025 08:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1739982318; x=1740587118; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5K4FEOaAuj8ZRtiYP0BTVitcPLRr2Kq/PgjSQHr4YSI=; b=JLxXHB7SijpRO5oUsXRb1abgZP0HuYiOjVkApSGSGE3zdaX/zpD9jPiHc8KU/TlPwZ C7FhQmCWm5cfviq0cgkf5BdUlclF860IWHkkU5sZ6SSZ5PK5H3qp3MRRpZRWvOZHdbzZ 5T311H78PIgQOI+y0P1x8Zgk/f8ur1c0L9XnYfzeeB8vXUBs9BaRCNIpXqQSEt5Q8+PT ihxVPK9cK4Ueg6G7sDfPhE6ogRJf181B+F0RUDuf49Q0X72NfgXlKapB6PhhzD2QLKyw 27zp1tKw4mBdYBCRR7n1LNMXYA3wUUrV23YOx09/JOEoJIqAOFr+Saan/TF/yR7ZUd6j 23iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739982318; x=1740587118; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5K4FEOaAuj8ZRtiYP0BTVitcPLRr2Kq/PgjSQHr4YSI=; b=B4Iv6hv7mMmGzmeAbmWgxc9U1nz1O7OYK5eeZU5C2v2pwPaiFAwoEgiF2LPV2KwsFN Ys3bOsQ+7jQB9ixqLzGYoY9N22xGpuGF0RIdt0aL+fjOVyLqeZPwf829Ba/uVhdedTz7 pGrEhAtSbZEf413VQt1e8v2HVJjuQ4ryqkKeXgkJN5ejFg9K/d+dgin7W1XEqNAMJYdG PjA1k36dakRyvQVFXh5E1SEc2gsC1fY/+XV8hD+MABXwWgcSWeBqD7k764eit8VTaQwL 6H/eN2sRmwsJ7rNTczNoSkdAMJgrL5OeU+ku46fTdHrPt20i81i0x8IXrLLyXAEG4Mpu 6ELg== X-Forwarded-Encrypted: i=1; AJvYcCXVA4k2kjASSBeTgnoV3yAX/HvWHcrP6dTZfWmk5ncZB/5fk1VARWzQAarme+9RmXMm/rcFkoDG+g==@kvack.org X-Gm-Message-State: AOJu0YxZi/ZVm3FUAIhY6rsgC8V92fKOBObhOFFr6iq42v02NRfB2jRI iCuDvBJXQkGgc6VY8zvaQPn937yRshiXLxjrd8WdIJdF0SJ5IccJAMF+5UiaBN8= X-Gm-Gg: ASbGncsx8A+MOtfRMT+Bfw5GeU3k/42S//k5Hy7/3AgLKmLozj6/BMTKJNqhNkK92HH QCrsbWpaS2heHj8MXUl+b2MdhB7DU9z4ABoUprIZirMJvE59F2aFsEtme5jwO6wbVI8yJTEKpOI g8cz39wDEtyTYEobV35+MQMEEN/HqvnKG4n4MWq/xQqPKgygenIBmquKlO8H2dCoRkk+T535JFn hoRbAE2isFoXTqSM8/KKsqW7lR7FAJJCp2/Y9bm5vK8jj5dqqUDW2ezjunTlKN2yTNpB3jzud5y HuEvFvCnHbI= X-Google-Smtp-Source: AGHT+IGzDMxDRSO7tIzCZYHTeRIrYyJDa2dEbxHA0GLL6as5GUtS88pFw3LkO+acUE2TeDls0mZXYQ== X-Received: by 2002:a05:6602:6d11:b0:855:670a:e687 with SMTP id ca18e2360f4ac-855b396d596mr408445639f.3.1739982317377; Wed, 19 Feb 2025 08:25:17 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ee903b9375sm1887506173.54.2025.02.19.08.25.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 08:25:16 -0800 (PST) Message-ID: <64379346-a39b-4903-b861-0e25e9e79821@kernel.dk> Date: Wed, 19 Feb 2025 09:25:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/filemap: fix miscalculated file range for filemap_fdatawrite_range_kick() To: Jingbo Xu , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: brauner@kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk References: <20250218120209.88093-1-jefflexu@linux.alibaba.com> <20250218120209.88093-2-jefflexu@linux.alibaba.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250218120209.88093-2-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4FA3440015 X-Stat-Signature: kyqrzaiyg8st4zdysa6k6pggm6j4snfm X-Rspam-User: X-HE-Tag: 1739982319-629218 X-HE-Meta: U2FsdGVkX18dhwFzry2AtHT0nbON4VhYJD6/B9H8a6anEz6TERxTfeZv91xZaYBWfLzt+KHVq1FdnUwOtGbkO0oc/mMczMRlLUWkHSuSyDyb+hAulblV7UCTQJaP45oOrm83srm8AurT1pOBG/JfQekS9IzXM9ym0AsyUoYrVMQignPoIzVXPrS/xMaDwyqH+D9g+5bgF7k4a3fBwbGpEgpT4b86jdC/BrJ7QsKZX9ZPEX8KDjV/Y34alO1vQ1hF9HDcTNJVtfl7SNbOHJZVi5dPT7L+JKuDI0MTcxpwCQrXOrPkQZKq/skqHQCKp2KpRJRVP5nYC8nJ/b/lzDzFBri2caQ8FZKqUTAnpvFM2lY4e6wioFviJA+WK0/XTSwIgnC76Cq/5+aJ+4E3Yn+aVWXLv91/aiowJBmUUDuN/TbzjWKS8VPKRgsuiYWPaC0cH9Ol3KgfPObSkqeCswAX0ibs61kYnOSYK/ZT20xx3wvphqm8N+e2iMOwcLU68lO6jI7P4NXZYkaDXABLGvx1qmmMOzwXr87r9xzlGejLDb7olPXl9lmdYvtwM165utEzw44cZsbFkZkKxXPZM7pkcYxoGasjJWADSUsWXHhx90ToLOSOwX/7CA+AOMq99TbSrMz3VRuTkBG4zGWWmJn0S5yLvs7yqW8cL1/6YnTJm1xI8DmIFjQwzZ3UAH39KlMjjoi9HBTBhZYbBcZKX2rCB9nmwC7bfQ+UHTHd7iGF87bg3/LuJ2MlWtKmu18BelrhvemEH3zZmwtjPYN1yaC1qFYzGsWcC1BW4nZ0A3Boa7hPHNxNMz8Z671DnBOJQ1sutUaGMdQrDToEQS1tD4gDF396h/V1sfRe/p/1ehS0eNeXFJyNHsFCB+sJNO1f837J6kDQdhKc/pTMKL8QElXqeYqz7eefjasyaj9wi7NpIjZ/BRgY+48cPLcirClIN5652Wz9XLM1a/zV/7Ou04m xF32uQLL XdR9zt0zktDgCiZn4X3w1sFOSaD00ihF4RvvHTPovKeJkykybtWwccMomOHKz32EHilCUja0Q6lJkOYd/He/SIgYOu5DjVeanXkcB+ZE8LgwfsvIw45eZEvzifBS58BbCuJPoIRrtcMLHltzzefKzag6L+CWdPJgM1qTVtJ35j19TLCB9ixocfebmSWPgDm+dFGWI6exaHWZ56vffQ4Xo8MYpCoUWa7SmNrqB3+cf3tw3g++m+76DxvuKdZipI00L1us4/vn+p9bovAnBrwcGiSMhyxSA1/0YUHPy0YiBNto3vhujqy1DoDxlpza8bbaiY5UpzsLyXPbghAaZjE4lPM2Z0jNmELCz+A1jRJatWQ0D8014dUdNVr9O+M1mnYpiYXNMuxC1CEZRPlk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.005703, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/18/25 5:02 AM, Jingbo Xu wrote: > iocb->ki_pos has been updated with the number of written bytes since > generic_perform_write(). > > Besides __filemap_fdatawrite_range() accepts the inclusive end of the > data range. Fix looks good, this got introduced because the logic got moved into generic_write_sync() rather than being a separate helper. Reviewed-by: Jens Axboe -- Jens Axboe