From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E5AEC05027 for ; Fri, 17 Feb 2023 10:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7D866B0073; Fri, 17 Feb 2023 05:41:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D06716B0074; Fri, 17 Feb 2023 05:41:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA7D56B0075; Fri, 17 Feb 2023 05:41:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A88676B0073 for ; Fri, 17 Feb 2023 05:41:07 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 74FDC1209EB for ; Fri, 17 Feb 2023 10:41:07 +0000 (UTC) X-FDA: 80476441374.07.BB46317 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf18.hostedemail.com (Postfix) with ESMTP id AC5621C0009 for ; Fri, 17 Feb 2023 10:41:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=no6u20rM; spf=pass (imf18.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676630465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WU6nO7CCB97I99Huoj4lQsvLMmgyaTdeXN8f3OXE4hk=; b=y8nhGJGO1ETBMVHFRoC/SUE5n3qT2tAVSJbPeIp9zflM2nm+XukE/ynWeZ3raBjmBF2OBS QF5sr7j4/3J6ivuQh9dCUWgflwo0vSb/YgfidcNVDvWKFz77016VoJcymnA7Vi5ocYjqQC tLGOUo/e3Td/R94VLj3czUXmsOScRuU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=no6u20rM; spf=pass (imf18.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676630465; a=rsa-sha256; cv=none; b=eiahkb3Vd9Ufq+xk8SmgoXgbgXyKOR4g0MgGymZ8QxSIfdnCJcdKaOgBEdSo93rtIRu6HQ XB//z2pVRhFo21QuH3vN1YaMBVr3Ya94XqdCGnqK0qALV6yzlkDnlJ6HpZcqzhWsnGmxGV VK34v0LvGfFNS6Ne5jH3JiXGQwLBGvk= Received: from [192.168.10.28] (unknown [119.155.16.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3672A66021A1; Fri, 17 Feb 2023 10:41:00 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676630464; bh=8pIiR66rNGUMu2TCI8ZyhpmZ6WKJjoXJUbmf1lKrgXY=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=no6u20rMm6YO6MgHK0jkrI2daypqWpGso0y1VhkoWeaNfYRkSWJk5n/epFayoJPvm pX5XOlE2jE66AkjeYsCphfL3+3JPSN9alJ7FS7GWdViwIc3BunLhbnif6MEI2eI4UD yyWGjiJSW2HAZLk7f59oKiqiyEN4SaQTj+rIo+JWC847am7UXxeGJquyqr48rz5KO8 u1t55NfmwXpkD3gEer0zd6GgnlF0ZUXuGhOC7hK4MnGxfTyeg05DLt5NEmJ1kAun/T aaKnSjNLSAtAEd8bMdoQvfLmR4tyWEavrwmmFidJW7CWBhtcSjMB89yxIUNGsDS7Og aChk8eruyA8Aw== Message-ID: <643097f2-f29e-313b-cfb1-4095ae641448@collabora.com> Date: Fri, 17 Feb 2023 15:40:51 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Cc: Muhammad Usama Anjum , David Hildenbrand , Andrew Morton , kernel@collabora.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] mm/userfaultfd: add VM_WARN_ONCE() Content-Language: en-US To: Peter Xu References: <20230216091656.2045471-1-usama.anjum@collabora.com> <20230216091656.2045471-2-usama.anjum@collabora.com> <4d29a9ec-027d-06b9-8543-87d386e58c94@redhat.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 69d5xztntjfrhiarsiqtokxuwoj41yqe X-Rspamd-Queue-Id: AC5621C0009 X-HE-Tag: 1676630465-846000 X-HE-Meta: U2FsdGVkX1+2FmOPcelKE8/fHOkeN5k3t7RrXeRemHOlO9+zCmxay0jvQEON2xQQDWb7cnUKmP4VNja9GWYdxLJxlll7HkocHNXCqE6ftsSDSfKjJG3Xun07AxHiP2gERaz7RKIyvUgJxD+7A2S75i5lDXepNEB2eFrv0beuOGRRBNvOoOsH36Hgam0cSCHi0XZjB82wCrFGR9od2826eZingn8hkwnRH/U1d9m0XvRSYfWsG5YdoXt8zwQuOQ6kcr/nNzZmyQjoet6SCXMG+pv6yUUXkOIjCAZ/QODoybO3aocujO/uzYWYyJynOq79RaCZEcXD73Js60cY/fKPaGpF4QMfkcPj//G3m7mg1NEgGvYIQcQl//mEPwd4lQIca2s4045ZX7ZuoTppoVdLBqtvOae7PdyRIL23kbMrloI+VQMBfjrRa7RynQr7krAcGT6LGajifIGFF5OFz5p09k0XmuzpwU0Oux6IqaV3Ee8UFL01KcObcezXpwihthzS7q0boqTXHgLMV8D58TBKcnYQl1NVEDqRVOtD57tcOnpP952oBLvVgZ/5wiHSL7UK0xtYTct9ZSDEKkkHeF7pZhiR1PovsSe0vJTLjTK2z+dQA1klSO8umoU2zO5QIprezZH6aEidMw8W0BCwW56LBrgW2OY0SzJbshhcLCa1HZTdCT6rCCBdgWjRSApquyfWGAkqy49OmOpywH+zLUTH53qb4NDJRZtrSN9VgVlbO9NiEgH9IIYVrG6x5yc3hdohSevWEJjT24DKSAGhirhfDRe6fGBob8e+sllf5RcPKbfcM3HFhaHyc4i54mfXLb2J9n8DMrv8bnChE1BRWPWh3OaA33JQ695AqliCq9kbXm4uGhGQc0wcPCUvhUvxyIxMCqeImvNX0lKE4rGaeFzE7br9Wt6n8BnB6KtN3CDXMDigsaLDKdLzrMsTT1F8LMcNgUZ47NIxemZ8J8YReqb pD56b3sY KlC4xOKDVT4rx9Io7Z8IVyR0J55yMOGnokw6WAgIQor0GJD0XPxmktVzsjbDlavJcbYXjXHrhdTCqPTk00qqMmcXrxOQBlPeHX5IZWXJhK8Mn2fhiuJ0v925B2kWLyacSZoNvoNtQPW3yufzO0xrq7NuFdTFN6sZ5qR0vK3YkjRIiXWgUxkXuxcmCbY9/6uhwJR8KmCb2q8HvD2PZg0Olr8Q7wV61ROMoJEENVDJ5wmVybX6ECzvOZa4uu8rjUde7XXWjJmcyv2dGeIYUPeYb97RS7pj4Bpkxv5fqLoqq4Ke2drViYixrAKd6lKCOGibNnfd3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.013471, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/17/23 1:26 AM, Peter Xu wrote: > On Thu, Feb 16, 2023 at 02:48:51PM +0500, Muhammad Usama Anjum wrote: >> On 2/16/23 2:24 PM, David Hildenbrand wrote: >>> On 16.02.23 10:16, Muhammad Usama Anjum wrote: >>>> Add VM_WARN_ONCE() to uffd_wp_range() to detect range (start, len) abuse. >>>> >>>> Signed-off-by: Muhammad Usama Anjum >>>> --- >>>>   mm/userfaultfd.c | 2 ++ >>>>   1 file changed, 2 insertions(+) >>>> >>>> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c >>>> index 77c5839e591c..d89ed44d2668 100644 >>>> --- a/mm/userfaultfd.c >>>> +++ b/mm/userfaultfd.c >>>> @@ -717,6 +717,8 @@ long uffd_wp_range(struct mm_struct *dst_mm, struct >>>> vm_area_struct *dst_vma, >>>>       struct mmu_gather tlb; >>>>       long ret; >>>>   +    VM_WARN_ONCE(start < dst_vma->vm_start || start + len > >>>> dst_vma->vm_end, >>>> +             "The address range exceeds VMA boundary.\n"); >>> >>> VM_WARN_ON_ONCE is sufficient (sorry for spelling out the wrong variant >>> earlier). >> Will do in the next version. Thanks. > > Shall we just squash the two patches? Will squash in next version. > -- BR, Muhammad Usama Anjum