From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF02C6FD1D for ; Tue, 4 Apr 2023 17:36:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54A596B0071; Tue, 4 Apr 2023 13:36:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F9E36B0074; Tue, 4 Apr 2023 13:36:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C1DA6B0075; Tue, 4 Apr 2023 13:36:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C3126B0071 for ; Tue, 4 Apr 2023 13:36:16 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E9F0D140F2F for ; Tue, 4 Apr 2023 17:36:15 +0000 (UTC) X-FDA: 80644412310.08.1FEBCAE Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf05.hostedemail.com (Postfix) with ESMTP id 206AE100008 for ; Tue, 4 Apr 2023 17:36:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=f5gX2wkq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680629774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Z1DSaq3VFchGKzMkuppKkMuZ02nBNd6ugtDdxGTU1k=; b=xZqKHHiZfBYih7YdEBwD8Sq/aZq0l9abMKV9Km3nve2S3GzsLf4l92U9p7P7QpUpIurGwv LENfvWLirin0bDW7UhLdLJZxOm+nxIyJzrWvXrEPF7jQZmFcIG/8Ld7ebL0j6FJcnfOzAv Vi6WbMzQCBmxAN2YIuobwKSK/XhNupA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=f5gX2wkq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of willemdebruijn.kernel@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=willemdebruijn.kernel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680629774; a=rsa-sha256; cv=none; b=EqlnO8GoAHAGA5dTTN6sgHygTMfkDvLWT3nPmyHa7i20SFxqqcfWJPWUDZ4/4br5QvDJ9o s6bxHNGUUK8EhfBv3pW360b0/6rPggj5Gyzqtm/+koNNpgQZiKuaPy62xYiYenu7vyWeic q/UJy2s7ynfABYCiWzXycWIhbCsvf/c= Received: by mail-qv1-f53.google.com with SMTP id ev7so5117347qvb.5 for ; Tue, 04 Apr 2023 10:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680629773; x=1683221773; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4Z1DSaq3VFchGKzMkuppKkMuZ02nBNd6ugtDdxGTU1k=; b=f5gX2wkqrAoiMblcAQuuJb8lAFGg23a2sQHkp6HtVaJg8FDt2ejL5nTg1wHkUJvrui jaaEEnLdaxr69bom2j9BD9wRgQgSArQP7KUL22iOL2NM0bGEsqBXBZoWgyeNW0KpnlVq SMjoGHIMxlFjMmWnwdLP0cisFpmszR0uefaLEboVei3ol7U8Jp3PmQRh091YPdIvxgol 4Kled2XQqKbOunVH9s6yqb8iQbezNK7IJUKeSSWqqmzsoP8AF9wHC1hhM0IijQXpG3oy ATKK/WTaFZGvkz26pkXdfYEjGwkkH2dWTsgLjOINF2TZHj3Z3qLrFIqs9JEP+DqBHFS3 aTMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680629773; x=1683221773; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4Z1DSaq3VFchGKzMkuppKkMuZ02nBNd6ugtDdxGTU1k=; b=3cGHnBj61Y6HQPOexCxNde4tudzHdSJz3G7HC2TaAT6FEECNTxpHcj/SUzu3Bcmnew UIf8Lx/DgF3Gs4PJ/EU4h/b/EeYqosHvcxJEU7ngFIRcI4bT4Zbj5i+5PqqZw/IeTxSz xMf9cSw6X85AHicGQw2e4mOMrFptNYndGDNBvlWOH4xw4fQoBygOTEyvwTedRQuURaTU jTKrvr1sqyLGPQ1UAaM95IIA12jQsBRyStqBTcMFXzN30QsRMQrAYqzjJ6biHin40ynQ ++9slBim3/3H2yhTdmZJrVxfk7gIyLf4N/6UFkpSwGgaQQgMABRuhASvR+dpu+CC/+R0 v8FQ== X-Gm-Message-State: AAQBX9c4WnIA1hatczu/ekUcAH6P7XfWm/X0pLhuoJE35pKdt8GFYIfq mQyZ0uI+liLs5Z5fQpXb/n8= X-Google-Smtp-Source: AKy350Z23k8fMVTzMdrsIJFMN4WdkO04DiDvcgHJCEHpVKeNB/JKhOJwLjldeAZHPeYbENi695HiOA== X-Received: by 2002:a05:6214:e6b:b0:5ba:852:272c with SMTP id jz11-20020a0562140e6b00b005ba0852272cmr4398157qvb.8.1680629773236; Tue, 04 Apr 2023 10:36:13 -0700 (PDT) Received: from localhost (240.157.150.34.bc.googleusercontent.com. [34.150.157.240]) by smtp.gmail.com with ESMTPSA id kr22-20020a0562142b9600b005e45f6cb74bsm836386qvb.79.2023.04.04.10.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 10:36:12 -0700 (PDT) Date: Tue, 04 Apr 2023 13:36:12 -0400 From: Willem de Bruijn To: David Howells , Willem de Bruijn Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Message-ID: <642c600c428d2_339347208d8@willemb.c.googlers.com.notmuch> In-Reply-To: <2688906.1680628610@warthog.procyon.org.uk> References: <642c5731a7cc5_337e2c208b0@willemb.c.googlers.com.notmuch> <642ad8b66acfe_302ae1208e7@willemb.c.googlers.com.notmuch> <64299af9e8861_2d2a20208e6@willemb.c.googlers.com.notmuch> <20230331160914.1608208-1-dhowells@redhat.com> <20230331160914.1608208-16-dhowells@redhat.com> <1818504.1680515446@warthog.procyon.org.uk> <2258798.1680559496@warthog.procyon.org.uk> <2688906.1680628610@warthog.procyon.org.uk> Subject: Re: [PATCH v3 15/55] ip, udp: Support MSG_SPLICE_PAGES Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 206AE100008 X-Stat-Signature: nx77bgzet5agwnbnw9765b43b8chbn76 X-HE-Tag: 1680629773-673789 X-HE-Meta: U2FsdGVkX19gGlt0lFjVzobjqX8OGe5picS3DNu3+sLpBVvhDc5FexzWDK4pgI+bxCVTiAjK4nYkUyzc+xGI+b0oSTwMOwGGD7y4raijOw3yU64hU+5JPG8vW+4yWKJCwZghR1f4vJeEpmXtbOYafZAseAP/0/M91SCgDL9eTB0zBbW5rQLm+658S4rH2KzMWku9ACj5rQFcGQMn9M9YW+WzMDILV4zL8fxZXjKOnCkv1hg1aRICbwKlJzHvDzJGtYnUrz8CFvdgYp31UzrPJRdmM5q5PmOat/ZcSTskpFHC6X2fjMCSarPEyEDvSveaN2skqPHWt7l2gTlV1WVRUkTQv6BWB/xl8k9RcRpsZfHXK2N9t86hLnheeXc54ixvSQo/pc9gqzJx8jaTajv7W8R3YoxfOpMsFeFc5wMRKHCFBRdlFFXZlkxtxEPIjq+o1ygynP6mJC0r84J79E1S5d87gyHwEFMLOkjFdk6pH33e52TnnrcjMkQJIE/QacLdlNc/8nQeN9biuJwO1ZrOvj+4tQQmWQMvCyqA+OPgRStOa1e8qIwNmeIwS0+Kchvww3+Y81c/nItH5MUen7kLmhy85ZzpPC4dAYDoxLwMz5XwPpPCiIG4xQLV7IOm3z1OAou8TzI0C84dwusFymtni8QVnHJHG2WOeVRiIX8PFsu8wHcCee6n+1549XZIMm9Or+Ui0kl4Ioj9hYqa85GlfGPSRvKWyTHrAZ1eg5ehtEd0JfEB61bG5iGP2khCCGeEdG0dZoVD2rNXsZAXJV5WZYtPXiNYL9Uccjme1TVM2LUN5xP2ea1oJpvj7UGSOWpxuB3oo0vJjKIJJbiUBLzzyJuc46gDYHS+YOxLK3B7MLuFOl4rQVEkg0FV0mWURBs1vXZgCRLP/cqZEPQy9NTCruXXHuWTIo+saa84OnYSOivwajLu+t3Tc9dCNpv7bc5YNbG5K5YHvK/3Tsn0nYG ixXvUtvj yDKw7/WTuKH4m6I+jY5nuMUAVtqP2zbTptOPdKiQxMMC/ECxM4lmfuBjf5CN2tva/ts3qjo/QT7bRVclf1j9CKP2KileHipMTJz4cxYUI1lyC3PKw2qw1XcDOYOJVJ8KL6m6izxXGWYzGPIire0r2ZmnrVnsgItTb2n2D27KMh9UQlf7I3zAb7zdM6CbftUWvv5bjO36K7rPzwg8Aa2+vpPMedrx0jNJfjfG8t801C9YvvWqGyh1z/Um6ny0IxHf9/VZOnQITuYH3UiQzH3NLr1rpKWsZPZ0fEyEOhqGMjntXhInKth8zMe9p9FBhpk/FIFEQ6zZ7TRF3YqLgiuTfbEmQDJ6NJb/gKdC9tkcpa4X2Yf84ggJOa4JolP9fMKPvO0ViTnUX9WfOVC+JeN6OLtxYU5Q0yAIwJhpvCQj/jD4ovXN6WvnfEiHiDnHG2CWEYuKBE9GXZdtE9uk3kJh+TYkKP+JtBjpYPsED56zejG8T4gNkMtuwVZypH57a1KXxFz7vDYooGy3nDAfGSUQue2+HFBr6Ri91c06tROqAPxijqvsFtPo+cglVLHSw/3C7Vry0+ujLcTV70smQUh+26VCnVG/yf2uRfnPZJhi+xME2gXg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells wrote: > Willem de Bruijn wrote: > > > > Okay. How about the attached? This seems to work. Just setting "paged" to > > > true seems to do the right thing in __ip_append_data() when allocating / > > > setting up the skbuff, and then __ip_splice_pages() is called to add the > > > pages. > > > > If this works, much preferred. Looks great to me. > > :-) > > > As said, then __ip_splice_pages() probably no longer needs the > > preamble to copy initial header bytes. > > Sorry, what? It only attaches pages extracted from the iterator. Ehm indeed. Never mind.