From: Thomas Prescher <thomas.prescher@cyberus-technology.de>
To: "fvdl@google.com" <fvdl@google.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"muchun.song@linux.dev" <muchun.song@linux.dev>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] mm: hugetlb: add hugetlb_alloc_threads cmdline option
Date: Tue, 25 Feb 2025 13:01:47 +0000 [thread overview]
Message-ID: <642590c8685a8ff8c042d628336bc7380217ee16.camel@cyberus-technology.de> (raw)
In-Reply-To: <CAPTztWaRDD9v+-yk_DJAb9FzZDyQF93B_BawxcmSSUitRp1a5w@mail.gmail.com>
On Mon, 2025-02-24 at 09:37 -0800, Frank van der Linden wrote:
>
> Maybe mention that this does not apply to 'gigantic' hugepages (e.g.
> hugetlb pages of an order > MAX_PAGE_ORDER). Those are allocated
> earlier in boot by memblock, in a single-threaded environment.
>
> Not your fault that this distinction between these types of hugetlb
> pages isn't clear in the Docs, of course. Only hugetlb_cma mentions
> that it is for gigantic pages. But it's probably best to mention that
> the threads parameter is for non-gigantic hugetlb pages only.
>
> - Frank
Very good point. I will update the documentation accordingly.
next prev parent reply other threads:[~2025-02-25 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 13:49 [PATCH 0/2] Add a command line option that enables control of how many threads per NUMA node should be used to allocate huge pages Thomas Prescher via B4 Relay
2025-02-21 13:49 ` [PATCH 1/2] mm: hugetlb: add hugetlb_alloc_threads cmdline option Thomas Prescher via B4 Relay
2025-02-21 13:52 ` Matthew Wilcox
2025-02-21 14:16 ` Thomas Prescher
2025-02-23 2:46 ` Andrew Morton
2025-02-24 10:42 ` Thomas Prescher
2025-02-24 17:37 ` Frank van der Linden
2025-02-25 13:01 ` Thomas Prescher [this message]
2025-02-21 13:49 ` [PATCH 2/2] mm: hugetlb: log time needed to allocate hugepages Thomas Prescher via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642590c8685a8ff8c042d628336bc7380217ee16.camel@cyberus-technology.de \
--to=thomas.prescher@cyberus-technology.de \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=fvdl@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox