From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A35A2C433DB for ; Mon, 15 Mar 2021 02:04:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1989C64E46 for ; Mon, 15 Mar 2021 02:04:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1989C64E46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 956726B0006; Sun, 14 Mar 2021 22:04:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 905826B006C; Sun, 14 Mar 2021 22:04:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A7FE6B0070; Sun, 14 Mar 2021 22:04:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 5B8056B0006 for ; Sun, 14 Mar 2021 22:04:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1D2171E14 for ; Mon, 15 Mar 2021 02:04:34 +0000 (UTC) X-FDA: 77920464468.20.9080C58 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf15.hostedemail.com (Postfix) with ESMTP id 1DDE5A0000FA for ; Mon, 15 Mar 2021 02:04:32 +0000 (UTC) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DzKSF3ByZz8yPD; Mon, 15 Mar 2021 10:02:37 +0800 (CST) Received: from [10.174.177.131] (10.174.177.131) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Mon, 15 Mar 2021 10:04:24 +0800 Subject: Re: [PATCH 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge() To: Matthew Wilcox CC: , , , , , , , , , , , , References: <20210313103225.16607-1-linmiaohe@huawei.com> <20210313103225.16607-2-linmiaohe@huawei.com> <20210313200359.GL2577561@casper.infradead.org> From: Miaohe Lin Message-ID: <641f4d6d-97d2-63a8-c61b-a42f71dcba6c@huawei.com> Date: Mon, 15 Mar 2021 10:04:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210313200359.GL2577561@casper.infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.131] X-CFilter-Loop: Reflected X-Stat-Signature: uoszdumwk6ebjz1nmkawkcmjmc1xscwx X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1DDE5A0000FA Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=szxga07-in.huawei.com; client-ip=45.249.212.35 X-HE-DKIM-Result: none/none X-HE-Tag: 1615773872-851668 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi: On 2021/3/14 4:03, Matthew Wilcox wrote: > On Sat, Mar 13, 2021 at 05:32:19AM -0500, Miaohe Lin wrote: >> +static inline void try_to_split_huge_pmd_address(struct vm_area_struct *vma, unsigned long address) >> +{ >> + if (address & ~HPAGE_PMD_MASK && >> + range_in_vma(vma, address & HPAGE_PMD_MASK, >> + (address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE)) >> + split_huge_pmd_address(vma, address, false, NULL); >> +} > > This isn't "try to split". This is "split if needed". I think the > comments also need to be moved up here. > Make sense. Would do it in v2! Thanks! > I'm not even sure this is really an improvement. > . > At least we can eliminate a couple of duplicated lines and use helper range_in_vma() to improve the readability slightly. Right? :)